Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I467f0715b2e7e1e65faed19bd2a5e31939426bfd
Reviewed-on: https://gerrit.libreoffice.org/74378
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I207d21e674366046e2663ebaf7f5161cde2c5fab
Reviewed-on: https://gerrit.libreoffice.org/74336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This started to assert/crash with commit
d258fc29560baa5ecae03ebc2740e11420643e27, but such redlines are really
not valid so it's a regression from commit
16916a14a2ce382aa4ff2a25f8e477108aba5a67.
Change-Id: I4c03a96a43b62a3c5321535a34c2d09b155b79c0
Reviewed-on: https://gerrit.libreoffice.org/74371
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Replace with comphelper::getUnoTunnelImplementation.
Change-Id: I001293ca25387a34cff9872c6db2ab72c6c4d617
Reviewed-on: https://gerrit.libreoffice.org/74385
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I53a019f05978bab62ad0da3d0eb08f37f8ec1e18
Reviewed-on: https://gerrit.libreoffice.org/74414
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I93511574f8ab7d564baf1f031d54ca0e72ca345e
Reviewed-on: https://gerrit.libreoffice.org/74380
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Use range-based loops or replace with comphelper or STL functions
Change-Id: I7613057ba7063e04ca39a654f8a15c0354694783
Reviewed-on: https://gerrit.libreoffice.org/74309
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I7ccd6af737c21a50fe7df25266198ee6989c4c69
Reviewed-on: https://gerrit.libreoffice.org/74110
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Id0d89edfad0ccaae22610c5c999afc6b8686441d
Reviewed-on: https://gerrit.libreoffice.org/74392
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8cce34c7817834f0c4fb0bfc68b95464b5563ddb
Reviewed-on: https://gerrit.libreoffice.org/74398
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I0c17121e2fc2d26d09f6c7b1f28b97ea2a43363d
Reviewed-on: https://gerrit.libreoffice.org/74396
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
See tdf#74608 for motivation.
Change-Id: I3e2afe5184f686180b287078477f095792c9ac12
Reviewed-on: https://gerrit.libreoffice.org/74384
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Revent commit 693e8d1eb28c916ea8bb91667ed5511ff0907d2b
Change-Id: I87618aad941d92aca2801e1c2b7dfcdbdc007474
Reviewed-on: https://gerrit.libreoffice.org/74408
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Replace with comphelper::getUnoTunnelImplementation.
Change-Id: I52f780059be7626a03bf79044cfc580bb33f3fd3
Reviewed-on: https://gerrit.libreoffice.org/74383
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Replace with comphelper::getUnoTunnelImplementation.
Change-Id: Ic569783ae01f731f54b54775b8e0eba162cc4b78
Reviewed-on: https://gerrit.libreoffice.org/74381
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Replace with comphelper::getUnoTunnelImplementation.
Change-Id: I8dcd0bf1cfbaa02fbb7c128421506f1c30d87773
Reviewed-on: https://gerrit.libreoffice.org/74387
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ib966fd55b4aad7644046e1c283abf97934187183
Reviewed-on: https://gerrit.libreoffice.org/74393
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I41d3f505a398974fa4b27eae1538a58f2871a4dd
Reviewed-on: https://gerrit.libreoffice.org/74390
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ib804fd330ffae4b0e6c33c1247265955a3be9f2e
Reviewed-on: https://gerrit.libreoffice.org/74389
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I073a1d282bf64c7176fb35121e6e4d59ad6b9f0c
Reviewed-on: https://gerrit.libreoffice.org/74397
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Replace with comphelper::getUnoTunnelImplementation.
Change-Id: I8a457dc2aa701957f463b31bd6cc112337999aad
Reviewed-on: https://gerrit.libreoffice.org/74377
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...where scoped_lock was originally meant as a transparent generalization of
lock_guard, but eventually had to supersede it under a new name, for backwards-
compatibility reasons, see
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0156r2.html> "Variadic
lock_guard (Rev. 5)" and
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0488r0.pdf> "WG21
Working Paper, NB Comments, ISO/IEC CD 14882".
Change-Id: Ie58909f63beec5939601183d6bcda3bc638d5747
Reviewed-on: https://gerrit.libreoffice.org/74382
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I8169fab36b9664f7a820c9f6781e0c61723aeecc
Reviewed-on: https://gerrit.libreoffice.org/74391
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I740ccb13699879ac667009e262076c3c6e118d0b
Reviewed-on: https://gerrit.libreoffice.org/74395
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I26a820082ee95ca076c060ad29f30283f50bdd98
Reviewed-on: https://gerrit.libreoffice.org/74394
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
The condition "nFontType & RASTER_FONTTYPE" can never be true since we reject
such fonts, so nHeight is always zero and we can simplify the code a bit
accordingly.
Change-Id: Ib3a19777909e16367c8168e86e474c1a5ee64a5b
Reviewed-on: https://gerrit.libreoffice.org/74400
Tested-by: Jenkins
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
|
|
Without that, the system's time zone was used which on DST
transition dates leads to non-existent times when switching
to/from DST. As the calendar use and number parser/formatter nor
conversions or calculations are time zone aware, using not DST
afflicted UTC is the better choice.
Change-Id: I3303c6620d8c4b9d081555c8293954fb1bd67895
Reviewed-on: https://gerrit.libreoffice.org/74386
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Ibb809807294a9fef201fa6c62912f25917374259
Reviewed-on: https://gerrit.libreoffice.org/74373
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
it already call View::GetWindow()->Invalidate internally
for the usual case, and correctly calls EditViewInvalidate
when the editview is not used in a vcl::Window
Change-Id: Ic83150117a8738ce5c6f34875057fd743bdb173a
Reviewed-on: https://gerrit.libreoffice.org/74365
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
With `--convert-to pdf xlsx/tdf116206-1.xlsx` with xlsx/tdf116206-1.xlsx as
obtained by bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment
"Example file with lots of random data" at
<https://bugs.documentfoundation.org/show_bug.cgi?id=116206#c0>), my ASan+UBSan
build will eventually fail with
> .../include/c++/10.0.0/bits/random.tcc:461:25: runtime error: index 624 out of bounds for type 'unsigned long [624]'
> #0 in std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul>::operator()() at .../include/c++/10.0.0/bits/random.tcc:461:25
> #1 in double std::generate_canonical<double, 53ul, std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul> >(std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul>&) at .../include/c++/10.0.0/bits/random.tcc:3336:23
> #2 in std::__detail::_Adaptor<std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul>, double>::operator()() at .../include/c++/10.0.0/bits/random.h:179:11
> #3 in double std::uniform_real_distribution<double>::operator()<std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul> >(std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul>&, std::uniform_real_distribution<double>::param_type const&) at .../include/c++/10.0.0/bits/random.h:1857:12
> #4 in double std::uniform_real_distribution<double>::operator()<std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul> >(std::mersenne_twister_engine<unsigned long, 32ul, 624ul, 397ul, 31ul, 2567483615ul, 11ul, 4294967295ul, 7ul, 2636928640ul, 15ul, 4022730752ul, 18ul, 1812433253ul>&) at .../include/c++/10.0.0/bits/random.h:1848:24
> #5 in comphelper::rng::uniform_real_distribution(double, double) at comphelper/source/misc/random.cxx:104:12
> #6 in ScInterpreter::ScRandom() at sc/source/core/tool/interpr1.cxx:1768:21
> #7 in ScInterpreter::Interpret() at sc/source/core/tool/interpr4.cxx:4026:43
> #8 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) at sc/source/core/data/formulacell.cxx:1905:23
> #9 in ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned int, unsigned int) at sc/source/core/data/column2.cxx:2964:15
> #10 in ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, int, unsigned long, unsigned int, unsigned int) at sc/source/core/data/table1.cxx:2476:16
> #11 in ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScAddress const&, unsigned long, unsigned int, unsigned int) at sc/source/core/data/documen8.cxx:422:11
> #12 in ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int)::Executor::doWork() at sc/source/core/data/formulacell.cxx:4714:29
> #13 in comphelper::ThreadTask::exec() at comphelper/source/misc/threadpool.cxx:279:9
> #14 in comphelper::ThreadPool::ThreadWorker::execute() at comphelper/source/misc/threadpool.cxx:83:24
> #15 in salhelper::Thread::run() at salhelper/source/thread.cxx:40:9
[...]
suggesting that there is racy concurrent access to the internals of singleton
std::mt19937 comphelper::rng::RandomNumberGenerator::global_rng.
Change-Id: I8209b3903918c567fc832abbb84c8fbcc08e444b
Reviewed-on: https://gerrit.libreoffice.org/74368
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I14d8883d8a0bcba02327395a17bc56978649de4b
Reviewed-on: https://gerrit.libreoffice.org/74374
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
regression from
commit 72c191e046112df73c66be8dc8d1bec5a546fa60
Date: Wed Sep 19 12:11:38 2018 +0200
loplugin:useuniqueptr in ThumbnailView
Change-Id: I9bdcec5c2f14b1bd33998041d4b2d8cd2f7be052
Reviewed-on: https://gerrit.libreoffice.org/74362
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
jmux' suggestion at
<https://bugs.documentfoundation.org/show_bug.cgi?id=125971#c7> turns out to be
the correct fix after all; explained in a lengthy comment why that seemingly
wrong call of translateToInternal happens to do the right thing.
(Much of this patch is about passing the XComponentContext down to where it is
now needed in Qt5FilePicker::getSelectedFiles.)
Change-Id: I235554f8494cd3094a011d5a903059326db499fc
Reviewed-on: https://gerrit.libreoffice.org/74359
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
- tdf#92083 Help: Move Color bar item from View->Toolbars to View menu
Change-Id: I05f65e0c00517fc7b4b8f4d4a93fdb0b4a6d185e
Reviewed-on: https://gerrit.libreoffice.org/74112
Tested-by: Jenkins
Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Long Cell-level hyperlink was clickable in neighboring cells.
Change-Id: I3e2a4db170975d997f3fe471188fd0ead593ad6e
Reviewed-on: https://gerrit.libreoffice.org/74033
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I1b30cb700461fa66192a4b86bf577d1babc76cb7
Reviewed-on: https://gerrit.libreoffice.org/74353
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
regression from
commit 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed May 15 15:35:51 2019 +0200
tdf#125254 Performance: A spreadsheet opens too slow, part2
without this fix, the file from the above bug chews up more than 16G and
crashes my box. With the fix, it loads, and requires about 2G.
Change-Id: I87063196e56b49eab52e77126347bf8d421b1e0f
Reviewed-on: https://gerrit.libreoffice.org/74352
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I17eda9a9cb0425983fe6d23ee2c5b5db4a221b5e
Reviewed-on: https://gerrit.libreoffice.org/74346
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I070f81e2c5a623374c72a8a4ff5a034bf3d1f11c
Reviewed-on: https://gerrit.libreoffice.org/74338
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I126c2565720770ca0fca9fef69a1690cc0bca948
Reviewed-on: https://gerrit.libreoffice.org/74345
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
The problem is that some SwTextFrames (1415 in particular) inside the
follow-flow-row of a table move backwards, during(!) which the
follow-flow-row is deleted; i.e., the SwTextFrame was already moved
backwards by the pNewUpper->Calc() in MoveBwd(), then it is Cut and
Pasted at the end of pNewUpper, when it is actually already a lower,
somewhere in the middle...
This triggers the assert in SwFrame::PrepareMake() that was added in
commit e14056e6e88d9b8d988b7b88b2776a8fc952031b
Prevent this by using the IsDeleteForbidden() check that was introduced
in commit 0005b330eaed0b5559042d2597fb45e0c9125d7e; this is similar to
how MoveBwd() already locks section frames to prevent such problems.
Ultimately a regression from 18765b9fa739337d2d891513f6e2fb7c3ce23b50.
Change-Id: I893ec3e491b4cbe1569edf97fec31d3dd74548ed
Reviewed-on: https://gerrit.libreoffice.org/74298
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
96be3821f7dad19004a43696555eaa4fa2e1aef5 follow-up
Change-Id: I1e585a1f4bcd68757cce7b6327757cd7e9ee660f
Reviewed-on: https://gerrit.libreoffice.org/74306
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I373dbfe89f7563adf7abd44f458da4c79d6f6ca8
Reviewed-on: https://gerrit.libreoffice.org/74314
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I2d5ab9fd1117a4c57eb42ca849daf0949a79ff50
Reviewed-on: https://gerrit.libreoffice.org/73999
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I8b39caafc157e309e638eec1a66d9302f1a11a73
Reviewed-on: https://gerrit.libreoffice.org/74307
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Move XShape Java tests to C++ for ScShapeObj.
Change-Id: I349c4abb09c3e9e43285b63ee5f19f55d967b38f
Reviewed-on: https://gerrit.libreoffice.org/74331
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I02b5d5d7a294fe368e54b4f84d643a55eecadd9c
Reviewed-on: https://gerrit.libreoffice.org/74311
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I64022d6d94560d695271393b27e3b008755bd7a6
Reviewed-on: https://gerrit.libreoffice.org/74315
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I1a74632221a1ae05e035c9aa5bd04914cfe7e7d6
Reviewed-on: https://gerrit.libreoffice.org/74318
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I3df900c495faee29f8ecd42ba5a64e26d403d2fd
Reviewed-on: https://gerrit.libreoffice.org/74320
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|