summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-08-01Fix typoAndrea Gelmini2-2/+2
Change-Id: I2e2f9bf41bbe0427ab39a1f1870bc5104cd88bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137654 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01tdf#149916 follow up to include expand field textJim Raykowski1-1/+2
in cross-reference entry text Change-Id: Iaff06e02d272bbe41e63da5356e6c9a6f67c26f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137665 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-01tdf#138868 SdNavigator: track object selected on canvasJim Raykowski5-5/+60
Change-Id: Ie28d0ee9482d0bcb4a0a8803e499af3bc0e816d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135084 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-01Add 'JobName' to PrintOptionsSamuel Mehrbrodt3-4/+25
Allow users to specify a job name which is sent to the printer (by default this is the current document name). Usage: Sub PrintWithCustomJobname Dim mPOpts(1) As New com.sun.star.beans.PropertyValue mPOpts(0).Name = "JobName" mPOpts(0).Value = "My Job Name" ThisComponent.Print(mPOpts()) End Sub Change-Id: Id7c1c0da7f581b1c050bb3e6d61dd01b7e8205f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137562 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-08-01tdf#142628 Update icons for Field and Field by TypeRizal Muttaqin16-3/+30
Change-Id: I0f369c0d7c426b6f8930f4d34d7e2130c71a06c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137647 Tested-by: Jenkins Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-08-01tdf#120972 DOCX: fix import of decimal tabulatorsTünde Tóth3-3/+18
Use locale specific decimal separator for decimal tabulators, because OOXML does not support custom decimal separator. Regression from commit c0b6aadedc9429eee4f4df85957e00e29ccb0c8f "(related: fdo#81033) writerfilter: default tab fill character is space". Change-Id: I9d89e5817707f3b39a1b718b732f6e289f7c6a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136846 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-31vcl: Better kashida insertion position validationKhaled Hosny2-5/+35
Use the new HarfBuzz glyph flag HB_GLYPH_FLAG_SAFE_TO_INSERT_TATWEEL if available to prevent kashida insertion where is would interrupt shaping (between contextual glyphs). Previously we only prevented it when there is a ligature across the insertion position, with this change fonts that use contextual alternate instead of ligatures will be handled better as well. Change-Id: Ibb42a310c1e7dbcb225a1ba3acac82154b4edb3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-31Update HarfBuzz to 5.1.0Khaled Hosny3-20/+2
Dropping negativeadvance.patch that was applied upstream. Change-Id: I8eba49d2d158c0c29911f4079315ed0bf87b7fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-31tdf#150166 DOCX export: fix broken file with tracked ToC movingLászló Németh4-4/+27
It seems, bookmark export always resulted unpaired bookmark elements around ToC sections without causing any interoperability problem, but replacing bookmark elements with moveRange (where needed) releaved the problem, resulting a file format issue in MSO. Skip export the unpaired moveRangeEnd elements until there is a better solution, i.e. exporting moveRangeStart elements also in paragraph-end positions before TOC sections. Note: for back-porting this is the best, i.e. simple enough to be stable and to get a quick review. Regression from commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519 "tdf#145720 DOCX export: fix loss of tracked moving". Change-Id: I93de467b6a43b2dd3fa97defaef47993969bb7ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137623 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-31sc, out of order undo: allow multiple actions from other viewNoel Grandin4-8/+88
this is the calc equivalent of commit c88c2d40d1a4aebc46b25368b80c02bc2f136658 Date: Fri Nov 12 08:39:35 2021 +0100 sw, out of order undo: allow multiple actions from other views Change-Id: I5acbd1e1cacef7c2e2a549f4d2270e961f576a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31Related: tdf#150196 can't change away from "indeterminate" stateCaolán McNamara2-9/+43
Change-Id: Iefa29d422eb810b4f1404bb9582fac508e1853f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-31Fix typo in codeAndrea Gelmini2-2/+2
Change-Id: Ica86f2c5043fd8f78e83d06778e4b0f468032474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-31tdf#150201 Fix endianness for placeable WMFofftkp2-1/+25
The constant PLACEABLE_SIGNATURE in graphicfilter2.cxx had wrong endianness, which would cause the WMF file detection to fail for placeable WMFs. Changed endianness since WMF files are in little endian. Also added test using placeable and non-placeable WMFs. To run the test: make CPPUNIT_TEST_NAME="testDetectWMF" -sr CppunitTest_vcl_graphic_test Change-Id: Ia3c61bae5ab27375636f21bc902f773804cf9273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137634 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-31Fix typoAndrea Gelmini1-4/+4
Change-Id: I75b3562ac1710c4eed32b916382ec4fff7ce7041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137644 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-31tdf#145226 sw: ODF export: fix table-row/table-cell stylesMichael Stahl5-78/+103
The SwFrameFormat for table lines and table boxes gets an auto-generated name in SwDoc::MakeTableBoxFormat()/MakeTableLineFormat(). The problem is that xmltble.cxx assumes that these SwFrameFormats never have a name, and sets names on them temporarily during exportTextAutoStyles(), then later reads them when exporting the table-rows and table-cells, then eventually resets them all to an empty name. One issue is that it assumes that a non-empty SwFrameFormat name indicates a style has been exported, but that isn't always the case, and the name may still be an auto-generated one. Another issue is that overwriting the names interferes with the use of the names in Undo operations. So store the name for the ODF styles in members of the filter classes instead of the core model. (regression from commit 083fe09958658de8c3da87a28e0f8ff7b3b8a5e9) Change-Id: I9b17962decbf9f8ecd2a91551230cf0f012e7a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127548 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-31sc, out of order undo: allow a subset of a non-empty redo listNoel Grandin3-10/+116
This is the calc analogue of commit 60665dc4a2af238939b1a5056ae4a4ce2c083159 sw, out of order undo: allow a subset of a non-empty redo list Specifically, we used to not allow out of order undo at all if the redo list was non-empty. This relaxes that condition a bit. Out of order undo is OK with a non-empty redo list, in case all undo actions in the redo list are either 1) owned by the current view or 2) independent from the undo action to be executed I.e. if view1 has lots of type undo actions and an view2 adds a single type undo action on top of it, then allow view 1 to execute multiple of its typing undo actions, not just a single one. Change-Id: Ib7ab88e9ebbefce267d3c7d567debd1cd98d7d6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31clang-tidy modernize-pass-by-value in writer*Noel Grandin35-115/+137
Change-Id: Ib08c971eb3e859e7b04cdd408af7966d83c2955b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31tdf#149944 Do away with some excessive, unwarranted horizontal spacingAdolfo Jayme Barrientos1-3/+1
Change-Id: I01e2e57dd85802eba1ab024ca3730ba30f311e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137642 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I3cfb8f3daf8e670adc5fe29edb2e3b6ce2ace0cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137640 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30Fix typoAndrea Gelmini1-9/+9
Change-Id: I8ebd08019541a22acfe763330c2579b9b5c4c7bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137638 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I55558e5252c238be2417d370040760ed9c450a4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137641 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30Improve vcl scheduler documentationHossein1-5/+18
* Fixed a heading problem * Marked variables, functions and identifiers as fixed width * Added several related links Change-Id: If5e56c1e2a474fcfa52601ccda7911bf9e80c913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137636 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-30gtk4: convert AtkObject::accessible-role to something elseCaolán McNamara1-0/+33
we only use AtkObject::accessible-role for "static", but there doesn't seem to be a good match to anything I can see in gtk4. convert it to accessible-role of "alert" for lack of a better idea. Change-Id: Ic0795fed006b827914f1319150a915187188a4db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-30sc: allow undo of typing in 2 views independent from each otherNoel Grandin18-13/+218
This commit follows the same pattern as commit c72e500ccaf0ce2261c5233b80fba9342778f810 sw: allow undo of typing in 2 views independent from each other with some changes since calc and writer have different undo/redo infrastructure on top of SfxUndoManager. Change-Id: Ib6e7e21caccb94752c01c529b5013553dba8b4f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-30Assert downcastJim Raykowski1-0/+1
In this case it should be guaranteed that pField is a pointer to SwGetRefField by: else if (pField->GetTypeId() == SwFieldTypesEnum::GetRef) To follow best practice to allow some diagnostic in debug mode, assert(dynamic_cast) before using static_cast to downcast. Change-Id: Ib2c6fb4259b66d5059f1886e23d05fc1c2aa3682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137578 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-30Add help and list executables options for bin/run scriptHossein1-0/+33
bin/run script is described as: "simple wrapper script to run non-installed executables from workdir". When the bin/run script was used without parameters, it was generating error as it could not run the folder workdir/LinkTarget/Executable. Now, we print usage instructions in this case, or when help is requested with -h, -help or --help. Also, now user can get the list of executables with -l, -list or --list. In normal execution, the script's name is also printed. For example: $ ./bin/run minvcl Setting env variables and running workdir/LinkTarget/Executable/minvcl ... Change-Id: I5c62c300d5247f55d1d1cfd095cecffc979d494b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137626 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-30tdf#117967 Fixes Save confirmation dialog for user cancelMatt K1-1/+18
The "Confirm save" dialog is launched from SfxMedium::CheckFileDate via "xHandler->handle( xInteractionRequestImpl );" and if the user canceled it the error is saved in the SfxMedium via "SetError(ERRCODE_ABORT);". Then, control is returned to the calling function SfxObjectShell::SaveTo_Impl which currently doesn't handle the cancel error condition, so this change just adds a check to detect it and return instead of doing more "save" processing. This return then goes to the calling function SfxObjectShell::DoSave_Impl which also does some save processing after cancel, in particular it updates the timestamps of the current SfxMedium (which are checked in SfxMedium::CheckFileDate from above and determines whether the "Confirm save" dialog will be launched), so this change prevents the updates to the timestamps by exiting early (i.e. before "DoSaveCompleted();" is called) if the abort error condition is seen so as to avoid a timestamp comparison result of equality which would prevent the "Confirm save" dialog from showing on every subsequent save action from the user. Now the behavior is for the timestamp comparison to fail equality (as would be expected if the file changed underneath the user) so as to ensure the "Confirm save" dialog continues to show for every subsequent save action by the user. Change-Id: I9c4aefc163a06029c80a8a28cdf4a09dff0031a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137540 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2022-07-30tdf#149467 fix re-entrance crashJim Raykowski1-12/+3
This crash is caused by an odd re-entrance happening. In this case re-entrance to SwContentTree::UpdateTracking happens when SfxHintId::DocChanged is broadcast from SwDocShell::SetModified when GetContentAtPos is called from SwContentTree::UpdateTracking which eventually causes a stack crash. Getting model position for view point when getting content at position (GetContentAtPos call to GetModelPositionForViewPoint) shouldn't set the document modification state. Which is what happens using the steps to repro this crash. This patch disallows setting document modification state during the DocumentStylePoolManager::GetFormatFromPool call from SwTextINetFormat::GetCharFormat. backtrace of last 100 levels before crash: 1 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 551 0x7fffbddbde96 2 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 3 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 4 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 5 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 6 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 7 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 8 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 9 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 10 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad 11 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 40 0x7ffff4180f32 12 SwDocShell::SetModified docsh2.cxx 1446 0x7fffbe53b663 13 SwDocShell::Ole2ModifiedHdl docsh.cxx 1150 0x7fffbe52d660 14 SwDocShell::LinkStubOle2ModifiedHdl docsh.cxx 1131 0x7fffbe52d597 15 Link<bool, void>::Call link.hxx 111 0x7fffbd8889f5 16 sw::DocumentStateManager::SetModified DocumentStateManager.cxx 50 0x7fffbd888729 17 SwDoc::MakeCharFormat docfmt.cxx 861 0x7fffbd6ef2b8 18 SwDoc::MakeCharFormat_ docfmt.cxx 883 0x7fffbd6ef43a 19 sw::DocumentStylePoolManager::GetFormatFromPool DocumentStylePoolManager.cxx 1514 0x7fffbd89132c 20 sw::DocumentStylePoolManager::GetCharFormatFromPool DocumentStylePoolManager.cxx 1718 0x7fffbd892d86 21 SwTextINetFormat::GetCharFormat txtatr2.cxx 144 0x7fffbdfa1a03 22 SwTextINetFormat::GetCharFormat txtinet.hxx 52 0x7fffbddb4f4e 23 CharFormat::GetItemSet atrstck.cxx 145 0x7fffbddb07e5 24 SwAttrHandler::PushAndChg atrstck.cxx 345 0x7fffbddb1047 25 SwAttrIter::Chg itratr.cxx 102 0x7fffbddf02db 26 SwAttrIter::SeekFwd itratr.cxx 296 0x7fffbddf1104 27 SwAttrIter::Seek itratr.cxx 419 0x7fffbddf17b3 28 SwAttrIter::SeekAndChgAttrIter itratr.cxx 158 0x7fffbddf06e2 29 SwTextIter::SeekAndChg itrtxt.hxx 313 0x7fffbde01791 30 SwTextCursor::GetModelPositionForViewPoint itrcrsr.cxx 1658 0x7fffbddff83f 31 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 604 0x7fffbddbe337 32 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 33 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 34 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 35 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 36 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 37 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 38 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 39 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 40 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad 41 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 40 0x7ffff4180f32 42 SwDocShell::SetModified docsh2.cxx 1446 0x7fffbe53b663 43 SwDocShell::Ole2ModifiedHdl docsh.cxx 1150 0x7fffbe52d660 44 SwDocShell::LinkStubOle2ModifiedHdl docsh.cxx 1131 0x7fffbe52d597 45 Link<bool, void>::Call link.hxx 111 0x7fffbd8889f5 46 sw::DocumentStateManager::SetModified DocumentStateManager.cxx 50 0x7fffbd888729 47 SwDoc::MakeCharFormat docfmt.cxx 861 0x7fffbd6ef2b8 48 SwDoc::MakeCharFormat_ docfmt.cxx 883 0x7fffbd6ef43a 49 sw::DocumentStylePoolManager::GetFormatFromPool DocumentStylePoolManager.cxx 1514 0x7fffbd89132c 50 sw::DocumentStylePoolManager::GetCharFormatFromPool DocumentStylePoolManager.cxx 1718 0x7fffbd892d86 51 SwTextINetFormat::GetCharFormat txtatr2.cxx 144 0x7fffbdfa1a03 52 SwTextINetFormat::GetCharFormat txtinet.hxx 52 0x7fffbddb4f4e 53 CharFormat::GetItemSet atrstck.cxx 145 0x7fffbddb07e5 54 SwAttrHandler::PushAndChg atrstck.cxx 345 0x7fffbddb1047 55 SwAttrIter::Chg itratr.cxx 102 0x7fffbddf02db 56 SwAttrIter::SeekFwd itratr.cxx 296 0x7fffbddf1104 57 SwAttrIter::Seek itratr.cxx 419 0x7fffbddf17b3 58 SwAttrIter::SeekAndChgAttrIter itratr.cxx 158 0x7fffbddf06e2 59 SwTextIter::SeekAndChg itrtxt.hxx 313 0x7fffbde01791 60 SwTextCursor::GetModelPositionForViewPoint itrcrsr.cxx 1658 0x7fffbddff83f 61 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 604 0x7fffbddbe337 62 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 63 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 64 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 65 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 66 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 67 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 68 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 69 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 70 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad 71 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 40 0x7ffff4180f32 72 SwDocShell::SetModified docsh2.cxx 1446 0x7fffbe53b663 73 SwDocShell::Ole2ModifiedHdl docsh.cxx 1150 0x7fffbe52d660 74 SwDocShell::LinkStubOle2ModifiedHdl docsh.cxx 1131 0x7fffbe52d597 75 Link<bool, void>::Call link.hxx 111 0x7fffbd8889f5 76 sw::DocumentStateManager::SetModified DocumentStateManager.cxx 50 0x7fffbd888729 77 SwDoc::MakeCharFormat docfmt.cxx 861 0x7fffbd6ef2b8 78 SwDoc::MakeCharFormat_ docfmt.cxx 883 0x7fffbd6ef43a 79 sw::DocumentStylePoolManager::GetFormatFromPool DocumentStylePoolManager.cxx 1514 0x7fffbd89132c 80 sw::DocumentStylePoolManager::GetCharFormatFromPool DocumentStylePoolManager.cxx 1718 0x7fffbd892d86 81 SwTextINetFormat::GetCharFormat txtatr2.cxx 144 0x7fffbdfa1a03 82 SwTextINetFormat::GetCharFormat txtinet.hxx 52 0x7fffbddb4f4e 83 CharFormat::GetItemSet atrstck.cxx 145 0x7fffbddb07e5 84 SwAttrHandler::PushAndChg atrstck.cxx 345 0x7fffbddb1047 85 SwAttrIter::Chg itratr.cxx 102 0x7fffbddf02db 86 SwAttrIter::SeekFwd itratr.cxx 296 0x7fffbddf1104 87 SwAttrIter::Seek itratr.cxx 419 0x7fffbddf17b3 88 SwAttrIter::SeekAndChgAttrIter itratr.cxx 158 0x7fffbddf06e2 89 SwTextIter::SeekAndChg itrtxt.hxx 313 0x7fffbde01791 90 SwTextCursor::GetModelPositionForViewPoint itrcrsr.cxx 1658 0x7fffbddff83f 91 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 604 0x7fffbddbe337 92 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 93 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 94 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 95 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 96 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 97 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 98 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 99 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 100 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad Change-Id: I7e0814cf3a42dc876dd60c926d4b2245a036cc3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135802 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-30tdf#118696 better fix for sd Navigator object selectionJim Raykowski1-10/+5
resulting in unexpected view movement This fix reverts commit 3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 and reintroduces DrawViewShell::MakeVisible with change made to the passed object rectangle always being the snap rectangle instead of the rectangle returned from a call to object GetLogicRect. Change-Id: I05e777545fb1093838c05618e87ad4d4f5ec003c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137008 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I1b6c7eccebffc80b057eb2730428b20047ee685b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137625 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: Ic4929dd699b4b28572e46c99ce49d95371b54bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137624 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30tdf#150045 Set secondary/explanatory labels apartAdolfo Jayme Barrientos16-1/+112
Rationale in commit 0ebbe1f0080f474fd583e5912c9605e6fb2e13d5, of which this is a follow-up. Change-Id: If75aa32bf02aeb8761f5b7f4ddbbeaa3bdcaab3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137618 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-29Verify signing certificate cryptographically before use in testsMike Kaganski5-9/+27
Documents signed using an invalid (e.g., not having a trusted root) certificate give signatures that obviously can't pass validity tests. Change-Id: Id4b097516e06c548ea42cad65d76bbd8a6853cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137620 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-29Resolves: tdf#147782 restore focus to launching frame asynchronouslyCaolán McNamara2-3/+16
Change-Id: I7ebde70e4e1aae861f6ac7d70a91741596cb2cc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29gtk4: update vcl when popup was closed by some external meansCaolán McNamara1-0/+9
Change-Id: Ie580cd0b42ca1c928bfea20a4a9f1494021047d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29cid#1507489 Big parameter passed by valueCaolán McNamara1-4/+4
and cid#1507490 Big parameter passed by value Change-Id: I53a8ee3fd0312de6fecd39238eff90cfff5b3261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29cid#1507491 cut and paste typo triggering 'Constant' variable guards dead codeCaolán McNamara1-1/+1
Change-Id: I9b833575f3cc3ba886b355eefdfa9155d2dffae1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137587 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-07-29svx: manipulate SdrObject::m_aOutRect indirectlyTomaž Vajngerl11-106/+189
Change-Id: I0d8a8e4df06595250c07a61181fbd76fe1da5662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-29svx: remove using namespace and unneeded "css::" ns declarationsTomaž Vajngerl4-137/+122
Change-Id: If2eb5f61798e4efbcc845957fc1345b1560bcbe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137570 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-29Related tdf#117276 sc: Show hidden filter elements as inactive elementsBalazs Varga1-4/+9
Ignoring filtered-out value when we unselecting All, re-selecting All button, hitting the Cross-button ("Hide only the current item") or hitting the Check-button ("Show only the current item"). Followed up commit of 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1 Change-Id: I33e169a08054f1afec887915730eeae9a26d4739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137558 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-07-29cid#1507492 Improper use of negative valueCaolán McNamara2-2/+2
Change-Id: I7c44307917df3397cfc9c99a982c54f51693e660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29tdf#87605 Add new words to technical dictionary.nazanin yadi1-0/+5
Change-Id: Ic9eaf11c75f91812d3feb839f47e0898e12d65e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135455 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-07-29Better valid certificate check, consider filter dataMike Kaganski3-13/+41
Otherwise, testSignCertificateSubjectName that has an explicit certificate subject name requirement would fail when user has other valid certificates, but not this one. Change-Id: Ic3c440a8316314c922a53a51085a3e829f235f6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137593 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-29tdf#119840 make this loop a little more efficientNoel Grandin1-2/+7
by breaking out early Change-Id: I2444c9f8b79e0b517eb3ab3b19fed2d98c52a8e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29use more SwPaM::StartEndNoel Grandin36-147/+88
which is more efficient than calling Start() and End() separately Change-Id: I41c99527bcb37728bb9a87f63ed654e0be3d1f0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137614 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29clang-tidy modernize-pass-by-value in xmlreaderNoel Grandin2-3/+4
Change-Id: I448d3119129a864e79dbef336e46545f9aca8b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29tdf#150187: Crash in Presentation Styles - Background objects - ModifyJulien Nabet1-0/+6
Regression from e85b482df3fa01e5a2b549df63db96cc49f1ca78 (use SfxItemSet::GetItemIfSet in cui) Change-Id: I74889f21f2bda248946269b0caf5ddc629002ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137580 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29gtk4: add an initial placeholder image to flag there will be one set laterCaolán McNamara1-0/+6
Change-Id: Ib1696b16990d3ae08fd2be10cc9fe89322287369 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137576 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29resave with latest gladeCaolán McNamara1-32/+32
Change-Id: Ic47dd35a859723895d25ffa210d8cc8971c28e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29tdf#150100 sc import and UI: fix double cell border dialogBalazs Varga5-17/+83
Hide "Hairline (0.05pt)", "Very thin (0.5pt)" and "Thin (0.75pt)" predefined border types for Double cell borders, because it has a minimum thickness 1.1pt, which means, we cannot allow to select them. Also setting the Medium (1.5pt) predefined thickness to the border width for Double borders as the thinnest possible predefined value. TODO: tdf#146466: Inconsistent choices of borders between toolbar and sidebar Change-Id: I46ccb206835a34a6dfaa39e63e614bb01bc6b02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137441 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 04:36:51 +0000