summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-09-25loplugin:useuniqueptr in SfxWorkWindowNoel Grandin2-30/+27
Change-Id: I30ae51c05dfbee5fc754d26d3de3e41c30834b31 Reviewed-on: https://gerrit.libreoffice.org/60952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in SvxRTFParserNoel Grandin3-48/+33
Change-Id: Ib759d5bcc7ce7cd9ea8ad752e5363375fa24e8f0 Reviewed-on: https://gerrit.libreoffice.org/60957 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in cmis::DataSupplierNoel Grandin2-14/+6
Change-Id: If12889ffe320c6a2e2808709ce53438e92077a58 Reviewed-on: https://gerrit.libreoffice.org/60958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25inline SvxIconChoiceCtrlEntryList_impl typedefNoel Grandin2-48/+35
and simplify usage in SvxIconChoiceCtrl_Impl Change-Id: If72d14be66cdf3135ad4edf5502a478a0857d7dd Reviewed-on: https://gerrit.libreoffice.org/60951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in CmisPropertiesWindowNoel Grandin2-13/+5
Change-Id: I113160675aa7af0a3a425fe0cab4f68ee24adf27 Reviewed-on: https://gerrit.libreoffice.org/60956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in CustomPropertiesWindowNoel Grandin2-22/+12
Change-Id: I8d3f700fcdcb853518729f966dd8651579676a36 Reviewed-on: https://gerrit.libreoffice.org/60954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in CmisPropertyLineNoel Grandin2-42/+18
Change-Id: If54a2c546cb3c65417c1ebcc4957cce41597dd07 Reviewed-on: https://gerrit.libreoffice.org/60955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25loplugin:useuniqueptr in ThumbnailViewNoel Grandin6-35/+36
Change-Id: I95817a03afedbee4ffb28041a9834e591356102d Reviewed-on: https://gerrit.libreoffice.org/60953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25Simplify containers iterations in xmloff/source/[c-d]*Arkadiy Illarionov21-294/+191
Use range-based loop or replace with STL functions. Change-Id: I2af2d739d55a0bf480bb6e9d57b49dd16806af30 Reviewed-on: https://gerrit.libreoffice.org/60734 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25tdf#119599 RTF import: fix missing deduplication of font sizeMiklos Vajna5-31/+64
Deciding when to and when not to deduplicate repeated direct formatting of paragraph / character properties is stricky, this bug is about a case when deduplication should happen and did not, since commit 1970a686273c5d4fc1eeb4430283e37085d9f647 (tdf#113408 RTF import style dedup: separate paragraph and character handling, 2017-10-31). Especially that deduplication works in both directions: it should remove properties which are duplicated and also should insert explicit default values for not repeated properties. Fix the problem by making the getDefaultSPRM() aware of the context (which style type it deals with), and then by making sure that only default properties relevant for the given style type are inserted. Change-Id: I35b6599cc47fa51b8754fd921c61a3b31a283547 Reviewed-on: https://gerrit.libreoffice.org/60946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-25KJ: Add LICENSE fileRizal Muttaqin1-0/+166
Change-Id: Iee80ba5e1dab7d36798dc3e9dcbae3dfc86e86a0
2018-09-25tdf#120108 KJ: Update decrease indentation & wrap icon; add LICENSERizal Muttaqin12-0/+8
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b7
2018-09-25tdf#119922, sanitize the point count when extrapolate is usedMarkus Mohrhard1-0/+2
Change-Id: Iec5e591f51ab13efa4b014b82df213e91eb5b793 Reviewed-on: https://gerrit.libreoffice.org/60949 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-25tdf#120015, don't crash without major tick marksMarkus Mohrhard1-0/+4
Change-Id: Icac79eb1c0c47388f96d37d2921c81fb6c848607 Reviewed-on: https://gerrit.libreoffice.org/60948 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-24This remark is now unnecessaryAdolfo Jayme Barrientos1-1/+1
Change-Id: I766ae652ef08c865eb5faa0f2d53220ccb00c828
2018-09-24Personas: add 6 themes to the selection dialogandreas kainz3-28/+102
Change-Id: I1e8c28f477602c7578ca7e40bd7d14550dc1aaf8 Reviewed-on: https://gerrit.libreoffice.org/60930 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen99-83/+216
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24make all the related inheritences formatted the same wayCaolán McNamara9-9/+9
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24tdf#118690 don't try to process all messagesJan-Marek Glogowski1-1/+6
Regression from commit 221b0ab1245b ("WIN use Reschedule instead of own dispatch loops"). This limit the maximum reschedule loops as the original code did. There is still a busy loop when opening the print dialog, as it was before the patch, but this at least gets printing started. Change-Id: If867329b82b13c898bb15b08584244084488a66c Reviewed-on: https://gerrit.libreoffice.org/60310 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-24Remove accidental addition of executable bit under icon-themes/*Adolfo Jayme Barrientos3969-0/+0
Change-Id: I6a2bcdd8403494490a44c11179bf87411f73d32a
2018-09-24loplugin:external (clang-cl)Stephan Bergmann77-191/+265
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24-Werror,-Wunused-variable (clang-cl)Stephan Bergmann1-1/+2
Change-Id: I4132e02ce9a4eb509a2e70a705068102f95ffd3e Reviewed-on: https://gerrit.libreoffice.org/60937 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Resolves: tdf#119624 stray image_position bottom for some icons in buttonsCaolán McNamara8-9/+0
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24missing includes (--with-webdav=serf)Stephan Bergmann3-0/+8
Change-Id: I021b378b2ae001a38c8f84a71e90ec4f14c905e6 Reviewed-on: https://gerrit.libreoffice.org/60928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Scheduler: add per-priority Task listsJan-Marek Glogowski6-117/+158
This way we don't have to search the whole list for a higher priority event, if an immediate Task is found. This probably helps bugs like tdf#119724 and tdf#119428. Change-Id: Ic5685193d1bedb6996cf46f0ee2cba42190ff7cc Reviewed-on: https://gerrit.libreoffice.org/60572 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-24loplugin:simplifyconstruct (--with-webdav=serf)Stephan Bergmann1-1/+1
Change-Id: I3a52b0e2517cfd88f661dde2b01b2e6bc6913ba2 Reviewed-on: https://gerrit.libreoffice.org/60927 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Personas: add 6 default themesandreas kainz25-1/+784
Change-Id: Id8a920054c5b6f560ff2b26ce39c2a99574ad680 Reviewed-on: https://gerrit.libreoffice.org/60929 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-24Simplify assertion codeStephan Bergmann1-13/+8
...avoiding conditional blocks and variables (that need careful #if'ing to avoid them being either undefined or unused depending on NDEBUG and OSL_DEBUG_LEVEL combintaion) Change-Id: Ica9fe3857694f5c0a6e9079dfff05f2e0554b781 Reviewed-on: https://gerrit.libreoffice.org/60926 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Looks like these functions can be static and not STDAPIStephan Bergmann1-4/+4
...as they appear to only be called from within this .cxx. (And <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> documents that STDAPI expands to a return type of HRESULT, among further decoration.) Change-Id: I4994e6e6f8fe0466f9aa9b4c9cf2c20bd718fa05 Reviewed-on: https://gerrit.libreoffice.org/60925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24weld ScTabPageProtectionCaolán McNamara2-56/+46
Change-Id: I85fa703ebe73987822f85ff722f02627751937ec Reviewed-on: https://gerrit.libreoffice.org/60909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24coverity#1438870 Big parameter passed by valueCaolán McNamara1-40/+50
Change-Id: I6ade72ed19b63b7f68c8f58c57bb409eab55e55c Reviewed-on: https://gerrit.libreoffice.org/60919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24sw: prefix members of SwRedlineExtraData_Format, ...Miklos Vajna2-32/+32
... SwRedlineExtraData_FormatColl and SwRedlineExtraData_FormattingChanges. Change-Id: I7dedf293ba06879985d4652e073642d5a15d97ca Reviewed-on: https://gerrit.libreoffice.org/60922 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-24elementary: improve many icons, add more 32 pxRizal Muttaqin4697-29962/+6864
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b6 Reviewed-on: https://gerrit.libreoffice.org/60920 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-24NB tabbed: graphic update writer and draw layoutandreas kainz2-75/+162
open calc and impress and drop down graphic menu Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b5 Reviewed-on: https://gerrit.libreoffice.org/60778 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-23Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' - tdf#108890 Chapter Numbering button “Format” renamed “Load/Save” Change-Id: Iec39885663c838dfaf112c1a4a99bcde7b9f9036
2018-09-23coverity#1401334 Uncaught exceptionCaolán McNamara6-8/+12
Change-Id: Id6dad66b3c55e5b3049f57e65c857db5abce50b1 Reviewed-on: https://gerrit.libreoffice.org/60901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-23tdf#120056 reorder radiobuttons elements into desired logical orderCaolán McNamara1-20/+20
Change-Id: I770dad005779e7bf347221afad46633371f17a07 Reviewed-on: https://gerrit.libreoffice.org/60908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-23tdf#108890 - "Format" in outline/chapter dialog not self-explanatoryheiko tietze1-1/+1
Renamed to Load/Save according discussion on BZ Change-Id: I7444ffc6b2d6158542357364fd6a282a1684a33d Reviewed-on: https://gerrit.libreoffice.org/60876 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-23qt5: fix buildThorsten Behrens1-0/+2
Add missing header after 60a23d5d5f0963cd9bea7711ff4336418e3d6392 Change-Id: Ic24a78db3b425966e49fec96160d10670f68dea4
2018-09-23ŧdf#120069: Do not crash changing background color in drawXisco Fauli1-1/+12
Regression from c57f10b67fceef47d304d74dce93be7389a7720c, where I disabled the master background in Impress but not in Draw, and both share some common code. Besides, disable master background in draw as well. Follow-up of bug tdf#111306 Change-Id: I772382b5ed8eff3a35d001ea498810613137d172 Reviewed-on: https://gerrit.libreoffice.org/60913 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-23loplugin:unusedmethodsNoel Grandin19-329/+154
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22Always disable loplugin:expressionalwayszero, to avoid false positivesStephan Bergmann1-5/+0
bdade7e3fc33c1832c6f6a472443fca8238738d2 "tdf#105444 DOCX import: don't put extra paragraphs in comments" caused > /home/sbergman/lo2/core/writerfilter/source/dmapper/DomainMapper_Impl.cxx:441:22: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > (sizeof(SAL_NEWLINE_STRING)-1 == 2 && xCursor->getString() == "\n")) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ now with sufficiently new Clang, and the code looks reasonable, and there's no apparent way to avoid such false positives in the plugin. (It could check for a sub-expression of the problematic expression being an object-like macro, but SAL_NEWLINE_STRING could just as well be a variable instead of a macro. That variable would need to be defined in some #if to have different values on different platforms, so the plugin could theoretically check for such conditional inclusion, but it's not clear whether that's worth it and would even be a useful heuristic to not produce neither too many false positives nor too many false negatives.) So just disable the plugin for good. Change-Id: I85dc8573735ccac4e19be20ab7443cbaa85a3164 Reviewed-on: https://gerrit.libreoffice.org/60907 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-22Ensure settings consistency for default personasMuhammet Kara2-8/+25
Change-Id: I7610e890a8b49c50bf23ed07daa5517c33edcb8d Reviewed-on: https://gerrit.libreoffice.org/60897 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-22ofz#10610 Direct-leakCaolán McNamara1-1/+1
Change-Id: If7cd5e7157419c5d3b3a7ff834613e7f6489047c Reviewed-on: https://gerrit.libreoffice.org/60900 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#119569 try most likely to succeed method to get column metadata _before_Lionel Elie Mamane1-16/+23
We first try to prepare the statement and get metadata information. That's fine. Some DB engines/drivers will not give column information on an unexectured prepared statement. In that case, first try to execute the statement with all parameters set to NULL, which is likely to succeed. If not, keep "execute the raw SQL indiscriminately" as a last resort. I'm not sure it will ever be useful, though. Change-Id: I76b5fd6b2059e96fabe9a611c8e3ed115acfc964 Reviewed-on: https://gerrit.libreoffice.org/60884 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-22tdf#120045 propagate_natural_[width|height] illegal in gtk 3.18Caolán McNamara1-2/+0
no warning in glade about it, though there is for other such things that don't exist in the targetted version Change-Id: Ib1522aaf9709b94274db378678314dc945048d97 Reviewed-on: https://gerrit.libreoffice.org/60899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22external/harfbuzz's libharfbuzz.a links against icuuc libraryStephan Bergmann1-0/+1
buovjaga reported on IRC that his build (implicitly --without-system-harfbuzz --without-system-icu) failed to link e.g. Library_vclplug_gtk3 due to harfbuzz missing symbols from ICU, like > /usr/bin/ld: /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/.libs/libharfbuzz.a(libharfbuzz_la-hb-icu.o): in function `hb_icu_unicode_decompose_compatibility(hb_unicode_funcs_t*, unsigned int, unsigned int*, void*)': > /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/hb-icu.cc:334: undefined reference to `unorm2_getNFKDInstance_62' [...] It is not clear to me why Library_vclplug_gtk3 would actually use libharfbuzz.a's hb_icu_unicode_decompose_compatibility (and for e.g. my builds, it apparently doesn't), but in general libharfbuzz.a does depend on some symbols from icuuc, so it is correct to add icuuc to the link when linking against harfbuzz. (And "gb_LinkTarget_use_external,...,icuuc" conveniently only adds libs for linking, and does not add C/C++ include file paths, which would not be wanted here.) (<https://gerrit.libreoffice.org/#/c/60882/> "Revert 'Add more more dependencies to VCL makefiles'" was a false start trying to address the above issue.) Change-Id: Ic8bcfa2aab185f8a9487d7787b4f22068e7cb481 Reviewed-on: https://gerrit.libreoffice.org/60898 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-22unwind ItemWrapperHelperCaolán McNamara4-18/+5
Change-Id: I171150342e04bee6efd97f36f769a2c3d1db4bd7 Reviewed-on: https://gerrit.libreoffice.org/60887 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22weld AlignmentTabPageCaolán McNamara15-638/+610
Change-Id: I253a01b053efe836b0657f9a711cecd060b6782b Reviewed-on: https://gerrit.libreoffice.org/60883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#67248 unittest for: Use localized layer name only ...Regina Henschel2-0/+15
for display in UI. The test counts the layers. The error was, that a user layer was merged into a standard layer. Change-Id: Ib73e14965689b005a7d42811b6de9126dd3ef57d Reviewed-on: https://gerrit.libreoffice.org/60892 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 05:31:58 +0000