Age | Commit message (Collapse) | Author | Files | Lines |
|
Regression from 2b58a0979f9206cfca6d78cb2f3d5e65cd735f8b
"Add sanity check to avoid potential crash in the Collabora Online
server"
Change-Id: I2fcfb634b47f9d76f8efbbd64a8e69ea236894c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135024
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
(CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
2022-04-07) for motivation.
Change-Id: Icbf2c3b4c1dfcdf551ea8c1f1f9520449b55289a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135029
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
API version 32 refers to the Android 12L feature drop
(Android 12.1).
According to [1], "12L is a special feature drop that makes Android 12
even better on tablets and foldable devices."
When getting over the list of behavior changes for apps targeting
Android 12, I didn't realize anyting relevant specific to API level 32
not yet in API level 31 as well, so there seems to be no need
for any special adjustments for this update on top of
commit 2ab389b251744fa7f3f6b060c09746e59d87f3b1
Date: Tue Apr 19 10:33:27 2022 +0200
android: Update compileSdkVersion/targetSdkVersion to 31
[1] https://developer.android.com/about/versions/12/12L
Change-Id: Ic99c4ee5b81b6584648fa4717e23cc7f3c78bdab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134988
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: If2edff8006c3aa904d40dabf679d5ed0b0fd0127
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134987
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: Iac3831d400d29b45be82d2585ca1454ed22676be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134986
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
(Likely broken) DOCX documents exported by Writer raised a SAX
exception, when PopFootOrEndnote() tried to access to a
not-existent footnote, because PushFootOrEndnote() failed to
create that.
Note: the original ODT contains hundreds of frames, and
these and the text content of the document have been put
into the TOC section during Writer's DOCX export, resulting a
broken document.
Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
"tdf#76260 DOCX import: fix slow footnote import".
Change-Id: I9e32feb0cae778a87f034a8b5c41989fec90899d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134934
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Add paragraph property to disable automatic hyphenation of short
words based on a minimum character count.
Note: there is a (broken) global option for Minimum Word Length
at hyphenation, see "Minimal number of characters for hyphenation"
in Tools->Options->Language Settings->Writing Aids), but
for better/comfortable paragraph-level adjustment of typesetting,
add a paragraph property for it. The same option is available e.g.
in Adobe InDesign and in CSS Text Module Level 4 (hyphenate-limit-chars).
* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationMinWordLength)
* Add ODF import/export
* Add ODF unit test
* Add layout test
Follow-up to commit 8c018910ae4d8701b1ce2a95727b9baed4016da3
"tdf#149248 sw offapi xmloff: add option to not hyphenate last word".
Change-Id: I68715f47d17b5c022430bd0e74c88a97bc7f81f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135028
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I96d99fbdce2b0432676acec8b327cece7c39bcb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134983
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since...
commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3
Date: Mon May 23 15:48:41 2022 +0200
Advanced Diagram support: Isolated IDiagramHelper, selection visualization
we've already derefed pObj so can drop that check
Change-Id: I9bdab5c069405c0015f74e4621e7b37fbbed2dd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id418d65ce165d93e84463ae321ca2db869e857cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134670
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I9fbee006237ccb70e31109023cf46b21aec325d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134668
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I12273f1193a4089743b8e5a9716432e065930cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134990
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Fails with commit 9a76be53dfb801b754bf55f9d4b8c5f82991a62f (sw content
controls, picture: add LOK API, 2022-05-23) reverted.
Change-Id: I6164e597099632a2212afee86ac9a4c7555e5c61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135022
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Add option to disable automatic hyphenation of the last word of
paragraphs for better typography.
Note: the same option used e.g. in Adobe InDesign, and a
similar one in CSS Text Module Level 4 (hyphenate-limit-last).
* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationNoLastWord)
* Add ODF import/export
* Add ODF unit test
* Add layout test
Follow-up to commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69
"tdf#121658 Add option to not hyphenate words in CAPS".
Change-Id: Ida29c65b5a7cbfd7c399c342781531a6fb86f639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134985
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
can put SwDataChanged on the stack
Change-Id: I6631d04e181e2156184833642abdfab83092da60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135015
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
shaves 20% off the time of
./instdir/program/soffice.bin --calc --convert-to pdf
~/Downloads/ofz24932-1.rtf
Change-Id: I85c8bdd51895d768c37d247f6bf07ce9183d1107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since...
commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3
Date: Mon May 23 15:48:41 2022 +0200
Advanced Diagram support: Isolated IDiagramHelper, selection visualization
we've already defered pGrp can just drop that check
Change-Id: I2b36a5fdc7e49ba1a8d4be5df910be0392bb7960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135019
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This started with commit 3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4
(framework: avoid re-creating protocol handler instances all the time,
2022-05-02). In case there are 2 monitors, then one monitor shows the
slideshow, the other shows the presenter console. The presenter
console's protocol handler in
sdext::presenter::PresenterProtocolHandler::Dispatch::Dispatch() has
mpPresenterController->GetWindowManager() as an empty reference on the
2nd time the presentation starts.
The above commit started to cache protocol handler instances at a frame
level for performance reasons, and this is meant to be safe in general,
but the presenter console's window manager is re-created between
slideshow runs, so it depends on framework/ code to re-create the
protocol handler all the time, which is problematic here.
Fix the problem by introducing a framework::CacheInfo interface that
allows protocol handler implementations to signal if they want to avoid
being cached.
This should be good enough for now, but if later it turns out that there
are too many broken protocol handlers out there, then we can consider
flipping the default and only cache handlers which explicitly opt in for
this behavior. This is not done in this commit.
Change-Id: Ic159813b1b339540bc8c4e780c4d6d7d2d4d2445
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135020
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I06456afa84314b3348bce177c939f510e00aa743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134993
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which speeds up some searching in the pool
Change-Id: I9fe7da50b4d803010c88702d8cd03c3380e7cc0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134992
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
by using std::move on the newly created poolitem, so that the pool does
not need to clone it
Change-Id: Ib90b14173d19768517eb2a31cc0a105e5eb4d7c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134991
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Map the Date, DateFormat and DateLanguage UNO properties to:
<loext:content-control loext:date="..." loext:date-format="..." loext:date-rfc-language-tag="...">
And do the opposite on import.
Change-Id: I16d3f755d77ed20380d877ba65dfe6d063f2bec2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134977
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I37b2f965edffbc8ff803ca84389e06b61d27f225
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134980
Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
... from https://crashreport.libreoffice.org
The script saves the data into a .csv file
Change-Id: I771d144402a3039851c99b025c52bd6e799f71ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134283
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Unnumbered Entry, Add to List icons
Change-Id: I8b00bc0780a483d7c71597c8d09cd35228d92e7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134984
Tested-by: Jenkins
Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I3f89238187dfb8cfd7a929d5f5576b83f6ec37c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134982
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I29074d801eaef57f160ce14b943b21831b327ecf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134979
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This reverts commit a4a62ea283e20a01c0c0c99359c6e029484fedb0.
Reason for revert: misstyped bug number
Change-Id: Idcaa75db63e006def67841e5c7df1b68aa7f0f40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134999
Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I3843420f896c8913267ec7d699804304c1bc2af4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134976
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I242cf305d4e6d8ef26968e196c9f169754b90d5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132849
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
This went wrong in commit 5de22d1e559cd0f1f5fa4e247f0ce153710fbeab
(Handle "addfont" from Collabora Online, 2022-03-09), running e.g.
online.git unit-tiff-load with sanitizers complains:
kit/Kit.cpp:2977:9: runtime error: call to function (unknown) through pointer to incorrect function type 'int (*)(const char *, const char *, _LibreOfficeKit **)'
I.e. the type in lok_preinit_2() is LibLibreOffice_Impl**, but the type
in LokHookPreInit2 is LibreOfficeKit**.
Since this is just a pointer, there is no harm in adapting
lok_preinit_2() to match.
Change-Id: Ib80711a5ae7719a9058151f482aca50c43185348
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134941
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Which was perhaps the last missing piece of the "sd theme: shape fill
color" story.
Change-Id: Ice75d91412aa56afe0c9995086097d491ebf7299
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134952
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to 35e3b240996d1ad5f3011d72f92e8623665a09e2
- Fix typo in reference
following f3b76b5e8d644176704c4619304278869ae57127
tdf#141474 Cdbl, Cint, Clng, Csng accept keyword arguments
Change-Id: Ie580b7a975fe0f5bf0e3563fd9dba7762314a2f1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134911
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This way at least e.g. std::vector::operator[] will still check
bounds even though things like iterator debugging will not work.
Change-Id: If3c550cfec68eee9a19050fc8e60fca07148b4a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134946
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Removed a redundant assert on returned value of `MacrosTest::loadFromDesktop`.
Change-Id: Ia318cd770b120baff87e7cf5f01120beaf112794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134957
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: Ic15b8e56959606d8dbacb073d6e80d5188dc7502
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134975
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I341871c65e63f37ffc3507daaefe035f6762e62b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134956
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Writer apparently sometimes asks to lay out RTL text as LTR,
for whatever reason, and Harfbuzz in that case does not give
consistent results usable for creating subsets of glyphs (or maybe
HB_GLYPH_FLAG_UNSAFE_TO_BREAK is not reliable in that case).
I don't quite understand what the problem here is, but avoid
it by checking whether the text is LTR or RTL and simply do
not try to create a subset from the glyphs if the text does
not match the way it was asked to be laid out. I don't even
know if this is correct handling or just a workaround for something.
Change-Id: Ic77db04f529c9ca2c194893a2127e85953accf32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134950
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ic0e5ea44525e7cf76a6de1f64f77b943b8347dfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134948
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
I.e. use the existing operator==. I don't feel like writing
operator<< for it just for one unittest though.
Change-Id: I63181765a4987a5d6efedc74a1e20d56a70eaa83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134947
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I7f9290383eabcf3733f15f8f45193ee04db9852f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134953
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Seems on Windows, we're hitting the 8k character max cmd line length,
on setups with slightly deeper src tree path locations. Shorten length
of expanded call_installer calls by putting shell script into PATH
locally.
Change-Id: If1cddab9e4e07a7c5ebfae7a4e88e43b1bc8b907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134938
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Change-Id: Ie5a84488312b9f17733747942e45d767cd5d4966
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134928
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
A small optimization.
Change-Id: I21786ce713bd39d14c075a941d83c060d04b8886
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134949
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
For now at least, as this is causing a number of Jenkins Mac failures,
even though it originally passed (and still occassionally does).
This reverts commit 04a36851aab1272c9c21ac97d0fc0f4ffe372fe0.
Change-Id: I21454b6ec59e96dfb5f6eb723d4eb8f19948d195
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134955
Tested-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
without the overhead of the UNO service engine
Change-Id: I4a02fda2b3c92a897634374bf72cfffee4f531f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134923
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Idcb296980ea498373a0fb4f8c0c584eef2c5c9f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134922
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8b664f10bee232355eeb431de6b1445d9c797f6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134921
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6a966e84574716a215d1625cde8b6826185cc451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134935
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
just ignore it in that case
Change-Id: I8f294acd9ee16d2f9c8662614fac3672f80b3376
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134937
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|