Age | Commit message (Collapse) | Author | Files | Lines |
|
comphelper::AsyncEventNotifier is an amazing class that dispatches
events in separate threads, no doubt implemented during times of
exuberant optimism about the tractability of shared-state
multi-threading.
Unfortunately the authors forgot to think about how all those awesome
threads will be joined, so if they are somehow blocked, then it may well
happen that the events are dispatched when the main thread is already in
DeInitVCL, and the objects required for the dispatching already smell
somewhat funny.
This happens quite reproducibly when changing dbaccess' ModelMethodGuard
to lock the SolarMutex too, then CppunitTest_dbaccess_RowSetClones
crashes in DeInitVCL() because one AsyncEventNotifier thread was blocked
until then by SolarMutexGuard, and this test never Yields once its
document is loaded.
Try to fix this by joining the "DocumentEventNotifier" threads from
DeInitVCL() itself.
Since there's no rtl::WeakReference to go with rtl::Reference, refactor
the AsyncEventNotifier and create a new AsyncEventNotifierAutoJoin
that has to be used with std::shared_ptr and std::weak_ptr.
Change-Id: I50a0749795acb04b0776e543f7125767b697ea35
Reviewed-on: https://gerrit.libreoffice.org/27581
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I29503324f221c42208267f4f0d36922e89119fdd
|
|
there still isn't enough space for it in writer, but at least
what is there can be read.
I'd love to get this info out of the status bar and into some
overlay shown in the selection when moving the object.
Change-Id: I688690a57253d3774c06f5edcb0931503c6d2ac6
|
|
Change-Id: I917e5457be6de152b39e91ad41b6ed196dfe3e45
|
|
regression from...
commit eb276d11a652601f743d69ada7a38016bd97d73e
Author: Fridrich Štrba <fridrich.strba@bluewin.ch>
Date: Mon Jul 8 14:01:17 2013 +0200
fdo#38878: Upgrading internal xpdf -> poppler
before this the hashed _OOO_pdfi_Credentials_ was used
in the removed OOoImportSecurityhandler::authorize
but after this the hashed password continued to be
passed through stdin, while the unhashed password
was the required data.
Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
|
|
Change-Id: If32319c1d93756d633f07a21c76e0107181704b0
|
|
Change-Id: I3adb510be10b12953e2889d0d3b74402479194ee
|
|
Change-Id: I84bf3788ac092c491d7c5a9f86421f1cf9f3e814
|
|
Change-Id: Icdd71733c4e9f4b36e6e957e4dea772087890faa
|
|
Change-Id: Ia1bcc1be9e61626da2d60ea679d4b6e7e114ac9f
Reviewed-on: https://gerrit.libreoffice.org/27661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
|
|
Change-Id: I1dbb6bf57dc78f321e6e6d69b7e573309aff8f48
Reviewed-on: https://gerrit.libreoffice.org/27658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I2e5c8102684494fd3d7c1c70971a09d0c940a124
Reviewed-on: https://gerrit.libreoffice.org/27637
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6
Reviewed-on: https://gerrit.libreoffice.org/27580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Not needed, unlock() checks if a lock is present first.
If present, it means that LOCK is available, inferring the presence of
UNLOCK availability.
Change-Id: I007c4b02b27e8a40f15721c0308c894ad6f482fd
Reviewed-on: https://gerrit.libreoffice.org/27660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
|
|
Change-Id: I68a46cfad2cdc09c1963576275033ff40c678c04
Reviewed-on: https://gerrit.libreoffice.org/27655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I77ffd10e94ecebb045e0a9e7c756180790645885
Reviewed-on: https://gerrit.libreoffice.org/27651
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ica56ab0821718c75c902f97cad3d278cd568f157
Reviewed-on: https://gerrit.libreoffice.org/27644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I0c322cb157b102faa8d5cfdeb696f7912d5aa720
Reviewed-on: https://gerrit.libreoffice.org/27656
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I439ded1581bcbe623abbcd2a1e51402689c56057
Reviewed-on: https://gerrit.libreoffice.org/27645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Id36e716253768321e1ddfb977a22470c6b694147
Reviewed-on: https://gerrit.libreoffice.org/27510
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I566c5554bf32ea18121c5a186365b97c91667c5d
|
|
Change-Id: Ic82520cc0ff41ce9630460ffe6320f8f278f2bf8
Reviewed-on: https://gerrit.libreoffice.org/27646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I3d12e141e1cf6c70c3fbae7b6fb25a2fabeed77b
|
|
On some MS Excel version (OS X), the column "width" is
not applied, if "customWidth" key (in "col") is not set to "true".
It means that in case of .xlsx files, exported by LibreOffice,
all columns have default width. To resolve that "customWidth"
key was added during export into .xlsx file format.
During development it appears that Default Column Width is wrongly
calculated, and it was done not according to MS documentation.
This issue was also fixed. After fix default column width is
properly set.
MS documentation:
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.column.aspx
Change-Id: I0d1944081a5ea445d1e4284db62e9b4d504bf1c0
|
|
Tab Window
Add emoji.json to installation directory
Read the JSON data from code
Filter emojis according to categories
Insert Emoji at cursor position
Toolbar control
Change-Id: Ia5a577ce41398132872914ebfa499e4d4077d57e
Reviewed-on: https://gerrit.libreoffice.org/26700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
HTTP error 501 the server tells us the used method is not
implemented, non need to retry.
Change-Id: I4529d2bc27a87e8f3463ded578c6c55e0701ae17
Reviewed-on: https://gerrit.libreoffice.org/27636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
|
|
Added some verbose SAL_INFO to detail server responses to PROPFIND.
Corrected a wrong comment and beautified a bit code I introduced
in commit 3b26a2a403ca5e99b0dd07d042d47501c091af16.
Change-Id: Id59749fe60fe0b451d8e0f4093d7902fe94bbed0
Reviewed-on: https://gerrit.libreoffice.org/27635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
|
|
Change-Id: I70348b4e4bb85850331044e901c03aabb0d22ef8
|
|
Change-Id: I04a85820914a9b50ded0545d5a685b6bda205e77
Reviewed-on: https://gerrit.libreoffice.org/27650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ic6eda2e0b5c398a0644d3274fa4f6169d6dc09d9
Reviewed-on: https://gerrit.libreoffice.org/27600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I70a7b10d46cdafc4dd59f8fc046587a6219a2218
|
|
In .xlsx, the XML_outlineLevelRow and XML_outlineLevelCol keys
are required for Microsoft Office365 application
to properly displaying Outline values.
Change-Id: If4184ddc4fbfaa409732ddb0fb4ca85b4a27b024
|
|
Change-Id: I926a0df300aad01f531832f857373e9764c32b1a
Reviewed-on: https://gerrit.libreoffice.org/27653
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ib0877d9ad871a24e49ee59aac70b43e969480236
Reviewed-on: https://gerrit.libreoffice.org/27601
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I662113d5c980ac3cf47d8f27450ffb7c0d3d6519
Reviewed-on: https://gerrit.libreoffice.org/27602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
... so it actually gets disabled in menu or removed from context menu if we say
so. Used with disallowing Paste for Ctrl+A selection or protected cells.
Change-Id: I7d5f8bdc7b7adee65d08b93ddee015aef953d95d
|
|
... which exhausts memory unless you have 100GB or more of free RAM.
Change-Id: Ie6f02c48457f80acad33d2286194765f8343f2fb
|
|
Change-Id: Ib24b00d501b9c56d83a8cbd8bca4351109e07f54
|
|
and one hasn't been set yet via the mail merge wizard. This
should have the same effect as launching mail merge and cancelling
it, which is given as the workaround
Change-Id: I9deb8173d2e18ccde705a923a74ef8a1175e9393
|
|
Change-Id: I4e9298fced82c6ef21611873a756f509b049c662
|
|
Change-Id: Iba980a6016ae7c604964ce1f12707818609fabdb
|
|
Change-Id: Ie191d66d3902281ccf7962d025ecc60e48e20cba
|
|
Change-Id: I4ea78c729bec2e8879426dae6116d747083c72b3
|
|
rather than spend the rest of my life protecting each one
Change-Id: I181df33b052a0303f072ce0252d98562231569e2
|
|
Change-Id: Ia50ea146052c2014ea16474186e2d15ce93581c1
|
|
Change-Id: Ie747db5f46b0a83bda44d211b0ac69bc19092fbc
Reviewed-on: https://gerrit.libreoffice.org/27615
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ic8060ebdabb86d8b724ee419fdfcc1f58e8a0316
Reviewed-on: https://gerrit.libreoffice.org/27614
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
If anything fails at context creation then don't forget to
deallocate resources.
Temp window creation is written C like, as it was copy/pasted from
an C example.
Change-Id: Ia9d704e42206b1d4c37db2954bba4f165e3c8389
Reviewed-on: https://gerrit.libreoffice.org/27613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
To get the anti-aliased polygon we draw a anti-aliased line around
every trapezoid. This works fine until we draw a transparent
polygon where the lines become visible because of blending. A much
better and faster way is to just draw the polygon outline with
anti-aliased lines. This is done with this commit.
Change-Id: Ice50e5eb3343f2c5d51ade8ad0e170043541f0ff
Reviewed-on: https://gerrit.libreoffice.org/27611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I33c2c9b1c4ea3979f16b36af170c515df1f6b0c2
|