summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-12-07Natvis: improve O(U)String visualizersMike Kaganski1-6/+16
... and unify them. Makes sure to show non-printing/special characters in the strings (like \n, which didn't show properly); expands buffer to show all its elements, not only the first one. Change-Id: Iab12bbb51f9e39b066866649b297f51837c7c0f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143767 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-07loplugin:singlevalfieldsNoel Grandin9-450/+765
Change-Id: Ic7dd2cb433add02ecc72eee0c85dd7f0efe1d47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-07Check for failed mallocStephan Bergmann1-0/+4
...thereby silencing > In file included from /usr/include/features.h:490, > from /usr/include/bits/libc-header-start.h:33, > from /usr/include/stdio.h:27, > from soltools/mkdepend/def.h:40, > from soltools/mkdepend/main.c:58: > In function ‘read’, > inlined from ‘main’ at soltools/mkdepend/main.c:197:28: > /usr/include/bits/unistd.h:38:10: error: ‘__read_alias’ specified size 18446744073709551614 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=] > 38 | return __glibc_fortify (read, __nbytes, sizeof (char), > | ^~~~~~~~~~~~~~~ > /usr/include/bits/unistd.h: In function ‘main’: > /usr/include/bits/unistd.h:26:16: note: in a call to function ‘__read_alias’ declared with attribute ‘access (write_only, 2, 3)’ > 26 | extern ssize_t __REDIRECT (__read_alias, (int __fd, void *__buf, > | ^~~~~~~~~~ seen at least with -Wp,-D_FORTIFY_SOURCE=3 manually added to gb_COMPILEROPTFLAGS in an --enable-optimized build against recent GCC 13 trunk Change-Id: I9ca3c0ea8c579fffbdad52d7d39a4ce82085ddcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143760 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-07sw, lok: implement a getCommandValues(Bookmarks)Miklos Vajna3-3/+81
There was no LOK API to get a list of all bookmarks where the name matches a certain prefix. This is useful in case the API client wants to know what previously inserted bookmarks were deleted by the user as part of deleting text content. Add a new getCommandValues(".uno:Bookmarks") that returns the names of matching bookmarks. Do not return the bookmark text, assuming that would be updated by the API client anyway. In practice this is needed by Zotero in case it wants to model its citations with bookmarks. Change-Id: I42a544c3c64496519eec6826b58a310ec86dee74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143764 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-07Revert "tdf#53023 - Remove last empty paragraph from auto text"Andreas Heinisch502-546/+96
This reverts commit ce64398653a896c8a48dd6cabe2b75d9c025873d. Reason for revert: UI-Tests hang Change-Id: Ib4b576e66da8642f3ffe8774e92a7e7c2c527b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143717 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-07tdf#151894 Pre-init NSSpellCHecker to avoid SolarMutex deadlockStephan Bergmann1-0/+22
Besides the deadlock scenario documented at <https://bugs.documentfoundation.org/show_bug.cgi?id=151894> "FILEOPEN a Base Document with customized event for open a startform by 'open document' LO stuck" there is at least one other known scenario documented at <https://gerrit.libreoffice.org/c/core/+/143565/> "Fix hang during JunitTest_framework_complex on macOS" (which even carries a true fix, for just that one scenario, which wouldn't require this hack). Change-Id: Iafcb39607e71cc3abe46ce762f9c1785a62acfd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139702 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-07tdf#151185 Make Table Design button toggle-ableRafael Lima3-3/+1
Change-Id: I86dfc7a6567b24cc6e9a20203625eeb09c17536c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143574 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-07sd: improve handling of table styles on page pastingMaxim Monastirsky4-3/+29
- Remove table styles that were copied from the source document, but not actually used in the pasted pages. Same as we were doing already for graphic/cell styles. - Disable the undo record of inserted cell styles, as long as we don't have undo actions also for the table style. This prevents data loss, as otherwise the table style will be exported, but not the cell styles it uses. The difficulty with having an undo action for table styles is that once a style is removed from its family it is disposed, so we no longer able to use that style for a redo action. This was "solved" in i#120015 for graphic/cell styles, by not disposing them at all. However table styles maintain cyclic references with their cell styles, so we can't give up on disposing. I'll take the time to think on a proper solution for this (e.g. making copies of styles instead of dealing with the original ones might be an option). For now, let's just remove this unfinished undo attempt. Change-Id: Iae06273217b2d695401921a84e7edf096556530e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143749 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-12-07Resolves: tdf#152392 use sidebar text color for COL_AUTO in examplesCaolán McNamara1-0/+33
Change-Id: I5f5c1a6c79c65bd1d4bf2de4af02bef5d60ee5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-07sw: split out some of the LOK parts of SwXTextDocument into a separate fileMiklos Vajna3-140/+183
Because this has little to do with UNO. Change-Id: I683832d0704086f259a29bc1eefae77fd62f26e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143761 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-07sdext: move the include of XComponentContext.hpp to where it is usedKevin Suo2-2/+1
... and remove unsed include. XComponentContext.hpp is used in pdfiprocessor.hxx but not in drawtreevisiting.hxx. XMultiServiceFactory.hpp is not used drawtreevisiting.hxx. Change-Id: Ic98cbcdcacd07cf2163e02ac569781f70edd953c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143570 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-07sw layout xml dump: avoid confusing content of SwParaPortionMiklos Vajna3-20/+26
The problem is that the SwParaPortion is also the first line layout, so the string it presents is not the content of the paragraph but of the first line. Just remove it as we have better replacements: - in case really the whole paragraph is wanted, the (text) content of the parent SwTextFrame can be used - in case in fact the first line is wanted, then the first child SwLineLayout still has a portion attribute the provides the unchanged substring Change-Id: Ic4a0f64ecc40e9a74adc79c5205d5d92c882256b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143743 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-06Resolves: tdf#152381 Treat 0-0-0 invalid date as 0 relative daysEike Rathke1-0/+16
Change-Id: I70cf18395e26ababa854299a58f8839f5bdf8e2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143748 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-12-06tdf#152029 Visually draw attention to in-view bookmarkJim Raykowski7-36/+224
when mouse pointer is over bookmark entry in the Navigator content tree This patch brings attention to in-view bookmarks when the mouse pointer is positioned over bookmark content entries in the Navigator content tree. All in-view bookmarks are brought to attention by placing the mouse pointer over the bookmark content type (category) entry. The patch adds a parameter to the weld::get_dest_row_at_pos function to give the option not to auto scroll. It is needed to prevent auto scrolling when used in the the mouse move handler. Additional use can be made in the content tree CommandHdl to make the tree not jump when the context popup menu is activated for entries near the top and bottom of the the visible tree. Change-Id: I04e306286ca58ab6c8ae7e5c02b25a0592c4a9d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143628 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-12-06Fix typoAndrea Gelmini1-1/+1
Change-Id: I30f6c0d9a3d373078cffc46a243cdde99e707b81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143742 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2022-12-06Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 490d42493e8dbec31ad58978df5084b080a36fcb - Fix typo Change-Id: Ie6f0171043ce7f0efc3db60e1b9aab7f4c3a75c2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143716 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-06weld InformationDialog info dialogCaolán McNamara12-316/+132
Change-Id: I6a3631fe06a1b46164f01d706ecefd7252509382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143740 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-06InformationDialog is a misleading nameCaolán McNamara5-8/+8
It's not the Minimizer dialog, it's the document frame that the dialog is associated with. Change-Id: Ifb7de8dc3fa5ffa5180dab17f9b327fe7296dd0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143738 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-06add Assistant::set_page_side_imageCaolán McNamara6-3/+19
Change-Id: I70685a74ebed465771473ce885f4f29af209cda6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143737 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-06Resolves: tdf#121297 weld Presentation MinimizerCaolán McNamara17-1693/+1508
Change-Id: Ifdf1746bc9f6567a1aded233a4350f6828604c9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143678 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-06sw:qa: add mailmerge export directly pdf unit testHenry Castro2-0/+71
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I53570149a6e05f05f9ebff7d4931d7f1a02a27f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143490 Tested-by: Jenkins
2022-12-06sfx2: rename FN_PARAM_1 to FN_NOUPDATEHenry Castro4-4/+7
The parameter is intended to not update the fields from data source otherwise it will reset to the first record. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I204cd20b8eb0b3f26c204e139c72b479c83bbf0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142276 Tested-by: Jenkins
2022-12-06sw, .uno:InsertBookmark: add a new BookmarkText parameter and accept HTML thereMiklos Vajna3-1/+75
There was already an UNO command to insert a new bookmark with the provided name, in a non-interactive way. What was missing is to allow specifying the bookmark text, which is to some extent not part of the bookmark, but e.g. the bookmark dialog allows editing that still. Add a new BookmarkText parameter to .uno:InsertBookmark, in case it's specified then we interpret this as HTML and we create the bookmark on the imported content, not simply at the current cursor position. This is similar to commit 1c2ef850db29beb369dcc89a58fc73416ecd9c5c (sw, .uno:TextFormField command: accept HTML in the FieldResult parameter, 2022-11-16), but that was for the field mode, while this is for the bookmark mode of Zotero. Change-Id: I4928d173e197796d40fdb53f81e84b6bfd77cdc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143736 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-06sfx2: add log information to catch the exceptionHenry Castro1-2/+14
Add log information for data analysis if the ExportTo fails due to an exception. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142239 Tested-by: Jenkins
2022-12-06crashtesting forum-en-4598.odsNoel Grandin1-1/+12
the pattern object may be replaced inside the IsValue() call because it might trigger interpreter logic Change-Id: I99cee16333f3ab0585d94de98946ea77938e14ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143734 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-06get-forum-attachment: Add one more mso forumXisco Fauli1-0/+1
Change-Id: Ie8549b8f965197f1afeb1886db0bf7f70464377c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143739 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-12-06Resolves: tdf#151722 use UI Language for localized font namesCaolán McNamara1-6/+3
instead of system locale Change-Id: Ie1f33644fcb8529b237db372b7d8daea19af8ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-06Resolves tdf#132398 - New hicolor/macOS iconsgaljit682-141/+364
- Replaced old with new hicolor icons - Added files wherever were gaps - Changed non-oasis mimetype files to symlinks - Removed "draw.svg" and put "drawing.svg" in scalable - Added "macos" directory for special MacOS icons Change-Id: Id10a386f6144db4f0a1a7a118c44687fffbe0568 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139754 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-06build installer packages with make parallelism instead of GNU parallelChristian Lohmaier4-71/+63
6204336cc7242ff1b0fdc26ccb7f8dd4f362fb78 added support for building installsets in parrallel using the GNU parallel tool, this patch changes that to use make's own parallelism, dropping the need for the external tool. By not creating huge commandline for all packages at once/sequentially, the workarounds to modify the PATH variable can also be dropped. Since : is a special character in makefiles separating a target from prerequisites delimiter in the installer-tuples has been changed to the hyphenation point. The dependencies on the install.phony target have been moved to the actual installset targets (and those are .PHONY targets as well since the target file isn't actually generatead). Also unify the tuples for the different platforms, even if the first element is only used for Windows. Move the msi templates to a separate directory for the different types, so that packaging can also be done in parallel on Windows. Move the setup back to the makefile so it can be setup prior to running the script. Previoulsy the script used grep to remove comments from the msi template files, and had to use "|| true" since grep would also return error when not finding a match/on empty files. Switch that to awk so it can run without that workaround. Change-Id: I2f8b73e04d0f601cb0b4e2d8352a38ef9957bc17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143679 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-06tdf#150940: Store frame reference in the panelMike Kaganski3-7/+14
It is needed to properly dispatch the commands in case of embedded objects, otherwise they are dispatched to the top-level frame. Change-Id: Ia5fadf7c35bded75f1ca20a682dc6c9f14548990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143693 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-06tdf#152058 THEMES: Not possible to change back to default lookNoel Grandin1-2/+0
Revert "dont keep writing to config when persona is set to 'no'" This reverts commit e0c424ba729e4659ce1007254adbbceafbeaef5b. Change-Id: Ia2724c075c7a5fc8deaaedc5cd4356f93b9a6f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-06Need --disable-gen for the Qt5-based WASM LibreOffice nowTor Lillqvist1-0/+1
Otherwise we get the slightly mysterious "Can't select gen VCL plugin, if --without-x is used!" error from configure.ac. Change-Id: I3ffda8f7306ff48a619052df25186f0989370d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143707 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-06Move cppu::BaseMutex up to the base class OPropertySetNoel Grandin50-104/+33
Change-Id: I0e51987714e32ece19609c7a6d500995e6fc3601 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-06Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 2201e80bead1e137a96775b2b6081752caeed77f - Fix grammar Change-Id: Idae562b619b8cacde07eeae62d995782f5c2b7ed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143590 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-06tdf#53023 - Remove last empty paragraph from auto textAndreas Heinisch502-96/+546
Remove the last empty paragraph before inserting an auto text. The carriage return at the end of it is appended in SwXMLTextBlockParContext::~SwXMLTextBlockParContext() which can't be removed without introducing side effects. In order to compensate for the change, a paragraph has been added to the existing only text auto texts. Change-Id: Ie098f23d7bdc70798197e5714e041c8fd79f0439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143353 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-06Disallow linking files as Writer sections in OnlineAndras Timar1-0/+16
Change-Id: I9e4971c72db44ca8216ac468240dd52d46e0b680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143225 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143672 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-06tdf#152134 Customize: assign user macro to menu hangsNoel Grandin1-21/+12
regression from commit d4257daba1155ebccbfebea99bad0e4152ca9b08 Author: Noel Grandin <noelgrandin@gmail.com> Date: Fri Dec 24 20:58:28 2021 +0200 use comphelper::WeakComponentImplHelper in MenuBarManager We should not hold the mutex while firing events, since the mutex is now non-recursive. Change-Id: I6ee45df0bf27df3ca1fd31857285ceb820161d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-06Simplify a bitMike Kaganski1-22/+17
Change-Id: Ieeb7f66e224283ac41b98cc184207a4da6d231ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-06Update libxmlsec to 1.2.37Miklos Vajna1-2/+2
Fixes two regressions, see <https://github.com/lsh123/xmlsec/discussions/452>. Change-Id: I81317d81e61d1a0d113ebf46d7813b2db7e0aea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143684 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-06tdf#151847 Some chart UNO objects were not advertising their types propertyNoel Grandin6-0/+33
which means that accessin them from python and trying to use the XPropertySet and related interfaces doesn't work nicely Change-Id: I873f6a6fcb048e7f8244313cd737c04b003259a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-06tdf#152380: add checks for names and values sequences length equalityMike Kaganski10-1/+39
Change-Id: Ibeef551126874bcfffb4e7736588e2e1873f5768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143681 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-06Shuffle code aroundKhaled Hosny1-56/+55
Change-Id: I3b3a88c91634fb19a39d21cdd0095d34badea1e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143687 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-06Simplify PhysicalFontFace::CreateFontSubset() a bitKhaled Hosny3-25/+20
Hide the logic inside fontsubset and don’t leak it to the caller. Change-Id: Ibc845e0051eaeb64e8de42f80d4d404fd6a3880e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143686 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-06tdf#113048: Fix PDF ascender and descender of some fontsKhaled Hosny6-21/+34
Use the same ascender and descender calculation for fonts with CFF table as fonts without CFF table. This also provides a better fix for tdf#138325 and tdf#151039. Change-Id: I416a123199e94401fa557fce95013eb8b0590e33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143683 Tested-by: خالد حسني <khaled@aliftype.com> Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-06"using namespace com::sun::star" -> css in header fileKevin Suo2-5/+3
See Stephan Bergmann's comment the following change (thanks!): https://gerrit.libreoffice.org/c/core/+/143598 Change-Id: I409b823439979c64cadcb582d8fb4dec4ff412b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143664 Tested-by: Jenkins Reviewed-by: Kevin Suo <suokunlong@126.com>
2022-12-05Make check for complete type more explicitStephan Bergmann2-2/+2
When 485c9d4f0e59e13e772da8f8a7975f0ddd77c33e "Clarify the use of untools::WeakReference" introduced cppu::detail::isUnoInterfaceType and its use in the requires-clause of unotools::WeakReference::get, its commit message argued that while isUnoInterfaceType only works if the given type is complete, that would already be taken care of via the use of std::is_convertible_v in the implementation of unotools::WeakReference::get. But while std::is_convertible_v nominally requires its argument types to be complete (unless they are void, or arrays of unknown bound), typical implementations like recent libc++ or libstdc++ do not seem to enforce that (and just return false in such a case). So better make isUnoInterfaceType explicitly require that the given type is complete. Which turned up one case where it isn't at the point where unotools::WeakReference<SdrTextObj>::get is called. (And while the resulting call to dynamic_cast<SdrTextObj*>(...) in the implementation of that function would cause an error when SdrTextObj is not complete, compilers happened to instantiate that template specialization only at the end of the TU, by which time SdrTextObj happened to be a complete type in the TUs including that sd/source/ui/inc/futext.hxx. So all happened to work out OK.) Change-Id: I704b8b437fa836e290245d1727e4d356128ef63c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-05Drop dummy functionKhaled Hosny2-11/+0
Type 1 support is long and this was always dead code anyway. Change-Id: Ia00626e7d44419af333feb59d4dc52e624ffd263 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143682 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-05cid#1517256 Dereference null return valueCaolán McNamara1-0/+1
Change-Id: I20bcd522526d5da3dcb9f24f7ae07ad6f9465459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-05NFC cleanup docxattributeoutput: use existing function to clearJustin Luth1-6/+1
The function already clears these things, so use it - which should also prevent bugs where a clear is put in one place and not the other. A dead giveaway was that m_bHasId = false is also done in the function. Change-Id: Ibb97b8da246404841afa5a03d11514dbcc7157b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143604 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-05Make sure bHasShadow has a valueStephan Bergmann1-1/+1
Change-Id: Ic955e31619799918f26d6db2d6e688decfbce6c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143676 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-29 18:43:14 +0000