summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-09-09a system cuckoo isn't availableCaolán McNamara1-0/+1
build without it and see what warnings there might be Change-Id: I54b4d0c784631d26f634c63157563203bc37f1b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121864 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09crashtesting: assert making thumbnail on reexport of tdf127770-1.ods to odsCaolán McNamara3-4/+54
convert to B2DPolygon earlier and do scaling on B2DPolygon's doubles #18 0x00007f534e1093bc in ImplLogicToPixel(tools::Long, tools::Long, tools::Long, tools::Long) (n=<optimized out>, nDPI=<optimized out>, nMapNum=<optimized out>, nMapDenom=<optimized out>) at vcl/source/outdev/map.cxx:268 __PRETTY_FUNCTION__ = "tools::Long ImplLogicToPixel(tools::Long, tools::Long, tools::Long, tools::Long)" n64 = <optimized out> #19 0x00007f534e10a4ff in OutputDevice::ImplLogicToDevicePixel(tools::Polygon const&) const (this=this@entry=0x55c3ebbb9f60, rLogicPoly=...) at include/tools/gen.hxx:80 rPt = Point = {x = -794275722273860480, y = 0} i = 0 nPoints = 2 aPoly = {mpImplPolygon = {m_pimpl = 0x55c3e9fdc250}} pPointAry = 0x55c3e9c9b970 #20 0x00007f534e0ff4d4 in OutputDevice::drawPolyLine(tools::Polygon const&, LineInfo const&) (this=this@entry=0x55c3ebbb9f60, rPoly=..., rLineInfo=...) at vcl/source/outdev/polyline.cxx:251 nPoints = 2 aPoly = {mpImplPolygon = {m_pimpl = 0x7f534e0bfde8 <__gnu_debug::_Safe_sequence<std::__debug::vector<OutDevState, std::allocator<OutDevState> > >::_M_invalidate_if<__gnu_debug::_Equal_to<__gnu_cxx::__normal_iterator<OutDevState const*, std::__cxx1998::vector<OutDevState, std::allocator<OutDevState> > > > >(__gnu_debug::_Equal_to<__gnu_cxx::__normal_iterator<OutDevState const*, std::__cxx1998::vector<OutDevState, std::allocator<OutDevState> > > >)+208>}} __PRETTY_FUNCTION__ = "void OutputDevice::drawPolyLine(const tools::Polygon&, const LineInfo&)" aInfo = {mpImplLineInfo = {m_pimpl = 0x55c3eaa4ca68}} bDashUsed = <optimized out> bLineWidthUsed = <optimized out> #21 0x00007f534e0ff3d8 in OutputDevice::DrawPolyLine(tools::Polygon const&, LineInfo const&) (this=this@entry=0x55c3ebbb9f60, rPoly=..., rLineInfo=...) at vcl/source/outdev/polyline.cxx:135 __PRETTY_FUNCTION__ = "void OutputDevice::DrawPolyLine(const tools::Polygon&, const LineInfo&)" #22 0x00007f534e1f1d56 in MetaPolyLineAction::Execute(OutputDevice*) (this=0x55c3e998e300, pOut=0x55c3ebbb9f60) at vcl/source/gdi/metaact.cxx:481 #23 0x00007f534e1be27a in GDIMetaFile::Play(OutputDevice&, unsigned long) (this=this@entry=0x55c3e9e4c700, rOut=..., nPos=86, nPos@entry=4294967295) at vcl/source/gdi/gdimtf.cxx:371 nCurPos = 48 i = 48 pAction = 0x55c3e998e300 nObjCount = <optimized out> nSyncCount = 4294967295 #24 0x00007f534e1be4e1 in GDIMetaFile::Play(OutputDevice&, Point const&, Size const&) (this=this@entry=0x55c3e9e4c700, rOut=..., rPos=Point = {...}, rSize=Size = {...}) at vcl/source/gdi/gdimtf.cxx:512 aDrawMap = {mpImplMapMode = {m_pimpl = 0x55c3e9f338d0}} aDestSize = Size = {width = 756, height = 1020} pMtf = 0x0 aScaleX = {mnNumerator = 756, mnDenominator = 341, mbValid = true} aScaleY = {mnNumerator = 1020, mnDenominator = 461, mbValid = true} rOldOffset = Size = {width = 0, height = 0} aEmptySize = Size = {width = 0, height = 0} bIsRecord = false #25 0x00007f534e1be9c5 in GDIMetaFile::CreateThumbnail(BitmapEx&, BmpConversion, BmpScaleFlag) const (this=this@entry=0x55c3e9e4c700, rBitmapEx=..., eColorConversion=eColorConversion@entry=BmpConversion::N8BitColors, nScaleFlag=nScaleFlag@entry=BmpScaleFlag::Default) at include/rtl/ref.hxx:206 aAntialias = Size = {width = 756, height = 1020} aBitmap = {maBitmap = <incomplete type>, maAlphaMask = <incomplete type>, maBitmapSize = Size = {width = 94299930324064, height = 139995769668141}} aVDev = {<ScopedVclPtr<VirtualDevice>> = {<VclPtr<VirtualDevice>> = {m_rInnerRef = rtl::Reference to 0x55c3ebbb9f60}, <No data fields>}, <No data fields>} aNullPt = Point = {x = 0, y = 0} aDrawSize = Size = {width = 189, height = 255} aSizePix = <optimized out> nMaximumExtent = 256 aAntialiasSize = Size = {width = 760, height = 1024} Change-Id: I4284a7da0684845d7c0af136b25c5210d522c79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-0/+14
Change-Id: I8eaf65fa4d1982ff60f612088adea6d636246612 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09tdf#143905: Parse password from connection stringjucasaca1-11/+25
Parse user and password, so its possible to connect to a firebird server more over embeded and file Change-Id: Idbfa526e2a29f6f8bed5165f57844350c8b6d127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121638 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-09Fix typoAndrea Gelmini1-1/+1
Change-Id: I899c68cf53657eaab6a72ae36594606b31d9fb8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121859 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-09tdf#144241 don't return a negative width for osx edit regionCaolán McNamara1-5/+7
instead expand the region to the min osx width Change-Id: I01dc336c97ba9573948e1ca8f3eeb3ac46008819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09flatten DocumentRedlineManager a littleNoel Grandin2-166/+164
no need to allocate these things separately Change-Id: I832e77587e1272a6be5dfc8d460891564ed07517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09reserve space in vector to reduce reallocationsNoel Grandin1-98/+99
Change-Id: I6263c0b742331138188f7b557c05b2a59188d4fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09fix std::move same object more than onceNoel Grandin1-1/+1
after commit 8104d771b10a5c8b15eae4b67aa112ae2ef77b5b tdf#144052 reduce Primitive2D copying spotted by mikekanganski Change-Id: I97e4675a9042cfafa3f9f6c053ba2f50aeea2183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09tdf#144052 reduce Primitive2D copyingNoel Grandin94-308/+314
when creating charts, by using a Primitive2DContainer&& parameter in the GroupPrimitive2D constructor, which forces the call sites to pass a temporary, and at most call sites, we can std::move in an existing local variable. Change-Id: I531970918800c6832ab606b5a4ff5fd2d47ccf5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09Resolves: tdf#144389 get_accessible_parent should only be called on vcl implsCaolán McNamara1-16/+5
Change-Id: If5d8718fcd9bcccee37e162a99cc68ff4a77de8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09merge ThumbnailView and ThumbnailViewBaseCaolán McNamara9-38/+20
only ThumbnailView inherits directly from ThumbnailViewBase and it will simplify a11y if ThumbnailView instead of ThumbnailViewBase is available Change-Id: I715faa3f9b2cec68c1de07479b7d1dbbd9ddbcc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09ODT export: order <style:font-face> elements inside <office:font-face-decls>Miklos Vajna4-12/+108
This builds on top of commit 92471550b8c43d8ff0cef8b414884d697edf9e63 (ODF export: sort <style:font-face> elements based on the style:name attribute, 2021-03-11), the additional problem was that the style:name attribute already has number suffixes to have unique names for fonts where the style name would match. This means that even if we sort the container right before writing the elements, which font gets the number suffix depends on the insert order. Fix this by additionally sorting the font items before insertion, given that a single call-site does all the insertion, at least for Writer documents. This is required as SfxItemPool::GetItemSurrogates() exposes a container which is based on SfxPoolItemArray_Impl, which uses an o3tl::sorted_vector<> of pointers, so effectively unsorted, the order depends on the pointer address of the font items. Change-Id: I46569b40796243f7f95b92870504c2023b2ce943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121823 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-09tdf#144052 speedup inserting large chartsNoel Grandin3-5/+60
we don't need to immediately re-order objects when setting the Z-order, just set the dirty flag and we can calculate the proper order layout. This takes the time for the chart to appear from multiple minutes to 20sec for me. Change-Id: If80569da09469423f19f9fe82b40dfbdac14f161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09reduce time in ResetEvent (tdf#144052)Noel Grandin1-0/+5
Change-Id: I3e9c906a026e7455fb775d110eca32f8533614e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09loplugin:redundantfcast ignore necessary temporariesNoel Grandin3-14/+53
when passing data to a method that is of type Foo&& Change-Id: I0e6bcfb42d6ebcbc7cb19e510ab2010a2cc2bb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09don't need to explicitly call GetFocus()Caolán McNamara3-6/+0
if GrabFocus() succeeds the GetFocus() should be called anyway Change-Id: I2a448659acd990bf570fe56907ac826138cc9938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09Resolves: tdf#144376 focus into protected ScTextWnd shouldn't be possibleCaolán McNamara4-2/+11
the expectations are that this isn't possible and if it happens then under windows there is a QueryCharPosition which will trigger the deletion of the ScTextWnd EditView due to that expectation before it is then unconditionally dereferenced Change-Id: Ied5d8031ae7d74669a2958dbcdec87843a26d384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121839 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09workaround -Wshadow in libcuckooNoel Grandin1-0/+7
that triggers with gcc (Ubuntu 10.3.0-1ubuntu1~20.10) 10.3.0 Change-Id: I038e229890fcc3c8bb7986a747434e9e033b4f5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121838 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09add assert to verify that lock() calls do not accidentally nestNoel Grandin1-0/+2
Change-Id: I6582de99867f98a9afaf219c3bdd53c1f5fca509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-1/+1
Change-Id: Iead995bc6c568c9e517c6402e875127343f30651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09tdf#130795 use concurrent hashmap in SharedStringPoolNoel Grandin14-73/+205
we are loading a spreadsheet in parallel here, but the parallel threads achievei very little actual concurrency because of heavy contention in the SharedStringPool mutex. So switch to a concurrent hash map. I looked at a couple of different ones (including the Folly one), and this was the one with the simplest resulting code. This takes my load time from 12.5s to 8s Change-Id: I04d6d8e11d613b510eb3bc981f3338819b7ac813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121717 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09vcl: move OutputDevice antialiasing functions to outdev.cxxChris Sherlock4-18/+30
Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually, the plan is to separate metafile processing from rendering. Also include unit test for SetAntialising() and GetAntialiasing(). Change-Id: Ie9eefa2de17ce583ca4acd9d86df004981a0c9b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121020 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-09sw: use more StaticWhichCast() in source/core/Miklos Vajna3-3/+3
See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for motivation. Change-Id: I2214fb9a6942551088f44b1882897f7849518203 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121827 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-09Update git submodulesStephan Bergmann1-0/+0
* Update helpcontent2 from branch 'master' to ab1e841eac31980f39ecfcbac897220a5d5b7c2a - Fix duplicate id ...apparently introduced as a (copy/paste?) typo in ab28d2cbdffe0e5c9a966fa5f7659a455a042663 "sf-exception.PythonPrint new method", causing build failures like (<https://ci.libreoffice.org/job/lo_ubsan/2129/>) > Error: Duplicated entry. ID = par_id201613654395537 LANG = en-US in File /home/tdf/lode/jenkins/workspace/lo_ubsan/helpcontent2/source/text/sbasic/shared/03/avail_release.xhp > /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/HelpTarget.mk:67: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/HelpTranslatePartTarget/de/helpcontent2/source/text/sbasic/shared/03/done' failed > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/HelpTranslatePartTarget/de/helpcontent2/source/text/sbasic/shared/03/done] Error 255 Change-Id: Ib8a773b04d8df1ed62b4d5a5780de2b9e70f88ae Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121834 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-08ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2-5/+7
sidestep the resize behaviour of SvMemoryStream by using an honest std::vector and make it use that buffer Change-Id: Ic5e405010ac076fc04e1ca8dc6dbb495162101ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08no need to call expand() hereNoel Grandin1-9/+5
we can just return the value directly Change-Id: Ia4a79ebe668dd426edbe95baee8d8cf91d4bc3f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08avoid double-lookupNoel Grandin1-3/+4
this is hot when creating charts Change-Id: Ic096d9293a48d53fc2cadfda95b5b7a13ba16f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08avoid some ref-countingNoel Grandin1-4/+4
Change-Id: I04dfa4070b2e64c4ab7cb59d4a5c4668e98dc076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08convert some OSL_ENSURE -> assertNoel Grandin26-45/+40
where we are just provide checking for a following static_cast. I'd rather have an explicit assert failure than a random crash Change-Id: Iab6c6b056341018deaa74b78b075e564f72c58d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08fix copy paste in assertion message (vcl/gtk3/gtkinst)Julien Nabet1-1/+1
Change-Id: I2603dcb809d2bf062f3b14f7c21583fde1da9f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121829 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-09-08tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCellMichael Weghorn6-0/+296
Add a new class 'AccTableCell' that implements the IAccessibleTableCell interface from the IAccessible2 spec and add what's needed to expose it to accessibility tools via COM. Since there's no specific XInterface for table cells that an XAccessible's context could be queried for, make use of the fact that a table cell's parent is a table, i.e. its accessible context implements XAccessibleTable. AccTableCell keeps a reference to that table and remembers the cell's index in the parent to retrieve information on the cell from there. This addresses the > At least for LibreOffice Table Cells don't implement > IAccessibleTableCell, and therefore there's no way to get the row and > column span. LibreOffice itself also does not expose the merged state in > the accessible name of the cell. comment from [1] (which is the NVDA counterpart for LO's tdf#124832) and may also help for tdf#100086, though more work will be needed on LibreOffice and/or NVDA side for both issues. [1] https://github.com/nvaccess/nvda/issues/9310 Change-Id: I0f53212d14ee17c760b9e6c91be2154a1b25d862 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121821 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-08tdf#100086 tdf#124832 wina11y: Implement IAccessibleTable2Michael Weghorn3-7/+111
Extend 'CAccTable' to implement the 'IAccessibleTable2' interface in addition to the (deprecated) 'IAccessibleTable' interface from the IAccessible2 spec. 'IAccessibleTable2::get_cellAt' and 'IAccessibleTable2:get_nSelectedCells' are basically the same as 'IAccessibleTable::get_accessibleAt' and 'IAccessibleTable::get_nSelectedChildren' under new names. 'IAccessibleTable2::get_selectedRows' and 'IAccessibleTable2::getSelectedColumns' are essentially the same as their 'IAccessibleTable' counterparts, except that they have the first param removed (which is ignored in the IAccessibleTable version anyway). 'IAccessibleTable2::get_selectedCells' is similar to 'IAccessibleTable::get_selectedChildren', but returns an array of references to selected cells, while the latter just returns an array of their indices. Note: Just having the IAccessibleTable2 interface, but not the IAccessibleTableCell one implemented makes the experience when using the NVDA screen reader temporarily worse, e.g. it now only says "selected" instead of the name of the currently focused cell in Calc. Implementation of IAccessibleTableCell is added in an upcoming commit (Change-Id: I0f53212d14ee17c760b9e6c91be2154a1b25d862, "tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCell") and makes NVDA announce the name of the cell again. Change-Id: I75346efc3b6e79d5ebf5e1954e9c516244efb887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121820 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-08Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: Icc9747237c4ff23cd844f23531f0de37ca1a37d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121798 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-09-08update creditsChristian Lohmaier1-1867/+1875
Change-Id: Ie9a3df3c6dc8af63023e579638f13026451a346f
2021-09-08related: tdf#118938: simplify uitestXisco Fauli1-24/+9
use execute_dialog_through_command like every other test and remove the try/except complexity Change-Id: Ie9cb68e56174516002c15afe89e4314e4c16a755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121826 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-08uitest: sc: factor out common codeXisco Fauli8-226/+113
Change-Id: Iaba3b9633eac26516bbb4bb0b6baadb4c6772fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121808 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-08Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 9088fa2a2fefecaa450cc2b9767a8d958b9e4350 - SF_Base.CloseFormDocument() new 7.3 method Change-Id: Id58053f554c27819aa073ea8312ece8fb32710a0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121762 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-09-08Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to ab28d2cbdffe0e5c9a966fa5f7659a455a042663 - sf-exception.PythonPrint new method Change-Id: I11402201ef509816fc38665eae8d057e1761274a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121469 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-09-08related to tdf#132744: clean-up unit test documentLászló Németh1-0/+0
commit a7b12e23bf9ac8e394405a1de5835e18e40c27c2 "tdf#132744: sw: Add unittest" added an ODT file with a – likely proprietary – photo in a *453 kB* PNG file. Replace the image with a *68 B* PNG in the test document. Change-Id: I684ed3494bf9e7c0489395309e39cd41e78384ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121785 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-08ofz#27296 limit row span when fuzzingCaolán McNamara2-2/+5
Change-Id: I3069875f64acaf394cfef7f6478abc974022d536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08tdf#141908: replace usage of sal_Int32 with colorsBaran Aytas1-4/+4
Change-Id: I536e2c8d15db7c4973525ffc1e0abfb211228751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121703 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-09-08no need to do this dynamic_cast in a release buildNoel Grandin1-2/+1
just make it an assert Change-Id: I6cd84c9988a3d5111d24b44aae46dc6d69ca06ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08tdf#143359 sw: track deletion of empty table rowsLászló Németh6-8/+43
Empty table rows were deleted immediately during change tracking, or in the case of a deleted table also with non-empty rows, accepting table deletion kept empty rows. Note: as a workaround for tracking of the empty rows, i.e. rows without text content, add a redline with invisible text ZWJ in the first cell of the empty row. See also commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d "tdf#143215 DOCX import: fix tracked empty row insertion/deletion", commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b "tdf#142701 track changes: fix layout regression of image deletion" and commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Note: switch off unnecessary redlining of tdf#132744 unit test to keep the sake of that test (i.e. cut of the selected table with empty rows). Change-Id: Ief59008e8714fb88afdfce867598e3dda21bfba5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121784 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-08indexing: fix correct size and pos. for shapes + more testsTomaž Vajngerl4-13/+59
Determining the position and size of the shapes (SdrObjects) was wrong as the assumption was the values are in Hmm but were in twips. Added some more tests that check rendering of SdrObjects. Change-Id: I6ef9287892d1774a1243118a5c97f58384bcfd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121801 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08tdf#114878: sc: Add UItestXisco Fauli2-0/+74
Change-Id: I4edac5f45f18e1aa85d1936a2577420ee274f43e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121804 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-08ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-11/+11
Change-Id: I9117bc6b499c8f86663980c26b7247e58c9737d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08simplify static_cast after dynamic_castNoel Grandin13-124/+120
Change-Id: I53ae7f18519fdd878730d1d0316ebc408271c66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08cui: fix spell check dialog pointlessly modifying text shapeMichael Stahl1-1/+4
In Impress, closing the spell check dialog without doing any changes will replace the entire text of a shape, creating an sd::UndoObjectSetText and messing up the formatting. Apparently in commit bbb1428e3666acc7503d86704bbf1e1a4ac04795 a check of the modified flag was removed, but it's not obvious why, so add it back, which appears to fix the problem. Change-Id: I8ce6c75f097baa82f11f7b1c813262845001ae7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121807 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-08Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'master' to 4460c7babd574c5040a528d10fe51001c27680bc - update translations for 7.2.1 rc2 and force-fix errors using pocheck Change-Id: I4b8c8e545d7aba21bf9e925bfb9018be6e4c04f8
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 14:19:12 +0000