summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-09-01tdf#138519 use gtk_adjustment_set_value instead of gtk_spin_button_set_valueCaolán McNamara1-1/+4
for FormattedSpinButton because the latter doesn't change the value if the new value is less than an EPSILON diff of 1e-10 from the old value Change-Id: I410ceec28e1855e53de8c2982e540c612578bf54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121439 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-01Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-1' to e2b905b6fd271224552f5146b0632fcea8a1a025 - update translations for 7.1.6 rc2 and force-fix errors using pocheck Change-Id: I33f3530234e3ec6571ef3bc9096ac7511da550f6
2021-09-01update creditsXisco Fauli1-2074/+2152
Change-Id: I8fc0e8085dd647f3677554084a0de139a71e4367 (cherry picked from commit 2cfcc8d7c988631333998a78b4b40cb17b025fe7)
2021-08-31tdf#143940: the style index might be -1Xisco Fauli1-5/+7
Similar to 52aebe6986bcec07071adb3f94d6c09fea147044 < tdf#138466 Crash when creating different scenarios > ExportColumns calls GetStyleNameIndex which might return -1 so check the index is different than -1 as it's already done when calling ScFormatRangeStyles::GetStyleNameByIndex Also move fix for tdf#138466 down the stack to be consistent Debug builds will still assert, see coverity#1438402 Since 5e777f23fd0118f6649f0d9e30eb77a72f1099e4 < loplugin:useuniqueptr in ScColumnRowStylesBase > where the nIndex < 0 check in ScColumnRowStylesBase::GetStyleNameByIndex was removed Change-Id: I084bfa04c39f37cb325c3b3df76801b3abdea994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7246759822aff30e4e4e1bca7949eae3b0d960ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121069 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-5/+10
Change-Id: I4a34981e6597743f9f3a9ad6ca063cb347a68d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121213 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-2/+2
Change-Id: I35210b36a927b96f29d0a07a3cf63e226e4c4453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121159 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-4/+4
Change-Id: Id3acc87a697a61bcf3794745846071bc99fc8d8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121190 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-1/+4
Change-Id: I649e8b8fa0d1752f0f4b0b6b688cea8ae945bb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121154 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-0/+8
Change-Id: I136816837eddcb1bf81c23b6f4fcfa65e9335629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-8/+8
Change-Id: I3ced8d55a7c725e8efb80a49b4fa7e4c84d1be5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121162 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-27openssl: upgrade to release 1.1.1lMichael Stahl1-2/+2
Fixes CVE-2021-3712, CVE-2021-3711 (not obvious if any of them affect LO) Change-Id: I98652348977a5a3c728f1d4fdf7293b76a93b630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121026 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 5c391f4346e86bd5d7528fbb42a3af64f98a03d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120987 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#139660 one of the group needs to be activeCaolán McNamara1-9/+9
in this case using ToolButtons instead of ToggleToolButtons will work ok Change-Id: I806a8fc409ae346dd6734be13d69c4b171e54c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121123 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-24rhbz#1996735 SwEditShell::GetCorrection can return nullCaolán McNamara1-1/+3
Though the exact steps to reproduce are unknown. From the text seen in the backtrace the language is possibly Finnish in which case voikko is probably the spellchecking backend in use. Change-Id: I9b3186e4699946235ccc161575bba7d4a3820565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120879 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-23tdf#144022: make sure to create missing columns if neededMike Kaganski1-3/+3
Change-Id: I1a0771fbe8023859ab29d8114303b62f6a3d539c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120731 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 23c1ec0d498124fbe275145d236db455f83cd850) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120873 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-19tdf#142264: make sure to load potentially unloaded objects when savingMike Kaganski4-9/+99
Commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc happened to reveal a pre-existing problem that XLSX export only saved those OLE objects that were kept loaded in the OLE object cache, subject to thevalue of org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects. Before that change, the imported charts were marked modified on load, and that prevented them from unloading in OLEObjCache::UnloadCheckHdl, because SdrOle2Obj::CanUnloadRunningObj returned false. After the mentioned change, the charts started to load without the wrong "modified" state, which allowed them to be properly managed by the cache, and the export filter implementation error surfaced. It's likely that commit 692878e3bb83c0fc104c5cca946c25ccf2d84ab2 tried to workaround the same underlying problem for charts that for some reason / at some point in time didn't get marked modified on load, and that commit converted an error shown in Excel into silently missing charts. This change makes sure that whenever a reference to chart document is requested from XclExpChartObj, it is actually loaded and ready for reading data. Possibly something could be done on the level of old reference that becomes non-functional (although valid) as the result of unloading, so that it would automatically reload on following use. That would make operating on the references robust. I didn't find an obvious way to do that. It is interesting to investigate, it the heizenbug related to images disappearing from documents, as users keep reporting without robust reproducers, might possibly be caused by a similar problem. Change-Id: I45fcdc98254157d805c7519340b5265526f27166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120695 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-18bump product version to 7.1.7.0.0+Christian Lohmaier1-1/+1
Change-Id: Icf9b68055439f39b77a83bff0baaf17ee43f3219
2021-08-18tdf#101630 - gdrive support w/oAuth and Drive API v3Christian Lohmaier10-56/+1008
LibreOffice is only using drive.file scope, so can only see files it owns/that were created by LibreOffice. In addition, also store the refresh token in LO's password-store if the user enabled persistent storage, removing the need to to the copy'n'paste dance to grant access each time LO is launched. related tdf#115643 also store the refresh token for onedrive consolidate the fallback-auth provides for onedrive/gdrive into one, they are all the same login in browser, then copy code method that ultimately should be changed to having LO listen on local port for the code Change-Id: I97e3843682c302d2884e35ece6e72bc3a07e2539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119572 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 73041de9563c9a973d1b5394c6e5520a7d799980) fix install with --disable-cmis Change-Id: I51430a860a0b5047b566ed8184f0f563ec54f288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119661 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 299b72e4c9ad239d747e47eaf004400f5a590695) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120544
2021-08-18tdf#143619 validation circle anchor is specialRegina Henschel3-0/+41
For usual drawing objects, maStart in its Calc user data means the cell address of left/top of snapRect/logicRect. For validation circle it means 'address of cell to be validated'. Thus corrections might be needed, if a general method is used for validation circle. Here the method SetLogicRect() calls via broadcast ScDrawLayer::SetCellAnchoredFromPosition(), which calculates maStart from snapRect/logicRect. Because the circle is extended to cover a larger area than the to be validated cell, maStart got the cell address of the cell one left and one above of the to be validated cell. Now the old, correct address is backuped and restored. Change-Id: I9646da3f22fef45a6e47e59ef55a70307e2f9cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119715 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 0cff1aa48453ee0c05bafcac5360329fb6bf9557) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120147 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120224 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-08-18Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-1' to 1a0b8b7d4403c257ae6e0f43bfa791a4c91831d8 - update translations for 7.1.6 rc1 and force-fix errors using pocheck Change-Id: I01602df1c63103029e3c9198db5e7032addf89c2
2021-08-18Resolves: tdf#143785 save/restore SdrModel::IsChangedCaolán McNamara1-0/+2
Change-Id: I253915c359cf72f80b21e21ff34e0ee406e5b3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6dc23567639bebf18ceb8d9a3721228bffe14202) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120578 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-18Resolves: tdf#139220 with ~1000 selected shapes a11y UpdateSelection crawlsCaolán McNamara1-60/+75
so fetch the selected shapes once and sort them for quick lookup in the loop over maVisibleChildren. As an side, not changed here, SvxShapeCollection::getByIndex looks suboptimal with a body of std::vector<Reference<uno::XInterface>> aElements(maShapeContainer.getElements()); return uno::makeAny(Reference<drawing::XShape>(aElements[Index].get())); Change-Id: Idec7c003e7c5ee02000d4642d4fdb0d940548d97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120584 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-17Resolves: tdf#142003 tracked changes in footnotes offset in .doc importCaolán McNamara3-6/+1
Reverts: commit e71d05eaa9a8c9e628b256f3e889b85ac11ed474 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 27 15:42:26 2018 +0100 ofz#8038 defer subdocument redlining to end of parse like main document Change-Id: Ie8d7a98c7927dcba53228ebcd991d715d8faabe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b5870d727685ec10447e8ae446ada895250fec2e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120581 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-17tdf#143778 these async callbacks expect to have SdrModel::IsChanged of falseCaolán McNamara2-3/+8
when they are entered. They are adapted from the original non-async SwDrawShell::ExecDrawDlg where the start of SwDrawShell::ExecDrawDlg has... bool bChanged = pDoc->IsChanged(); pDoc->SetChanged(false); and the end has if (pDoc->IsChanged()) GetShell().SetModified(); else if (bChanged) pDoc->SetChanged(); and before async dialogs the start and end happened before and after the dialog appeared and disappeared. The intent seems to be unset the sdrmodel-changed and restore its original state if the dialogs caused nothing to happen and to explicitly set SetModified on the document if something did. Now the async dialogs callback happens after SwDrawShell::ExecDrawDlg has ended and so the callbacks start with SdrModel::IsChanged at its original value (restored by the end of ExecDrawDlg), not the "false" they were originally written to expect. For simplicity set the SdrModel IsChanged to false at the start of the callbacks and continue to restore to the passed in bChanged state if there was no changes by the callback. Change-Id: I671b35acab6d1b391fa7e6590c09f8be135449b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120548 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c64f221fc2e22ffa60c4d78240893f7f04531b3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120576 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-17tdf#143357 use a DateFormatter and a separate Calendar menubuttonCaolán McNamara7-25/+115
similar to what we ended up with in DateControl in svtools/source/brwbox/ebbcontrols.cxx Change-Id: I37c843ff7e1e8e39b318db80fe590ce5f796f46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120454 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-17Resolves: tdf#96561 Include embedded null-characters while assembling CSV lineEike Rathke1-1/+10
... instead of prematurely ending analysis and skipping the remainder that is still part of data read. Change-Id: I8f34bc9672e37f9c1c1ae81ddeba464360add7c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120555 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7bd03074ae7362d8fffe5182529626a0b43a0ed1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120572 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-16Related tdf#143895: Mysql MEDIUMINT is DataType::INTEGER not DataType::SMALLINTJulien Nabet1-2/+2
Change-Id: I324b18cc164cb2f38b7b8411c557c6c208e8d69d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120536 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins (cherry picked from commit 997ff7166ceca0a5af80297a0e789af2ff0c6617) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120448
2021-08-16tdf#143452: make 2 buttons in the date form control translatableJulien Nabet1-2/+2
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bafd50ee06d982e19d54fae0f9d8f968a2dedbd4 weld DateField Calendar floating window Change-Id: I43c108908c6e802f3a8014ccf3fa243bebcae0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119293 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 73503ce975ce0923bfe2cfd075ac8b91de20f29e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120445 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-16upgrade to openssl-1.1.1kCaolán McNamara1-2/+2
Change-Id: Ibd930ab4f97e2f74868b73163d7f2f46fb466749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120437 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-16Related: tdf#143357 explicitly set the default of focus-on-clickCaolán McNamara3-0/+3
this should already be the default according to https://developer.gnome.org/gtk3/stable/GtkWidget.html but it's apparently False nevertheless, so make it explicit here for these widgets where there is a focus watcher to commit their changes and the absence of this is non-cosmetic. Just these initially for a small backportable change. Change-Id: I96442b4e844ce0446f56276c1b648ca5ce57b740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a36447215fa13f3ca92b22ac63e8164859ddb8ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120428 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-16Related: tdf#143357 set blank label for no dateCaolán McNamara1-2/+5
instead of current system date Change-Id: Ic504b34990a8ea5151ec653de2db860c1cd4b8ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ecf901685ac0c6c7b27b81096bea96cdc3d2c2ca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120430 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-16tdf#139811 trigger layout when content changesCaolán McNamara1-0/+6
in writer styles panel of page deck which is similar to the draw case of tdf#143795. Doing this always in PanelLayout::queue_resize might make the most sense rather than these manual triggers, but do it this way initially for a safe backport. Change-Id: I4bd2e9cb9d52b66a73cd0615406052e19e6e8b51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120369 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-15Resolves: tdf#143809 "INF" may be a named expression or DB area nameEike Rathke2-7/+31
... to not be caught by rtl::math::stringToDouble() handling XMLSchema-2 "INF" and "NaN" and set as error. Change-Id: I9bf7aad416a69d4c3c0d49d6c80168097040a3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120337 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b37fd7f38165dadc5b1a674b73f4b18824e4789e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120435 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-13Resolves: tdf#143795 trigger layout when content changesCaolán McNamara1-0/+5
Change-Id: I9ec19b55f2b46ac8dd1415f45d5e0368fa52fbfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120367 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13Resolves: tdf#132739 two style tags where there should be just oneCaolán McNamara3-5/+10
Change-Id: Id9c8c8cc8c5ffdd21ba79ff39a6279cf2ddc8025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120360 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-13Resolves: tdf#143843 disable the recently-used widget during loadCaolán McNamara2-0/+2
We show a busy-cursor but the widget can still be interacted with so another document can be launched by clicking on another recently-used item while the first one is still loading, and the recently-used widget isn't prepared for this scenario so the second to complete load will crash. Disable the recently-used widget when its cursor is set to busy, and in the (unlikely) case that the load doesn't complete normally (missing document or load filter error) and the recently-used widget still exists and its cursor is unset from busy then reenable it for user input at that point. Change-Id: I8f4487f3dbede14c9778e49442366bd9445f1d63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120363 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-11tdf#143769 don't crash on null XFillColorItemCaolán McNamara1-2/+3
use same solution as: commit 5ee0e6ab93ad791f5e79506efafd16cb7364ffb1 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Tue Jul 21 19:01:26 2015 +0200 avoid crash with color listbox for now Change-Id: I36ac6513546961ec8d8d1e9437a8ef88574acbf4 Change-Id: I46c55461e5867431a6e9c838b5ef462f9581eb28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120248 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-10Resolves: tdf#143023 explicitly connect to ControlBase focus-[in/out]Caolán McNamara9-84/+114
instead of listening to the generic vcl::Window/Control focus events. The thing which really gets/loses focus is now a Widget hosted inside the ControlBase. also contains... fix comment Change-Id: Ia1783aff3fded7fd73de2b04b9aced647771a92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> establish that DbCellControl Window member is always a ControlBase and remove resulting known redundant dynamic_casting Change-Id: I5f098ef1adee3ad5d2a2bc5fcd30523f980df2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> EventWindow is always a svt::ControlBase update DataBrowser has-focus when child widget loses focus similar to tdf#135641 case, focus-out becomes an issue with the bibliography editor if focus-in is seen on clicking in a cell, then click in a GtkEntry and tab around in a circle. Without this lose-focus support focus will be grabbed back to the cell of the initial click on a circuit of the focus-cycle Change-Id: I36288ed21dc4357c077f8dee55b55abf2457c2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111157 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 422a8c3218b484817a8723b57fe9845d6abb83f4) reportdesigner focus out handler clobbering the preexisting handler set by the databrowser, so chain one after the other Change-Id: I5aa16635031be425b9354e5a2d6b891a81d54e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 731f08e5a84817dbc3c6be6e670025d51f39cd61) Change-Id: I012d0bea687aa6d5965a4e2f6ce3899bfc629f1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120006 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-10undo blocking emitting focus events during grab_focusCaolán McNamara12-45/+18
revert... commit f97dbac73fe149e8fed0932890d0c1d6be4869a3 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jun 26 21:00:02 2019 +0100 infinite focus changing in toc biblio page which blocked calling focus-changed callbacks when grab_focus is called explicitly analogous to how we block value-changed callbacks setting values through code but don't block them when the value is changed by user interaction. In retrospect that was a poor choice, so revert that and subsequent workarounds in favour of just not calling gtk_grab_focus if the widget already has focus. checked: a) tdf#138427 focus set to wrong input box b) tdf#138078 only call GetFocus if we gained focus from an unfocused state c) tdf#137993 ensure the toplevel vcl::Window is activated d) tdf#136941 call focus in handler explicitly Change-Id: I411480e2d627aa9995fb41b0aa17e9fb6d34d73f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit db1cf111666847ce5ce93d18ae5ae8c29a4c44d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120079 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10move async focus-in/focus-out workaround to known client that needs itCaolán McNamara3-54/+60
and for the normal case process immediately. Use-case is the bibliography editor, modified uncommitted entry, click in browser column margin area to select a new row, the entry should commit its old contents to the old row before filling from the new row Change-Id: Ib41d96afcfa86bcd1075b9512d4cfab593afa66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111152 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c56e0c791a79dc414108e1b2fbf0f7eb38657f10) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120078 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-10Always provision PATH the cygwin way under WindowsThorsten Behrens4-15/+3
With PATH essentially serving the role of LD_LIBRARY_PATH under Windows, there was the notion that this needs to be provided in Windows notation, for win32 gnumake. That was perhaps once true; currently we're always evaluating PATH inside a shell, not the Makefile. So this since a while only worked accidentally, due to cygwin transparently converting between DOS and UNIX PATH vars. It did break though for corner-cases, e.g. SRCDIR!=BUILDDIR, and BUILDDIR e.g. D:\FOO. With that simplification, also GNUMAKE_WIN_NATIVE can go. Change-Id: Ied5a0443dc70e7dc629c0c0620e6ce911d9a73d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119941 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit da36d655608c3da39fd79d95974e1f7404a27aa0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119977 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-10update creditsChristian Lohmaier1-2107/+2139
Change-Id: Iad0175ccc7a1ee903812f34bcacb86e3f90e58b3 (cherry picked from commit 555366667c9a62f366230843c1727b0643a06b1a)
2021-08-09tdf#132696 PPTX import: fix missing SmartArt when it's part of a group shapeMiklos Vajna3-1/+35
Regression from commit e9986153e44d7ec6ca9c5f1373971de74dcbacda (PPTX import: import SmartArt drawing into single GroupShape, 2019-03-14), the problem was that oox::ppt::PPTShape::addShape() and oox::drawingml::Shape::addShape() were not in sync. PPTShape unconditionally maps SmartArt to shapes, while the shared Shape class defaults to converting it to a non-editable metafile. The above commit changed the handling of in-groupshape SmartArts to go via Shape::addShape() instead of PPTShape::addShape(), which exposed the underlying problem that the convert-to-metafile mechanism is currently only working in the DOCX case. Fix the problem by again ignoring the convert-to-metafile flag for the PPTX import case. This also exposed a previously hidden problem: make -C oox -sr CppunitTest_oox_drawingml CPPUNIT_TEST_NAME="testGroupShapeSmartArt testTdf131082" started to make testTdf131082 fail. The tweak in Shape::createAndInsert() fixes the testcase failure, but likely there is a deeper problem there, unrelated to the regression. Change-Id: I4e1e9645eaa266d0d7560767c3c59ba9549ccdb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120122 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 030cdbc7f8782eb196f09661bc2f116d790de9be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120145 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 84033de1bfe3e6951a1f563d85e40fb6d29ff3be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120149
2021-08-09tdf#143582 - Clear return value of the method before calling itAndreas Heinisch3-0/+32
Otherwise the function keeps a copy of its return value, which may be used in an upcoming call. Change-Id: I4977c39e1ce48cfd5ab067a4df4783f10505a9ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119905 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120197 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120211
2021-08-09tdf#142436 svx: fix handling of linked background imagesMiklos Vajna5-1/+67
Regression from commit 9fb7aaf570c03c8a26d763f1205fb8c890e8211a (Make linked graphic register into LinkedManager again, 2018-04-13), the problem was that now SvXMLImport::loadGraphicByURL() produces a Graphic that has its type set to GraphicType::Default, but when drawinglayer::primitive2d::createNewSdrFillGraphicAttribute() consumes this graphic, it expects that the type is either a bitmap or a metafile. Fix the problem by explicitly loading the image when the default-type, origin-url-set case happens: this is rendering, so no problem to load the URL and that will give us the expected graphic type. This is also meant to keep the original problem fixed, since the Graphic that is part of the doc model is unchanged. (cherry picked from commit c88ff9298b25132fc34102230cef0263f045a523) Conflicts: drawinglayer/source/tools/primitive2dxmldump.cxx Change-Id: If5bba09faa23ef35f99152d4b5d30cd9cf67ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120140 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-08Resolves: tdf#143759 Limit empty search's empty column to actual search rangeEike Rathke1-2/+6
... instead of the non-/filtered last row. Change-Id: I9b941af688a8083d472a793a6bc6b6dbb7b916ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120176 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 15960931988cfd898e14a12d6b9cddaf6d8b0ade) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120135 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-08Resolves: tdf#137637 keep user selection during initializationCaolán McNamara1-0/+2
Change-Id: Ibef83d132ce951393a996aae94b8cdee51da1a64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119866 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-08tdf#143626 "protect" always shown checked for sections linked to fileCaolán McNamara1-1/+0
Change-Id: I8a403a25ae5c5e3b6183ba559b0224f2886eb925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119862 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-07crashreport writerfilter: findColumn(unsigned long,unsigned long)Justin Luth1-0/+6
Although the crash reports don't show getRow as a separate item in the list of functions leading to the crash, it just CAN'T be a problem with mTableDataStack.empty() or !mTableDataStack.top() because they are unconditionally used or popped later on in endLevel(). So I resisted the urge to test everything, and just verified that the row (which exists for m_aCellProperties) actually exists in the table manager - similar to getGridBefore(). These functions were added via tdf#129452 writerfilter: use column, not cell when comparing rows 7.1 commit 19d7f9624e92422409ed2744091d502fdae8692b The crash report did not identify any example documents or reproducable steps, so no unit test was possible. Change-Id: I5a27dc40db18f05ad4656789d3e61ec1ff4de471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119420 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 82b14219969c4f80d421015c9e89e8d3db4650d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119616 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit edc53ec766993b0b7910e87b3765d720565191d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119979
2021-08-07Resolves: tdf#143720 treeview not resizing to fill available spaceCaolán McNamara2-2/+4
Change-Id: I041c3a743b8624f49bfe57e8a4469535e334e5dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120068 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-04Resolves: tdf#143664 {de-*} accept "Mär" and "Mrz" for MarchEike Rathke1-0/+16
Change-Id: I82c094687137995a634450cb4f617909859d1688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119916 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4961dbaecc9e5cac57d99d2ea9d265a90daa4a8b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119859 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-05 23:34:01 +0000