summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-08-01Fix typosAndrea Gelmini3-4/+4
Change-Id: Id59caa7da8fdfd613eb3b97196c52131aeb7378c Reviewed-on: https://gerrit.libreoffice.org/58375 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-01Remove "officially dead now" rtl_cache slab allocator mechanismStephan Bergmann6-1059/+43
...after <https://gerrit.libreoffice.org/#/c/58263/> "the custom SAL allocator is no longer used" got merged. According to my July 31, 2018 comment there: "However, [...] this change is effectively a final coffin nail for the 'rtl_cache' mechanism. It could be argued that the alleged benefits of that mechanism (if it were still working) might be real (at least on some platforms; which would need measurements), and that it should be made working again (by reverting the effects of both ce906b8096081dee15dc8cc96e570d5b0b587955 'skip tricky allocators on G_SLICE=always-malloc' and bc6a5d8e79e7d0e7d75ac107aa8e6aa275e434e9 'Disable custom allocator' on rtl_cache_alloc/free again). But it could just as well be argued that the 'rtl_cache' mechanism is effectively gone for long enough now (since end of November, 2017, with bc6a5d8e79e7d0e7d75ac107aa8e6aa275e434e9 'Disable custom allocator') without any (apparent) negative consequences, so that it can be removed for good with this change." Change-Id: I8c1e45d494fc22555a9e675ab27be9e6e404abde Reviewed-on: https://gerrit.libreoffice.org/58369 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-31nitpick, following f0dcfe008d58053e52c51b10e51c58eae27c1f0bJulien Nabet1-2/+2
In code comment, typo + replace OSL_FAIL by SAL_WARN Change-Id: I77fc643f86a2711ce68aa206923ac7913ab81e12 Reviewed-on: https://gerrit.libreoffice.org/58374 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Further cleanups and improvements in /shared/01/020*.xhp files Change-Id: I7b6da19227f2b4a4ee33a634b16481f0ef720837 Reviewed-on: https://gerrit.libreoffice.org/54905 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Further cleanups and improvements in /shared/01/011*.xhp files Change-Id: I12ec3e9901eecb31131ad2497bd1c545cde4f51c Reviewed-on: https://gerrit.libreoffice.org/54842 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups and improvements in /shared/05/*.xhp Hopefully also fixes visual glitches in https://help.libreoffice.org/6.1/en-US/text/shared/05/00000150.html Change-Id: I4698bc0ecf547ac2231cb28d6ccef3025e0b832f Reviewed-on: https://gerrit.libreoffice.org/55444 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/05/*.xhp Change-Id: I35b699fc4408809a6f5e7802e16b17594781ed15 Reviewed-on: https://gerrit.libreoffice.org/57133 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/05/*.xhp This partial patch hopefully also fixes visual glitches in https://help.libreoffice.org/6.1/en-US/text/shared/05/00000150.html Change-Id: I753ffda535df10c453b36b459178e0d1a5974f79 Reviewed-on: https://gerrit.libreoffice.org/57132 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/02/011*.xhp files Change-Id: I91875370ab207dfb94f06070f081194050402cd0 Reviewed-on: https://gerrit.libreoffice.org/57127 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/02/011*.xhp files Change-Id: I0a41efdc51a2696936235d614c9044e929b3a2b2 Reviewed-on: https://gerrit.libreoffice.org/57126 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/02/011*.xhp files Change-Id: I7ec108d45b8b14a15f910867032625b2f48897a6 Reviewed-on: https://gerrit.libreoffice.org/57125 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: I3897b484ca802b5482a4f2278cbed10b0ede30e8 Reviewed-on: https://gerrit.libreoffice.org/57124 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: If9dfa504db1edd23f18012419fd7bad5f6c064ae Reviewed-on: https://gerrit.libreoffice.org/57123 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: I6251ed2d63735b2a0f39a9bf9c8d6b5571657a5e Reviewed-on: https://gerrit.libreoffice.org/57122 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: I34225b401def6a2e6e00aa725e20a17b9a4c3a21 Reviewed-on: https://gerrit.libreoffice.org/57121 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: I42a6cff181c3e3e5bf6dc4cca04865caab2e9bad Reviewed-on: https://gerrit.libreoffice.org/57120 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: Ife7ef0ba0416063a3807386664a52466a6a683db Reviewed-on: https://gerrit.libreoffice.org/57119 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/01/04*.xhp files Change-Id: If7ebf56aeec57c267f81706d61650c101b33f323 Reviewed-on: https://gerrit.libreoffice.org/57118 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Break my patches into smaller changes untill the last 2 action items are resolved: https://gerrit-review.googlesource.com/Documentation/user-inline-edit.html#not-implemented-features This should also helps reviewing. Change-Id: I88cfbf66a3a091097a27a20bd4c41b1261769bfd Reviewed-on: https://gerrit.libreoffice.org/57111 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanup in /shared/01/02*.xhp files Change-Id: Iff5a39d1ed1a0d269f6d49e499cb9bbf71ccfea4 Reviewed-on: https://gerrit.libreoffice.org/57117 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Font features: Use Graphite instead of HarfBuzz if availableTomaž Vajngerl11-71/+123
When searching for font features, use Graphtie if it is available instead of HarfBuzz, because HarfBuzz will only give a subset of OpenType features in a Graphite font, but will ignore additional features specific to Graphite. Change-Id: I00c8790ee4d1e1ab906928f649d2a3e54163557f Reviewed-on: https://gerrit.libreoffice.org/58306 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31crashtesting: stack exhaustion exporting moz1253590-2.svg to odgCaolán McNamara2-479/+557
happens on the crashtesting box, but not locally, comparing the stack frames its clear that the stack used on the crashtester for VclPixelProcessor2D::processBasePrimitive2D is over double that used locally... comparison on > objdump -S workdir/CxxObject/drawinglayer/source/processor2d/vclmetafileprocessor2d.o |less gives... void VclMetafileProcessor2D::processBasePrimitive2D(const primitive2d::BasePrimitive2D& rCandidate) gcc-4.8.2-3.2.mga4 has... sub $0x5b0,%rsp vs... gcc-8.1.1-5.fc28.x86_64 has... sub $0x2e0,%rsp lets split up this method Change-Id: I6d84f555a01b5c58f530adb9b9b8cb8803c985bf Reviewed-on: https://gerrit.libreoffice.org/58364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-31crashtesting: stack exhaustion exporting moz943243-4.svg to odgCaolán McNamara2-1188/+1288
happens on the crashtesting box, but not locally, comparing the stack frames its clear that the stack used on the crashtester for VclMetafileProcessor2D::processBasePrimitive2D is over double that used locally... comparison on > objdump -S workdir/CxxObject/drawinglayer/source/processor2d/vclmetafileprocessor2d.o |less gives... void VclMetafileProcessor2D::processBasePrimitive2D(const primitive2d::BasePrimitive2D& rCandidate) gcc-4.8.2-3.2.mga4 has... sub $0x11e8,%rsp vs... gcc-8.1.1-5.fc28.x86_64 has... sub $0x4c0,%rsp lets split up this method Change-Id: I73ef1eb0280224988176986918a2d025344197d0 Reviewed-on: https://gerrit.libreoffice.org/58362 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-31push it around a bitCaolán McNamara1-1/+1
Change-Id: I26423e8d0f0c8a35447afbcc38eaab14c277359f Reviewed-on: https://gerrit.libreoffice.org/58356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-31tdf#119015: don't call TableModel::optimize in CellCursor::merge()Mike Kaganski4-1/+25
Better do that explicitly in the SvxTableController::MergeRange, so that the UI-driven operation still optimizes the table, but import code gets the initial column count, and not throw trying to access the deleted column. Change-Id: Ib4b4d716935ec2036ccb839c36f1be5b0cb878d5 Reviewed-on: https://gerrit.libreoffice.org/58359 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanup in /shared/01/02*.xhp files Change-Id: Id1057af0e0ac1dbbf9cf8d18dfc181416911622b Reviewed-on: https://gerrit.libreoffice.org/57116 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanup in /shared/01/02*.xhp files Change-Id: Ie2d121c7abd2b57c923e8500096269e8ae662c6b Reviewed-on: https://gerrit.libreoffice.org/57115 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanup in /shared/01/02*.xhp files Change-Id: I7866fba42217456a6cf997b3f61472249f8df921 Reviewed-on: https://gerrit.libreoffice.org/57114 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanup in /shared/01/02*.xhp files Change-Id: I85c2513952e20e11b7063f7700c559a0ab01968c Reviewed-on: https://gerrit.libreoffice.org/57113 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanup in /shared/01/02*.xhp files Change-Id: I6e0b1a7c36e6d530a4648806c5d323ca427223b9 Reviewed-on: https://gerrit.libreoffice.org/57112 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Further cleanups and improvements in /shared/01/010103*.xhp files Change-Id: I4489ea771b44cb92ce145dbf31c01c16ad10e113 Reviewed-on: https://gerrit.libreoffice.org/54835 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Further cleanups and improvements in /shared/01/0220* - 0222*.xhp files Change-Id: I1f0a81dee3348ec06af81f78f725a3a35f13fe26 Reviewed-on: https://gerrit.libreoffice.org/54932 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - WIP: tdf#118008 Review of Format menu help page(s?) Change-Id: Id3a87aa5523d4f84a7ea6e523dfe59d655c03054 Reviewed-on: https://gerrit.libreoffice.org/55445 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-31Add missing sal/log.hxx headersGabor Kelemen128-0/+129
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from sfx2 to starmath Change-Id: I40ee7bfae6efdadd862319b7b693ad22c648e1c4 Reviewed-on: https://gerrit.libreoffice.org/58222 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-31try to detect that a formula does not contain any implicit intersectionLuboš Luňák7-97/+213
Commit 67444cbe disabled svDoubleRef completely for OpenCL, which means many formulas weren't handled by OpenCL even if the implicit intersection problems are quite rare. This patch tries to detect formulas implicit intersections in formulas and if it's certain that a formula does not contain one, then it's ok to use OpenCL with svDoubleRef. The detection is done by having ScCompiler analyze each opcode call and its parameters, which should provide sufficient information to know if implicit intersection can take place or not. The extra compilation can be avoided by using OpenCL's compilation and doing the svDoubleRef conversion later on the RPN code, to be done later. This is opt-in, so if unsure don't do anything, if it turns out that some opcode needs special handling, it can be simply added. Change-Id: Iaa52fa7eb8b14dc8c2b92384a21e2ab8efe0ddd7 Reviewed-on: https://gerrit.libreoffice.org/57959 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-07-31protect against accessing before the start of pCode in FormulaCompilerLuboš Luňák1-1/+6
If the expression is bad, such as in sc/qa/.../sheet.fods, 'pCode - 1' may actually refer before the array of tokens, since nothing has been added yet. So make that element nullptr. This is a bit hackish, but checking in every place that pCode is valid seems tedious. Change-Id: Ia099a50583f60d93a2e20b1f7b5e44b0121a275b Reviewed-on: https://gerrit.libreoffice.org/58198 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-07-31even more implicit intersection computationLuboš Luňák4-1/+137
This extends 60c5ca1b87 to do implicit intersection while generating RPN code for even more opcodes. This will serve as a basis for making it possible to know when ScGroupTokenConverter can convert svDoubleRef to a matrix without the problems mentioned in its convert() method. Change-Id: I8dfeefc026418bd5644bd266ad94c31f670e811c Reviewed-on: https://gerrit.libreoffice.org/57958 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-31more fix windows --enable-debug buildNoel Grandin1-2/+2
follow on to commit cba7acca97ac0245b93e27ba46351285fd7c5ff2 fix windows --enable-debug build which tried to fix the regression from commit 9cceba9a928cf3b3447f293020be2fe76c035ed5 make DBG_TESTSOLARMUTEX available in assert builds Change-Id: I054552a53fd86a9b6cefcdad055f1f870c47e07c
2018-07-31loplugin:returnconstant in ucbNoel Grandin7-15/+11
Change-Id: I2810468e64bba8bc9f8af4dff170bc1ab310fe2f Reviewed-on: https://gerrit.libreoffice.org/58337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31loplugin:unnecessaryoverride small improvementNoel Grandin4-14/+52
when we have two definitions of the same method in a straight inheritance path up our hierarchy, we were missing a warning Change-Id: Ibc0f11644c7321a0d5618024860c2503665d8835 Reviewed-on: https://gerrit.libreoffice.org/58354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31loplugin:returnconstant in editengNoel Grandin7-15/+12
Change-Id: I9e38c1634466e580af29547df554d620b5b7860c Reviewed-on: https://gerrit.libreoffice.org/58336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31fix windows --enable-debug buildNoel Grandin1-1/+1
regression from commit 9cceba9a928cf3b3447f293020be2fe76c035ed5 make DBG_TESTSOLARMUTEX available in assert builds Change-Id: Id3747e2a342830e0184251b909b577b2a8814543
2018-07-31tdf#118080 fix formula importing of ppt animation.Mark Hung2-28/+6
Change-Id: I5f56e0d70a13418b0bde45c2fc65f56fdb365263 Reviewed-on: https://gerrit.libreoffice.org/58209 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-31sd/qa: fix saveAndReload with PPT format.Mark Hung1-5/+5
UIName instead of Type were used as TypeName to initialize SfxFilter, and caused problems in DrawDocShell::ConvertTo() when saving PPT format. Change-Id: Iaffe7025a163c7520442c96921e8540903284ebf Reviewed-on: https://gerrit.libreoffice.org/58208 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-31Rename/Delete worksheets and slides option on Android ViewerMert Tumer9-3/+182
Change-Id: I57f379f0283ecc1a456e44f9fefcfd3b3e56a46c Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/58327 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31Setting visibility of menu items instead of disabling or enabling themMert Tumer3-7/+27
On Android Viewer Signed-off-by: Mert Tumer <merttumer@outlook.com> Change-Id: I1fc21f84f5063afe3b91bf26401f9fcacc66b6c8 Reviewed-on: https://gerrit.libreoffice.org/58285 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31Renamed "Font Back Color" to "Highlight Color" on Android ViewerMert Tumer1-1/+1
Change-Id: Ia87a8091cf7ca7f15b9be7d5368f314d20421258 Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/58283 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31tdf#118976 Make area pattern tab page display pattern previewJim Raykowski1-0/+2
Change-Id: If30b83ec93897b85784d66c699ece377f47f68d4 Reviewed-on: https://gerrit.libreoffice.org/58265 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31tdf#117892 Blue Area/Background Bitmap tabpage Preview fixJim Raykowski1-0/+2
Change-Id: Iaef3651407d1df85b1cb221821d47c33e111016e Reviewed-on: https://gerrit.libreoffice.org/58206 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31remove SdrGrafObj::IsSwappedOutNoel Grandin4-254/+1
and consequently a whole bunch of related code leftover from commit e4eb416c3ef81d098ed61caabd2077cbbb2418bc remove swapping and link from GraphicObject and Graphic Change-Id: I2f8a631441e06aa52db6d9ad247e8ae6be1004ed Reviewed-on: https://gerrit.libreoffice.org/58195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-05 16:27:39 +0000