summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-03-31tdf#140343 sw page rtl gutter margin: add DOC filterMiklos Vajna6-3/+38
The import's tokenizer was there since commit 3e13e053749e1bf19179bf83bdf0a18a9488b5e8 (#i2408# Import and export set/ask references fields as set/input, change references to bookmarks to show variable as appropiate, 2002-02-04), but it tried to read 2 bytes, not 1 byte, so it was broken. This did not cause problems in practice till commit b897cc4dfc7111eb8dfd5d8aa8c970f21ab035d6 (consistently track amount of buffers remaining, 2017-04-10) started to check for not reading past the end of the buffer. The export was missing, since we previously tried to handle this at import time, so the doc model didn't have the info anymore. Change-Id: I0d15a16893de96104812b0cba4566c53f92673ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113415 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-31Initial version of script to install dependenciesNoel Grandin1-0/+52
Change-Id: I2002d3c2c522a4cd027417f894bd03e03b85eeb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113336 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-31remove internal 4bit scanline formatsNoel17-218/+6
since we have already removed the 4-bit internal bitmap formats. Change-Id: Ie481aaa8e25642a47e30beb6f37e2d3beda304e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-31tdf#140863: sw: Add UItestXisco Fauli2-1/+77
Change-Id: Ic1d3a56857dd68f436b870168ab394729a31d629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113416 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-31Use isEmpty instead of comparing getLength to 0Mike Kaganski1-1/+1
Change-Id: I9c1a0e2bce162c2222ef06f5fc4e92bac7bb1c69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113362 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-31tdf#140343 sw page rtl gutter margin: add ODF importMiklos Vajna9-1/+140
See <https://issues.oasis-open.org/browse/OFFICE-4105>, the proposal is to not map this to a new attribute of the <style:page-layout-properties> XML element, rather only write writing mode on export and infer RtlGutter from that writing mode in import. This is similar to how FillBitmapOffsetX and FillBitmapOffsetY are two UNO properties, but there is a single draw:tile-repeat-offset attribute for them. This has the benefit of simpler ODF markup, at the cost of more complicated xmloff code. Change-Id: I189a7ec62d4e5624e20252b7259a36133594fe40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113405 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-31tdf#141158 DOCX: import discarded headers/footersAttila Bakos (NISZ)12-17/+247
Before the inactive DOCX headers/footers lost during import time. Now it can be restored by disabling the options “Same content on left and right pages” and “Same content on first page” on the Header and the Footer panes of the Page style. This is for improving the interoperability with other Office programs, e.g. supporting DOCX text document templates better. Follow-up of commit f5dc6b11d2218d94c9effe7a1ab418d0133da5e3 (tdf#140117 sw UI: keep headers/footers when inactive). To start the py-UItest run: $ make UITest_writer_tests7 UITEST_TEST_NAME="tdf141158.TestTdf141158.test_tdf141158" Note: In spite of this patch implements the left/first/first_left page header/footer stash at import time, the left one works correctly at now. This is because the first pages have different page styles so changing the right page style will restore the hidden header/footer content. For this problem further improvements are planned, exactly in the filter part. Number of unit tests had to be modified, because before these headers and footers were dropped. Co-developed-with: Daniel Arato (NISZ) Change-Id: I3dd452a648bc465710698707c083734dc762ed94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112580 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-31LOK: getPartInfo now returns master page countPranam Lashkari1-0/+3
master page count will be used when switching to master view to know how many slide previews to be shown Change-Id: I11735797d16538a9f667a85b90a86b1e6cf9b5aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113358 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-03-31Make RTFKeyword and RTFControlType scoped enumsMike Kaganski9-4373/+4373
Change-Id: Ifae0afd1468ab162b8d815e8b614afc1442169a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-31tdf#117212 sw mailmerge: merge only the selected rangeBalazs Varga3-44/+47
All records were merged before saving or printing the record range selected in “From 'X' To 'Y' of the “Save Merged Documents” or “Print Merged Documents” dialog windows (opened via the Mail merge toolbar). This was a waste of time in the case of selecting only a few records. Change-Id: I52c47d3c5707b09ed7f9b05a1a0f4d20a5595b8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112922 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-31tdf#140343 sw page rtl gutter margin: add DOCX filterMiklos Vajna9-0/+47
Map to <w:rtlGutter> inside <w:sectPr>. Change-Id: Iaa1d9da8c1585ec31c7cbe539f49643eb972c327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113398 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-31tdf#140343 sw page rtl gutter margin: add layoutMiklos Vajna2-2/+31
We used to get the gutter margin on the left side and the right gutter margin on the right side, which works for normal and mirrored layout. Swap these two in RTL mode. Change-Id: Ibe866c2d971ce72e94fab5d5c71040ab62ffbe93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113395 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-31This should be a static methodMike Kaganski2-3/+3
Change-Id: I70b725d42a91151e0c1f2f1fedc4be18433a7cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113397 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-31Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' to a9113079e1329ac1bcbf44c76b1419624567000a - Update spelling (remnants) Change-Id: If5276323db6930782e249e902c5ad4c00334d51b
2021-03-31Fix the test in Windows RDP sessionsMike Kaganski1-1/+1
Without the fix, this is failing there with Test name: VclComplexTextTest::testArabic equality assertion failed - Expected: 71x14@(0,1) - Actual : 70x14@(1,1) See also commit 6f995da5a652d993ab253b3363188cd18e289728, that tried to address the same issue (it was reverted later in commit 536666539ce999cfe97378671a7186e38c32bdfc). Change-Id: I708c22deb5f1f8a59e2e22cba14b298acaa81d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113396 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-31drop 4bpp image formatsNoel12-117/+22
on a path to simplifying our internal bitmap stuff, aiming to support a smaller set of image formats, but support them in an accelerated fashion. Change-Id: I5f8bf3cd49abf16ce460771492cdd5f358cb34df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113313 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-31tdf#134385 doc/docxexport: maybe export false contextualspacingJustin Luth3-1/+26
Instead of LO 4.2's solution of never exporting false, export if the inherited value would be true. Otherwise there is no way to override an inherited value. RTF doesn't have a "false" version of \contextualspace, so I ignored that format. Change-Id: I6d05eb9a5d3fbfbfca0fddd7eda0c230baa25c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113064 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-31xmlsecurity: replace OOXMLSecParser implementationMichael Stahl3-234/+1312
This is similar to 12b15be8f4f930a04d8056b9219ac969b42a9784 and following commits, but OOXMLSecParser has some differences to XSecParser, such as using a ds:Manifest, and requires a couple extra namespaces. Change-Id: I56e39d9609db8fcad50ca1632ff482c1f0a30ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113381 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-31sd: clean up not needed HAVE_FEATURE_PDFIUM ifdefsMiklos Vajna4-42/+73
Towards completely avoiding the HAVE_FEATURE_PDFIUM ifdef forest. Change-Id: I490c64a724729086d6156dc815f89d4e0d1ec709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113390 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-31UI Selection dialog: reword UI descriptionMing Hua1-1/+1
The description of Groupedbar Compact variant starts with a general description about both Groupedbar UI variants (the compact variant and the full variant), then specify what is special about the compact variant. Therefore it should starts with "The Groupedbar interface provides...", just like the description of Groupedbar Full variant in the previous line. Change-Id: I98bec4efce996b7f17461a8bb1504e80d70279c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113393 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-31tdf#139350 android: Fix handling of new docsMichael Weghorn3-26/+19
Pass param 'takeOwnership=true' to the 'saveDocumentAs' method when saving a newly created document in Android Viewer in 'LOKitThread::loadNewDocument', so the newly written document is used subsequently, rather than continuing to more or less operate on "private:factory/swriter" (for the Writer case, similar for the others). Extend 'LibreOfficeMainActivity::saveFileToOriginalSource' to handle this case as well (show a proper message and reset the modified state after saving). Drop now unnecessary special handling for the case of saving new files from the toolbar or the dialog shown when exiting without having saved previously. Change-Id: Ief95620e324aa2abc318f1add0b91376ffe669d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113376 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-31tdf#139350 android: Add param to allow a "real" "Save As"Michael Weghorn6-18/+40
So far, LOKitTileProvider's 'saveDocumentAs' method was always saving a copy of the current document (or doing an export), but was not continuing to use the newly saved doc afterwards. Add an additional parameter 'takeOwnership' to the method to specify whether to do so. In other words, * the 'takeOwnership=false' case continues to do what was done previously, it basically does what "File" -> "Save a Copy" or "File" -> "Export" does in the desktop version * the 'takeOwnership=true' case now basically does the same as "File" -> "Save As" in the desktop version (except that the path is already known in the Android case) This essentially forwards the "TakeOwnership" param to LibreOfficeKit, which was originally added there in commit a121074cbd07939713e169586469b934aedbe594 Date: Wed Feb 10 13:26:50 2016 +0100 lok: Introduce a "TakeOwnership" filter option for saveAs(). It is consumed by the saveAs() itself, and when provided, the document identity changes to the provided pUrl - meaning that '.uno:ModifiedStatus' is triggered as with the "Save As..." in the UI. This mode must not be used when saving to PNG or PDF. Change-Id: I11b5aa814476a8dcab9eac5202bd052828ebbd96 This also adds a new 'SAVE_COPY_AS' event type to save a copy without taking ownership, and switches all uses of the 'SAVE_AS' event to that new one for now. (So the behavior remains unchanged, but the terminology is hopefully clearer.) Except for one instance in LOKitTileProver::saveDocument (where the cached version of the document is written to the original URI, if present), all other places are left with the previous behaviour in this commit. Further changes will be done in follow-up commits. Change-Id: I11996cd7276a6c6f2774535cd3e53cb997c8cd4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113375 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-31android: TileKitProvider: Optionally detect file type from documentMichael Weghorn3-10/+23
Add an overload for the 'saveDocumentAs' method that takes just one parameter and auto-detects the file type to use from the document. Use it when creating new documents. Change-Id: I0f275ce159176292ffa1e52ed37673a486ab9428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113374 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-31Related: tdf#137577 Update Name Box range name list on sheet renameEike Rathke4-1/+6
... for sheet-local names that include the sheet name. Introduce SfxHintId::ScTablesRenamed for this as the existing ScTablesChanged is fired quite too often. Change-Id: I94c3479bba4d4cc8b75905e3fa4f35d9a8737870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113391 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-31python3-ify hrcex & uiex (creation of pot files)Christian Lohmaier3-12/+13
Change-Id: I824c9ed536a1e852d6bd157fbd7d4766327b7bcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113319 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-30Exclude some tests in Windows RDP sessionMike Kaganski5-0/+106
It seems that RDP may change (limit?) color space (even configured to use 32-bit colors), and then some tests start failing like this: Test name: BackendTest::testDrawAlphaBitmapMirrored equality assertion failed - Expected: c[80000000] - Actual : c[84000000] Debugging ImplDrawBitmap in vcl/win/gdi/gdiimpl.cxx, and adding a call to GetPixel immediately after the call to StretchDIBits, shows that the resulting color on the device is different from the color in the bitmap data: e.g., for original color {128, 0, 0} the result is {132, 0, 0}. Calling GetColorAdjustment shows that there's no color adjustments set for the device, so I can't detect or modify the behavior this way. So just disable the tests for now when running in RDP sessions. Change-Id: Ie89d07f18f53e56bed6f7fa58432b8575b4d9f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113388 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-30Related: tdf#137577 Be able to select a global named range from Name BoxEike Rathke4-25/+63
... if an identical sheet-local name exists. Change-Id: I6d92a7ed93e81da64f60c26fd81eb6775582b053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113384 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30fix some --disable-scripting warningsCaolán McNamara3-6/+7
Change-Id: I0fa5ec5e0fc7a08f5558f013ec75fd7d4fe5c1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30short circuit image creation if dest size is zeroNoel Grandin1-1/+1
Change-Id: Iace5c871c6a95da8828fa103474f77d5d0555484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113385 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-30tdf#140343 sw page rtl gutter margin: add UNO APIMiklos Vajna3-0/+21
When true, the gutter position may be right and top, not left and top. Change-Id: I5e3e4b4d9cb217b81b2712cb208ca5725d46ae28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113349 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-30upload libcdr 0.1.7David Tardon4-18/+5
Change-Id: Ie01fdee7379c398fe7df7c140e2f0059bea71abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113380 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2021-03-30Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'master' to 7b43a13473ab1c692d33577af1ec191179e9079a - update translations for master and force-fix errors using pocheck Change-Id: I84eb112a5f299d0c0ec33a280ab490cf22ae6d46
2021-03-30For now, skip problematic test_tdf141166 also for --with-helpStephan Bergmann1-0/+8
...similar to how it already got skipped with 10fbf2b80e11620f3fc1691aa7968e6d3d460db9 "Skip a problematic UITest for --with-help=html/online". (And note how the check for "-DWITH_HELP" in $SCPDEFS would unfortunately also hit for the --with-help=html case, see configure.ac, if that were not already filtered with the preceding check, anyway.) The better fix would arguably be to make the code close both the "LibreOffice Help" window and the "LibreOffice Help Not Installed" dialog, whichever shows up for a given configuration. But this temporary fix at least gets --with-help builds like <https://ci.libreoffice.org/job/lo_ubsan/1961/> going again. Change-Id: I9d9d6ffeb26a056fa3fe65085264d75822e7646c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-30ScDocument::GetRangeAtBlock() name is always passed, so use referenceEike Rathke4-9/+7
Change-Id: I1dec40b6da2375b292ba4c9912c4736fcd7ca551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113348 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30drop ---disable-scripting again for fuzzingCaolán McNamara1-1/+0
Change-Id: I80aa5b856d8800f9499fcaf66244ca095e275d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113378 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30tdf#140839 - TotD image sizeHeiko Tietze2-2/+2
Previous size of 100x120 has shown to be too small for thumbnails so we agreed on 150x150 Change-Id: Ia43bc424a164024e8a4ecf851cad3fab4f342e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113343 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-30fix the endif placement for GTK_CHECK_VERSIONCaolán McNamara1-2/+1
Change-Id: I1ff3f3c32990947a353c5908665b156d87d8ff58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30tdf#135662: sw_uiwriter3: Add unittestXisco Fauli2-0/+26
Change-Id: I517bff275bba0a84a69e79f45db1c2a873965feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113345 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-30Related: tdf#137577 Display (sheetname) with sheet-local names in Name BoxEike Rathke6-11/+26
... if current cell selection matches a sheet-local name, so it can be differentiated from an identically named global name. Which is already the case when listing and picking a name from the list. Made it necessary to adapt an UI test checking for Name Box content. Change-Id: Ia90b8961c3ae213cf7bb53f3b610a65805bba6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113330 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30Update git submodulesRafael Lima1-0/+0
* Update helpcontent2 from branch 'master' to 8ec0053e3f8610f06c7f7eae0680549a1c9fd896 - Fixes localization in SF String, TextStream, Timer and UI help pages Change-Id: Ic860d9861006ba69b6d2b593877f2cfa39f31402 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113286 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-30Update git submodulesRafael Lima1-0/+0
* Update helpcontent2 from branch 'master' to ba389e0d4c71bd220689d912470c345746203d6e - Fix localization in SF_Platform, SF_Services and SF_Session help pages Change-Id: Iad67f233d3448043bd30475a7a7c383c8e8dd1ca Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113217 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-30tdf#99913 XLSX import: set filtered flag for rowsTünde Tóth4-10/+66
hidden by AutoFilter to support copying the result of filtering. Unlike ODS and XLS, XLSX doesn't differentiates filtered and manually hidden rows, and without this fix, copy of the unupdated data of the loaded filtering contained the hidden rows, too. Change-Id: I390d1a84b9bf275f3d3782756553b2f236487758 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113040 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-30cid#1222237 Untrusted loop boundCaolán McNamara1-3/+21
Change-Id: Ic7d5da2242498aa5d53d77d6479042c71b87f057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30tdf#140336 ms formats export: export NONE background for ParaBackColorJustin Luth6-8/+34
This fixes a regression from LO 4.2 with tdf#88583's commit 60cdeb2d441a6bf5c55f511f574b2b9dd598fbb8. It isn't only SOLID that needs to be written, otherwise there is no way to cancel an inherited background. And only write out a SOLID if one is specified here. Do not duplicate a style's SOLID fill into every sub-style and paragraph. (Yikes) This fixes DOCX (seriously) and DOC (de-duplication), but not RTF (which doesn't write out transparent brushes). Surprisingly, I didn't find any examples where a NONE was specified that matched an inherited NONE. But it IS important (probably because of a bug) and also smart to determine and avoid writing NONE if there is no inheritance. So then, there is no reason not to do the last step of checking if the current brush matches the inherited brush. [That also paves the way for a potential follow-up commit to try deduplicating SOLID fills as well, although that likely adds grabbag complications into the mix. And perhaps deduplication isn't desired either, in case the user actually wanted to duplicate (if that is even possible under UI conditions).] Change-Id: I8958a68c779057d9fc5da74eca50fcf5b41d8b52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113105 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-30ImplGetWinChildClipRegion never returns nullCaolán McNamara3-18/+16
Change-Id: I3784e47e8584718a51e0fff68382dce833da26f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30cid#1473732 Untrusted loop boundCaolán McNamara1-6/+7
Change-Id: I0d0585f8d379fc0586ee76527f96e50c92953d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30cid#1474044 Untrusted loop boundCaolán McNamara1-6/+6
Change-Id: I9f060fe0b56905def7b81a9b7da0b504367eb36c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30tdf#141329 fix refresh shows the wrong categoryVert D2-2/+4
Change-Id: Iec36c7aa4cb54773a759260638f03b1b218faaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-30related tdf#131801: remove completed TODO commentJustin Luth1-2/+0
The todo was done in LO 7.1 with commit c77b9c349f0a48392d8cb7a49532844b2cafb5ba Michael's reference to testParagraphMark is puzzling because the only place that is found is in a unit test, and Miklos' ooxmlexport.cxx test has nothing to do with numbering. Change-Id: Ie24ff6a69edf92f9dbe586c64a6ea631718002cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110122 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-30Simplify SwFormat::SetPageFormatToDefaultMike Kaganski1-9/+2
Change-Id: I5a85a3f32cd88cb8306d54e2fafa4156056cc577 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>