summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-10-14tdf#137356 framework: fix opening the same document twice for long loadsMiklos Vajna7-16/+195
If the document loading is long enough that the statusbar is updated, then we can have this situation that we start loading the document, then spin the main loop during load and do a second load of the same document as part of the main loop spinning: #0 SwDoc::SwDoc() (this=0x1c6a180) at sw/source/core/doc/docnew.cxx:194 ... #6 0x00007ffff359a6dd in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x1c5c260, seqArguments=uno::Sequence of length 15 = {...}) ... #33 0x00007fffeeb81ecd in Application::Reschedule(bool) (i_bAllEvents=true) at vcl/source/app/svapp.cxx:460 ... #36 0x00007ffff4265251 in framework::StatusIndicator::start(rtl::OUString const&, int) (this=0x1aace80, sText="Loading document...", nRange=1000000) at framework/source/helper/statusindicator.cxx:51 #37 0x00007fffd026dfd3 in XMLReader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) (this=0x1bb7d20, rDoc=..., rBaseURL="file:///.../test.odt", rPaM=SwPaM = {...}, rName="") at sw/source/filter/xml/swxml.cxx:630 ... #42 0x00007ffff359a6dd in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x1bce4d0, seqArguments=uno::Sequence of length 15 = {...}) at sfx2/source/doc/sfxbasemodel.cxx:1883 The reason for this is is that by the time LoadEnv::impl_searchAlreadyLoaded() searches for frames which already have this doc open, the first load is still in progress, and we assiciate the frame with its controller (which has the URL) only once the load finishes. Fix the problem by setting the URL on the frame directly for the duration of the load: this way an in-progress load also counts as a duplicate and we'll have just one document open at the end. Regression from commit 74ac65c49cc1d53b1aa93c2b7c720255867aace2 (#i114963# Enable IPC before OpenClients to allow client connections when printing., 2016-09-06), we just didn't process incoming requests on the socket before, so the problem was less visible. Change-Id: Ib138c4c264e2508c20104ab268501bcca31e2790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104310 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-14tdf#136577 sw: fix Undo of Replace with nothingMichael Stahl1-1/+1
The UI doesn't allow to replace an empty selection anyway, but it now happens on Undo. (regression from e1629c210ad78310e3d48c0756723134a27b89df) Change-Id: I468f28335beaeb8c42df8ed4cfc90f2c03129239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104308 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-14ImageTree::getImageStream may sub a req for a .png with svg dataCaolán McNamara1-9/+11
so we can't rely on the input path name as to its data format. its going to be either png or data, so select which based on the first byte, so presumably keeping the startup optimization of commit 9e5cbcf90f15f46f84900a58bcaee437b98587f6 Date: Wed Dec 18 15:35:19 2019 +0200 load images by explicit type Change-Id: I0b2b743c138075f651d376767984be88745327a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137477 - Access templates via tight extensionsHeiko Tietze3-141/+114
UI modified and code added Change-Id: I1231bb03bc96295b9a7e6cdb85162f7f8ea3add0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104285 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14sw: fix unsorted redlines in SwTable::ConvertSubtableBox()Michael Stahl1-1/+1
ooo12626-10.odt asserts because MoveNodeRange() handles redlines only with an explicit flag. (regression from e366c928819c44b5c253c45dca6dae40b71c9808) Change-Id: I80c6e696e51c6d9c366af30ecf8b6df265d0fc91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104286 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-10-14tdf#137446: sc: Add UItestXisco Fauli2-0/+62
Change-Id: Ied157591f779e19b953b7e59df3fd975d38826f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104277 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14tdf#133260: sc_ucalc: Add unittestXisco Fauli2-0/+21
Change-Id: I4661057a3e65f0e5ab7b18d8ad44bcd08a659039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104281 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14add unittest for SkiaSalBitmap copy-on-write data sharingLuboš Luňák3-0/+46
Change-Id: I2e331785d49c55116bf9cb893be25da1067df8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104283 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-14tdf#135260 sw_redlinehide: fix insert-with-delete differentlyMichael Stahl2-10/+4
The problem with the fix for tdf#127635 is that now the cursor doesn't move left on backspace if change tracking is on. (regression from 398ba26077f9029bdf6f7378bfc9ce8376b6f02d) Revert that and fix the autocorrect position in SwWrtShell::Insert() instead. Change-Id: I5989a589b654fc6e5ba3dd66922af15eff758ecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104280 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-14Fixes to TipOfTheDay dialogHeiko Tietze3-9/+12
* Reverts 231a4e024b85aa0ad06a5632d3f514152babea30 and sets initial value to -1 to start from zero * Improves translatability of string Change-Id: Ib541a72fa3f6eecdf5bbdf17ce2a4e56ff90c397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104276 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-10-14Resolves: tdf#137445 use the DisableEditHyperlink state as of menu launch timeCaolán McNamara3-2/+29
at context menu popup time set if the EditHyperlink entry should be disabled and use that state if queried about it if EditHyperlink is dispatched from the menu. So ignoring where the mouse currently happens to be when the menu was dismissed. The dispatch is done async, if at all, so also trigger an async Query with Invalidate so at least one Query is ensured to reset the stored state Change-Id: I970b15954851f39b039d844c44711bf712fcb482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves: tdf#137382 update label to "Keep inside text boundaries"Seth Chaiklin1-1/+1
was "Follow text flow" uses same non-conflicting keyboard accelerator as before 'x' Change-Id: I61d93f0c73efc813a71f8625c38caebccdac5793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104163 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-14Fix of accessibility warnings for the additions dialogHeiko Tietze3-116/+270
Adds also an icon to the dicitionaries linkbutton Change-Id: I49d40f92bd055ec976dd1ba8f02e9c88064512b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104275 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14Resolves: tdf#137248 Fix wrong condition breaking non-group interpretEike Rathke1-4/+4
Regression from commit 4f36f2ccab6286ec09480caea602c0fa19195736 CommitDate: Thu Sep 10 11:15:47 2020 +0200 detect if a cell still needs interpreting after Interpret() The bool return from ScFormulaCell::Interpret() does not indicate if it was succesful but whether a group interpret was done. As both calls here happen in a non-group context bailing out on that if false (no group interpret) is wrong. Instead, ask the cell if it still needs to be interpreted after having been interpreted. Change-Id: I40eeeef65e1da3d729cb3fef550620b1ea0a5741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104261 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-14Resolves: tdf#137453 Implicit conversion from sal_uInt64 to sal_Int32 is bad..Eike Rathke2-17/+18
Change-Id: I5681249808cf623d3b7df09988f285268ea8d85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104255 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-14mbMousePosFreezed is always falseCaolán McNamara5-9/+1
Change-Id: I664b8e8c02b3af6af96300e3b2aa40a1cff91946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137429 - Ensure first tip is shown firstHeiko Tietze1-6/+6
Starting in safe mode (or the first time) shows now array[0] instead of [1] Change-Id: I50643c4443705a5137080c6dbdb1ad329151b308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104230 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14better fix for tdf#136455 without destroying widgets we don't truly ownCaolán McNamara1-18/+7
Change-Id: I9c3148fc6dd8658e1ff4a91ff83888288806f9e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14SetMousePosFreezed is always called with falseCaolán McNamara2-2/+2
Change-Id: Id1e32f3a4d7efd7805a2142682b1e9486d120539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104258 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137447 - Access icon themes via tight extensionsHeiko Tietze3-223/+346
Button and code added to optgdlg Change-Id: Ib4aa0883a6af2844ab68ed3c0b7f0e21bc655d94 Signed-off-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14loplugin:external (clang-cl)Stephan Bergmann1-0/+5
Change-Id: I2d636f229ea52505cc263ea0219cf9f00130effd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14tdf#76047 XLSX import: fix links to external dataAttila Szűcs4-1/+28
in array formulas to avoid loss of cell content. Without using SetExternalLinks in applyArrayFormulas the IDs of the linked files were not replaced with file names. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I57c304a46899f4171db9ad12e7e187bd6e4c1c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104049 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-14-Werror,-Wshadow (clang-cl)Stephan Bergmann1-3/+3
Change-Id: I3f76ca202c38b42f55d669a0160fa8203b136031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104246 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14tdf#137025 sw: apply textbox padding set in TextAttila Bakos (NISZ)5-0/+115
dialog window using Spacing to Borders in Format->Text Box and Shape->Text attributes... on the selected text box. There are two types of text boxes in sw, the older editeng one, what worked fine, and the newer one, the shape + text frame one, where modifying Spacing to Borders had no effect. This has been fixed by copying the modified shape attributes to the associated text frame. Change-Id: I8da0b414fd4771fa86851d9a6affbd9502894ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103674 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-14cleanup SdrGrafObj and remove unneeded semi-colonsTomaž Vajngerl1-21/+38
Change-Id: I817eaecf9c88440586e0d5fcd3fd0a3ce592195d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104237 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-14pdfium: add an FPDFImageObj_GetImageMetadata() wrapperMiklos Vajna3-46/+16
And in general use more pdfium wrappers in CppunitTest_vcl_pdfexport, so all the '#if defined OSL_BIGENDIAN' checks can be removed. Change-Id: Id05e6ecf3dbb103a263d6068085eede847be320f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-14loplugin:includeform (clang-cl)Stephan Bergmann1-4/+4
Change-Id: If1cffd3896d87695ba189728d8c1f1f04d55b6b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:unreffun (clang-cl)Stephan Bergmann1-1/+0
Change-Id: I9e478c71662aa5a5347d11adae0435e737fced82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104247 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:stringconstant (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I407b5e80a331950790f549ac8a50e8d7e49ee6d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:redundantcast (clang-cl)Stephan Bergmann2-3/+3
Change-Id: I2918d9ac8a4600bf5729604bda1beffb1dca78d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104244 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14-Werror,-Wmicrosoft-exception-spec (clang-cl)Stephan Bergmann1-1/+1
> C:/lo/core/bridges/source/cpp_uno/msvc_shared/except.cxx(124,11): error: exception specification in declaration does not match previous declaration [-Werror,-Wmicrosoft-exception-spec] > RTTInfos::RTTInfos() throw() {} > ^ > C:/lo/core/bridges/inc\msvc/except.hxx(93,5): note: previous declaration is here > RTTInfos(); > ^ Change-Id: I7fa9d85de70d1398f89443b202b9b60c36dcc46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104243 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14Derive FormulaExternalToken from FormulaByteToken, tdf#133260 follow-upEike Rathke2-16/+9
This should always have had a ParamClass member variable and SetInForceArray()/GetInForceArray() functions but never did. Now with commit 3a33828b8de7554e497051738c722b1764960a86 CommitDate: Tue Oct 13 21:36:31 2020 +0200 Resolves: tdf#133260 Propagate ForceArrayReturn from inline arrays it broke CppunitTest_sc_subsequent_filters_test with the virtual dummy assert() in FormulaToken::SetInForceArray(). Unfortunately not caught earlier but at least it did now. Remove the duplicated FormulaToken overrides and simply derive from FormulaByteToken instead that has all we need. Change-Id: I7946602955970fb9d6f349efdacb41389e211b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104262 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-14Fix namespace errors in new "vro" manifest.xmlJulien Nabet1-4/+4
Fix these: /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:2: namespace error : Namespace prefix manifest on manifest is not defined <manifest:manifest> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:3: namespace error : Namespace prefix manifest for full-path on file-entry is not defined <manifest:file-entry manifest:full-path="/" manifest:media-type=""/> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:3: namespace error : Namespace prefix manifest for media-type on file-entry is not defined <manifest:file-entry manifest:full-path="/" manifest:media-type=""/> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:3: namespace error : Namespace prefix manifest on file-entry is not defined <manifest:file-entry manifest:full-path="/" manifest:media-type=""/> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:4: namespace error : Namespace prefix manifest for full-path on file-entry is not defined :file-entry manifest:full-path="DocumentList.xml" manifest:media-type="text/xml" ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:4: namespace error : Namespace prefix manifest for media-type on file-entry is not defined :file-entry manifest:full-path="DocumentList.xml" manifest:media-type="text/xml" ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:4: namespace error : Namespace prefix manifest on file-entry is not defined :file-entry manifest:full-path="DocumentList.xml" manifest:media-type="text/xml" ^ Remark: I don't know why these errors don't appear for "pt-PT" which has the same way to declare manifest.xml Perhaps because only "pt" and "pt-BR" are used and don't use this buggy way? Change-Id: Ibe8e03ec3d2e307be5ba96eb07ad710801f43eaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104260 Reviewed-by: Mihkel Tõnnov <mihhkel@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-13tdf#137446 catch divByZero in ResizeMultMarkedObjRegina Henschel1-3/+3
When a horizontal or vertical line is resized, the height or width is zero and yFact or xFact are invalid Fraction. They are passed on to SdrTextObj::NbcResize. There an invalid Fractions returns -1 for GetDenominator and results a faulty mirroring. Change-Id: Iafe91827cfc7a8b6ccff852115f01ccbb90e54b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104234 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-10-13split out detection of should disable EditHyperlink as standalone functionCaolán McNamara2-30/+43
Change-Id: I69c4d93b402a33d5ef3b55a7fc0a053332eb0196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104253 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13Resolves: tdf#133260 Propagate ForceArrayReturn from inline arraysEike Rathke1-9/+45
... and functions returning array/matrix. Same as for TRANSPOSE() and FREQUENCY() but not mentioned in ECMA-376-1:2016 OOXML. Change-Id: I1e9f1151b2bc0b7de892f4f3d9f91b9a6b86b67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104249 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-13uilogger : Add support in the Logger and DSL for Vertical TabAhmed ElShreif2-0/+22
For example the DSL syntax will be: >> Choose Tab number 2 in 'tab_id' from parent_id We don't need DSL change as it will already handled by normal Tab grammar Change-Id: I51f294134be88c4ac88baf73c53d81187a023061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101516 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-10-13sw_redlinehide: fix crash in SwTextNode::SplitContentNode()Michael Stahl4-26/+109
Bug happens in the "top" branch of SplitContentNode(). SwTextNode::CutImpl() sends several hints to the SwTextFrame so that it invalidates itself; a SwInsText and a SwDelText most prominently. The SwInsText won't have an effect because the target node doesn't have text frames yet, but the SwDelText should be sufficient to update the text frames' MergedPara and invalidate the text frames. The MergedPara is re-created by SwTextFrame::RegisterToNode() anyway, but that *doesn't* invalidate the SwTextFrame. Then an additional SwDelText is sent, which will *not* invalidate the SwTextFrame, because its MergedPara is up-to-date so nothing gets deleted by the hint. It's unclear why the LockModify() is done here, since CVS initial import, perhaps it's some premature optimization; try to remove the manual sending of SwDelText and just let CutImpl() do it. Also remove an odd assert in UpdateMergedParaForMove() that i don't understand the reason for now. Change-Id: Iba7196556f614356dba4def74f039a88f392eb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104219 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-13translate comment to EnglishTomaž Vajngerl1-1/+1
Change-Id: I8315f585b899031d238d339d3833c9f0d536dfab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104236 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-13combine duplicates togetherCaolán McNamara2-8/+16
Change-Id: Ic4d5b50051cee4ab65a366ed7d26c222a7ca3008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13Missing test dependenciesStephan Bergmann1-0/+3
Otherwise, from-scratch `make CppunitTest_sw_uiwriter` failed for me on Linux with > warn:vcl.builder:1934376:1934376:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:1939531:1939531:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:1943074:1943074:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/sfx/ui/infobar.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 Change-Id: I8f1ece408b8c5f0e389378f15a2652a45cb93103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-13bnc#887230: sd_export_ooxml1: Add unittestXisco Fauli2-0/+18
Bisection of tdf#137367 points to the commit fixing bnc#887230 Make sure we don't regress here Change-Id: I54877ca5fae8c7074baf1211ec983c1bc1961f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104232 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-13tdf#101122 DOCX custom shape export: remove bad fillRegényi Balázs5-4/+67
of (simplified export) of not filled custom shapes by adding missing fill="none" to a:path. Note: in OpenDocument, unfilled shape path is defined by draw:enhanced-path command "F", see section 19.145 in ODF v1.2. Co-authored-by: Szabolcs Tóth Change-Id: I0be2aada3deb06828216e0441c91c389a673f87c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104205 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-13Resolves tdf#137424 - UI Picker missing 'Contextual single'Heiko Tietze2-4/+4
Exclusion by experimental on/off updated Change-Id: I714b8ffc5a148d09607ab20763b6d35de2a9e2be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104231 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-13VclScrolledWindow vertical scrollbar one pixel too far to the leftCaolán McNamara1-1/+1
Change-Id: I6d9afb87b8d99e3c622b9d69fbfa88528adadb81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104228 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13tdf#134987 convert DOCX to ODT: fix lost chartsBalazs Varga4-0/+70
Embedded charts of DOCX documents were lost or replaced by images during conversion to native ODT format, resulted by bad handling of XEmbedPersist objects in EmbeddedObjectContainer. Note: Add missing loext:external-data to ODF 1.3 schema definition to fix ODF validation error in gerrit. See commit 2054af83fefb955e20de2b40178a11726525057e (fdo#72520 : Added property to store external data path in chart) and commit a49a9dab3168c03a539adc131f2ade03236edb69 (fix one more ODF validation error). Change-Id: I9edff9af3a79370ea447ffc6078da3520d0c6f63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104104 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-13static_cast after dynamic_castNoel15-72/+60
Change-Id: I68c20dfbedb84660cf25df785e1e0b13a7592994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13static_cast after dynamic_castNoel17-90/+72
Change-Id: If93fa126f10393a250cc1ad64bee28e84c42a6b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13static_cast after dynamic_castNoel32-240/+168
Change-Id: I53e10fbebfd07c471ddd9b264562317251700500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13with a DND_ACTION_NONE drag action and zero target-formats disable dragCaolán McNamara1-2/+8
so we can support dynamically disable/enable dnd Change-Id: Icfec79c332ef073e04be5a57747e849b27098732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 11:00:37 +0000