summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-05-26Breeze & Sifr tdf#136916 add dark underlines variant iconsRizal Muttaqin80-0/+40
Change-Id: Ic15b8e56959606d8dbacb073d6e80d5188dc7502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134975 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-05-26unittest for SalLayoutGlyphsCache glyphs subsetLuboš Luňák1-6/+52
Change-Id: I341871c65e63f37ffc3507daaefe035f6762e62b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134956 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-26do not use glyph subsets if LTR/RTL does not match (tdf#149264)Luboš Luňák1-1/+44
Writer apparently sometimes asks to lay out RTL text as LTR, for whatever reason, and Harfbuzz in that case does not give consistent results usable for creating subsets of glyphs (or maybe HB_GLYPH_FLAG_UNSAFE_TO_BREAK is not reliable in that case). I don't quite understand what the problem here is, but avoid it by checking whether the text is LTR or RTL and simply do not try to create a subset from the glyphs if the text does not match the way it was asked to be laid out. I don't even know if this is correct handling or just a workaround for something. Change-Id: Ic77db04f529c9ca2c194893a2127e85953accf32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134950 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-26test also SalLayoutGlyphsCache in glyphs caching unittestLuboš Luňák1-16/+29
Change-Id: Ic0e5ea44525e7cf76a6de1f64f77b943b8347dfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134948 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-26check GlyphItem equality properly in a unittestLuboš Luňák2-5/+2
I.e. use the existing operator==. I don't feel like writing operator<< for it just for one unittest though. Change-Id: I63181765a4987a5d6efedc74a1e20d56a70eaa83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134947 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-26convertLanguageToLocaleImpl() speed-up a gazillion en-US fallback casesEike Rathke1-0/+10
Change-Id: I7f9290383eabcf3733f15f8f45193ee04db9852f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134953 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-05-26Reduce cmd line length for make_installer callsThorsten Behrens1-1/+2
Seems on Windows, we're hitting the 8k character max cmd line length, on setups with slightly deeper src tree path locations. Shorten length of expanded call_installer calls by putting shell script into PATH locally. Change-Id: If1cddab9e4e07a7c5ebfae7a4e88e43b1bc8b907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134938 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-26ofz#47617 don't skip TIFFClose on error conditionCaolán McNamara1-1/+1
Change-Id: Ie5a84488312b9f17733747942e45d767cd5d4966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25don't try glyph subsets if cloneCharRange() would return anywayLuboš Luňák1-1/+5
A small optimization. Change-Id: I21786ce713bd39d14c075a941d83c060d04b8886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134949 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-25Revert "verify that all results from SalLayoutGlyphsCache match"Luboš Luňák1-25/+13
For now at least, as this is causing a number of Jenkins Mac failures, even though it originally passed (and still occassionally does). This reverts commit 04a36851aab1272c9c21ac97d0fc0f4ffe372fe0. Change-Id: I21454b6ec59e96dfb5f6eb723d4eb8f19948d195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134955 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-25directly instantiate IndexedPropertyValuesContainerNoel Grandin14-71/+95
without the overhead of the UNO service engine Change-Id: I4a02fda2b3c92a897634374bf72cfffee4f531f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25elide some OUString allocationNoel Grandin4-11/+16
Change-Id: Idcb296980ea498373a0fb4f8c0c584eef2c5c9f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25std::set->o3tl::sorted_vector in MathTypeFontSetNoel Grandin2-3/+4
Change-Id: I8b664f10bee232355eeb431de6b1445d9c797f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25tdf#149068 don't call any OpenGL if the context is initially 'invalid'Caolán McNamara1-5/+12
Change-Id: I6a966e84574716a215d1625cde8b6826185cc451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25tdf#149280 modified called after dialog was destroyedCaolán McNamara1-2/+5
just ignore it in that case Change-Id: I8f294acd9ee16d2f9c8662614fac3672f80b3376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134937 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25sw: refactor and create Justify::SnapToGrid()Mark Hung4-95/+156
Move snapt to grid code from SwFntObj::DrawText() to Justify::SnapToGrid() and create a simple unit test case testSnapToGrid. Note that SnapToGrid() is for "Snap to char is on" case. Change-Id: Ib9b3a08c744216e37dd260434700cbf3f079a0fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134707 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-05-25tdf#148467 Move sparklines items to Insert/Format main menuRoman Kuznetsov1-10/+10
Change-Id: I2606fdd6301e5d1cb1e855d79a971762ed2d835d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133608 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-05-25use comphelper::ByteWriter in UNOMemoryStreamNoel Grandin1-1/+42
to avoid a temporary buffer Change-Id: Ibe1d4ffb240993e14eaaddb219f9cde328f9afbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134919 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25elide some OUString allocationNoel Grandin6-24/+56
Change-Id: Ia21421731dadc1d0e65da182471eb2b8d799782b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25allow comphelper::OEnumerationByName to use a vector too for namesNoel Grandin4-16/+33
so we can skip some allocation. Use a std::variant to preserve existing functionality Change-Id: If01ebb04f7895fd52fa3f5d90648868fd38dc39e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia3d5775b938d626457ac4701a5d62f7b7e4162e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134939 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-25sw: add stub Title impl for SwAuthorFieldMiklos Vajna1-0/+6
It is advertised as a property, but it's not implemented: just avoid the assert fail on inspecting the UNO wrapper. Change-Id: Icd20c0edf543cf5ac435b9dcfdc8542f435ef231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134936 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-25tdf#148864 Qt switch QtObjectWindow to QWidgetJan-Marek Glogowski2-33/+57
... and therefore rename it to QtObjectWidget Replacement of the QWidget with QWindow originally happened in commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3 ("tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL"), but that unfortunately has a very sparce commit message with no reason for this change. Then the code was further complicated in commit 25edbded9946801effd117b9c46de0f8b4bc5632 ("tdf#125517 Qt5 implement a minimal Qt5ObjectWindow") and a few follow up fixes to restore input and focus handling. But appearingly all this QWindow handling isn't necessary and just returning to a QWidget based class fixes the problems with the video overlay (AKA QWidget::winId()) and video playback for good. The OpenGL Impress transition (Fade) mentioned in the original tdf#121266 bug still works. This also adds the previously missing SolarMutexGuard to all the overridden QtObjectWidget functions, which call the SalObject's Callback function. I accidently triggered a DBG_TESTSOLARMUTEX crashing Impress while debugging this. Change-Id: Ia22cabfd4f3585dc7fa3f9f18a913c5bd1987dd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134864 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-05-25Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'master' to baa28fb3a6161fa057808d25b69ce24e21a1f9d8 - update translations for master/7.4 and force-fix errors using pocheck Change-Id: I6791c0fed18c372d154a25de9c826720bb037af8
2022-05-25check column again when going to the next Calc sheetLuboš Luňák1-2/+2
Since the number of allocated columns may be lower in the next one. Change-Id: I92eb4642ed01ff6c858a250aefcfa36c565103d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134932 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-25elide temporary vector in PathSettings::impl_convertPath2OldStyleNoel Grandin1-14/+9
Change-Id: Ib86933ef564b0d27c47dbbaddaa55f03b8426c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134927 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-2550 null derefs seen in crashreporting reportCaolán McNamara1-2/+8
Change-Id: I42f1179ad1d60ac70ccda5362590853a69fd3712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-2591 null derefs seen in crashreporting reportCaolán McNamara1-0/+5
Change-Id: I8114f57cf5a5f74b2debac963813dcf6aac1bd0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25tdf#65911 add accelerators for style editingSeth Chaiklin1-0/+13
Alt+C - character style Alt+P - paragraph style Shift+Alt+P - page style Change-Id: I8d9f48ae87daf9c2ad5db2445fd5a74e821dc076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132705 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-05-25svx: fix one more EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli1-1/+3
See https://crashreport.libreoffice.org/stats/signature/SvxShowCharSet::PixelToMapIndex(Point%20const%20&) Change-Id: Ied5698fd47220fae54d72be263c3eeed5fb77911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25tdf#149018 a few more "Objects" -> "OLE Objects"Seth Chaiklin2-3/+3
-- part of a general project to use "OLE Object" instead of "Object" in the UI when appropriate. * updated command sequence in one "tip of the day" and converted tip to a question (after preferred style) * title of dialog box for inserting or editing an OLE object Change-Id: I519930c2e95c7a157c43a0870dca8b3df362b65d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134895 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-05-25cid#1504535 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: I354e6ccc118ec20649eac5257375e493c8172dfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25ofz#47587 TimeoutCaolán McNamara1-28/+37
Change-Id: Ic2e168020ad9040705fbdcd0b6945c6a2d2f5b8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134884 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25sw content controls, date: show a date picker on clickMiklos Vajna12-7/+256
- add a new SwContentControl::GetDateString() that knows how to produce a formatted date, taking the language and the date format into account - add a new SwDateContentControlButton that knows how to open popup a calendar on click and that puts the selected date into SwContentControl::m_oSelectedDate - extend SwWrtShell::GotoContentControl() to consume that selected date & update the document text accordingly - in case SwSelPaintRects::HighlightContentControl() notices a date content control, create an instance of this newly introduced SwDateContentControlButton Change-Id: Ia2cb0fa3aefbf543b8dc2e96bcebb41408eb12c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134926 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-25tdf#149068 put a OpenGLZone around the sync indirect opengl callsCaolán McNamara1-1/+2
to get the opengl version Change-Id: Ibd55974a39d9d79c9ec9a03e4d4482e4e8755471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-25verify that all results from SalLayoutGlyphsCache matchLuboš Luňák1-13/+25
The code used to do it only for computting glyph subsets, but some of the failures there show that bugs in font code elsewhere can make the cache returning different results, so check even for normal repeated cached calls. Change-Id: I8a18710546fe2557f69aaef4ab0bdb63c62a9253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134659 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-25Resolves tdf#119447 - Improve sidebar height in start centerHeiko Tietze1-4/+7
Reduced the font size multiplier from 1.4 to 1.2 to fit the window into 768px height and added the branding image to the height calculation Change-Id: I05473155f0068880298a461fe8491468b07079b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134867 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-05-25Advanced Diagram support: Isolated IDiagramHelper, selection visualizationArmin Le Grand (Allotropia)25-144/+336
Moved and isolated IDiagramHelper to own file to get SdrObjGroup smaller and less dependent again, all places adapted. isDiagram() now available at SdrObject directly, adapted and have less places which need to cast for SdrObjGroup for check. Started to add SdrHdl/selection visualization to seleced Diagram. Only as a start, will need to be extended to look good/better, plus evtl. functionality in handles/UI. Corrected error(s) found by failing UnitTests More clang-notes (static, namespace) I nneeded to follow Change-Id: If4675b3270d3ee30259fce49deb017dbbaf5c0c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134825 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-05-25tdf#56266 sw xmloff: fix tracked deletions in insertionsLászló Németh3-11/+104
RedlineSuccessorData export, i.e. tracked deletions within tracked insertions were loaded as plain tracked deletions during an ODF roundtrip. After that, e.g. rejecting all changes couldn't reject the lost tracked insertion, keeping the text of the tracked deletion as part of the original text by mistake. Regression from commit a9019e76812a947eb54cfa8d728c19361c929458 "INTEGRATION: CWS oasis (1.3.276); FILE MERGED 2004/05/12 11:00:37 mib 1.3.276.1: - #i20153#: changed <office:annotation> and <office:change-info>" Note: RedlineSuccessorData is still stored in an extra text:insertion within text:changed-region, only the not ODF-compatible office:chg-author and office:chg-date-time attributes were changed to dc:creator and dc:date elements in RedlineSuccessorData export: <text:changed-region> <text:deletion/> <text:insertion/> </text:changed-region> Because this structure still causes a bootstrap ODF validation error in the odfexport and layout tests, check the export with uitest. See also SetChangeInfo()/RedlineAdd(). Change-Id: Ic15c468172bd4d7ea1fd49d9b6610204f23d0036 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134860 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-25Resolves tdf#146762 - Consistency for list indent and level shortcutsHeiko Tietze1-19/+15
Previously: * Shift + Tab on the first item decreases the indention * Tab on first item increases the indention * Shift + Tab on any item but the first does nothing * Tab on any item but the first demotes the list level * Ctrl + Tab on any item including the first inserts a literal tab New: * Tab on any item demotes the list item (move right) * Shift + Tab on any item demotes the list item (move left) * Ctrl + Tab on any item indents the whole list * Ctrl + Shift + Tab on any item outdents the whole list Change-Id: If64a5103a271d30c10fc903a306c9271e61cae49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134856 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-25SvxUnoXPropertyTable is never passed a null ptrNoel Grandin9-57/+42
and make the type of the constructor functions more precise to avoid unnecessary UNO_QUERY at the call site Change-Id: I8164fd3df131720cf86eaf6d49735a3157d3cc97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134914 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-25Add Makefile for the FirstUnoContact C++ SDK exampleHossein4-0/+103
Add Makefile for the DevelopersGuide/FirstUnoContact C++ SDK example. The example now can be built using the same process for other C++ exmaples. The DevelopersGuide examples will be categorized into several directories, according to the language: basic cxx java python This requires that all examples ported to each of these languages. Change-Id: I95c5c324fef66664836b5e07bf34c98117e6b478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134596 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-05-25VCL SysEnvData: add Invalid Platform and ToolkitJan-Marek Glogowski2-10/+24
I accidently almost introduced some subtle sytactic error in Qt, because the default platform and toolkit values are actually valid. So add an Invalid value to both enum classes and then sprinkle some asserts, so these tests aren't working on invalid data. Thanks Michael Weghorn for catching this in review. Change-Id: Ic6a0764dfc5168181251023f4d1c66ffa32651d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134882 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-05-25tdf#125925 Qt migrate KF5 theme font settings codeJan-Marek Glogowski6-229/+64
Currently all implemented Qt platforms use freetype and fontconfig to handle the font selection, so just move the font styling code from the kf5 VCL plugin to qt. This really minimizes kf5 by just keeping the special file picker handling in that VCL plugin. Change-Id: I0bbb2496379396afc46e34fe0d026702dce1492e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134862 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2022-05-25tdf#149205 sd theme: fix PPTX export loosing dk1 and lt1 colorsMiklos Vajna4-19/+69
Document theme of Impress documents were exported to PPTX only partially: dk1 and lt1 was hardcoded to the SYS_COLOR_SCHEMES define, while the rest was written from master-slide-specific svx::Theme. The benefit of this is that our theme is just a set of colors (<a:srgbClr> markup in OOXML), while dk1 and lt1 is more dynamic by default in PowerPoint (<a:sysClr> in OOXML). The downside is that this way a custom dk1 and lt1 color was lost on export. Fix the problem by switching to <a:srgbClr> markup even for dk1 and lt1: not using the <a:sysClr> markup doesn't seem to be a problem in practice, or at least much less problematic than rendering with bad colors. If there is a need, dedicated <a:sysClr> markup support can be still added later by extending svx::ColorSet::maColors to not only store a list of colors, but also some additional properties of those colors. Change-Id: I26df3fd8c891c217df0d36382f6599805198f4bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-24no need to call makeStringAndClear hereNoel Grandin1-2/+2
we are passing it to a u16string_view arg Change-Id: Ieef467fde2acccedf41381e97e93034fffceca22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-24comments: reassign ID when copy commentPranam Lashkari3-1/+9
reassigning new ID will make all the comments have unique IDs this will also ensure there is no mixup when working with comments ID Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I94b433130c68354ab94d4d6e9b86751038b31af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134686 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 0d3bba5c383ef8b9f62c121a26fed4445c813949) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134792 Tested-by: Jenkins
2022-05-24fix thread-safety in OInterfaceContainerHelper4Noel Grandin1-4/+12
we need thread-safety here (even though we use a mutex), because we use a singleton, and the singleton can be ref-counted when the OInterfaceContainerHelper4 is deleted, and is generallly not held at that point, and that is tricky to enforce. Change-Id: I1d61495786d5f0e18deae724b2eb6c6645feb51a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134872 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-24tdf#145248 don't start a drag if actively selectingCaolán McNamara1-1/+2
Change-Id: I00565adbb32a6d9109a75548a544e79ba1951650 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-24Resolves: tdf#148168 disable gtk treeview seach boxCaolán McNamara1-0/+1
Change-Id: I63691d86084832e89d248527c214bcdcc98dc3fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 06:49:53 +0000