summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-05-01convert enums to enum classes in svgnode.hxxTomaž Vajngerl12-62/+62
converted XmlSpace, Display Change-Id: I4aced2d7c2f6fcb4adc59949a6ac22d4ddd375a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114953 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-01convert enums to enum classes in svgtools.hxxTomaž Vajngerl17-241/+241
converted SvgUnits, NumberType, SvgUnit, SvgAlign Change-Id: I703b1d9396f42b3af1a36c683628e90161f2717d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114952 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-01update native-code.py with services for vba scripts in CalcTomaž Vajngerl1-3/+38
Change-Id: I54eb60d3be2717c17daa6b7634ccee3e099cbb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-01fix dashed line info conversion for metafile (tdf#136957)Luboš Luňák1-32/+59
My previous change had two problems: - It didn't handle correctly the case when something repeated, such as dash-dot-dot. - The rounding when setting lengths was a left-over from my first attempt when LineInfo used integers and not floats. Change-Id: I914241590b1ddec22df04c05dfe65e76e921ee52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114940 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-30tdf#137679 Use kahan summation for ScInterpreter::CalculateSkewdante2-22/+21
Change-Id: Ib9e34fd14d9968a5a8c79805da4f12d9a3422de8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114818 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-30throw() -> noexcept, part 1/3: Manual scaffoldingStephan Bergmann2-1/+17
The legacy `throw()` dynamic exception specification is gone for good from C++20 (even if compilers typically still accept it, but e.g. Clang has -Wdeprecated-dynamic-exception-spec to at least warn about it). Introduce SAL_NOEXCEPT for use in URE interface include files. (For both the existing SAL_THROW_EXTERN_C and the new SAL_NOEXCEPT, base usage of `noexept` not on LIBO_INTERNAL_ONLY, but on the actual compiler C++ version, so that e.g. building CppunitTest_cppu_any-external, which uses gb_CppunitTest_set_external_code but not gb_CXX03FLAGS, will not potentially complain about those macros expanding to the legacy `throw()`, like when building with Clang -Wdeprecated-dynamic-exception-spec manually enabled.) Change-Id: I7e5c7f8d5f0fd622cfc9987d656b1f68541375aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114908 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-30Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 6b24e1b46b633ccbbf65159f858c9a496479e426 - sf_basic.xhp pt. 2 Change-Id: Icb81fca7bdea283d3da6c113d1305d47c5bc6ff3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114867 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-04-30tdf#137679 Use kahan summation for ScInterpreter::SumProductdante2-35/+17
Change-Id: Id0ef5b30a01054337f0ad3afd8c71311e6b2b469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114888 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-30don't grab focus if we already have focusCaolán McNamara1-1/+6
for cases like the combobox of tdf#138281 so we don't end up selecting the content if we already had focus Change-Id: I2294b2d17d56e5282d7d84859eb9002ebb3b9ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30simplify WallpaperNoel Grandin4-208/+73
All of it's member fields are already COW types, so it doesn't need the complication Change-Id: I44e402e8e80fe96462fc4e1aa06b9ec6815e3cd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-30tdf#79049 speed up OOXML workbook load (3)Noel Grandin1-4/+8
Exit this loop early if we aren't going to make progress anyhow. This takes the load time from 40s to 34s for me. Change-Id: I31887442cde6e3fc05f1fce10bb3dde9c2b88bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-30tdf#79049 speed up OOXML workbook load (2)Noel Grandin2-69/+90
the allocation of memory and pointer chasing was slowing things down in the styles conversion. So switch to more cache-dense data structure, and re-arrange the loops to be more cache friendly. The takes the time from 1m9 to 40s for me. Change-Id: I876580adc7823313b0cdb067f2f6b3e61c39ecf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-30sw: add some SAL_INFO on DoIdleJob interruptMichael Stahl2-0/+8
Change-Id: I44df06ab4bad1a5e0aaf5409590f5d7869f33482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114937 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-30sw: speed up DoIdleJobs(WORD_COUNT)Michael Stahl1-0/+8
SwTextNode::CountWords() has early returns that don't clear the WordCountDirty flag, for nodes that don't contain any plain text. This speeds things up considerably for tdf135116-1.odt, which didn't finish the idle jobs after 5 minutes in an optimized 7.1 build, because the time slice tends to expire iterating nodes in word-count before it can make progress. With this it does ~25 WORD_COUNT pages and then ~90 AUTOCOMPLETE_WORDS pages per idle, sending OnLayoutFinished after 13-14 seconds. jmux just pointed me to commit 0fedac18214a6025401c4c426466a5166553e8ec which is not in 7.1 today and may have improved the performance here. Change-Id: I5e9651da3a173649c49fc36edefb23298dfd6bc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114936 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-30serf should use bundled openssl headers, not system openssl headersAndras Timar1-0/+1
Change-Id: I4431e5141a80394950f5711051065df42fe85f8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114934 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-30reinterpret_cast to SwPostItContent when field type is postitJim Raykowski1-12/+34
Change-Id: I4ed914479c07c786fdc3401c56f7d793777df751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114897 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-04-30Related: tdf#138281 move grab_focus to ActivateFindCaolán McNamara1-3/+5
and remove the explicit KeyInput callback handling of "KEY_RETURN" in favor of the ActivateHdl callback which Entry emits from its built-in KeyInput handler Change-Id: Ie6ddc8d73345400586418f2495958b14ab61c7d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114907 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30tdf#79049 speed up OOXML workbook loadNoel Grandin14-83/+164
we spend a lot of time in ScAttrArray::GetLastVisibleAttr which appears to be very expensive for this worksheet. This is re-computed every time we enter SfxBaseModel::getArgs Reduce the recomputation by introducing a new method which only retrieves specific SfxBaseModel arguments. This takes the load time from 5m9 to 1m9 for me. Change-Id: I605fae0faa94760c7d6993877c9559ea5dc813cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114905 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-30tdf#137945: sc: Add UItestXisco Fauli2-0/+33
Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114900 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-30tdf#78864 sw track changes: cross out deleted imagesLászló Németh3-1/+59
Show Changes mode shows deleted images with crossing out to allow differentiate deleted and inserted images during change tracking. See also commit d6322bcedc197a654abc7d64bfea8cf570f123bf (tdf#59463 track changes: record deletion of images). Change-Id: If9bc2252c6cdd06cbe267fe130023c416aa53ce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114906 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-30tdf#141946 sc: fix broken filter criteria when inserting columnTünde Tóth2-5/+80
The autofilter criteria weren't remain with the filtered column when we inserted a column left of the filtered column. Change-Id: If366d9de9518da3d13ec2ba6b1b36e4f98c76019 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114881 Tested-by: Jenkins Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-04-30allow dnd into weldeditviewCaolán McNamara3-2/+11
Change-Id: I42fafed01a3884279781642154656f0ee32ad431 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30extend the selection range so adjacent lines are considered one blockCaolán McNamara1-1/+30
and so we get one border around multiple lines of an editview selection Change-Id: Ic641035da1c7d2b891cd6e6193b524e6b581e76f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30svgio: change some OSL_ENSUREs to (std) assertTomaž Vajngerl1-5/+5
Change-Id: Ie7e7e6276e5a528fb99a6dfda00e9826c5245fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114899 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-30svgio: change SVGToken enum to enum classTomaž Vajngerl32-600/+600
Change-Id: Ic2618c91b1793463b7ce0a42ec1db100d11acfa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114898 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-30vcl: iOS/macOS - move graphic render func. into AquaGraphicsBackendTomaž Vajngerl10-1765/+1906
This change moves graphic rendering function under AquaSalGraphics into a new AquaGraphicsBackend, which inherits from SalGraphicsImpl. This is part of the refactoring to make it mandatory that a SalGraphics always has a SalGraphicsImpl associated, which will make it possible to simplify the SalGraphics interface and enable the posibility to implement alernative graphic backends (Skia). Common variables and attributes are moved to AquaSharedAttributes and are shared between SalGraphics and SalGraphicsImpl. Change-Id: Ie48da87002ec8e4011ba92fdc9170f3a86761517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114701 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-30allow utf-8 in xml names (liborcus) (tdf#141672)Luboš Luňák2-0/+305
Change-Id: Ib150d55b588a572e4352396f18de2331983b2aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114892 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-30drop DropTargetHelper from SmEditWindowCaolán McNamara2-16/+1
dnd into its child always worked while the inheritence from DropTargetHelper began in commit daf3e2909104fcb4c0a36d6e1fd6f44e1b61c980 Author: jp <jp@openoffice.org> Date: Thu Jul 5 09:58:51 2001 +0000 Changes for TFD636 but always returned DND_ACTION_NONE for the parent window Change-Id: Ida1ae0f8e68ba04452ed952c4eca3ac66f240132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-30Reshuffle code a bitStephan Bergmann1-13/+9
Group the various SAL_THROW_EXTERN_C macro definitions more closely together, and the C++ SAL_THROW_EXTERN_C and COVERITY_NOEXCEPT_FLASE macro definitions do not need to be inside an extern "C" block. Change-Id: I8c56f5c2efd287934cc75b20e79c27769e887e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114845 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-30external: update libxmlsec to 1.2.32Miklos Vajna5-100/+5
And drop the 2 upstreamed patches. Change-Id: Ia821023d9cc06df5e9e7aef82c070ad1c98b67e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114894 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-30loplugin:stringadd (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I132643eb73129e1319af36b7c8aac36a516714b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114896 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-30tdf#137741 SW: Add fields content type to NavigatorJim Raykowski5-8/+195
also makes Comments category be tracked Change-Id: I038ba87d6ae0b96bae2d7a213ec5df92ac7d566d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112560 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-04-30tdf#133548 don't change outline level attrib and list style attribJim Raykowski1-11/+0
when a new paragraph style is created based on a "to outline style assigned" paragraph style Change-Id: Ia757ca375e0e8749a24c27ad8e3f40daff7ef55d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112255 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-04-29sw html/reqif export: fix size of presentation data for "real" OLE2 embeddingMiklos Vajna3-2/+25
InsertOLE1Header() can either take its OLE1 presentation data (preview) from OLE2 or from RTF (SwOLENode). The presentation data size we wrote was incorrect in the OLE2 case case: nPresentationData is the RTF size, nBytes is the actual buffer size. In practice this made the embedded object non-editable in Word (when trying to edit the RTF fragment). This went wrong in commit 0d027abbc5609b096d2a954e77aa7354a55928ab (sw reqif-xhtml export, embedded objects: take OLE1 pres data from rtf if needed, 2020-09-02). Change-Id: I89019202c9a8b40c1b9a21f611f1190fd50073a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114889 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-29tdf#141963 put focus in vcl parent during Function key processingCaolán McNamara1-4/+10
Change-Id: Ib63567c9ce208cb7dd522a1bce9d99fa44a72554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29tdf#141422 Set inital height of the develepment tool window.Gülşah Köse1-0/+1
Change-Id: I703edc227ee163e2a7b8fb9b03c71f055c6e0a3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114775 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-04-29Can use stack instead of heap (desktop/lockfile)Julien Nabet1-3/+3
Change-Id: I31f53436e31ca0dfe7de34bb252f104d4a1b34f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114885 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin86-759/+438
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29rename A field in ::Color to TNoel Grandin2-9/+9
because it's actually transparency, not alpha, and having proper naming helps my limited brain keep track of stuff better when debugging And have both the stream operator and the debugging printer print out alpha values, for consistency. Change-Id: I9bc9ffcb71d554603591935e4043a3fb14646ebd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114886 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 4ee2f0f82f99a865e765309eda367d5fc016674b - sf_basic py2bas bridge It includes Basic functions rework in order to - share content, - correct Basic keywords argument names tdf#141474 - accommodate Python lowercased arguments. Change-Id: If59a82444a8e001b02d085f5e10e0053666f8485 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114008 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-04-29tdf#141967 bail early in Activate if disposingCaolán McNamara1-0/+5
because focus bounces around the dialog as its being torn down widget by widget Change-Id: I2afd094bb13929c25268168175c142ca8e0074e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114880 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29lok: Disable the "AutoInput" again.Jan Holesovsky2-2/+8
This partially reverts "lok: sc - suppress LOK editengine events for the calc input bar." The feature itself is very problematic in Online: 1) causes unwanted jumps to other cells, 2) causes the selection blinking in the cell when typing, and 3) it is very annoying in the form that in which it is implemented in LibreOffice anyway, compared to other office suites. Let's disable it, and enable again when we address the above issues. This (partially) reverts commit 91319ad56887f932b2da334db560d5d0a79a0280. Change-Id: I2234455c29069f74d13896474f3499035935931b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113047 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 65990058f041c3f1d280a69d411eb4ceacf5a721) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113112 Tested-by: Jenkins
2021-04-29vcl: print dialog: remove broken codeXisco Fauli2-21/+0
This was introduced in 149807eb6100090e178505ba4a264bb38eba1e0c < Resolves tdf#127782 - Print dialog height > trying to fix the problem of the window size not being remembered after reopening the dialog, however, the problem is still reproducible in master with GEN, thus, remove this code Change-Id: I65f327fa692cd3e2b5597d04e9e15abc952fe6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114874 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-29tdf#141970 Revert "tdf#129606: Round the mean of the two subtractions"Mike Kaganski1-2/+1
This reverts commit d5ebe7c3089ab9f4d3fe0707169fc1ce024cdb70, and brings number of inexact values in testing back to lower numbers (see test document in the bug). Change-Id: I5cfb34b7260fc6e4866585af6a2a50e79696eea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114861 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-29Update git submodulesRafael Lima1-0/+0
* Update helpcontent2 from branch 'master' to c8cf56ede34cc13a90a930aab505828ee196005c - Create SFDocuments.Base service help page Change-Id: I2bf6bb4e28ed4390c26f9409dddd2aabd1dc878a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114509 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-04-29do not apply line dashing in drawinglayer (tdf#136957)Luboš Luňák10-96/+122
basegfx::utils::applyLineDashing() is not as good as the actual VCL backend dashing, and there are some rounding errors because of all the canvas transformation matrices or whatever, which leads to the drawing problem. So use LineInfo to carry the dashing information. As a part of this change, also make LineInfo use doubles instead of ints. The use of transformation matrices means that the values may be fractional and less than one. Change-Id: Ia5ac7d266cab344b7137052c81fbd96c1ce28003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114710 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-29Revert "tdf#136957 Use bigger dots for better handling in presentation mode."Luboš Luňák3-16/+6
This change was a workaround and a follow-up commit will handle the problem in a better way. This reverts commit 5d80f679e1891f98ef964efa1166c90d001c5806. Change-Id: I24a98a0828d3b6fbd014d58f37bf4da40d7dfdfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114711 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-29reuse SmEditWindow already present in SmCmdBoxWindow in testsCaolán McNamara1-29/+28
Change-Id: I48f15d584e15269336b289c8204588384f2f6998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29can stack-allocate thisNoel Grandin1-3/+3
Change-Id: I53de9926bb3eb662ab6f9065bf1d9190df76c0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29use unique_ptr in TextEditOverlayObjectNoel Grandin1-11/+9
Change-Id: I0deb52ee36a16aad91a5f945a6d92c1aa18a58a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>