summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-02-18Drop obsolete XEventBroadcaster again from XGlobalEventBroadcasterStephan Bergmann2-3/+1
272f0e97b12e634cdf49a1bff45e1b9068af7d9c "Improvements on previous commit" had "[m]ade XGlobalEventBroadcaster inherit document::XDocumentEventBroadcaster/ Listener replacements for obsolete document::XEventBroadcaster/Listener. This means some client sides unfortunately still need to use UNO_QUERY_THROW to obtain the obsolete interfaces; those client sides should be cleaned up to use the replacement interfaces instead." But then 13bedc55b1d533eadcfd4932ef57076e3642caaf "fdo#46808, use service constructor for frame::GlobalEventBroadcaster" unhelpfully added XEventBroadcaster back to XGlobalEventBroadcaster because the AutoRecovery code in framework/source/services/autorecovery.cxx still used the XEventBroadcaster interface via UNO_QUERY (but which was actually as intended). (And 79e0e713f798718902fed9740f147ce143bf7b76 "Update to XDocumentEventBroadcaster et al" meanwhile cleaned up the AutoRecovery code to use XDocumentEventBroadcaster instead of XEventBroadcaster, anyway.) This could be considered an incompatible change to XGlobalEventBroadcaster, but which is an unpublished interface added only in LO times, so lets assume that no 3rd-party code relies on its obsolete XEventBroadcaster interface. SfxGlobalEvents_Impl keeps implementing XEventBroadcaster (as well as XEventListener) for backwards compatibility. Change-Id: I13a5a7fc45d0b79acfdcd3e11bd9b8cc0ece6314 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88986 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18Revert too aggressive clean-upStephan Bergmann1-1/+3
This part of the code was not meant to be removed by 2ff77d088424bc3f5a8e38ef5c1aa3457d102eca "SfxGlobalEvents_Impl::m_xEvents is never changed and never null". Change-Id: I0947457b9b5b6cd79f9ea0aea63265d656787f47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88984 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18Remove unused HAVE_FEATURE_LDAPStephan Bergmann1-1/+0
It was introduced with 6776c53b7ce2e431d8636f4e5a755f50f787ec8f "Make LDAP support optional", but it appears that it has been unused right from the start. Change-Id: Ia4afe23433c42e279a36a030bd661b26da72735e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88945 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18SfxGlobalEvents_Impl::m_xEvents is never changed and never nullStephan Bergmann1-9/+1
It is always set in the SfxGlobalEvents_Impl ctor with m_xEvents = new GlobalEventConfig(); This code added with 3ddbfc311cd4471a6733b2d9dee338d3a80416c7 "INTEGRATION: CWS fwkpostbeta03" appears to be nonsense boilerplate. Change-Id: I6a6a75c619015815a8c6231862cd162de6361ecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88969 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18tdf#80194 UI: revert subscript DFLT_ESC_SUB to 8% (from 33%)Justin Luth5-4/+27
Originally this was at 8%, but long ago for some reason that I couldn't find, it was changed to match superscript's 33%. This primarily affects UI for editeng. 33% was completely wrong. It puts the subscript WAY too low. The font's descent is only 20% of the total font height, so to lower the character by 33% pushes it below the line instead of towards the bottom of the line. Many export fixes that match the formula which calculated the values for DFLT_ESC_AUTO_* were made to LO6.4 for tdf#127316. Changing this default suprisingly has almost no effect. Import and export do not depend on a specific escapement to determine whether to treat it as automatic or not. That is generally handled with special keywords, or in the case of RTF with a +1 on the nPROP value. Writerfilter's use is in a never-to-be-encountered failsafe edge-case. HTML's import is affected, but for the good, so I made it into a unit test. Primarily it affects the UI dialog - suggesting 8% when automatic checkbox is cleared, and the biggest impact comes with the toolbar button for Draw/Impress which don't set "automatic" mode, so they just take the DFLT_ESC_SUB value. Looks much better now. And that was the heart of the bug report - that editeng defaults for subscript were way off. Change-Id: I6769072d483467e86fea82dfc534eb5e04802491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88910 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-02-18uitest: test tab navigationXisco Fauli1-0/+43
Change-Id: I6be30cf419b5a7752ca168e4817efcb6981f803a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88966 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-18skip on-demand children in all_foreachCaolán McNamara1-1/+1
Change-Id: I7151ba11a67db440edd22156586d94bb9a01fcd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18reduce log noise a littleNoel Grandin1-1/+3
Change-Id: I5a5c2f70d416fd0daefa3a4a05c4cf1c73b214dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-18Resolves: tdf#130756 null deref in empty treeviewCaolán McNamara1-1/+4
Change-Id: Ie43081d5c1feb655ea1479476375ee7381f0a0ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18Related: tdf#130370 Let cut&paste/move of a sheet-local name reference ...Eike Rathke2-12/+6
... reference the original sheet-local name instead of a same name on the destination sheet. In bugdoc https://bugs.documentfoundation.org/attachment.cgi?id=102780 that is the case when cutting Sheet2.B3 and pasting somewhere on Sheet3. That yielded formula =value with result 3. (after the fix of commit 180fef2a54207555c39fb63ead5e66ba3a71a0cf, before it was #NAME?). Now it yields the expected formula =Sheet2.value with result 2. Change-Id: Id92778ea41544583e885eaccfbf82c26762925a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88939 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18drop unneeded includeCaolán McNamara2-4/+1
Change-Id: I2a35e48ae07844f8fc85cfa08fcde29b26eca8ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88929 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18rename XML_OLD_NAMESPACE_ constantsNoel Grandin3-25/+25
so I can use them with the XML_ELEMENT macro, which expects them to start with "XML_NAMESPACE" Change-Id: If8098448f451675aaff8ca2dcf9544e765cda965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88928 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-18fix uninitialized memoryLuboš Luňák1-1/+1
Change-Id: I1cae656d2059779774643de93c698281b55b86fd
2020-02-18Resolves: tdf#130370 Increment sheet-local name only for moved cellsEike Rathke1-2/+5
Probably that piece of code is not needed at all anymore since moving entire sheets and their names is handled differently nowadays. Needs further investigation. Change-Id: I2ac115c18354371d0abbfc6cc972d16edcb41021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88898 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18move svmedit.hxx internal to svtoolsCaolán McNamara5-9/+5
Change-Id: I52469e2029f292e7d5e9002cb9d098c14576a00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18calc sidebar cell appearance updateandreas kainz1-0/+3
Change-Id: I39b75c5a5ca18703c79e82334fae00c880919037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88885 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-18tdf#130519 Add "More options" button to Lists sectionRoman Kuznetsov1-0/+3
on Impress Sidebar Change-Id: I839cfe98e7d7ce8656f07977fe1ee4824d7f27ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88255 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara2-8/+5
Change-Id: Id3e20d4eebb02f0022b138dfcd835ea70f1417f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara2-5/+5
Change-Id: Ibacffee0520d7525d552820713f3d4d620e1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara2-4/+3
Change-Id: I636eb7bfd0c1d523751661a35edaa30181491de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara2-3/+3
Change-Id: I0f8d8ae81776f92637880f8ad1a82fcf948c9e5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara2-5/+5
Change-Id: I119959aa220b83b127f2886ed4e6e13717899733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move SVTXFormattedField, SVTXCurrencyField, SVTXNumericField to toolkitCaolán McNamara6-1148/+1135
Change-Id: If22200a4f342d4d779c612dbace61a4cf99471ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move NumericBox to vcl/toolkitCaolán McNamara2-21/+20
Change-Id: I3f51e917eb1979bf93f2233ec54abc31af8ef51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18tdf#130384 cui: fix automatic color showing up as white in the char dlgMiklos Vajna2-1/+22
Regression from commit b4554b8eddd048532269df610e89ae739c46fab7 (cui: add UI for semi-transparent shape text, 2019-11-22), the problem was that COL_AUTO has the alpha channel set to 0xff, and we should not clear that, otherwise the color list box will present the automatic color as white. Change-Id: I6eae788606b003eec014c0c4a22b40053ff534d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88884 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-18sw: add test for 391613785ae6fbb735cf7a86ea2f6a93161a8769Michael Stahl2-0/+837
Change-Id: I3f0f49c1eb5e680f8c30848da046b4dc975af218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88882 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-18tdf#130648 Add icons for ProtectField and PrtectBookmarksandreas kainz9-1/+56
Change-Id: I064c9ac69b224937b281ea5c9a1eefc3cdfeba6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88894 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-18Line Sidebar arrangement updateandreas kainz1-76/+88
Change-Id: I6b80382f159c92dce703f8d07d69fe183ff90d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88666 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-18Area Hatch dialog alignment fix compare to other area fill tabsandreas kainz1-2/+0
Change-Id: I39787941aa98b3623ef989e81c4dce0b402ef38c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88895 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-18NFC tdf#120412 cleanup2: use DFLT_ESC_* moreJustin Luth2-2/+2
Found in preparation for tdf#80194. Lots of related bugfixes in LO6.4. tdf#99602, tdf#127316 Change-Id: I1effb71d0fceaad45d211ba20529457d3d7406b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88909 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-02-18jsdialog: don't report hidden toolbox items as present.Michael Meeks1-0/+2
Change-Id: I965d41b15c437965b605e70b228f4da6ccbeb857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88766 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 105ffa961374ac3dfc7c2bde23f6c677b9a7f2f5 - Fix image size in page Change-Id: I8b3c885bb98d59880dfce42339344e6119fbf1c8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88893 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 7f5456a742f37e3817a48f8ce67f0af44dcf14bc - Update icon replacement table Change-Id: Id73f42124c4a5b08fedeaa28cf26043a03f52cfe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88886 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-17Image Property Dialog Crop and Image Tab updateandreas kainz2-108/+133
Change-Id: I5b60f8359b8ca27e3517b2422a5d53868584ab2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88415 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-17Resolves: tdf#130123 let the expert config columns be resizableCaolán McNamara1-0/+4
Change-Id: I08572bfe92c99d6e2e6b8ea27856817a6dddf1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17drop unneeded includeCaolán McNamara1-1/+0
Change-Id: I656a37b65f051d3a773c3b7c6b965038b99b354a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88881 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17cid#1458429 silence some CHECKED_RETURNsCaolán McNamara1-5/+5
Change-Id: I4499ba6a1c74f809901c20a05958ca13ecdf0382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld LimitBox Item WindowCaolán McNamara12-226/+185
also merge dbaui::LimitBox with dbaui::LimitBoxImpl Change-Id: Idd01e71d6afe817971223b46611c622a82883304 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17tdf#129675: This should be EmfPlusPenDataDashedLineXisco Fauli1-1/+1
else if (pen->penDataFlags & 0x00000100) was changed to else if (pen->penDataFlags & EmfPlusPenDataMiterLimit) where EmfPlusPenDataMiterLimit = 0x00000010 See https://bugs.documentfoundation.org/show_bug.cgi?id=129675#c20 Regression from 1bd303a4c38a1bc04c3cf7bf0e7a44ac0fdb209d Change-Id: I01ba4272aaa665a2fb0ab7ce9c05bb882db77d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to fe4e52a549628960e520bb0ef7fea0cca14911fe - Extend DTD to hold characters tags in <ahelp> Change-Id: Ie8eafde9e943ec28dfbe9bc9fc282b0f934f9b4a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88868 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-17DOCX import: don't touch the ZOrder of inline, in-shape objectsMiklos Vajna6-2/+23
1) This is not needed: Word only supports inline "anchoring" in textboxes. 2) If the textbox has a certain ZOrder, we don't want the inline shapes to be behind the textbox. 3) This allows restoring the old assert in sw_ooxmlexport7 that was changed in commit 99847d6b3005c5444ed5a46ca578c0e40149d77c (DOCX import: fix ZOrder of inline vs anchored shapes, 2020-02-12). Change-Id: I817e4fb70cb789e8eb116219050fc1aeaec76667 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88873 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-17tdf#130590 Chart OOXML export: fix custom label positionBalazs Varga3-0/+38
in case of all chart types except pie chart. Follow-up of commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property) Change-Id: I3ff1ca13928315f27988ae27c462a2f05354bc49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88371 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-17weld InputEdit Item WindowCaolán McNamara7-59/+155
Change-Id: I33e4fb378897289b7b54c80b9cb3d7e868381f96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17default to not selecting all on explicitly grabbing focusCaolán McNamara1-0/+7
like vcl does, cause there are assumptions built into the writer InputEdit that this is the case Change-Id: I39358e2c82f602fe2e9a62d54d075888fe80265f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88864 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17tdf#127167 Do not reset Draw/Impress page sizeKelemen Gábor1-4/+0
to default A4 when modifying the Size settings in Print dialog - LO Draw/Impress page Change-Id: I28321d29408964d97b2b347c0b9f16cb1fb63183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88530 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-17disconnect damage when target window is destroyedCaolán McNamara1-0/+4
Change-Id: I4b14ec12112e54bc913fe960808f0bbf8ba4bada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17improve changed_by_direct_pickCaolán McNamara1-1/+5
Change-Id: I5007c428b30a2827f5ba1a85eefdb8deed826b5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary button.hxx includesCaolán McNamara9-16/+16
and update pches Change-Id: I61ca0be7a838e4eec6c41e0ece58d8a6b0e64c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17Prefer prefix ++ operator for non-primitive type SwNodeIndexMuhammet Kara1-1/+1
Change-Id: I8863084065cd4ec3f1735a9469f6e28cd525abce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-17Remove never-executed else-blockMuhammet Kara1-5/+1
And the always-tru if-check Change-Id: I674d65506e1791fadab7d2871010528fd5dd94d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-12 22:50:46 +0000