summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-30Related tdf#129547: add Excel shortcuts insert time/date in Calc for German UIJulien Nabet1-0/+7
For German UI and locale German layout keyboard (based from https://en.wikipedia.org/wiki/German_keyboard_layout) https://www.traens.com/tipps/microsoft/datum-uhrzeit-excel.html indicates: " Einfügen eines statischen Datums in Excel Drücken Sie STRG + . (Strg und Punkt) Einfügen der aktuellen Uhrzeit in eine Excel Tabelle Drücken Sie STRG+UMSCHALT+. (Strg, Umschalt, Punkt) " so I added (specifically for "de"): POINT_MOD1 for InsertCurrentDate COLON_SHIFT_MOD1 for InsertCurrentTime Change-Id: I2523dddf918f9680f87c82c174e20462620948ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-30Simplify some calls to HtmlWriter::attributeMike Kaganski2-16/+16
Change-Id: I608efc6cf7ae05df5a0db3282e0a55315e286718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149759 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-30no need to make copies of the GrabBag mapNoel Grandin2-9/+9
Change-Id: I5cd697d0cfaf65a9ad581d4d7571a69e6214cbb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in xmloffNoel Grandin17-121/+72
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: Id38d983e59386554c61e9bdcd9333554bbf4665c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in vclNoel Grandin20-451/+359
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I44ce7183e4b292269fac1e3d2217286bf5abe823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149752 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in ucbNoel Grandin11-61/+28
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I2445a69dc46314c73f54c190a0c498c0309be06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30tdf#150471 Remove duplicated Freeze commands from the Tabbed UIRafael Lima3-98/+443
As discussed in the ticket, the commands "Freeze First Column" and "Freeze First Row" are duplicated in the Tabbed UI (under the View tab), since there's already a "Freeze Rows and Columns" command that already offers these 2 options. So this patch removes the "Freeze First Column" and "Freeze First Row" entries and keep the "Freeze Rows and Columns" comand. The label of the ".uno:FreezePanes" is also changed to "Freeze Panes" so that it doesn't occupy so much space in the tab. I set the ContextLabel to "Freeze Rows and Columns", so in the menu and context menus, the text shown remains "Freeze Rows and Columns". Change-Id: I57e6b22b103c2316ca0722878491b719e93b9bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149650 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-30loplugin:stringadd in test..toolsNoel Grandin4-44/+31
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I8619fa3280338afdfe75bdbfda6cb118d396e1c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in sd/sdextNoel Grandin14-313/+272
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: Ic95e72e1c857c6814d6e25b9820494cdfa535465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in ucbhelper..uuiNoel Grandin8-126/+49
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I49549347c1c041cc9ce103aed1fe1cc3bc1a780f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30add docstring for unclear default distance property in SvxTabStopItemSarper Akdemir1-0/+1
Change-Id: I6c9eef0a2167f738cdab8171d082becfca401d25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149740 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-03-30use more concrete types in chart2Noel Grandin6-69/+29
Change-Id: Iaefad282d40c83f58758b41db9b14f6e95552354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30loplugin:stringadd in sfx2Noel Grandin7-34/+20
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I72c2afa0b6bddfe00fe09f34eb1b1bf2177461d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30Report correct mimetypes for TIF and EMFMike Kaganski4-78/+72
Change-Id: I2eeb07780e3581eea29a9ad98b493de4e78a5d65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149745 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-30loplugin:stringadd in starmath..svlNoel Grandin12-109/+63
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: Id8f229c3a5223dee8d2710caf15d4612594fc763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149748 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-30tdf#146748 Change 'More Numbering/Bullets' options to 'Customize'Arvind K2-12/+2
Change-Id: Ia9ae20b8c73ddd762424c99eedbaf145fed81935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148142 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-30sw reqif-xhtml export: fix export of transparent TIFMike Kaganski5-14/+55
Since commit 22b50f1937de67e4ad9e692d6964aa5b8d33af7a (use libtiff for tiff import, 2022-05-21), transparent TIFs are imported correctly. As the result, reqif export started to output the transparent TIF images as GIFs, because XOutFlags::UseGifIfSensible handles case of transparency, and XOutFlags::UseNativeIfPossible didn't handle TIF. Additionally, the resulting mediatype was reported incorrectly: <reqif-xhtml:object data="[...].gif" type="image/tiff" ... > 1. Handle TIFs in XOutBitmap::WriteGraphic when XOutFlags::UseNativeIfPossible is specified. 2. Return the corrected mediatype from XOutBitmap::WriteGraphic, to inform the caller about the possible change. 3. Remove the XOutFlags::UseGifIfSensible flag when doing the reqif export, to avoid the format change at all. Change-Id: I99f7cfb8d12ef66d372700ec810bd8b269868ffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149744 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-30tdf#108188 - Use constant string for default page styleAndreas Heinisch1-1/+4
Change-Id: I7c398c3dec044722e4552527de8553506cda54f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149730 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-30UITest_{calc_tests6,chart,chart2,sort}: enable oneprocess modeMiklos Vajna5-0/+28
Execution time changes: - from 1m27,535s to 0m55,724s - from 5m40,926s to 4m46,884s - from 1m54,886s to 1m31,400s - from 3m30,592s to 2m20,833s for me. Also add a simple script that lists what's remaining to be converted. Change-Id: I274f5a11a0f606964bdad5d5e5254b65b09fe497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149739 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-30sw: fix undo comment of FN_UPDATE_FIELDSMiklos Vajna4-2/+7
It's updates, not insert. One has to dispatch .uno:UpdateFields to see this in action, which does something if the document already has exiting reference marks. Change-Id: If5a06d2a81aa2439977c9fc51c3af1ee241f9eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149738 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-29Add extended tip to labelselectiondialog.uiOlivier Hallot1-0/+10
Change-Id: I6b4d0a30c2a1a51694770ecd02eea3cf3677b5eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149732 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-29Bump Glade release for labelselectiondialog.uiOlivier Hallot1-37/+33
Change-Id: Id941b353e8d9f0df2de3816d47e03ec564351701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149731 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-29Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 1a24e9d015c2747c37533c9edec8a081318d6e96 - tdf#83283 link help page for Label Field Selection in Form design Change-Id: Id9abe070e03956c283b2f1c33fdb7737b7584f6a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149734 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-29use more concrete types in chart2Noel Grandin3-18/+19
Change-Id: I1ba60b690a0402d1a98f792c86ddd033e0c39ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more get/setFastPropertyValue in chart2Noel Grandin7-21/+41
Change-Id: I4979cf5dab8b35ba35a46808cef76dc3f81c59b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149725 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more get/setFastPropertyValue in chart2Noel Grandin10-37/+61
Change-Id: I1471309e200c8eec21844658b873f817565f9604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29Prevent accidental OUString(nullptr)Mike Kaganski1-0/+7
Similar to commit f20162304d73bc01955e9ef6506c3bd1c7016c48 (Rule out OString(std::nullptr_t), 2015-07-12); after that, OUString was changed to have only one ctor taking pointer in LIBO_INTERNAL_ONLY case, so became a similar issue. Change-Id: Iac851d1c24c0616ee52a112b81ba71877c28c493 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149696 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-29tdf#154445 - Export all page styles even if they are not in useAndreas Heinisch2-2/+27
Change-Id: If0ca5ea97ad545058c6a70d223158a87bf9207ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149729 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-29UITest_calc_tests{,2,3,4}: enable oneprocess modeMiklos Vajna4-0/+8
Execution time changes: - from 5m6,456s to 3m26,832s - from 2m56,710s to 1m56,982s - from 1m37,645s to 1m9,388s - from 1m52,203s to 1m12,651s for me. Change-Id: Ie3860309c768dd3aaf8efe40a1e995874737b052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149728 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-29use more concrete types in chart2Noel Grandin2-13/+17
Change-Id: I932d8a45d525b1b629a0aaee96a1643b155069f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149692 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29fix bug in WrappedRegressionCurvesProperty::setValueToSeriesNoel Grandin1-3/+4
ever since commit 1cd3e2038010cb37bda82d38dd058b793b7eec26 Author: Tomaž Vajngerl <quikee@gmail.com> Date: Sat Jun 29 18:43:16 2013 +0200 Multiple trendline removing and changing type support. Change-Id: Ibd24d0831932f25e60c05a00450d611e15875102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29tdf#153705 officecfg: use more Title Case in GenericCommands.xcuSabri Unal1-4/+4
Change-Id: Ief2ed6d86b5f65d354d4e47d9ef2999bef81d643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149723 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-29libjpeg-turbo: upgrade to release 2.1.5.1Taichi Haradaguchi6-15/+15
Fixes a serious regression that 2.1.5 had.[1] [1] "Release 2.1.5.1 · libjpeg-turbo/libjpeg-turbo" <https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.1.5.1> Change-Id: I0586d735e17789482e0e8e667aafd2b5613a1232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29crashtesting: xSource seen as empty referenceCaolán McNamara1-0/+6
#17 0x00007f42f14f1662 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6 #18 0x00007f42ef64c68f in com::sun::star::uno::Reference<com::sun::star::embed::XStorage>::operator-> (this=<optimized out>) at core/include/com/sun/star/uno/Reference.h:385 __PRETTY_FUNCTION__ = {<optimized out> <repeats 151 times>} #19 SfxObjectShell::CopyStoragesOfUnknownMediaType (xSource=..., xTarget=uno::Reference to (OStorage *) 0x561536cddad8, rExceptions=empty uno::Sequence) at core/sfx2/source/doc/objstor.cxx:3566 aSubElementNames = uninitialized uno::SequencePython Exception <class 'TypeError'> 'NoneType' object is not iterable: bResult = true #20 0x00007f42ef65551d in SfxObjectShell::SaveAsChildren (this=this@entry=0x561536dad540, rMedium=...) at core/sfx2/source/doc/objstor.cxx:3328 xStorage = uno::Reference to (OStorage *) 0x561536cddad8 AutoSaveEvent = false lArgs = {<comphelper::SequenceAsHashMap> = {m_aMap = std::__debug::unordered_map with 2 elements = {[{maString = "AutoSaveEvent", mnHashCode = 528032507}] = uno::Any(void), [{maString = "FilterName", mnHashCode = -1339490047}] = uno::Any("string": "draw8")}}, static PROP_ABORTED = {{str = Python Exception <class 'AttributeError'> 'NoneType' object has no attribute 'lazy_string': , more = {refCount = 1073741824, length = 7, buffer = u"Aborted"}}}, static PROP_ASTEMPLATE = <same as static member of an already seen type>, static PROP_COMPONENTDATA = <same as static member of an already seen type>, static PROP_DOCUMENTSERVICE = {{str = "DocumentService", more = {refCount = 1073741824, length = 15, buffer = u"DocumentService"}}}, static PROP_ENCRYPTIONDATA = <same as static member of an already seen type>, static PROP_FILENAME = <same as static member of an already seen type>, static PROP_FILTERNAME = <same as static member of an already seen type>, static PROP_FILTERPROVIDER = <same as static member of an already seen type>, static PROP_FILTEROPTIONS = <same as static member of an already seen type>, static PROP_FRAME = <same as static member of an already seen type>, static PROP_FRAMENAME = <same as static member of an already seen type>, static PROP_HIDDEN = <same as static member of an already seen type>, static PROP_INPUTSTREAM = <same as static member of an already seen type>, static PROP_INTERACTIONHANDLER = <same as static member of an already seen type>, static PROP_AUTHENTICATIONHANDLER = <same as static member of an already seen type>, static PROP_JUMPMARK = <same as static member of an already seen type>, static PROP_MACROEXECUTIONMODE = <same as static member of an already seen type>, static PROP_MEDIATYPE = <same as static member of an already seen type>, static PROP_MINIMIZED = <same as static member of an already seen type>, static PROP_NOAUTOSAVE = <same as static member of an already seen type>, static PROP_OPENNEWVIEW = <same as static member of an already seen type>, static PROP_OUTPUTSTREAM = <same as static member of an already seen type>, static PROP_PASSWORD = <same as static member of an already seen type>, static PROP_POSTDATA = <same as static member of an already seen type>, static PROP_PREVIEW = <same as static member of an already seen type>, static PROP_READONLY = <same as static member of an already seen type>, static PROP_REFERRER = <same as static member of an already seen type>, static PROP_REPLACEABLE = <same as static member of an already seen type>, static PROP_SALVAGEDFILE = <same as static member of an already seen type>, static PROP_SILENT = <same as static member of an already seen type>, static PROP_STATUSINDICATOR = <same as static member of an already seen type>, static PROP_STREAM = <same as static member of an already seen type>, static PROP_STREAMFOROUTPUT = <same as static member of an already seen type>, static PROP_TEMPLATENAME = <same as static member of an already seen type>, static PROP_TITLE = <same as static member of an already seen type>, static PROP_TYPENAME = <same as static member of an already seen type>, static PROP_UCBCONTENT = <same as static member of an already seen type>, static PROP_UPDATEDOCMODE = <same as static member of an already seen type>, static PROP_URL = <same as static member of an already seen type>, static PROP_VERSION = <same as static member of an already seen type>, static PROP_DOCUMENTTITLE = <same as static member of an already seen type>, static PROP_MODEL = <same as static member of an already seen type>, static PROP_VIEWONLY = <same as static member of an already seen type>, static PROP_DOCUMENTBASEURL = <same as static member of an already seen type>, static PROP_SUGGESTEDSAVEASNAME = <same as static member of an already seen type>, static PROP_AUTOSAVEEVENT = <same as static member of an already seen type>} aExceptions = empty uno::Sequence #21 0x00007f42ef6555fd in SfxObjectShell::SaveAs (this=this@entry=0x561536dad540, rMedium=...) at core/sfx2/source/doc/objstor.cxx:160 Change-Id: Ie9bb49a8ebff6d985e93c7738da241ff8d61ff2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29tdf#149064 ensure interaction handler is present when transfering with webDAVJaume Pujantell1-1/+2
Change-Id: I7a31f708e6fe01f07c7187aacd4657b5c6156c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149722 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-03-29tdf#124472 DOCX import: fix broken field command by skipping delInstrTextCzeber László Ádám7-8/+79
Process only inserted and not tracked parts of the (partially) tracked field commands to avoid of broken fields, e.g. hyperlinks with bad URLs. For example, instead of the previous bad URL 'https://www.libreoffice.org/"HYPERLINK https://bugs.libreoffice.org/', now the hypertext field of the test document imported with the correct URL 'https://www.libreoffice.org/'. Field commands have change tracking in OOXML, but not in ODF/Writer. OOXML delInstrText, i.e. deleted part of the field commands was imported as part of the actual command, resulting broken fields, e.g. hyperlinks. FieldCommand was splitted into two parts, deleted and non-deleted elements. This way the commands do not get mixed up if the order is changed and no fragmentation of deleted items occurs (otherwise it could fail on the test of tdf#150086). Change-Id: I97d22e5ee1fe647715206f86c4160ebcc4b9cca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148528 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-03-29use more concrete types in chart2Noel Grandin4-22/+18
Change-Id: Id665050f4f0763505e7f1ace6ade5bf9ab02edf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more get/setFastPropertyValue in pie chartsNoel Grandin8-31/+34
Change-Id: I17bf8631b5934d6d112f17e4a05025802dcde2f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin6-11/+12
Change-Id: I938aa1d6d3c20b35d9e11818d4b641d8a03decaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29crashtesting: Null-deref on export of forum-mso-en4-274729.xls to odsCaolán McNamara1-0/+2
and others, probably since: commit f02ec0d8489404966596cb0e949bf969e8e66fa2 Date: Wed Mar 22 08:50:15 2023 +0200 move hasUnhiddenData inside chart2::DataSeries Change-Id: Icf59439f00a40ef036decaa36f3d5af68787c864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29fix concurrent access to fontcacheNoel Grandin11-7/+63
Every now and then I see a crash in fontcache code. Add some DBG_SOLARMUTEX calls there, which spots a few issues. (*) In writer, SwDLL needs to be under the SolarMutex during init, and we can just move a method call to fix that. (*) in chart2, life is more complicated. Various of the static defaults we build want to call OutputDevice::getFontInstance. We can't just stick a SolarMutex somewhere in the call chain, because those maps are built on-demand, and then we end up with ABBA deadlocks between the SolarMutex and the mutex in the cppu::PropertySetHelper. So I picked a spot that is init'ed early on in chart2, and force the init of all the troublesome tables there. Change-Id: I832978bea35fd5fa681d144b8beff1af13ef3341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29Add an assertMike Kaganski1-1/+2
Change-Id: Iee190f27323202d5bb673aaba3116071f294a85b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149695 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-29tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert ↵Michael Weghorn20-176/+126
"VCL expect ... correct frame size for native menubars" This reverts commit afc828b9833b7a612369e95606ba56d41ef2c369 Date: Sat May 28 23:47:21 2022 +0200 VCL expect correct frame size for native menubars ... and renove the wrong framesize hack in the Qt backend because it caused several regressions and unfortunately the commit also doesn't fix all of the bugs mentioned in its commit message (while some previous patch sets of the change did address more, yet had other issues, s.a. the discussion in the commit's Gerrit change [1]). While e.g. the drag and drop issues reported in tdf#153458 and tdf#153800 could be fixed by translating the event position using `mapToParent()` (as is done in `QtWidget::fillSalAbstractMouseEvent` with the above commit in place), I currently don't see how to address the other issues and the overall direction of the change is not fully clear to me at this point. (There are also other pending changes in the relation change still pending in Gerrit that would presumably need more work/analysis.) After all, it seems the best way forward to revert the commit for now. This also reverts the follow-up commit commit 25da92004038c03c0feedf373e8038e7ee3e0c37 Date: Thu Jul 21 11:33:02 2022 +0200 Make JunitTest_toolkit_unoapi_1 succeed again on macOS that fixed a test failure introduced by the above commit. Luckily, there seem to be no follow-up commits that depend on this and the commits can be reverted cleanly without the need to resolve any conflicts manually. This reverts commit 25da92004038c03c0feedf373e8038e7ee3e0c37. This reverts commit afc828b9833b7a612369e95606ba56d41ef2c369. [1] https://gerrit.libreoffice.org/c/core/+/135082 Change-Id: I4c099ad7de8cbbad10da391ede4770d8c748fbde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149495 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-29Resolves tdf#152184 - Application color should follow system colorHeiko Tietze13-489/+261
This patch reverts the previously added "LibreOffice Dark" application color set and adds it to the automatic colors. Switching between light and dark changes the Automatic color accordingly instead switching to another color scheme. The added System Theme option makes Light/Dark follow the actual OS appearance. Reverts 6dfc49bb6a72bf6bb79167b12f0d2d0c5a155d06 (Introduce dark color set), 546ad5d17d3e363b75337c336cfb2b2f8acc55e3 (color scheme translatable), 9f0cf00d29298ed55737928ec4dddc50ac850cd8 (Update view options string based on theme) Change-Id: Ibf491f2e510fac5f1d27a7166560c4ec281d98d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149059 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-29expand out ChartModelHelper::findDiagramNoel Grandin35-107/+93
since it just calls findFirstChartDiagram Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin4-14/+19
Change-Id: I286ad05252bb34f7a1b8f7c08190bddc601faf3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29loplugin:stringadd in swNoel Grandin23-174/+136
when applying my upcoming patch to also consider O[U]StringBuffer Change-Id: I0999a0b04236c276d49c541bbbe3932ba3e5e05d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin11-62/+13
Change-Id: I818253350bd954d3a2a0f302493c896eb2e26994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29use more concrete types in chart2Noel Grandin21-106/+118
Change-Id: Ifd3bce5fc22371559203da673ca98913bc742c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-29Sync flatpak-manifest.in with FlathubStephan Bergmann1-8/+8
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/85022d587be454efd482bcb9baf657d570cc7d06> "Update GVFS, Kerberos5, Apache Ant and OpenJDK Flathub Extension" Change-Id: I6b03adb5872958578b7b2e4bfe3e26bea8882213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-26 21:31:19 +0000