summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-12-16tdf#91781 Round of improvements to Writer's menus for 6.0Yousuf Philips6-15/+108
Change-Id: I17c1edc2e14146144868df51a1f5a71e323eead6 Reviewed-on: https://gerrit.libreoffice.org/46451 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-16tdf#45904 Move _XCellRangeAddressable Java test to C++Jens Carl11-55/+86
Change-Id: Ic3c1e6d793d4405c2dc4b8e7d1d7b87ed94fc6c3 Reviewed-on: https://gerrit.libreoffice.org/46579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-16Move init of keywords around, preset with English, localized case by caseEike Rathke2-98/+51
This way we can't forget an sKeyword element and need to care only about the exceptions. Adds a slight penalty for German in that it has 25 keywords initialized twice, but.. Change-Id: I99ba228ef8b1517a32ce98a9c79cfbe2b1d0b340 Reviewed-on: https://gerrit.libreoffice.org/46575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-16Blacklist CELL() and INFO() for threadingEike Rathke1-1/+3
They access one utl::TransliterationWrapper via ScCellKeywordTranslator::transKeyword() for the localized keywords. Change-Id: Ia3c1ec8def761b3448d6be4c81d42723e1a28ea2
2017-12-16tdf#45904 Move _XCellFormatRangesSupplier Java test to C++Jens Carl11-92/+94
Change-Id: I95c20893878385ef173875956d3d7166b0e9e563 Reviewed-on: https://gerrit.libreoffice.org/46578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-15sw HTML export: add a filter option to produce XHTMLMiklos Vajna5-3/+43
Add initial support for writing XHTML markup as part of the HTML filter. This already emits valid XHTML for hello world documents. Times for 100 hello world inputs: 16032 -> 9957 ms is spent in ODT-load + export + close (62% of original). Change-Id: I51a0a20985958fbc817c196d3a966e55dcb3f13f Reviewed-on: https://gerrit.libreoffice.org/46567 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-15Make temp copy of dbaccess/qa/unit/data/firebird_empty.odb for testingStephan Bergmann5-6/+41
...in CppunitTest_dbaccess_firebird_test. Otherwise, the test would fail with > Test name: FirebirdTest::testEmptyDBConnection > An uncaught exception of type com.sun.star.sdbc.SQLException > - The connection can not be established. No storage or URL was given. if dbaccess/qa/unit/data/firebird_empty.odb is read-only, as DocumentStorageAccess::impl_openSubStorage_nothrow (dbaccess/source/core/dataaccess/ModelImpl.cxx) takes m_pModelImplementation->m_bDocumentReadOnly into account and returns a null xStorage. Adds a move ctor to utl::TempFile (thus causing copy ctor and copy assignment op to be implicitly deleted), but leaves any move assignment op undeclared for now, as none happens to be needed (yet). Change-Id: I6f9eff07eb54f1364a0560ffa4cf1f676a319d16 Reviewed-on: https://gerrit.libreoffice.org/46561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15Fix typosAndrea Gelmini2-2/+2
Change-Id: I061839727b3fd078284117fca3ea53413af7bcf0 Reviewed-on: https://gerrit.libreoffice.org/46574 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15Enable C++17 for clang-cl, tooStephan Bergmann10-3/+58
Similar to libc++ in C++17 mode, some types like std::auto_ptr are indeed removed in C++17 mode by default, and need _HAS_AUTO_PTR_ETC=1 to be enabled (see <https://blogs.msdn.microsoft.com/vcblog/2017/12/08/c17-feature-removals- and-deprecations/>). Unlike libc++, also std::binary_function and std::unary_function are removed (and need the same _HAS_AUTO_PTR_ETC=1 to enable). So either set that flag to make external code build, or use patches (for external/mdds) to make externals' files included in LO proper still work there. Change-Id: I886cc0de8196255334ee03ec48cb4bc54d460afd Reviewed-on: https://gerrit.libreoffice.org/46514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15tdf#113861: Unittest for chart datatable labels expansionVasily Melenchuk5-1/+253
Change-Id: I4ed9019fc1e637e344ab1cb80f650b32aa034a9a Reviewed-on: https://gerrit.libreoffice.org/45670 Reviewed-on: https://gerrit.libreoffice.org/46541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-15Get rid of loop counter variableMike Kaganski1-4/+1
Change-Id: Ia4f4e24819525287e720a9c016b3666bc006b545 Reviewed-on: https://gerrit.libreoffice.org/46531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15Update language-subtag-registry-2017-12-14Eike Rathke1-2/+2
Change-Id: Ieab59f83159cc95faa8119b7b43779329c0a4869
2017-12-15ofz#4649 don't care about exceptions for testingCaolán McNamara1-1/+7
Change-Id: I955460276c3bf98457eff6bc9503edd238a5650c Reviewed-on: https://gerrit.libreoffice.org/46506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15ofz#4643 Direct-leakCaolán McNamara1-7/+7
Change-Id: Ie4fff1a113916c7a3344959cfb4ee14c3fda2073 Reviewed-on: https://gerrit.libreoffice.org/46512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15Apparently missing dependencyStephan Bergmann1-0/+1
Some bots (the Jenkins lo_ubsan, some Jenkins Gerrit Build v2 macosx_clang_dbgutil builds) recently started to fail CppunitTest_sw_filters_test at least sporadically with an abort() from Scheduler::ProcessTaskScheduling (vcl/source/app/scheduler.cxx). ba81ac19b7aec4fd7f07fcec9f6ea6f85d9aaa24 "Report more debug information about caught exception" reveals that at least <https://ci.libreoffice.org/job/ lo_gerrit/24197/Config=macosx_clang_dbgutil/console> fails because of > warn:vcl.schedule:90989:529951052:vcl/source/app/scheduler.cxx:452: Uncaught com.sun.star.uno.DeploymentException component context fails to supply service com.sun.star.embed.FileSystemStorageFactory of type com.sun.star.lang.XSingleServiceFactory Due to the unfortunate try-catch in Scheduler::ProcessTaskScheduling it is hard to tell where the failure originates (and it only hits some bots and I at least can't reproduce it locally), but lets assume that a dependency on svl/source/fsstor/fsstorage.component is indeed missing, but manifests as a failure only in some cases (for whatever reason). Change-Id: I91214490ac6aab99a281c745ba4b2d138b12ddd1
2017-12-15lok: calc: LOK_FEATURE_RANGE_HEADERSMarco Cecchetti5-8/+35
For allowing the client to enable/disable the new range based header data Change-Id: I95da8ec3e48137fb75b9b22af3bb1296001ba9ca Reviewed-on: https://gerrit.libreoffice.org/46095 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 069cf9321be51e7203e336e0e87d8ba7dc9b729e) Reviewed-on: https://gerrit.libreoffice.org/46570 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-15tdf#100635 sw: fix layout crash caused by field expansion ...Michael Stahl1-1/+4
... triggering recursive layout-in-layout where a SwTextFrame that's being formatted is deleted inside some other frame's SwTextNode::GetFormatted(). The offending field is a SwAuthorityField that's located in a fly-frame with FLY_AT_PAGE anchor. SwPageFrame::GetContentPosition() is only called by field expansion code, so this shouldn't have an effect on layout. It already has a fall-back for the case when the frame has invalid flags, so handle the situation when the SwLineLayout has been deleted from the SwCache due to overflow the same way, which prevents the recursive formatting. Change-Id: I90437edb5692dc2bdec7ad03964588942bde05be
2017-12-15sw: prefix SwTextFrame::pTextCache memberMichael Stahl3-9/+9
Change-Id: Ibfbc59c9df89a3cde6226bd49cf33c2ac865d4a8
2017-12-15sw: clarify what the hell SwTextFrame::GetFormatted() actually doesMichael Stahl2-8/+13
Change-Id: I3af0ef5f10c6c2172499b481f3fab1400dca3c6f
2017-12-15tdf#100635 sw: fix crash in SwTOXMgr::UpdateOrInsertTOX()Michael Stahl1-2/+10
GetAuthBrackets() returns an empty string if the user selects [None], in that case apparently 0 bytes are used, multiple places check for that. Change-Id: I8375621fa553bc780db343ed8a0bd7ecb3c832dc
2017-12-15Resolves: tdf#113537 don't keep nEndRow=MAXROW if data ends aboveEike Rathke1-1/+6
Change-Id: I186034cada9718c067fa4dc7f72e2ca55ac06f83
2017-12-15-Werror,-Wsign-compare (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I4ef3bbcbf93eb2ba6a622b69fefed06321d82cf9 Reviewed-on: https://gerrit.libreoffice.org/46517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15-Werror,-Wsign-compare (clang-cl)Stephan Bergmann2-2/+2
Change-Id: Ia9cd493df71c520259c96a71f11237ee97937b32 Reviewed-on: https://gerrit.libreoffice.org/46515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15loplugin:salcall (clang-cl)Stephan Bergmann50-130/+130
Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15tdf#114484 - Make internal file and print dialogs obsoleteheiko tietze1-2/+1
Checkbox hidden in options dialog Change-Id: I918b328dec1a4fbb4ebbcc538ffa902160ee0b9b Reviewed-on: https://gerrit.libreoffice.org/46546 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-15lokdialog: Give non-programmatic name to autofilterPranav Kant3-0/+6
Change-Id: I8670a5aaa1703677cab173b2341c6e70e689f61a (cherry-picked from 04abf03ecb18ccf1f805faa763d6f29013efc6bb)
2017-12-15ofz#4647 Integer-overflowCaolán McNamara1-1/+1
Change-Id: Ic5593df7ad39e591ce15895205a02f2007da4147 Reviewed-on: https://gerrit.libreoffice.org/46503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15Try even harder to get at template args in loplugin:implicitboolconversionStephan Bergmann1-13/+26
After f82dc45bdb9e930878447015291c5b90c9325b57 "Use the canonical TemplateDecl", builds on macOS (at least those using C++17 and recent trunk libc++) started to emit false warnings for that std::pair< Reference<XConnection>,sal_Bool> aRet; aRet.second = false; code in dbaccess/source/ui/dlg/DbAdminImpl.cxx. There's a declaration of std::pair in type_traits and a definition in utility, and for some reason the declaration in type_traits was deemed the canonical one, while the SubstTemplateTypeParmType pointed at the definition in utility. So just check both, the original and the canonical TemplateDecl. Change-Id: I2fb9d5172c031e6ad4989b215f19d11a4b17f743 Reviewed-on: https://gerrit.libreoffice.org/46474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15lokdialog: If we already have the title, emit it during creationPranav Kant5-15/+27
Some dialogs load the UI before we "Execute()" the dialog, or before the dialog fires the InitShow event. In those cases, the title event has already been fired and won't be fired after dialog is created. Make sure that we send the title for such dialogs. Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4 (cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d)
2017-12-15lokdialog: gtv: Set dialog title on callbackPranav Kant1-0/+5
Change-Id: I6d96a9e2287afdcaad2f770e4b4c73d3671fc76b (cherry picked from commit f0a6fd58575ff6b9ebbfb0835aa8694923ddbffd)
2017-12-15tdf#114216 Uncheck Thousands separator on Number category selectionJim Raykowski1-0/+1
Change-Id: Iaf616379fad1333d63bc397a9fba2220d7bbfc9b Reviewed-on: https://gerrit.libreoffice.org/46072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-15loplugin:unusedindex fix false+ in nested loopsNoel Grandin2-11/+28
Change-Id: I31acbf104e49a4d1f077817a68d0b116fd2e0a30
2017-12-15improve the find-unused-typedefs scriptNoel Grandin3-28/+21
Change-Id: If4ab3bf8759c194e6005091d6df6a3a11cd633b7
2017-12-15CONTAINER_ENTRY_NOTFOUND not needed anymoreNoel Grandin4-5/+4
after we make dbaccess consistently use COLUMN_POSITION_NOT_FOUND Change-Id: Ia22c17196e8d651201c04239505d28e54369a8a4 Reviewed-on: https://gerrit.libreoffice.org/46501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15use ColumnPositions name more consistentlyNoel Grandin7-42/+41
mostly so I can track down more accurately what values are being stored in this vector<pair<>> Change-Id: I3755a098a577facef1c1af62c5583f0e2f7ca90b Reviewed-on: https://gerrit.libreoffice.org/46500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal: add pre-initialization scheme for allocations.Michael Meeks13-9/+255
This saves several megabytes of dirtied pages for each LOK client of Online. Change-Id: I425a2e7896879f0a64d71fcc0655e9e1fa1256aa
2017-12-15sal_Bool -> boolStephan Bergmann14-16/+16
Change-Id: If2e527d915d07b3b44d2a36e10704665ab8c7320 Reviewed-on: https://gerrit.libreoffice.org/46502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15Protect all LogicalFontInstance constructorsJan-Marek Glogowski15-86/+58
This way LogicalFontInstance can just be constructed by a PhysicalFontFace based factory. The patch also drops the wrong "Java logical font" comment added by commit 125cdf3404e60cf78f2a5547e9a06ce994df5c8e. Change-Id: Ibd5d7da0c3a65dbfa2c8ae6b05cf616d39b749f2 Reviewed-on: https://gerrit.libreoffice.org/46475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-12-15tdf#114479 : Blacklist MATCH() for threadingDennis Francis1-1/+2
due to reasons similar to VLOOKUP/HLOOKUP Change-Id: I4eeefd37d87d19ed4c27c58cd661206ce916823a Reviewed-on: https://gerrit.libreoffice.org/46499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-12-15loplugin:salcall (macOS)Stephan Bergmann2-2/+2
Change-Id: Ie3454079f405df91280658e62f72b5108dfb7714 Reviewed-on: https://gerrit.libreoffice.org/46473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15merge ImplPolygon and ImplPolygonDataCaolán McNamara2-24/+10
Change-Id: Ia59a4533965bb3b76c73cc23c31bff4718768339 Reviewed-on: https://gerrit.libreoffice.org/46454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15MSI cleanup: remove redundant conditionsMike Kaganski8-19/+12
VersionNT is now always greated than 600 (only needs checking in version checking action). ISSETUPDRIVEN and ISSCHEDULEREBOOT are specific to InstallShield and aren't relevant to LibreOffice installer. Change-Id: I6cb769c863e09f1568ae895a6cfbb0e5940c2486 Reviewed-on: https://gerrit.libreoffice.org/46434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-15clang-format: restore lost warning on touching formatted file without checkMiklos Vajna3-13/+15
Consistently only assign something to $clang_format if it's a good version, and also consistently return undef if we found no good version. Change-Id: Iadbbb56a5c15dfaeec5c80e3cc8fcc78b787c04b Reviewed-on: https://gerrit.libreoffice.org/46489 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-15tdf#51188: notify that geometry has changed when dragging the connector.Mark Hung1-0/+2
Change-Id: I7b7cb7719c9c735eeb4f964b1ae6ce6819186aed Reviewed-on: https://gerrit.libreoffice.org/46319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-15Report more debug information about caught exceptionStephan Bergmann2-6/+41
...in an attempt to track down why various tinderbox builds started to fail CppunitTest_sw_filters_test with an "Uncaught exception during Task::Invoke()!" abort. On IRC, jmux claims that catching exceptions and turning them into abort() here (instead of letting them propagate) is necessary: "The main problem was the wrong state in the scheduler. So something actually handled the exception, but the next caller into the scheduler had an invalid linked list of tasks, breaking things left and right." Change-Id: Ic3365e282404483518652c00160c2036b79991cf Reviewed-on: https://gerrit.libreoffice.org/46450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15loplugin:salcall (macOS)Stephan Bergmann23-44/+44
Change-Id: I297ac09358ce948acae9b73e8ed605964520c73b Reviewed-on: https://gerrit.libreoffice.org/46437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15once off loplugin: unusedindexNoel Grandin3-0/+110
Change-Id: Ifdf5da1f014c4f130eafed475c6781c029d54f1d
2017-12-15sal_uIntPtr/sal_uLong->void* in Popover idsNoel Grandin15-42/+42
Change-Id: Ifd7eeadeacffb90ea303c1e6bca807d310098f66 Reviewed-on: https://gerrit.libreoffice.org/46484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr->sal_uInt32 in X11SalGraphicsImplNoel Grandin2-2/+2
which matches the call sites Change-Id: I4db0c87f29c3368f32d600a10b5f43cb5ea6027c Reviewed-on: https://gerrit.libreoffice.org/46483 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr->SwLinePortion* in SwTextPortionMapNoel Grandin1-5/+5
which is the common base class of the two types we are using in that map, SwLinePortion and SwTextPortion Change-Id: Iff5b34124fc0655757f625f1daac8eb5b47bfe6d Reviewed-on: https://gerrit.libreoffice.org/46482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-03 17:47:21 +0000