Age | Commit message (Collapse) | Author | Files | Lines |
|
If the comment was the last item on the line,
clicking the mouse button
in the whitespace on the right did
not place the cursor on the right side,
but on the left side.
For comments in the middle of a line,
this change will mean that it will move
behind the comment 1 unit earlier
(1 TWIP I assume), but I would hope
that wouldn't matter.
This only works for the first comment for now.
A followup commit will do this for multiple
simultaneous comments, along with another
edge case consisting a very thin portion.
Change-Id: I49b15252441bc9e661644778dd417ef91f2447db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105746
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
These are unused since the pdfium-based signature verification.
Change-Id: Ie15369cbd0548febd03be3ac3475036e1f46cd16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106027
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ie1adad9228c4eadbe0d314c0dc27057e84cd721a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106037
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update dictionaries from branch 'master'
to 9e60a41935436ba15f3bcdf1c830ccc46f07b898
- Updated the English dictionaries: GB
Change-Id: Ic9ae52d71485dbc9118fd45982b2eaed3f3ae51f
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/105047
Tested-by: Aron Budea <aron.budea@collabora.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
|
|
Change-Id: Ic1365da6453c8cf02c518b576997784c928d7f2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106023
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since (doh!) having it as a function does not correctly log the
actual caller source line information.
Change-Id: Iae1007414259dea372f761765e090e1ed2ddbea9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105972
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia624f6be5f0d9bb8613475104e901457cc814eb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105307
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
No idea whether it works.
Change-Id: I008cf9fab56bedb2e1f33ad6a99c9cd95d7483a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106024
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I86b9bf57cbb5ee7e2b0d189d6ff78a3fbc9145fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106021
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Sending SwInsText will mess up merged paragraphs. Instead, send
SwUpdateAttr with which-id 0, which results in InvalidateRange_() being
called with at least 1 character.
This appears to be called only by fieldmark UI, and now asserts in
UITest_writer_tests5 DateFormFieldPropertiesDialog.dateFormFieldDialog.test_date_field_with_custom_format
Change-Id: I948ddefa3acece8809e4bf3d2beee6cec3ed56f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106022
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
DocumentContentOperationsManager::CopyWithFlyInFly() needs to copy
bookmarks before creating new layout frames.
Change-Id: Ib085cd230008149a55f1527b0bbd7bb7323340a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105986
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Jump over the hidden part when moving in from either side.
Change-Id: Iff6680249dfe66d6d5b1a39c4543b51a5238b075
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105985
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
HideIterator finds the next delete redline or fieldmark, whichever is
closer.
Change-Id: I4c6eac864da4b4bf531437e555a3994fd2670367
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105984
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
... in wsfrm.cxx
Change-Id: Iaa552f2527d47f475165a3f9da073052fc76ac51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105983
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
... where obvious.
Change-Id: Id941d59feea5a3539da9006725ef376b14bc7d1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105982
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
... in SwRedlineItr::CheckLine() and also SwRedlineItr::Seek()
Change-Id: I711ec37bd345cbf5f5f5339b8d792bcb56c425c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105980
Tested-by: Michael Stahl <michael.stahl@cib.de>
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Change-Id: I366fe171fbcadad7643c54d76c3e28cc4b6b5dfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105981
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Tracked the problem to bulk_insert_for_each, in an optimization case
that use a fixed width instead of calculating the rows width.
In that case vertical scrollbar is not supported.
Replace the call of set_column_fixed_widths to instead set just
the widths of the headerbar items if the treeview has them.
The optimization (use the fixed width instead of calculating row width),
happens since of setting pViewDataItem->mnWidth.
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I2ceb89eed84baf347204841a01fad34974f5f5f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105583
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
asserts since...
commit bf4bbc3c2174b21577b8878bc3197923ba44a029
Date: Thu Nov 12 15:38:13 2020 +0200
replace std::max(std::min()) with std::clamp
but looks wrong since...
commit ff916ccce1527b63aad17bbae0ad02a834cd31d6
Date: Tue Sep 30 13:51:36 2008 +0000
CWS-TOOLING: integrate CWS dr63
- mnScrollMax = limit_cast< sal_Int16 >( nApiValue, mnScrollMin, EXC_OBJ_SBS_MAXSCROLL );
+ mnScrollMax = limit_cast< sal_uInt16 >( nApiValue, mnScrollMin, EXC_OBJ_SCROLLBAR_MIN );
Change-Id: I002c764ed7129b1a66a7c827422b9d64034c6e53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106012
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
unused since 08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1 "related: tdf#103884
remove gltf/collada feature"
Change-Id: Ieed4a2dcd2f465de2356e640383bac2cd45b83d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106017
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It got technically unused when e79e8117dcc7475d8d90afeaaac9eb7050ff244e
"loplugin:unusedfields in sfx2" removed SfxFrameDescriptor::aActualURL, which in
turn had apparently become unused over a series of commits cleaning up unused
code. The function looks like a misnomer now, and it is not clear to me whether
what it does is still useful (and whether or not all the clean-up that brought
us here was actually good), but lets leave the remains as they are for now.
Change-Id: I0479068176cc72193b2b44fc49d8fd3d71eadcb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106013
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I074afd4397b6fc4631bd00655de56b8a154d7dff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105955
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
So this is a regression-inviting guess at a wrong impl.
And I am not a calc guy, so I shouldn't be making this
kind of a change.
The problem was that editingActive couldn't select
cells from other sheets for some cells near the
frozen border. The reason was that multiple splits
are considered active at the same time, and so the
editActive can be monkeyed with. Everything is all
so interconnected that I get rather confused.
This fix does not solve a same problem with a
true window split, only with a window freeze.
The freeze problem is that the left column was
looking at the column (outside its view) and asked
whether it fit inside the start X (0)
+ visible cells +1.
So pretending typical freeze of row 0 and col 0,
which means left starts at 0 and has 1 visible col.
Left activates if col is 0, or 1, or 2.
Since the only possible column in left is 0,
it should only activate in that case.
So visible cells should be --, not ++.
Right? Of course, something probably depends on
the editing view being turned on for partially
visible cells on the right or bottom side,
or perhaps even for the first invisible col/row,
and so this will probably cause a regression.
An alternative would be to -- for the left side
and ++ for the right side (to increase confusion,
but decrease regression potential).
Change-Id: I946512bc7b3994f1750527a1a8c55954234b0d69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105429
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
VCL implementations may have an optimized implementation,
and with Skia decomposing to polygons also causes drawing problems.
Change-Id: Ib1e317c627f01a43b77b9a8ee2335f4e319c37e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106016
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ie708250f970f2ce08c8c89e4bf001a5df23b99bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106015
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Just don't rely on details of Point implementation.
Change-Id: I0cd0d6b7cacbf2751803a854d78e4b099ccf197f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105978
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ic0e3d6e055fc2ff30042424f461acbd33ecc70ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106010
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Also made it necessary to adapt two places in libcdr and libebook
that used UBool TRUE which is gone now to use standard true
instead.
Change-Id: I1c1df3030f8b883bec6045756907ee0b78060382
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105964
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
It was possible to anchor the textbox both to page and
paragraph, resulting crash during file saving.
Change-Id: I0c95a13c0d8d58cd7cc1fa86de1b80bf088ba782
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105046
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Ia119da3b54fd957f3316637ddaa047cfd6a399fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105994
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
no need for such a thing to be "nullable", just default it to zero,
as one would be expect for such a type.
Change-Id: Ic8b78ca3288355c90820135b9ced2c865ff7606e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105970
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3284a2460845c0b4816ad0148560e82da9d4eb78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105975
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Some of them have been added to the UI ( from Css3 ).
There was not a criteria for color picking so I chose those whose name told me something, those I liked and some to have a more complete palette.
It would be nice to be able to ask our users whose colors from https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#Color_Keywords they want in the UI.
The color names have been left in alphabetical order.
Starmathdatabse has clang format.
Change-Id: I6ac1bdbc9e3ed10bff75a99b90bf92d3dcdcabcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 6fe17a80f5866a7dc3a213ac9cb8c066aff17987
- finish updating help for "View" menu for Draw
- remove placeholder <comments>
- add embeds for "Toolbars", "Sidebar", "Styles",
"Gallery", and "Color Bar"
- add control and description for "Comments"
- add control (with link) for "User Interface"
- add control and description for "Shift" (thanks to
Ilmari Lauhakangas for insight about its operation)
Change-Id: Ic6c5056bf0615212e1d472f8f63a3838e9fb8e71
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105856
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: Ie1b0ec1a17c959de6e0a837bf5eb200fc0be1dfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105958
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Improve FillAnalyse, FillSeries to continue linear sequences
of mixed values in merged cells (mixed values are string + number,
like 'a1','a2' or '1a').
It discovers the linear sequence only if the string parts are
identical. It recognizes user lists only if all elements are in
the same user list.
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I8810a0f1d637436222e3d0b9219da38ccb7c6346
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105784
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I28ad4a717000fab894f3df7c41b8e8eeaff5fad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105177
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
for example selecting two cells with the same
text content "A1", and autofilling them must result
"A1", "A1"... instead of "A2", "A2", "A3", A3"...
Remove an obsolete fix in FillAnalyse(). As 0
increment is handled by both user list and mixed
sequence cases, there is no need to pre-check that
the elements are the same.
Now FillAnalyse will return with the proper FILL_LINEAR
(or user list) instead of FILL_SIMPLE that caused the
unnecessary +1 increment.
See commit d64bd977a430182826252695f041a6ddd62e45ef
(tdf#137653 tdf#137624 sc: fix autofill user list sequence)
and commit 5af699cf62b2313980add377a777c49dc1e7ae2a
(don't deduce increment from multiple equal list entries).
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I0750816375486b5b95fb2e0fcfdb9b1d6c8ce7d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105791
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
MSVC compiler complains about 'warning C4312: "reinterpret_cast":
conversion from "unsigned long" to "HANDLE" of greater size'.
Seems like an real error, if real_handle is too small to hold the
full "HANDLE" value, returned by _beginthreadex.
Upstream strangely just fixed in master, not B3_0_Release branch.
Change-Id: I87ad263529e119f68da976245646bf8b69efd35a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105924
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: Ia573921566ec6079b843cbcc0401d9d0f5c62089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I083b5c63a1c96e36d958e3071d9a7b2be14373bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105973
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Skia can't create empty surfaces, so the recreation will hit the
std::abort() in SkiaSalGraphicsImpl::createWindowSurface. Origin
of the backtrace is some queued Resize event, which will hit
this a few times via SkiaSalGraphicsImpl::checkSurface.
This feels a bit like tdf#130831, where VCL tried to track damange
for an empty Qt image...
Change-Id: I75e22c987ba633e7a403541db8d580df33c68964
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105963
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to f803f33413ed171305013ecdc65084eda8f58d11
- Resolves: tdf#135668 + relevant to: tdf#136435 Outline Content Visibility context help in Navigator
new file ( swriter/01/outlinecontent_visibility.xhp )
Provides comprehensive information about new feature
"Outline Content Visiblity" (tdf#38093) added in 7.1
Thanks to Jim Raykowski for technical advice and feedback
( swriter/01/02110000.xhp ) Navigator
+ add <link>s to new page for "Outline Content Visibility"
+ change recently added <keycode> to <widget>
+ repair icon path for "Headings" (Thanks to Rizal Muttaqin)
+ repair icon path for "Move up" and "Move down" (again, Rizal)
( shared/01/02110000.xhp ) Master Document Navigator
+ repair icon paths for "Move up" and "Move down"
+ change position of <tip> to after icon
* update to <h1>,<h2>,<h3>,<tip>
+ change all image height and width to 1cm
Change-Id: Ice5351d26db2daeebb52ba5f24b08dae9f6178dd
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105362
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
for CELLRANGE data label field type. Add CELLRANGE to enum
com::sun::star::chart2::DataPointCustomLabelFieldType, like
we do at CELLREF, while both of them are not implemented, see
commit 790f9abeb1a1167ad5ab84c5fb855b36669c125b
(tdf#114821 import complex data labels in bar chart).
Regression from commit: 0d2340998415fb4b2f794054c62ef61c83e32155
(tdf#136061 Chart ODF/OOXML: fix missing custom labels)
Change-Id: I8e0f4ca9db6e613a190cbda31504a7542fc13a86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105934
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Skia update chrome/m88 removed the possibility to call
SkFontLCDConfig::SetSubpixelOrder() to set subpixel setup for all
surfaces. So I guess now we have to explicitly pass SkSurfaceProps
to every single SkSurface we create.
Change-Id: I15be37ba9301c92d0cb109e88f3d1396a7223208
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105922
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I74c19597b07e9d07ee90e4191b75787241fdd845
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105829
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Show leader lines to data labels in custom position
only outside of pie chart, as intended.
Change-Id: I87dee2d33f4f876ffca208f69a069e1f0bcee688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105920
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I374b4f448715db9563f6073c433b82caf3482874
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105953
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I325add499fbd4d11a942ce550346dcbcb5343e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105928
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|