summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-06-19tdf#39593 Remove GetImplementation from ConstItemContainer and ItemContainerArkadiy Illarionov5-24/+8
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I87e1d3afd3a742926c7054179092d3b58b6b4563 Reviewed-on: https://gerrit.libreoffice.org/74310 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18Colibre, elementary, KJ: Fix for tdf#107144rizmut64-58/+60
elementary: - Fix blurred zoom icons - Reverse top arrow on Small Capitals icons Change-Id: I81883334e5cfaf3dab528ed61ea46894017a6c36 Reviewed-on: https://gerrit.libreoffice.org/74301 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-18Copy targets instead of moving during redactionMuhammet Kara3-26/+13
To allow properly remembering the last state. * And some clean-up. Change-Id: Id0b0f4251e3578b8baced1e6e6b1161f46e324dc Reviewed-on: https://gerrit.libreoffice.org/74302 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-18VCL cleanup WidgetDrawInterfaceJan-Marek Glogowski24-495/+193
I don't understand why WidgetDrawInterface, which is basically a copy of the SalGraphics native controls interface, duplicated it, instead of cleaning things up. The whole commit message of commit 8fcfa3853a81, which added this code, is just: "custom widgets: Custom Widget Themes". That's it. So this patch does, what the original one skipped: replacing the SalGraphics interface with the WidgetDrawInterface. One result is the addition of handleDamage to SalGraphics to correctly handle the damage done by a custom widget theme to the underlying SalGraphics implementation. Change-Id: I5fda1a64b28e6560fb3c62e02b6dcda827f698e2 Reviewed-on: https://gerrit.libreoffice.org/74118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-18tdf#125934 Qt5 set the desktop file name...Jan-Marek Glogowski1-2/+4
.. but only on wayland, as this also overrides the individual window icons on X11. Change-Id: I1b453b23f0dfd4ef2616d7b8054580a6018cdc53 Reviewed-on: https://gerrit.libreoffice.org/74293 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-18Let autoredact dialog remember last stateMuhammet Kara1-6/+67
* By storing the JSON string as SvtViewOptions Change-Id: I08e323005612cb0181d2176af659eb54267fbb3f Reviewed-on: https://gerrit.libreoffice.org/74169 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-18Qt5 initialize bool before lcl_textMimeInfo callJan-Marek Glogowski1-2/+2
Change-Id: Ie1b2e77145c4f84dc7d2c1edd214363b7fa0625e Reviewed-on: https://gerrit.libreoffice.org/74294 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-18loplugin:passstuffbyrefNoel Grandin44-71/+81
Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb Reviewed-on: https://gerrit.libreoffice.org/74246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in xmlhelp..xmlsecurityNoel Grandin17-74/+87
Change-Id: Idbf0de3f953b08f98144241346533ad30f49269e Reviewed-on: https://gerrit.libreoffice.org/74285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in writerfilterNoel Grandin12-68/+69
Change-Id: Ie01d0e6af6af0cfeb46cdde38f52ab068b64db6b Reviewed-on: https://gerrit.libreoffice.org/74284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18sw: implement inserting comments when an as-char image is selectedMiklos Vajna6-0/+74
Only the UI was missing in this case: creating a text selection around the placeholder character does what the user expects. Change-Id: I1068fcee3e3b6d0a6fa47b37beb1bd1b918a82df Reviewed-on: https://gerrit.libreoffice.org/74297 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-18Remove redundant writeStephan Bergmann1-1/+0
...that had been there ever since the code's introduction with b5a9cc71d246c26da8aca4203da84c10c104c222 "Exif reading/writing and Jpeg lossless transformations support." Change-Id: I490eb85abb9966c6152bfc00e81589d6aef374cf Reviewed-on: https://gerrit.libreoffice.org/74295 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-06-18fix crash in header/footer calc dialogCaolán McNamara2-6/+17
cut and paste can happen when the EditView isn't in a vcl::Window Change-Id: I9fdbfe28c5ca5dd680b821ff8ce4e0133ab203aa Reviewed-on: https://gerrit.libreoffice.org/74279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-18tdf#111707 Add 'Remove Hyperlink' to context menu in ImpressSamuel Mehrbrodt8-13/+63
"Clear formatting" no longer removes the hyperlink, as now there is a dedicated context menu entry for this. Change-Id: Ic47795b9ecb238470f853da527c648f6edb94c09 Reviewed-on: https://gerrit.libreoffice.org/74272 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-18SmartArt: support ForEach referencesGrzegorz Araminowicz7-1/+90
ForEach 'ref' parameter causes specified ForEach node to be used instead. Used to create recursive structures like organisation charts. Change-Id: Iee61b2e103759355b59beb8d3f33eb3cce47c590 Reviewed-on: https://gerrit.libreoffice.org/74271 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-06-18sd: remove pre-gbuild map fileMiklos Vajna1-7/+0
As far as I see this map file is not used to control linker-level visibility in sd since the gbuild migration. Change-Id: Iaf8bbd7a87a994aef1758fc85d3e33b590ae04b7 Reviewed-on: https://gerrit.libreoffice.org/74270 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-18NB tabbed compact big update and syncronisation between appsandreas kainz5-2706/+7773
Change-Id: Ie1178e1e36334b35c7a00b2ec918c79041150c80 Reviewed-on: https://gerrit.libreoffice.org/74268 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-18Better type safetyStephan Bergmann1-4/+4
...following up on 42c0e433aca68c669bc0f55af404b6bae1655fba "Avoid -fsanitize=misaligned-pointer-use" Change-Id: I1ff787c7da829e838843c895d32dea3aa26e2cf4 Reviewed-on: https://gerrit.libreoffice.org/74263 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#39593 Remove toolkit::GridColumn::getImplementationArkadiy Illarionov3-13/+4
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I6b32cf388f32e7aa8f073daea0423fcbf169386d Reviewed-on: https://gerrit.libreoffice.org/74235 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#39593 Remove ScModelObj::getImplementationArkadiy Illarionov26-54/+55
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I06a8db37b5c5c38c52a15a76e6e2df3b431a2040 Reviewed-on: https://gerrit.libreoffice.org/74237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#39593 Remove Graphic::getImplementationArkadiy Illarionov3-10/+2
Replace with comphelper::getUnoTunnelImplementation. Change-Id: Ic0e2e78fea575af6da4870fbd372f2148a328e26 Reviewed-on: https://gerrit.libreoffice.org/74203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18sw: extract postit insert code from SwTextShell::ExecField()Miklos Vajna3-64/+80
Into a new SwWrtShell::InsertPostIt(), so I can reuse it in SwFrameShell. Change-Id: Ib327aed033067250f021f3857f4ba3adb8e6c597 Reviewed-on: https://gerrit.libreoffice.org/74264 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-18tdf#111824 Chart OOXML Export: fix Z axis labelsBalazs Varga3-0/+16
Export 3D barchart Z ("deep") axis properties into <serAx> xml tag, as the OOXML Standard requires. Change-Id: I8ee2282a28e9b4bdea6e96c96256f832b1a1aada Reviewed-on: https://gerrit.libreoffice.org/74170 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-06-18tdf#39593 Remove DOM::CNode::GetImplementationArkadiy Illarionov4-22/+17
Replace with comphelper::getUnoTunnelImplementation. Change-Id: If98801fd85bf0967c54e1924a04b6de371868942 Reviewed-on: https://gerrit.libreoffice.org/74234 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-18android: Fix non-debug build.Jan Holesovsky1-1/+1
Change-Id: If8bb944417da9a0aa6343d7dc87e7a1931689f1f Reviewed-on: https://gerrit.libreoffice.org/74149 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-18Fix typosAndrea Gelmini2-2/+2
Change-Id: I7afd722b18759366bda139c8b881c03c35623e24 Reviewed-on: https://gerrit.libreoffice.org/74256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-18loplugin:logexceptionnicely in swNoel Grandin14-52/+64
Change-Id: I92c84f5c869e5ccab344f7e3591d68a90a20eefa Reviewed-on: https://gerrit.libreoffice.org/74243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18User directory path changedSumit Chauhan2-16/+13
The old path was not rendering file from user directory in production build Change-Id: I58e84156f8c93933d59b1ab9d50e3b24becdf3cd Reviewed-on: https://gerrit.libreoffice.org/74181 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-06-18ofz#15335 avoid config during fuzzingCaolán McNamara1-1/+2
Change-Id: I7a0270fb36b4390ae2e8f365ace8e724938224c3 Reviewed-on: https://gerrit.libreoffice.org/74249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-18Avoid -fsanitize=misaligned-pointer-useStephan Bergmann2-24/+59
...like > vcl/source/filter/jpeg/Exif.cxx:158:31: runtime error: member access within misaligned address 0x624000a5610a for type 'Exif::ExifIFD', which requires 4 byte alignment > 0x624000a5610a: note: pointer points here > 00 00 00 07 01 12 00 03 00 00 00 01 00 01 00 00 01 1a 00 05 00 00 00 01 00 00 00 62 01 1b 00 05 > ^ > #0 in Exif::processIFD(unsigned char*, unsigned short, unsigned short, unsigned short, bool, bool) at vcl/source/filter/jpeg/Exif.cxx:158:31 > #1 in Exif::processExif(SvStream&, unsigned short, bool) at vcl/source/filter/jpeg/Exif.cxx:255:5 > #2 in Exif::processJpeg(SvStream&, bool) at vcl/source/filter/jpeg/Exif.cxx:132:20 [...] when inserting some .jpg into Draw. The swapping in Exif::processIFD had been introduced with 3ad12d1a540eeb54fbb34afc3b7a76bf9e3207c3 "fdo#57659: fix exif processing", and it had probably been an oversight that it used OSL_SWAPWORD instead of OSL_SWAPDWORD to swap sal_uInt32 ifd->offset (in two places), and that it failed to swap ifd->type and ifd->count in the bSetValue branch (see the discussion at <https://gerrit.libreoffice.org/#/c/6245/> "fdo#57659: fix exif processing"). Change-Id: If40ddb9b1ef4e2ffc08a0899920919989e8cdfdc Reviewed-on: https://gerrit.libreoffice.org/74236 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18loplugin:logexceptionnicely in vclNoel Grandin17-40/+57
Change-Id: I0ed575a11c84c2e8aabfa1b4204ba6ae27393d5f Reviewed-on: https://gerrit.libreoffice.org/74245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in toolkit..unoxmlNoel Grandin14-175/+159
Change-Id: I0a3126545f9ef98640f6dd166290e9b9e91b8355 Reviewed-on: https://gerrit.libreoffice.org/74244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18schema: update ODF 1.3 main rng draft to wd12Michael Stahl1-57/+75
Change-Id: Ib78cf2c3e9484c3e5691a3c7d47cf9df7558525f Reviewed-on: https://gerrit.libreoffice.org/74182 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-18tdf#125947 Two tools are missing from default Form Controls toolbarRoman Kuznetsov9-18/+18
Change-Id: Ie54b2a3f5051b115f8f04467282090a93525dfc3 Reviewed-on: https://gerrit.libreoffice.org/74191 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-06-18Simplify Sequence iterations in vclArkadiy Illarionov31-362/+270
Use range-based loops or replace with comphelper or STL functions Change-Id: If046738084c2d13cc1eaea6a03aaf60b63f62767 Reviewed-on: https://gerrit.libreoffice.org/74104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in starmath..svgioNoel Grandin8-22/+28
Change-Id: I356e574e28338f6fddc6932b4e41a461d851406d Reviewed-on: https://gerrit.libreoffice.org/74141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18tdf#42949 Fix IWYU warnings in include/svx/[t-v]*Gabor Kelemen37-43/+91
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I345b8c54890b5bc27f51addd2e6e73ba68b6b327 Reviewed-on: https://gerrit.libreoffice.org/73977 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-18loplugin:logexceptionnicely in svxNoel Grandin8-26/+24
Change-Id: I741cf5befbec0c2ab353baae4865722ede993c2e Reviewed-on: https://gerrit.libreoffice.org/74143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in svtoolsNoel Grandin8-26/+33
Change-Id: I631f3750af2e9a26d0a034f5a22d5b0c2910325c Reviewed-on: https://gerrit.libreoffice.org/74142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18tdf#45904 Move XGluePointsSupplier Java test to C++Jens Carl5-1/+71
Move XGluePointsSupplier Java test to C++ for ScShapeObj. Change-Id: I75babf46b664cccbb4d1df2af1764c3fa296903a Reviewed-on: https://gerrit.libreoffice.org/74140 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-18Avoid needless copy of itemMike Kaganski1-2/+3
Change-Id: Ifdf4f3559065dca5eeff61fffa9de223778691f4 Reviewed-on: https://gerrit.libreoffice.org/74238 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-17Fix comments about endian-nessStephan Bergmann1-2/+2
...which had been added with 256825346ef710d8ef111d7d75535af8a3c5426e "swap if the host endianness doesn't match the file formats", but apparently the wrong way around. Intel is little-endian while Motorola is big-endian, which also matches the later code that sets bSwap to true for bIntel (i.e., little-endian) in case of OSL_BIGENDIAN and for bMotorola (i.e. big-endian) in case of !OSL_BIGENDIAN. Change-Id: I0def56b95228310694d623d4a1a58eab84ce27c8 Reviewed-on: https://gerrit.libreoffice.org/74184 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17tdf#124549 Check Button toggle state before toggle.Shubham Goyal1-0/+4
Change-Id: I362cbc5613010e6586d63d6ebe45b40f05ffcbf1 Reviewed-on: https://gerrit.libreoffice.org/74117 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-17tdf#125968 fix the result order of text mime infoJan-Marek Glogowski1-2/+2
lcl_textMimeInfo returns three booleans when decoding the text mime string in the order: NoCharset / locale encoded, UTF16, and UTF8. Change-Id: I3cc4090e9874125ed68ec953d7d72889dead269b Reviewed-on: https://gerrit.libreoffice.org/74183 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2019-06-17Colibre: Fix for tdf#107144 & clean SVG filesrizmut102-341/+85
Change-Id: I6747f6e4331720828eff7ece184f4a8203684571 Reviewed-on: https://gerrit.libreoffice.org/74178 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-17KJ & elementary: Fix for tdf#89884, tdf#124127rizmut444-3388/+825
- Add/update support for locale language - Update for RTL language elementary: - Change ruler related icons's color - Update caption to be real caption - Update shadow below form icons - Add 3D extrusion, direction & surface icons - Update doc properties to use wrench just like upstream etc Change-Id: I7bea93526c98835da74e5818d9a55785a8462d60 Reviewed-on: https://gerrit.libreoffice.org/74180 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-17simplify codeStephan Bergmann1-1/+1
...following up on b70ab9e9e5630a965c5e6cc40c2480dddf1e2384 "Fix swapping of vector elements" Change-Id: Ib67b43345fa808bc25dff5aff11b387bb3455464 Reviewed-on: https://gerrit.libreoffice.org/74173 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17tdf#101978 vcl combobox/listbox floating window: avoid flickerMiklos Vajna4-2/+19
Regression from commit dca01def7885ad69cf66edd75cf8207a5adb64f9 (refactor ListBox/ComboBox to use RenderContext, 2015-05-07), the problem was that with VCL backends which don't paint on idle, the widget flickered on keyboard / mouse interaction, similar to the Calc autofilter. To avoid side-effects: - Avoid direct paint in ScrollBar::ImplDragThumb(), instead do Invalidate() + Update(), which is the same, but this way dragging the scrollbar with the mouse doesn't fails an assertion (because we tried to paint directly on a double-buffered window). - Only call RequestDoubleBuffering() for backends which don't handle focus themselves (i.e. not for gtk3); to be in sync with the Calc autofilter behavior. Change-Id: Iec9ad2fe9d32efb8da65cc26cf89cc47912bf545 Reviewed-on: https://gerrit.libreoffice.org/74176 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17tdf#51195, tdf#100348 Convert Fontwork to TextWarp on exportRegina Henschel4-18/+139
LibreOffice has Fontwork as property text-path in enhanced-custom- geometry. OOXML has the similar TextWarp as property of a textbox. The patch converts the custom shape to a textbox and sets the attribute prstTxWarp. Fill and outline of the Fontwork is lost. The import and export of fill and outline is tracked in tdf#119221 and still needs to be fixed. Change-Id: I8ea7b305d7d0a8367d61c1789f22b56d274a311d Reviewed-on: https://gerrit.libreoffice.org/74057 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-06-17long winded falseCaolán McNamara1-2/+1
Change-Id: I79510d5156123f03b97dc4c2a0426347ef969d90 Reviewed-on: https://gerrit.libreoffice.org/74175 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-02 10:31:42 +0000