summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-03-05don't use the vcl::Window parent to derive a treeview sizeCaolán McNamara3-14/+5
Change-Id: Idee74fbdf45574fbb7997498062aaac0fb11eb74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05don't use the vcl::Window parent to derive a treeview sizeCaolán McNamara1-2/+2
Change-Id: Ib86c3eb25df390b5b4fba576abb3158728ff0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111994 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05use valueset as the menu parentCaolán McNamara1-2/+2
Change-Id: I99c4bc5110ce494287342db5c2d4c42b1a79ee38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111993 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05tdf#138122 Detect window scaling for multi display configurations on macOSThorsten Wagner1-0/+7
Supplemental change to commit 0c36f364b14aacd0eeb53087ae2fce54402dc741 to disable additional unit tests unless bitmap scaling has been implemented Change-Id: Ic4861dabcb221976fe415b1d7110099ec66bb4ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111977 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-05use valueset as the menu parentCaolán McNamara1-1/+1
Change-Id: I3e8a841f838c4874e40d7d9e6abfbd61e2bb068d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05jsdialog: update on treeview item removeSzymon Kłos2-0/+16
Change-Id: I36b07284b18d3eda184fd6c3f186763d1265d2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110665 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111988 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-05emplace_back: use perfect forwarding if possibleThorsten Behrens11-62/+60
When using that new-ish method, try giving the compiler a chance to construct in-place. Left out harder cases using initializer lists, and might have missed slightly less obvious places. Change-Id: Ifcc3a6d4599474457e37dd17a35c41fc73e7a17e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111980 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-03-05tdf#115879: sc_logical_functions: Add function testXisco Fauli1-5/+55
Change-Id: Ia6b230564911f05b1d19669f4137fc3892619a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111983 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-05loplugin:refcounting (--enable-evolution2)Stephan Bergmann8-35/+28
Change-Id: I83f16646e5bd7c3814d9d3dd3fa6408c40f96bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111968 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-05ScriptForge - (scriptforge.py) Python-Basic machineryJean-Pierre Ledure10-19/+1498
Python scripts can now invoke usual Basic builtin functions Example: from ScriptForge import CreateScriptService bas = CreateScriptService('Basic') bas.MsgBox('This is the text to be displayed', bas.MB_ICONEXCLAMATION) Python scripts can use most ScriptForge services written in Basic Example: from scriptforge import CreateScriptService FSO = CreateScriptService('FileSystem') a = FSO.BuildPath('/tmp', 'xyz') Syntax and semantic are as close as possible to the Basic syntax Implemented are a SFServices class and its subclasses representing each a ScriptForge service and where the interfaces are defined (properties, methods and arguments) Their execution goes through the "machinery", i.e. a set of python and basic routines that manage the call from the python process to the appropriate service in an as much agnostic and generic way Only a limited set of services are implemented so far: SF_FileSystem (partially) and SF_Timer: they served as prototypes and initial tests Change-Id: I0b383b59359c12710e7165139e498cca5a7856bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111971 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-03-05CppunitTest_xmlsecurity_signing: run all tests in the disable-pdfium caseMiklos Vajna1-8/+6
Return early in case pdfium is not available, to avoid the ifdef forest. Change-Id: Ifdf71eb01437e4257679c9be7a25de9a3133a660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111978 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-05tdf#139734 Remove redundant asserts after functions loadFromDesktop and loadMoaz13-82/+0
MacrosTest::loadFromDesktop itself asserts on its return value. Thus, the additional checks in unit tests are redundant, and only create noise unrelated to the tested functionality. SwModelTestBase::load calls SwModelTestBase::loadURL which calls loadFromDesktop from within. Change-Id: I30061bbc6e13e05f0cfbf17a7910926070b996f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111547 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-05loplugin:refcounting return objects properlyNoel3-1/+42
check that when we return ref-counted objects, we do so using rtl::Reference, so that the object actually has a non-zero ref count. Change-Id: Ib3ffae0d2502f6d117550c82fde5449729c27324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111487 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-04-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...apparently ever since introduced in d2cd1fad73b97e62443a215c84b7b5d5ee74a818 "split and move MenuBar BubbleWindowManager to vcl" Change-Id: I479612969e9307daaa45b75d006d3929342b72aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04SidebarPanelBase is always created with a PanelLayoutCaolán McNamara75-94/+90
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04inherit NavigatorWrapper directly from SdNavigatorWinCaolán McNamara2-45/+9
Change-Id: Ifdb2aae5d9af32577adedd3512ab1f8a1e8047e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111975 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04drop newly unused PanelBaseCaolán McNamara4-157/+0
Change-Id: I5e84823fd25508c953dbe98c9d63e2333b4d6f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111974 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04remove intermediate TableDesignPanelCaolán McNamara8-166/+11
Change-Id: Icdc1aef7a0d53239ee41e818a56d137aa959249c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111973 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04remove intermediate CustomAnimationPanelCaolán McNamara14-193/+28
Change-Id: I34e1e3f87565cb9d8bf33f8e8f22844081785e21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111969 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04make both 'empty' widget and its treeview replacement the same sizeCaolán McNamara1-1/+5
so on flipping one visible vs the other the panel scrollbar position is equally valid for each mode Change-Id: Iae422c30eb8b752c407070b66852fe23fdc38912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111967 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04allow slide transition panel to be narrowerCaolán McNamara3-108/+119
Change-Id: Ib1fc71fe189b199fef6feb4f5f72f4513dfded97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111965 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04remove intermediate SlideTransitionPanelCaolán McNamara8-177/+15
Change-Id: Ifdecbd56b3da30081ed40e9940c7c2a6c7e1e48a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111962 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04use a single context menu handler at the valueset levelCaolán McNamara4-43/+27
instead of a custom right click handler in the valueset and a separate context menu handler in its parent Change-Id: Ia174892beb72ab79a3ceda1ad8992ce90a410db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111957 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04allow focus into master page panelCaolán McNamara1-5/+5
Change-Id: I34ab8ad6d267ffaab8ead2581e0d892ee37ec095 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111956 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04ofz#31672 Bad-castCaolán McNamara1-6/+6
==3484068== Invalid read of size 8 ==3484068== at 0x226E9EDC: SwClient::GetRegisteredIn() const (calbck.hxx:159) ==3484068== by 0x22A09E30: SwDoc::ChgPageDesc(unsigned long, SwPageDesc const&) (docdesc.cxx:465) ==3484068== by 0x238B1ECC: UpdatePageDescs(SwDoc&, unsigned long) (fltshell.cxx:1094) ==3484068== by 0x1CDD6E52: SwWW8ImplReader::CoreLoad(WW8Glossary const*) (ww8par.cxx:5482) ==3484068== by 0x1CDD90A1: SwWW8ImplReader::LoadThroughDecryption(WW8Glossary*) (ww8par.cxx:5939) ==3484068== by 0x1CDDAE71: SwWW8ImplReader::LoadDoc(WW8Glossary*) (ww8par.cxx:6243) ==3484068== Address 0x28c215c8 is 40 bytes inside a block of size 56 free'd ==3484068== at 0x483AEDD: operator delete(void*) (vg_replace_malloc.c:584) ==3484068== by 0x23009F47: SwFormatHeader::~SwFormatHeader() (atrfrm.cxx:503) ==3484068== by 0x9DDC3F3: SfxItemPool::Remove(SfxPoolItem const&) (itempool.cxx:741) ==3484068== by 0x9E17BD6: SfxItemSet::~SfxItemSet() (itemset.cxx:252) ==3484068== by 0x227FE847: SwAttrSet::~SwAttrSet() (swatrset.hxx:161) ==3484068== by 0x227FD139: SwFormat::SetFormatAttr(SfxPoolItem const&) (format.cxx:524) ==3484068== by 0x22A07AA6: SwDoc::CopyMasterHeader(SwPageDesc const&, SwFormatHeader const&, SwPageDesc&, bool, bool) (docdesc.cxx:248) ==3484068== by 0x22A09B4D: SwDoc::ChgPageDesc(unsigned long, SwPageDesc const&) (docdesc.cxx:457) ==3484068== by 0x238B1ECC: UpdatePageDescs(SwDoc&, unsigned long) (fltshell.cxx:1094) ==3484068== by 0x1CDD6E52: SwWW8ImplReader::CoreLoad(WW8Glossary const*) (ww8par.cxx:5482) ==3484068== by 0x1CDD90A1: SwWW8ImplReader::LoadThroughDecryption(WW8Glossary*) (ww8par.cxx:5939) ==3484068== by 0x1CDDAE71: SwWW8ImplReader::LoadDoc(WW8Glossary*) (ww8par.cxx:6243) since... commit f5dc6b11d2218d94c9effe7a1ab418d0133da5e3 Date: Tue Jan 26 13:11:42 2021 +0100 tdf#140117 sw UI: keep headers/footers when inactive Change-Id: I14787d4203c457393e8b5d0222df67d394a4c9ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111970 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04actually restore the original HFONTLuboš Luňák1-1/+4
A mistake I made when fixing tdf#137122. Change-Id: Ie3a258de69e17d8cedb3bf722841af1054bd0fe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111972 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-04Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 9121a0732c01e71a1f5dea5a6d32ee03a3157703 - tdf#133846 restrict Java bitness Help to Windows Change-Id: I69813601b657127f0fd6ad3ebd8e668e660815e0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111924 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-04Also check number of invocations in the testMike Kaganski1-8/+10
Change-Id: I4180f14aa633bf0f3f45178c1fd02b52b784f7e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111960 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-04tdf#139940 oox: mark end before growing largest segment backwardsJustin Luth2-1/+13
This fixes a regression in 7.1 (backported to 7.0.1) caused by commit 73993fdb5d4b507694cd0edf80887d19f7e2bf9a for tdf#134183. The largest segment has already been found, so we know where the next segment starts. Now if we grow it backwards, that shouldn't affect where it ends. So flag the end before growing the start, otherwise we would have to recalculate the end again. Change-Id: Iaae401d0438e533c7498be56f48fa153f7d3ff0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110004 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-03-04Update git submodulesSeth Chaiklin1-0/+0
* Update helpcontent2 from branch 'master' to ac3932ba6679a519bdee68fc3b750a0faa85f6f2 - tdf#139667 update chapter numbering help ( shared/01/06050600.xhp ) "Position" tab * add variable to <h1> heading ( swriter/01/06060000.xhp ) "Chapter Numbering" * corrections for "Load/Save", "Untitled 1-9" and "Save As" * add variable and link to <h1> ( swriter/01/06060100.xhp ) "Numbering" tab * "numbering style" -> "numbering scheme" * "format" -> "character style" * move 1,2,3 to top of numbering schemes to correspond to combobox in dialog. * add <relatedtopics> and embed links to "Position" and "Chapter Numbering" * update to <h1>,<h2>,<h3> ( swriter/guide/chapter_numbering.xhp ) * "Automatic Headings" section "numbering style" -> "numbering scheme" and update to <menuitem> and corrections in dialog box labels * "Remove Automatic Numbering" section + add keycode + add <note> about Shift+Backspace * update to <h1>,<h2>,<relatedtopics> Change-Id: I25e8f7d79b53db9ae8c53d04891a5e2b0f0465bb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111428 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-04jsdialog: single activation property for treeviewSzymon Kłos2-0/+3
Change-Id: Iaaeab7f14f1a05c38f41c4beb774a0980844fdb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110621 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111959 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-04jsdialog: handle standard buttons like helpSzymon Kłos4-0/+55
- dump response bindings - execute help callback Change-Id: Ib0696b4ba74a186a2b80d49f21a1442d1c520821 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110586 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111958 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-04autofilter: scale dropdown button according to zoom levelSzymon Kłos2-5/+16
Change-Id: I4f8a16e196bc33ea5b29fda0edc1f773a24e28db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111896 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-04Workaround a problem in Git for Windows' bashMike Kaganski1-0/+12
... where running './g pull -r' resulted in ln: failed to create symbolic link '.git/modules/dictionaries/hooks/*': No such file or directory ln: failed to create symbolic link '.git/modules/translations/hooks/*': No such file or directory Change-Id: Ie0bd2eaca44f8b1a2ad2de9083bbefc779e213e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111948 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-04macOS: use HITheme to draw listbox window borderNoel Grandin3-9/+26
Change-Id: I39fd6f643649bc405447d10e7072ae6dabd679b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-04master slide panel shouldn't have "more options" buttonCaolán McNamara4-5/+5
default the toolbox to hidden and show it if "more options" is enabled Change-Id: I6ff867268809d949e7854e0e76d3e45c8806797b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04The backtrace() etc API is available on macOS and iOS, tooTor Lillqvist1-68/+1
Change-Id: I9a62391c4d109cd2fd2ab60d92a9e3b631ee6773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111951 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-03-04sw: fix unwanted long vertical border around vertically merged Word cellMiklos Vajna5-0/+228
In case cells A1 and A2 are vertically merged, they can still specify different border properties for the two cells. Word draws the border properties of the covered cells, while Writer ignores the formatting of A2 in this case and only uses the properties of the covering cell. Table cell border collapsing rules already differ in Word and Writer, so SwTabFramePainter::Insert() knows if the table cell's border is Word-style or not. Extend this code to handle vertically merged cells better. In general, this means a cell no longer has a fixed set of 4 borders, but each edge may have several sub-borders. This commit is a step in that direction, and handles the case when a vertical (left or right) border style is set initially, but not set at the end -- as we iterate through the list of cells in a vertical merge. Change-Id: I35a05097ce70243099307ce8066766aef61a2bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111954 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-04Update git submodulesSeth Chaiklin1-0/+0
* Update helpcontent2 from branch 'master' to 32c582fe61715f10c4eeaf15aa0a7ac7af2388fc - tdf#134432 add module switches to "Character Highlighting" 1. Add appl-switch to description, because only Writer has character style. 2. Add appl-switch for Format - Character, because Calc does not have this option. 3. Add "click icon" in to howtoget with appl-switch, because Writer has extra options. 4. appl-switch for highlighting text selection. 5. appl-switch for remove highlighting text selection. 6. appl-switch for multiple selection in both highlighting and "remove highlighting" because only Writer can do this. Change-Id: Ie7fc3e713f2b3806f0a956a29e25df9d89346ea2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111182 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-04Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 5c2a52e32028e4d894704f171b18937786866686 - tdf#138193 SPECIAL CHARACTER DIALOG: Help for search field is missing Change-Id: I98035b70cf3542389d6cc5128439bebe4eee863b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111915 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-04Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to b342fbeee805b4272d4a2b8015fd65c0d708046a - tdf#133846 Inform where java is used Change-Id: I68a9e5cc366a80094d6d97bb9310d61a16bfe6a5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111920 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-04Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to e661fb9ccdc7d6bf364aa4a4e3b5e9f74acf8278 - tdf#138484 Clarify Writer Print Options are for new documents Change-Id: Ida202ff37fa9f559699bb05863d672344bef851a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111919 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-04tdf#116215 sc: move UItest to CppunitTestViKrAm-Bais2-42/+35
Change-Id: Iae6076bd34331e7ddf441a7d6de22ad9b784b0a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111867 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-04drop some unused forward declaresCaolán McNamara1-4/+0
Change-Id: I57df9a6903c75ca8fc822431ae8294f76167cc97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04explicitly name static methodCaolán McNamara1-1/+1
Change-Id: I691c7dc21d87f58d11263d0556991df8731b97d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111933 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04Improve unit test accuracyMike Kaganski2-11/+11
I didn't take clock resolution into account when created the test, and it failed for me occasionally because the value was slightly less than expected. The typical system tick resolution is documented at https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/high-resolution-timers Change-Id: Ie48b10d15b14f9ac7d292a2cc9916bcbfff44b6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111946 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-04CppunitTest_xmlsecurity_pdfsigning: run all tests in the disable-pdfium caseMiklos Vajna1-17/+84
Return early in case pdfium is not available, to avoid the ifdef forest. Change-Id: Iea6feb1492a68eb7ea718e4bee05f1e3bfc98e89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111936 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-04tdf#93415: sc_ucalc: Add unittestXisco Fauli2-0/+22
Change-Id: Id06ceb081459831637ee78e0a049cf7099772372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111942 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-04Related tdf#140762 Add texts for "Border style" toolbar itemMichael Weghorn3-18/+17
Make 'GetLineStyleName' a static method of 'SvtLineListBox' and use it to retrieve and set the names for the items used in the "Border Style" dropdown button in Calc's formatting toolbar. This ensures that the corresponding names are available as tooltips and for screen readers. Change-Id: I6b775e1bcd62deefd8a8a6a778dcee426bf3a1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111905 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-04tdf#140762 Set texts for items in "Borders" dropdown buttonMichael Weghorn2-17/+23
Associate textual descriptions with the images for the items in the "Borders" dropdown button in Calc's formatting toolbar. This e.g. makes them show up as tooltips when hovering over the images with the mouse and makes them accessible to screen readers (e.g. Orca with the gtk3 VCL plugin now says those texts instead of just saying "item 1", "item 2",...). This also adds the strings for the items where no corresponding ones exist yet. Change-Id: I02ce8abfa4aa59e06ca1ab45aff0685a19c323f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111871 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-30 11:34:23 +0000