summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-10-14loplugin:includeform (clang-cl)Stephan Bergmann1-4/+4
Change-Id: If1cffd3896d87695ba189728d8c1f1f04d55b6b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:unreffun (clang-cl)Stephan Bergmann1-1/+0
Change-Id: I9e478c71662aa5a5347d11adae0435e737fced82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104247 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:stringconstant (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I407b5e80a331950790f549ac8a50e8d7e49ee6d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:redundantcast (clang-cl)Stephan Bergmann2-3/+3
Change-Id: I2918d9ac8a4600bf5729604bda1beffb1dca78d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104244 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14-Werror,-Wmicrosoft-exception-spec (clang-cl)Stephan Bergmann1-1/+1
> C:/lo/core/bridges/source/cpp_uno/msvc_shared/except.cxx(124,11): error: exception specification in declaration does not match previous declaration [-Werror,-Wmicrosoft-exception-spec] > RTTInfos::RTTInfos() throw() {} > ^ > C:/lo/core/bridges/inc\msvc/except.hxx(93,5): note: previous declaration is here > RTTInfos(); > ^ Change-Id: I7fa9d85de70d1398f89443b202b9b60c36dcc46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104243 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14Derive FormulaExternalToken from FormulaByteToken, tdf#133260 follow-upEike Rathke2-16/+9
This should always have had a ParamClass member variable and SetInForceArray()/GetInForceArray() functions but never did. Now with commit 3a33828b8de7554e497051738c722b1764960a86 CommitDate: Tue Oct 13 21:36:31 2020 +0200 Resolves: tdf#133260 Propagate ForceArrayReturn from inline arrays it broke CppunitTest_sc_subsequent_filters_test with the virtual dummy assert() in FormulaToken::SetInForceArray(). Unfortunately not caught earlier but at least it did now. Remove the duplicated FormulaToken overrides and simply derive from FormulaByteToken instead that has all we need. Change-Id: I7946602955970fb9d6f349efdacb41389e211b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104262 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-14Fix namespace errors in new "vro" manifest.xmlJulien Nabet1-4/+4
Fix these: /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:2: namespace error : Namespace prefix manifest on manifest is not defined <manifest:manifest> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:3: namespace error : Namespace prefix manifest for full-path on file-entry is not defined <manifest:file-entry manifest:full-path="/" manifest:media-type=""/> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:3: namespace error : Namespace prefix manifest for media-type on file-entry is not defined <manifest:file-entry manifest:full-path="/" manifest:media-type=""/> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:3: namespace error : Namespace prefix manifest on file-entry is not defined <manifest:file-entry manifest:full-path="/" manifest:media-type=""/> ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:4: namespace error : Namespace prefix manifest for full-path on file-entry is not defined :file-entry manifest:full-path="DocumentList.xml" manifest:media-type="text/xml" ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:4: namespace error : Namespace prefix manifest for media-type on file-entry is not defined :file-entry manifest:full-path="DocumentList.xml" manifest:media-type="text/xml" ^ /home/julien/lo/libo_perf/extras/source/autocorr/lang/vro/META-INF/manifest.xml:4: namespace error : Namespace prefix manifest on file-entry is not defined :file-entry manifest:full-path="DocumentList.xml" manifest:media-type="text/xml" ^ Remark: I don't know why these errors don't appear for "pt-PT" which has the same way to declare manifest.xml Perhaps because only "pt" and "pt-BR" are used and don't use this buggy way? Change-Id: Ibe8e03ec3d2e307be5ba96eb07ad710801f43eaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104260 Reviewed-by: Mihkel Tõnnov <mihhkel@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-13tdf#137446 catch divByZero in ResizeMultMarkedObjRegina Henschel1-3/+3
When a horizontal or vertical line is resized, the height or width is zero and yFact or xFact are invalid Fraction. They are passed on to SdrTextObj::NbcResize. There an invalid Fractions returns -1 for GetDenominator and results a faulty mirroring. Change-Id: Iafe91827cfc7a8b6ccff852115f01ccbb90e54b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104234 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-10-13split out detection of should disable EditHyperlink as standalone functionCaolán McNamara2-30/+43
Change-Id: I69c4d93b402a33d5ef3b55a7fc0a053332eb0196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104253 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13Resolves: tdf#133260 Propagate ForceArrayReturn from inline arraysEike Rathke1-9/+45
... and functions returning array/matrix. Same as for TRANSPOSE() and FREQUENCY() but not mentioned in ECMA-376-1:2016 OOXML. Change-Id: I1e9f1151b2bc0b7de892f4f3d9f91b9a6b86b67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104249 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-13uilogger : Add support in the Logger and DSL for Vertical TabAhmed ElShreif2-0/+22
For example the DSL syntax will be: >> Choose Tab number 2 in 'tab_id' from parent_id We don't need DSL change as it will already handled by normal Tab grammar Change-Id: I51f294134be88c4ac88baf73c53d81187a023061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101516 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-10-13sw_redlinehide: fix crash in SwTextNode::SplitContentNode()Michael Stahl4-26/+109
Bug happens in the "top" branch of SplitContentNode(). SwTextNode::CutImpl() sends several hints to the SwTextFrame so that it invalidates itself; a SwInsText and a SwDelText most prominently. The SwInsText won't have an effect because the target node doesn't have text frames yet, but the SwDelText should be sufficient to update the text frames' MergedPara and invalidate the text frames. The MergedPara is re-created by SwTextFrame::RegisterToNode() anyway, but that *doesn't* invalidate the SwTextFrame. Then an additional SwDelText is sent, which will *not* invalidate the SwTextFrame, because its MergedPara is up-to-date so nothing gets deleted by the hint. It's unclear why the LockModify() is done here, since CVS initial import, perhaps it's some premature optimization; try to remove the manual sending of SwDelText and just let CutImpl() do it. Also remove an odd assert in UpdateMergedParaForMove() that i don't understand the reason for now. Change-Id: Iba7196556f614356dba4def74f039a88f392eb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104219 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-13translate comment to EnglishTomaž Vajngerl1-1/+1
Change-Id: I8315f585b899031d238d339d3833c9f0d536dfab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104236 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-13combine duplicates togetherCaolán McNamara2-8/+16
Change-Id: Ic4d5b50051cee4ab65a366ed7d26c222a7ca3008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13Missing test dependenciesStephan Bergmann1-0/+3
Otherwise, from-scratch `make CppunitTest_sw_uiwriter` failed for me on Linux with > warn:vcl.builder:1934376:1934376:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:1939531:1939531:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:1943074:1943074:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/sfx/ui/infobar.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 Change-Id: I8f1ece408b8c5f0e389378f15a2652a45cb93103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-13bnc#887230: sd_export_ooxml1: Add unittestXisco Fauli2-0/+18
Bisection of tdf#137367 points to the commit fixing bnc#887230 Make sure we don't regress here Change-Id: I54877ca5fae8c7074baf1211ec983c1bc1961f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104232 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-13tdf#101122 DOCX custom shape export: remove bad fillRegényi Balázs5-4/+67
of (simplified export) of not filled custom shapes by adding missing fill="none" to a:path. Note: in OpenDocument, unfilled shape path is defined by draw:enhanced-path command "F", see section 19.145 in ODF v1.2. Co-authored-by: Szabolcs Tóth Change-Id: I0be2aada3deb06828216e0441c91c389a673f87c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104205 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-13Resolves tdf#137424 - UI Picker missing 'Contextual single'Heiko Tietze2-4/+4
Exclusion by experimental on/off updated Change-Id: I714b8ffc5a148d09607ab20763b6d35de2a9e2be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104231 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-13VclScrolledWindow vertical scrollbar one pixel too far to the leftCaolán McNamara1-1/+1
Change-Id: I6d9afb87b8d99e3c622b9d69fbfa88528adadb81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104228 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13tdf#134987 convert DOCX to ODT: fix lost chartsBalazs Varga4-0/+70
Embedded charts of DOCX documents were lost or replaced by images during conversion to native ODT format, resulted by bad handling of XEmbedPersist objects in EmbeddedObjectContainer. Note: Add missing loext:external-data to ODF 1.3 schema definition to fix ODF validation error in gerrit. See commit 2054af83fefb955e20de2b40178a11726525057e (fdo#72520 : Added property to store external data path in chart) and commit a49a9dab3168c03a539adc131f2ade03236edb69 (fix one more ODF validation error). Change-Id: I9edff9af3a79370ea447ffc6078da3520d0c6f63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104104 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-13static_cast after dynamic_castNoel15-72/+60
Change-Id: I68c20dfbedb84660cf25df785e1e0b13a7592994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13static_cast after dynamic_castNoel17-90/+72
Change-Id: If93fa126f10393a250cc1ad64bee28e84c42a6b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13static_cast after dynamic_castNoel32-240/+168
Change-Id: I53e10fbebfd07c471ddd9b264562317251700500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13with a DND_ACTION_NONE drag action and zero target-formats disable dragCaolán McNamara1-2/+8
so we can support dynamically disable/enable dnd Change-Id: Icfec79c332ef073e04be5a57747e849b27098732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13sdext: fix use-after-free on global AccessibleFocusManagerMichael Stahl1-2/+13
The problem is that the destructor of the vector maFocusableObjects ends up dispose()-ing every element, which calls back into AccessibleFocusManager to remove the element from the vector, which invokes its destructor a 2nd time. Move it to the stack so it doesn't double-free itself. ERROR: AddressSanitizer: heap-use-after-free on address 0x612001571c00 at pc 0x7fc5e723ca72 bp 0x7fffbaa8d6d0 sp 0x7fffbaa8d6c8 READ of size 1 at 0x612001571c00 thread T0 #0 0x7fc5e723ca71 in cppu::WeakComponentImplHelperBase::release() cppuhelper/source/implbase.cxx:84:9 #1 0x7fc595211b27 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::awt::XWindowListener>::release() include/cppuhelper/compbase.hxx:86:36 #2 0x7fc5952093e4 in rtl::Reference<sdext::presenter::PresenterAccessible::AccessibleObject>::~Reference() include/rtl/ref.hxx:113:22 #3 0x7fc59522acd4 in void std::_Destroy<rtl::Reference<sdext::presenter::PresenterAccessible::AccessibleObject> >(rtl::Reference<sdext::presenter::PresenterAccessible::AccessibleObject>*) /usr/bin/../lib/gcc/x86_64-redhat-linux/10/../../../../include/c++/10/bits/stl_construct.h:140:19 0x612001571c00 is located 64 bytes inside of 312-byte region [0x612001571bc0,0x612001571cf8) freed by thread T0 here: #0 0x4be997 in free (instdir/program/soffice.bin+0x4be997) #1 0x7fc5ea2a5104 in rtl_freeMemory sal/rtl/alloc_global.cxx:51:5 #2 0x7fc5952097f4 in cppu::WeakComponentImplHelperBase::operator delete(void*) include/cppuhelper/compbase_ex.hxx:66:11 #3 0x7fc595211e07 in sdext::presenter::PresenterAccessible::AccessibleObject::~AccessibleObject() sdext/source/presenter/PresenterAccessibility.cxx:67:28 #4 0x7fc5e74a11b4 in cppu::OWeakObject::release() cppuhelper/source/weak.cxx:233:9 #5 0x7fc5e723cb05 in cppu::WeakComponentImplHelperBase::release() cppuhelper/source/implbase.cxx:86:18 #6 0x7fc595211b27 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::awt::XWindowListener>::release() include/cppuhelper/compbase.hxx:86:36 #7 0x7fc5e7194115 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() include/com/sun/star/uno/Reference.hxx:110:22 #8 0x7fc5e71f3944 in com::sun::star::lang::EventObject::~EventObject() workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/lang/EventObject.hdl:18:27 #9 0x7fc5e723d395 in cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:118:5 #10 0x7fc595211e27 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::awt::XWindowListener>::dispose() include/cppuhelper/compbase.hxx:90:36 #11 0x7fc5e723c6e9 in cppu::WeakComponentImplHelperBase::release() cppuhelper/source/implbase.cxx:79:13 #12 0x7fc595211b27 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::awt::XWindowListener>::release() include/cppuhelper/compbase.hxx:86:36 #13 0x7fc5952093e4 in rtl::Reference<sdext::presenter::PresenterAccessible::AccessibleObject>::~Reference() include/rtl/ref.hxx:113:22 #14 0x7fc59522acd4 in void std::_Destroy<rtl::Reference<sdext::presenter::PresenterAccessible::AccessibleObject> >(rtl::Reference<sdext::presenter::PresenterAccessible::AccessibleObject>*) /usr/bin/../lib/gcc/x86_64-redhat-linux/10/../../../../include/c++/10/bits/stl_construct.h:140:19 Change-Id: I95151807e9182ed5f43b63792fba86f83ee0bad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104208 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-13static_cast after dynamic_castNoel20-182/+157
Change-Id: If1194bd3364fef8b2d0c26c22854745d0fb7b412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13Set correct color for chart background in sidebarSzymon Kłos1-0/+47
Change-Id: Id41fba75133e3473dcb834c72ff2ecfb317ecb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103603 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104201 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-13static_cast after dynamic_castNoel24-177/+161
Change-Id: I487b5dc148f5a3d0d45f198c00179002841242ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13tdf#137180 RTF import: fix bad left margin with direct format/para style/numMiklos Vajna6-12/+130
This is a case when a left margin appears as direct formatting on a paragraph, the paragraph has a style and the style has the same left margin. But the paragraph has a numbering as well: so it's not valid to deduplicate the left margin from the direct formatting, because then the left margin from the numbering will be used, which can be a different value. Change-Id: I5e27502b8d505bdfddfdc910858f62e501db35a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-13tdf#137369 Add missing targeted icons as defined by links.txtRizal Muttaqin29-4/+19
Change-Id: I030368a09905f236ce43fa5d08740641d694fbad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104199 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-10-12use dot not comma for decimal placeCaolán McNamara1-3/+3
wrong since... commit acb1c390539730957fb509f18f469fc7f6133082 Date: Thu Oct 1 15:44:32 2020 +0200 Resolves tdf#137187 - More dictionaries via extensions dialog Change-Id: I01010d07d356dd696fd3432971b20194008c9487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104218 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12desktop: fix misleading commentMiklos Vajna1-1/+1
REQUEST_START is triggered with --show. Change-Id: I83fec4f0ae4df15ed7974f484b3001e886f82a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104217 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-12reindent CGMBitmap::ImplGetBitmapCaolán McNamara1-158/+158
no logic change Change-Id: I1172e97feb5e78b68ed395231a698459687493aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12ofz: TimeOut short-circuit with a zero mnScanSizeCaolán McNamara1-3/+8
Change-Id: I3ac7848170e8075fe192731495361cb2c5777e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12Resolves tdf#137187 - More dictionaries via extensions dialogHeiko Tietze8-45/+25
UNO command and linkbutton interaction replaced with the internal dialog DICT_REPO_URL removed, README adjusted Change-Id: I401737b538da229ac0d432007e7564105672ff40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103769 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-12Resolves tdf#135270 - Make the tight extensions dialog shinyHeiko Tietze13-202/+317
Information rearranged, empty icons instead of hidden, background and scaling of thumbnail Change-Id: Iae095134a717cb50670bf5d1786774c6424d283e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104079 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-12don't disable the fast path in DrawDeviceAlphaBitmap() (tdf#137311)Luboš Luňák1-10/+7
Only OpenGL and Skia implement the BlendBitmap*() calls, and so I disabled the direct path in an attempt to avoid forcing the mirroring if it takes place. But there's also the DrawAlphaBitmap() call that is implemented for other backends. So always do the mirroring already there if it takes place. Change-Id: I8c4c96ea18ac55ebad041e0d28c4228542d9b2e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104206 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12CaptureMouse on mouse-down and ReleaseMouse on mouse-upCaolán McNamara1-0/+5
Change-Id: I6a2096151bbe7b2bdf9210b3d023926270a9987a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12similar to tdf#120764 dismiss tooltips on showing popup menuCaolán McNamara1-0/+13
Change-Id: I4a3dd3d30fcab84bf9987f71a9c9cf0657ecfbb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12Resolves: tdf#137345 increment by a full second on up/downCaolán McNamara1-4/+4
Change-Id: I9884c1cd579fff85c425ffe51e1ed60f7095ad90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104209 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12render document thumbnail directly to bitmap, without metafileLuboš Luňák4-21/+77
I don't see the point of taking the detour via GDIMetaFile and then immediately drawing using it to a bitmap. Simply draw directly to a bitmap. Especially given that when drawing to a metafile some fast cases are skipped, e.g. DrawTransformedBitmapEx() avoids DrawTransformBitmapExDirect() and resorts to using the slow BitmapEx::getTransformed(). E.g. with tdf#136223. this makes SfxPickListImpl::AddDocumentToPickList() go from 30% to 13% of the total document loading time. Change-Id: Ib1643eddfc2b75a3d7be60138fb5226352805826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104114 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12Resolves tdf#137408 - Bad positioning of first items in extension dialogHeiko Tietze1-1/+1
Change-Id: Ic54ac8377bbfbd2c5b5b995ef8615bf0961bd100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104051 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-12try to read JPEGs as BGR if wanted and availableLuboš Luňák1-0/+6
BGR(A) is actually the format used by most VCL backends (Cairo and Skia at least). Change-Id: I1574aadabafcea274049d4c7021352913813bae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104130 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12Resolves tdf#137189 - Fixes crash at CheckInstalledExtensions()Heiko Tietze1-0/+1
SolarMutex added Change-Id: I18c6683e7a26892ce7f1d019cb1ee59ce03981ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104198 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Jenkins
2020-10-12implement ImplFastBitmapConversion() for 8bit gray sourceLuboš Luňák1-12/+22
With some documents SvpSalGraphics::drawTransformedBitmap() ends up calling StretchAndConvert() with 8bit grayscale source bitmap (e.g. OutputDevice::DrawTransformBitmapExDirect() uses them as dummy alpha masks). But ImplFastBitmapConversion() doesn't handle this case, so StretchAndConvert() falls back to doing it manually, easily making this 3x slower. But 8bit grayscale bitmaps sort of are actually non-paletted, so this is easy to optimize. Change-Id: I93aa3f283c8a182d76f3aa267ebd471e63d945e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104129 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12the alpha used by our 32bpp formats is true alpha, not transparencyLuboš Luňák1-2/+2
Apparently this code path has never been tested. Change-Id: I112543ad4f403bb50e5789ceacf57e0c009a9ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104128 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12implement fast bitmap variant for CopyScanline()Luboš Luňák3-8/+114
JPEG reads RGB, but e.g. with Skia the default bitmap format is BGRA. Change-Id: Iad1a9e99f286b03db0fa683c14d70b8ad48d3d9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104120 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12Changed font order for Korean locale tdf#137392DaeHyun Sung2-27/+27
changed font order priority. 1. put 'Noto Sans KR' ahead of 'Noto Sans CJK KR'. Because, New Noto Sans CJK font change the name. New Noto Sans CJK V2.001 released on 10 Apr 2019. In these font files, removed 'CJK' on names. Nowadays, New Linux distributions includes Noto CJK font V2.0. In Korean Linux environments, Noto CJK font v2.0 'Noto Sans KR' & 'Noto Serif KR' are already set default. 2. fixed Windows fonts for Korean on LibreOffice I watched Windows 10's Korean Font List Microsoft Docs: Font List Windows 10 - Typography; Korean Supplemental Fonts https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list#korean-supplemental-fonts I missed 굴림체;GulimChe, 돋움체;DotumChe, 굴림체;GulimChe. So. I added MS Default Korean fonts. As a result, I changed font order and add default Windows font names. Ref. 1: Google Noto CJK fonts Repository: https://github.com/googlefonts/noto-cjk 2: Microsoft Docs: Font List Windows's Korean supplemental fonts https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list#korean-supplemental-fonts cf.Apple Docs - Format Chinese, Japanese, or Korean text in Pages on Mac https://support.apple.com/guide/pages/format-chinese-japanese-or-korean-text-tanfbd4156e/mac Change-Id: I12594aa8f3122c05810a07a718aae7ec185ba481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12sw: prefix members of SwFormatAnchor, SwXDocumentPropertyHelper, ...Miklos Vajna5-83/+83
... SwXLinkNameAccessWrapper and TableHeadingCheck See tdf#94879 for motivation. Change-Id: I1108abc0d4ee6179c0b4d4dbe18af0730edbd2ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104200 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-12ofz#24932 collatoral ubsan failure seen in TimeOut caseCaolán McNamara1-2/+5
unsigned integer overflow: 0 - 1 cannot be represented in type size_t Change-Id: Iba74ce28752e4024e0921f91f28866fd9eaf248e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-28 14:23:52 +0000