summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-07-15coverity#1437954 Dereference null return valueCaolán McNamara1-1/+1
turn DBG_ASSERT into a real assert since... commit 904c97bbdf4c76709dbcacb11292668b98a9efd8 Date: Mon Jul 2 17:23:59 2018 +0200 move SvTreeList::*Sibling to SvTreeListEntry since they don't depend on SvTreeList at all Change-Id: Ib230ff2fc9ab1f68c6686c125dbf4213e77bea84 Reviewed-on: https://gerrit.libreoffice.org/57457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15coverity#1437953 Unchecked dynamic_castCaolán McNamara1-0/+1
Change-Id: I7f9e000cb47206444c4bda0896f56d220d86f04b Reviewed-on: https://gerrit.libreoffice.org/57456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15coverity#1437957 Unchecked dynamic_castCaolán McNamara1-0/+1
Change-Id: I1c1d699e585da5d758671422f8e438e5ac8b5b03 Reviewed-on: https://gerrit.libreoffice.org/57455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15coverity#1437958 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: I569c4367cc968f968c0f864bb3e231a7417d7560 Reviewed-on: https://gerrit.libreoffice.org/57454 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15remove SvxFrameDirectionItem::operator== overrideJochen Nitschke2-9/+0
base class SfxEnumItem has the same operator Change-Id: I57bd4878f34eb17ee16553bb3f6aa2b15af533d9 Reviewed-on: https://gerrit.libreoffice.org/57452 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-15cppcheck: useInitializationList in writerfilterJochen Nitschke4-7/+10
Change-Id: I4bbd2b4d3a4bba23936bd25a02cff011448e66f9 Reviewed-on: https://gerrit.libreoffice.org/57453 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-15Icon theme bug: add sc icons for some page layout iconsandreas kainz13-0/+25
this icons are needed in writer tabbed NB Change-Id: Id71ff2d125923af9b9f13d1f8c2d34aa30be60f6 Reviewed-on: https://gerrit.libreoffice.org/57382 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-15tdf#118377 Do not use disposed OutputDeviceArmin Le Grand1-4/+18
Change-Id: I7e085f69ce18e8e3c47fde690a939948454d4d15 Reviewed-on: https://gerrit.libreoffice.org/57319 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-15Developer ModeXimeng Zu7-13/+268
Added an settings option to enable Developer Mode, in which you can send UNO commands from the Viewer. You can also add properties to the command. Change-Id: I76cbb55771cdd5cea89da65ddf67e48e12745b41 Reviewed-on: https://gerrit.libreoffice.org/37045 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-15accessibility : move ensureIsAlive outside of implGetText and implGetLocaleArnaud Versini1-2/+14
Change-Id: Ib52a19045cde1b6d9d3f3b5d76c5c59d162a3fa6 Reviewed-on: https://gerrit.libreoffice.org/57153 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2018-07-15use array version of unique_ptrJochen Nitschke1-1/+1
fixes commit 592eb9217a52632e4271db3628c5aafb0cefbee8 loplugin:useuniqueptr in XclExpChTrTabId Change-Id: I03c4f12f0e821ca599db00d7eb2f44749e3c9e95 Reviewed-on: https://gerrit.libreoffice.org/57430 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-15add test for tdf#117816Markus Mohrhard2-0/+13
Change-Id: I470b4137a3b4e23acf0f4e949a7a834fed8069db Reviewed-on: https://gerrit.libreoffice.org/57433 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15tdf#117816, work around MS Excel bug with containsText cond formatMarkus Mohrhard1-0/+10
Excel seems to require the formula that is equal to the containsText condition. According to cfRule (18.3.1.10) "Only rules with a type attribute value of expression support formula syntax." which contradicts the MS EXCEL behavior. Change-Id: Ifa3f9fee58194f70a64b37c62922513435d43bb8 Reviewed-on: https://gerrit.libreoffice.org/57432 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14ofz#9116 Integer-overflowCaolán McNamara1-10/+10
Change-Id: I8715eaee5e71341beef1c146f5eca09581f87879 Reviewed-on: https://gerrit.libreoffice.org/57437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-14ofz#9403 null derefCaolán McNamara1-2/+3
Change-Id: I6efa4be9f4feb4f92f96f7030f933e4a0c406b1e Reviewed-on: https://gerrit.libreoffice.org/57435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-14Remove the check for IsRecalcModeMustAfterImport(), tdf#94925 follow-upEike Rathke1-15/+6
It's now superfluous as we set those cells dirty and broadcast in ScDocumentImport::broadcastRecalcAfterImport() Change-Id: Ia9dd4ad16c20b23ee8a1d46b69a4702b1ad4c81f Reviewed-on: https://gerrit.libreoffice.org/57439 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-07-14tdf#118123 Tango shouldn't fallback to Colibreandreas kainz1469-0/+6251
move missing tango icons from galaxy cause tango isn't finished without galaxy missing links in links.txt from 6.1 release are not added Change-Id: Ia199beabe2a465cb7e8013be807e610249f42424 Reviewed-on: https://gerrit.libreoffice.org/57288 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-14fix oss-fuzz buildCaolán McNamara1-1/+1
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9301 Change-Id: Iceb25764c483e20f09fe976d1271987643990aaf
2018-07-14Broadcast formula cells marked for recalc, tdf#94925 relatedEike Rathke3-0/+62
In fact the ScDocument::CalcFormulaTree() call in WorkbookFragment::recalcFormulaCells() never did anything because no formula cell was added to the tree. Only visible dirty cells were recalculated, but not their dependents. Change-Id: I11217fa19adb766f509d0d6854502112de547c59 Reviewed-on: https://gerrit.libreoffice.org/57431 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-14tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorUlkem Kasapoglu1-4/+1
Change-Id: I09016a06110772379ddf8b15f14446346b850cd6 Reviewed-on: https://gerrit.libreoffice.org/57339 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-14Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - tdf#115524 Some branch bookmarks are not working 2 simpress and sdraw modules Change-Id: I5d498cb7ab504277a54f6d002e1f8e88ce78ab0c Reviewed-on: https://gerrit.libreoffice.org/57411 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-14Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - tdf#115524 Some branch bookmarks are not working 1 With .ui dialogs, the Help system sends specific URL associated to the higlighted widget in the .ui dislog. Not every help page associated to the dialog has <bookmark branch="hid/<path to the dialog/widget"/> for all widgets of the dialog. As consequence, some URLs were not addressed and the default module entry page was displayed, instead of the dialog help page. The solution is to define a dumy bookmark '@@nowidget@@' to the help page associated to the dialog, and if the widget bookmark is missing in the help page then use the dummy target, thus offering a help page with the right contents anyway. This patch covers help pages for smath. Change-Id: I40b592271b0c336d4d3bacc33d2f3d19107ae702 Reviewed-on: https://gerrit.libreoffice.org/57393 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-14add test for tdf#91385Markus Mohrhard2-0/+40
Change-Id: Ic755d330f242a78214e8b1610aa496ecce3d61b4 Reviewed-on: https://gerrit.libreoffice.org/57410 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14tdf#91385, recalc cond format formulas during hard recalcMarkus Mohrhard3-0/+42
Change-Id: I54b650d228c89a15eb37294eb108ab736163a000 Reviewed-on: https://gerrit.libreoffice.org/57409 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14sc: disable sc_apitest::ScTabViewObj::testGetReferredCells()Miklos Vajna1-1/+2
This was added in commit 600987b415e537362125b4445ab7132535e6e1e1 (tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++, 2018-06-13), but as it was reported it fails on some Linux and Windows machines. Disable it till it's clear why that happens, as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-July/080521.html>. For the record, the failure what I can see is like this: xcellrangereferrer.cxx:32:Assertion Test name: sc_apitest::ScTabViewObj::testGetReferredCells equality assertion failed - Expected: Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 22 - Actual : Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 23 Failures !!! Run: 6 Failure total: 1 Failures: 1 Errors: 0 Change-Id: I8057c938134b651b5f0f62fe07c2ef66a99d2e66 Reviewed-on: https://gerrit.libreoffice.org/57396 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-14add tests for tdf#117809Markus Mohrhard4-0/+45
Change-Id: Ifbd48879a10acfbc6fdb0f2799321ff0684cdcc4 Reviewed-on: https://gerrit.libreoffice.org/57407 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14tdf#117809, listen to the actual conditional format range if necessaryMarkus Mohrhard6-11/+81
Change-Id: Ib83cf22e40f5e0338a3c85f631d30f00b80d8655 Reviewed-on: https://gerrit.libreoffice.org/57406 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14Resolves: tdf#94925 do not unset dirty if formula cell must be recalculatedEike Rathke2-8/+26
Change-Id: If70860b8babf1cce7fda2ae63412659e72dbb4c3 Reviewed-on: https://gerrit.libreoffice.org/57404 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-13sc: Add a test case for ZTEST() raising #DIV/0!Takeshi Abe1-4/+16
... when the sample stddev is 0. This follows up d17e8faa13b1f8d943b602aa6ea754c1b22fdd76. Change-Id: I4ce718f60f1dbcf58fdcbbb553c345c9c8907a2b Reviewed-on: https://gerrit.libreoffice.org/55741 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-13uitest Calc - ValidityZdeněk Crhonek3-0/+164
Change-Id: I0de19f41e177eebf6212ff2de905ca1a7859e9c5 Reviewed-on: https://gerrit.libreoffice.org/57394 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-13Rework FormulaTokenArray ScRecalcMode in preparation for tdf#94925Eike Rathke7-64/+65
Strictly order the exclusive bits by priority, let AddRecalcMode() handle all sets except forced ALWAYS or NORMAL. Introduce ONLOAD_LENIENT and ONLOAD_MUST splitting ONLOAD to be able to distinguish later during OOXML import. Change-Id: I188de2d53a2d54df32d24eeeb148c4f9e87e7cfc Reviewed-on: https://gerrit.libreoffice.org/57402 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-13gla11y: Enable warnings for GtkImage missing a labelSamuel Thibault11-1/+102
Change-Id: I6ba9c6bcb8ce4faef6853ea25b2a9e68a67d0087 Reviewed-on: https://gerrit.libreoffice.org/56152 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-13Remove now superfluous CheckLinkFormulaNeedingCheck() callEike Rathke1-3/+0
That's now done in the ScDocumentImport::setFormulaCell() anyway, called two rows below. Change-Id: I593a8781fced9930061a492e4ce613baba50207a
2018-07-13lokdialog: Don't hide dialogs in case of LOKPranav Kant1-1/+6
We change views (using setView) a lot in case of LOK. Changing the view, without this patch, leads to InitShow on the dialog which means invalidation of the whole dialog even though there is nothing to invalidate. This decreases performance as it increases the dialog paint traffic through the LOK API. We don't need to hide the dialog once it's opened in case of LOK. This patch improves the multiview dialog performance considerably (can easily be noticed in GTV). Change-Id: If2b4ceb945ccd86da3d90bbbb0a0b9fbade43f30 Reviewed-on: https://gerrit.libreoffice.org/57401 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-07-13tdf#110987: type detection, binary Office formats > templatesAron Budea1-8/+8
The templates for binary MS Office formats were higher prioritized than non-templates, this caused files in binary format and lacking file extension to be identified as templates. Change-Id: I5638b38dfa0a7520dd09cb497c05b6af0eb00834 Reviewed-on: https://gerrit.libreoffice.org/40651 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-07-13Remove obsolete (cargo-cult copied) dependenciesJens Carl1-30/+1
Change-Id: Ib1683d144597b0ed985321687dc269981e68b910 Reviewed-on: https://gerrit.libreoffice.org/57381 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-13sw HTML export: fix XHTML mode of 'Heading 7' styleMiklos Vajna3-17/+67
Font name, font size. Change-Id: I32b8b2d596b0e0aeb72156edaae83b4b04765583 Reviewed-on: https://gerrit.libreoffice.org/57392 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-13Move convertMeasrue and convertAnimationValue from sd to oox.Mark Hung5-367/+299
1. convertAnimationValue convert the attribute value of a animation target from MS ppt to the format that slideshow understand, moving it so that it can be resued in oox. 2. convertMeasure is used by convertAnimationValue, moving it togehter eliminate the duplicated function in oox. Change-Id: I41cd1cf731b6496d7ae96b174a1748326415593f Reviewed-on: https://gerrit.libreoffice.org/57287 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-13Refresh linked OLE representation when OLE updatedArmin Le Grand2-1/+38
Change-Id: If949778779f1a91901412938d0b0298e1d7cfc3e Reviewed-on: https://gerrit.libreoffice.org/57357 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-13Inaccurate symbol signs fixed (tdf#118381)Thorsten Wagner1-4/+29
Change-Id: I2af1d3e4c924acd2ae601f0b40fcf1b2be17c397 Reviewed-on: https://gerrit.libreoffice.org/56426 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-13loplugin:useuniqueptr in SbUnoStructRefObjectNoel Grandin4-10/+5
now that we have upgraded to VS2017, we can use std::unique_ptr in std::map Change-Id: Id01af07ccae7447405b8f0bc44b08043f453e54b Reviewed-on: https://gerrit.libreoffice.org/57384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-13tdf#118702: partially revert the fix for tdf#78907Xisco Fauli4-5/+9
This is a regression from 2df0d9d32d05f08ccf673fd0f61f650438511acb Reverting it as the unitest from tdf#78907 still passes. Besides, adding a new unittest for tdf#118702 Finally, adapt ooxmlexport9 and remove pointless assert which fails with: ooxmlexport9.cxx:557:Assertion Test name: testBnc519228OddBreaks::Import_Export_Import equality assertion failed - Expected: <Any: (void)> - Actual : <Any: (string) Converted2> Failures !!! Run: 155 Failure total: 1 Failures: 1 Errors: 0 Change-Id: I486e9489ef6c3978cbcf90f3b9885248f4f92110 Reviewed-on: https://gerrit.libreoffice.org/57338 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-13loplugin:useuniqueptr in ScImportAsciiDlgNoel Grandin2-4/+4
Change-Id: Ie73f89401a9e99f0cb11949cae3ebdde793b14bb Reviewed-on: https://gerrit.libreoffice.org/57359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-13tdf#118620 - unit test.Michael Meeks2-0/+20
Change-Id: Iae7d2f5cc1ed5b37d6b7ced983951a64e2114c2b Reviewed-on: https://gerrit.libreoffice.org/57369 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-13tdf#118620 - avoid out of bounds iterator for end of sheet pivots.Michael Meeks2-3/+8
Change-Id: I2ddcf56dc94175718739611f0791558fda87b1ba Reviewed-on: https://gerrit.libreoffice.org/57358 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-13related tdf#106174 writerfilter: replace broken FindParentStyleSheetJustin Luth3-18/+7
FindParentStyleSheet didn't do anything right. An empty stylename was supposed to check currentEntry, but instead it just returned null. The passed stylename was completely ignored if there was a currentEntry. And on top of that, the stylename itself was returned, not its parent. Even worse, the currentEntry properties were ignored because in that case it DID return the parent. Even the comments were totally bogus. Amazing... GetPropertyFromStyleSheet() has the potential for LOTS of use in writerfilter. I'm surprised it has hardly been used. Perhaps the completely wrong results led people to ignore it rather than investigate why it didn't give the expected results. Change-Id: I89a6b02877ab7990aa4eb58e5e0b6a572f3d10e3 Reviewed-on: https://gerrit.libreoffice.org/57195 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-13sw, writerfilter: various small cleanupsMiklos Vajna8-20/+14
Different parameter name in declaration and definition, repeating type name inside the very same line when initializing from a cast, and so on. Change-Id: I52dc29ed845fb1a780dfab586bfd67db0d4a9e54 Reviewed-on: https://gerrit.libreoffice.org/57370 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-13loplugin:useuniqueptr in SwUndoDeleteNoel Grandin2-10/+8
Change-Id: I942e55ffebf265a3138c25bedbb7ef882e6c0916 Reviewed-on: https://gerrit.libreoffice.org/57367 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-13loplugin:useuniqueptr in SwUndoSplitNodeNoel Grandin2-3/+3
Change-Id: Ib77b31a7558b5d3c928d774d3c6bdaeff26c177d Reviewed-on: https://gerrit.libreoffice.org/57366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-13loplugin:useuniqueptr in SwUndoInsertNoel Grandin2-4/+4
Change-Id: I229cace30597543fc63222ddb5acf78539d4ba39 Reviewed-on: https://gerrit.libreoffice.org/57365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 13:55:07 +0000