summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-03-22Updated coreOlivier1-0/+0
Project: help 0df6af74a2f1fb791d27ca316e206661bf74b2c5 Improve help text Unit #118023968 (uk) http://nabble.documentfoundation.org/Re-Unit-118023968-uk-tt4210625.html Change-Id: I02fa0a05a2e7a0ca18ab26021bc4293753f698ff Reviewed-on: https://gerrit.libreoffice.org/35507 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-03-22Fix building external/firebird with arbitrary localesStephan Bergmann1-1/+1
At least on Linux, building it with LANG=tr_TR.UTF-8 failed for me with ... > make[5]: Entering directory '.../workdir/UnpackedTarball/firebird/gen' > rm -f metadata.fdb > .../workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql -q -i .../workdir/UnpackedTarball/firebird/src/dbs/metadata.sql > .../workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/gfix -mode read_only metadata.fdb > .../workdir/UnpackedTarball/firebird/gen/Debug/firebird/databases.conf: illegal line <employee.fdb = $(dir_sampleDb)/employee.fdb> > Makefile:325: recipe for target 'metadata.fdb' failed > make[5]: *** [metadata.fdb] Segmentation fault > make[5]: *** Deleting file 'metadata.fdb' > make[5]: Leaving directory '.../workdir/UnpackedTarball/firebird/gen' > Makefile:166: recipe for target 'master_process' failed ... Change-Id: I1784aaa790e527d382e8449f8007b0ae2dc14698
2017-03-22iOS LibreOfficeLight removed start iconjan Iversen2-4/+0
Xcode decided to add an empty launch icon, removed. Change-Id: I62405114e49d176c16e452d05ec9d872c70d7880
2017-03-22Don't actually change OS-level locale with (unused) osl_setSystemLocaleStephan Bergmann4-71/+5
osl_setSystemLocale was introduced with af2938348bb539ccb27c92fe286b768d4143f662 "#88460# added osl_getProcessLocale and osl_setProcessLocale" but never actually used. So mark it as deprecated and, in the sal/osl/unx/ case, don't make it set the OS-level locale via imp_setProcessLocale (calling setlocale or setting the LC_ALL/LC_CTYPE/LANG env vars), same as in the sal/osl/w32/ case. Change-Id: I33348dba5de8ca80ca6fca210043286c0cfa9145
2017-03-22starmath: Make DoOpSubSup() return SmNodeTakeshi Abe2-13/+8
This spares a pair of push and pop of the stack. Change-Id: I046402c2e975a6b5f4148960a9daffa15cc55ff3 Reviewed-on: https://gerrit.libreoffice.org/35532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-22Use consistent include guard macro namesTor Lillqvist3-7/+7
Change-Id: Icc83a9a1257e422aa7593d6a8dd5af25a06a3384
2017-03-22lok sd: Fix crash when searching.Jan Holesovsky1-5/+14
This is a follow-up of ed5450f2a5ed8e72b48b4d976217746cea04a5c9 where the check for the HasView has been removed. Turns out that there are conditions when this really can happen, leading to crashes in the LOK searching. Unfortunately I did not manage to find a reliable reproducer to create a unit test :-( - so I suspect this commit might be more a workaround than a root cause fix. Would be great to find out the exact conditions leading to the situation when the EditEngine does not contain the EditView, and evaluate this fix against that - but that's hard without a reliable reproducer. A unit test for this fix is missing from the same reason. The unit test from ed5450f2a5ed8e72b48b4d976217746cea04a5c9 still passes. Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa
2017-03-22tdf#96099 Reduce no of typedefs used for trivial containersDennis Nielen1-5/+2
Change-Id: Idf7bd4c80f9dc1fb9f93859e1e1106dd620d2311 Reviewed-on: https://gerrit.libreoffice.org/35511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22fix typo: bee --> be or beendennisroczek2-52/+46
* Removed old comment cruft * clean up some indentation Change-Id: I0ddbd66aec0f27d7563dc4c2cfa2e095a48cda46 Reviewed-on: https://gerrit.libreoffice.org/35134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-22desktop: remove redundant virtual keywords in lokclipboardMiklos Vajna1-6/+6
Change-Id: I0b83a79e143180901ce2ae4ef02ff8b65cfb0694 Reviewed-on: https://gerrit.libreoffice.org/35529 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-22check for overflow in multiplyCaolán McNamara2-5/+98
gcc >= 5 and clang have builtins for this msvc has safeint.h and functions in the msl::utilties namespace otherwise fall back to certs demo implementations Change-Id: I6001a278c24b0be4b381d933d256f01f91ead55d Reviewed-on: https://gerrit.libreoffice.org/35505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-22min_slider_length is unusedCaolán McNamara1-3/+1
Change-Id: Ib7ddcdc822e8b08b4e1c3e282a3fe2f691a71569
2017-03-22stepper_spacing is unusedCaolán McNamara1-2/+0
Change-Id: Ia02c5e09c9ca9f5d0e6b0c0eb66283057ff8c1cc
2017-03-22comphelper::ThreadPool: guard against concurrent shutdown/pushTaskMichael Stahl1-7/+9
To join a thread, the mutex must be released - another thread in pushTask() could add a new thread to maWorkers at that point, which must of course not be deleted. Avoid the problem by transferring ownership of the to-be-deleted threads to the calling thread. (regression from bdaa13a87744e424d3c210fc7f3f9e4f199d8279) Change-Id: I9d4fcfe4cb46a336586b5663934a12d47b2d8ccb
2017-03-22tdf#94265: Correct the errorComputingDwarf1-2/+3
Always _WIN32 is defined, even in Win64. So the check must be to _WIN64 and then to _WIN32. Hope no more lines like this in code. Can you test programs with SDK 64 Bit?
2017-03-22Most of this was obsolete and misleadingTor Lillqvist1-28/+0
Change-Id: I769d9277e6ff931ca7d5d61d412b81c191d97083
2017-03-22jvmfwk: fix JVM detection on 64-bit WindowsMichael Stahl1-3/+3
_WIN32 is also defined on 64-bit Windows so reorder these ifdefs. Should i be surprised that this breaks several dbaccess tests for me but all tinderboxes are green? (regression from 9143dd4ebe37b608e43d04434cf831624bf55b65) Change-Id: Id917952d3135768355af711688ff70bf6c019a6e
2017-03-22gbuild: PythonTest depends on python.exe wrapper on WNTMichael Stahl1-1/+1
Change-Id: Idfd2a6d68fecfb5a473938a74a9020f76fbc2c4b
2017-03-22configure: MSVC 2017 devenv.exe doesn't start properlyMichael Stahl1-1/+4
... from a DOS style 8.3 path, for whatever reason. Special case DEVENV variable so it uses long path. Change-Id: I03bb20a8f35cd116edd33ec91178f9deddbc4257
2017-03-22gbuild: MSVC: unbreak CPPUNITTRACE='$(DEVENV)'Michael Stahl1-0/+2
... which is unlikely to contain the strings "gdb" or "lldb". (regression from c38a4d9ce248b4b3fcc9208b25dfa599fe506ac0) Change-Id: I355069ec512232898b246d2b0bf8912831f0c80a
2017-03-22iOS LibreOfficeLight moved entitlementsjan Iversen1-1/+1
Moved entitlements to correct group Change-Id: I6ab95b823fc4a4b8781b27d51ecb8d994f477dca
2017-03-22Missing check for rStream.IsEof()Stephan Bergmann1-0/+4
...after a324099538916eae7f7239d32fd98ec8018cbb72 "xmlsecurity PDF signing: only write incremental xref in an incremental update" inserted the 'if' before the 'while (!rStream.IsEof())' Change-Id: Ib527894031f356c3d6df40b70259469ef4c338de
2017-03-22Prevent calls to rtl/character.hxx functions with (signed) char argumentsStephan Bergmann14-31/+136
...that would implicitly be sign extended (for plain char only if it is signed), so non-ASCII char values would trigger the isUnicodeCodePoint assert. Change-Id: Iaf8024ad509e64525558e882fe3fd078cfb4ea91 Reviewed-on: https://gerrit.libreoffice.org/35523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-22IOS LibreOfficeLight settings supportjan Iversen4-0/+51
Adding support for using IOS Settings The idea is to move the LO settings into here, and let the user manipulate some of the fields. Change-Id: Ifbd1adc6aa395d7822bcec968f267bb85929bff3 Reviewed-on: https://gerrit.libreoffice.org/35528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@libreoffice.org>
2017-03-22Consistently mark function definitions in LibreOfficeKitInit.h as staticStephan Bergmann2-37/+10
...to give them internal linkage in both C and C++. Of those definitions that were not marked as static: * Those that had not been marked as inline had external linkage in both C and C++, so would have caused ODR violations were LibreOfficeKitInit.h included in multiple translation units. * Those that had been marked as inline lacked an external defintion in C. (Which 3f02b2aa51e32c46d5b6610480bc1ba22156a3ec "LOK init: avoid non-inline function definition in header file" had apparently faied to take into account.) (IOS_SWIFTCBRIDGE introduced in 028ef4748e53aa8f72c6464ce6bbeeb28c61d30c "LibreOfficeKitInit.h modified to avoid ODR" becomes unnecessary again.) Change-Id: Ibb8033cdbac87b20fa0e3b203b99571c1a7e7234 Reviewed-on: https://gerrit.libreoffice.org/35491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-22vcl: move in PDF tokenizer from xmlsecurityMiklos Vajna11-3267/+3343
The PDF code in xmlsecurity served two purposes: - a generic PDF tokenizer - signature verification The first purpose is useful to have in VCL, so the PDF export code can use it as well when it comes to PDF image handling. This commit just moves most of the PDF code to VCL, it does not touch the PDF export code yet. With this, also the somewhat odd xmlsecurity dependency of CppunitTest_vcl_pdfexport can be removed as well. Change-Id: I6fe8294ed5c4aa4d79f4b2ddef80a4d1c9d566cc Reviewed-on: https://gerrit.libreoffice.org/35513 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-22update brows and printlayout iconsandreas kainz18-129/+266
Change-Id: Ia82936daeb5db8fb45e818e516bb37fb527d858d Reviewed-on: https://gerrit.libreoffice.org/35524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-22Comment clean-up that was inadvertently missing from previous commitStephan Bergmann1-3/+5
Change-Id: I5eb0758f84495a8410260f61ff645a086efb1ca7
2017-03-22Use nl_langinfo_l instead of setlocale+nl_langinfoStephan Bergmann1-20/+6
...as the former is less of an MT nightmare (nl_langinfo_l can only conflict with calls to nl_langinfo in other threads, not with calls to nl_langinfo_l in other threads, so since this was the last remaining use of nl_langinfo in LO itself after a7cdba3a0e48360e2ed549e9d8996fe41460df70 "Use nl_langinfo_l with an explicitly created locale" things should be safer now; also, setlocale was an MT problem, of course, inadequately atempted to be addressed with that aLocaleMutex). Hopefully, all relevant platforms that support nl_langinfo also support nl_langinfo_l (where both are POSIX). Change-Id: I28a18bc4ffa930e3f2e949634dae161377e2911c
2017-03-22Use nl_langinfo_l with an explicitly created localeStephan Bergmann2-26/+36
(where empty string arg to newlocale, per SUSv4, means "an implementation- defined native environment. This correspons to the value of the associated environment variables, LC_* and LANG") instead of relying on whatever setlocale would be in effect here. Also, nl_langinfo_l is less of an MT nightmare than nl_langinfo, which is of benefit once the last remaining use of nl_langinfo in sal/osl/unx/nlsupport.cxx will also have been changed to nl_langinfo_l. loplugin:nullptr needs a little hack, as SUSv4 locale_t could be anything from an integer type to a pointer type. Change-Id: Ic35dcbc2e0a4f650694b48df12470dd89476dff5
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin61-142/+175
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22create SfxDisableFlags enumNoel Grandin41-705/+712
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22starmath: Make DoSubSup() return SmNode by taking another nodeTakeshi Abe2-24/+25
as an argument, not from the top of the stack. Because no token belongs to groups TG::Limit and TG::Power at the same time, we can replace TokenInGroup() with direct comparison with each group. Change-Id: I44882ab40f59c4de1c0e2cbbdc354e43de926ab1 Reviewed-on: https://gerrit.libreoffice.org/35500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-21uitest: also accept child windows having focus for loggingMarkus Mohrhard1-3/+23
Change-Id: I6c09900aa95a01330b5bedf12f3e4a7a03e5a620 Reviewed-on: https://gerrit.libreoffice.org/35517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-21uitest: better support for listbox loggingMarkus Mohrhard2-0/+13
Change-Id: Ibd2625ba40cafdb07a2fcb5b2cfdd0e5f9e72b94 Reviewed-on: https://gerrit.libreoffice.org/35516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-21uitest: always start with a clean fileMarkus Mohrhard1-1/+1
Change-Id: I0ad8d63a2dda2da3c58a626ccf9d60085c1521d5 Reviewed-on: https://gerrit.libreoffice.org/35515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-21xmlsecurity: separate signature verification from PDF tokenizerMiklos Vajna5-13/+14
Signature verification code depends on sax and xmloff, but the rest of the PDF tokenizer could be otherwise moved down to lower layers without problems. Change-Id: Ieca57279e9517935821c1d34f217fd10548035ef Reviewed-on: https://gerrit.libreoffice.org/35512 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-21ios LibreOfficeLight iCloud supportjan Iversen8-40/+152
Added iCloud document support to fileManager Change-Id: I7c8f78b6b148926398b170ee8a32d3c09413205f Reviewed-on: https://gerrit.libreoffice.org/35503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@libreoffice.org>
2017-03-21tdf#105415 Use the system caret width on GTKColomban Wendling2-0/+12
Change-Id: I6b7fc9d06a49613cc6fe247b44c56f36935082fa Reviewed-on: https://gerrit.libreoffice.org/35282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-21comphelper:: fix MSVC hang in ThreadPool::shutdown(), try #2Michael Stahl2-11/+32
This takes a different approach than commit 9899ffd244dd367ba69dffe1f21f4f0222064a46. Change the ThreadPool to automatically shutdown and join all threads whenever waitUntilDone() is called. Then start the threads again in pushTask(). Because the ThreadPool is meant to be used synchronously with waitUntilDone() called after adding all required tasks, this should obviate the need to call shutdown() before process exit, as there won't be any threads running at that point. Change-Id: I2b8e639004a94cf05ccb4522aa1f0d3dac88a936 Reviewed-on: https://gerrit.libreoffice.org/35510 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-21Notebookbar: multiple context containers supportSzymon Kłos2-4/+23
Possibility to add multiple context containers. Each container should have name "ContextContainer" or "ContextContainerX" where X >= 1 Change-Id: Ie689ebde624f766b11d96370d6b108018f9130c9 Reviewed-on: https://gerrit.libreoffice.org/35506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-21Argument to parse_locale is never nullStephan Bergmann1-39/+35
Change-Id: I610d3637f4a4520ef4eefed29851727f519de02c
2017-03-21On Linux etc., obtain locale value from env vars instead of setlocaleStephan Bergmann1-16/+11
setlocale has the drawbacks that it is racy and that it sets global state, so better avoid it. The way LC_ALL, LC_CTYPE, LANG are honoured is as suggested by SUSv4, then falling back to "C". Change-Id: I606ecc01d37a0a9067a90e6dcce098009094493c
2017-03-21Just include rtl/locale.hStephan Bergmann1-3/+1
Change-Id: Ida509af3632bf6dccc139c770bd3cbdee7b71fca
2017-03-21Mark rtl_locale_get/setDefault as deprecatedStephan Bergmann1-10/+9
unused in LO itself since 73bda5058bcef6be9a3185aa46375c7b147ffa22 "ditched rtl::OLocale" Change-Id: I6fd713f4771d7a7a397ef08002d1b9d754417f67
2017-03-21sw: those should be assertsMichael Stahl1-2/+2
Change-Id: I2785b1d98307a19666ad3aabf3bbaff19a9d0a6e
2017-03-21tdf#96505 - Get rid of cargo cult long integer literalsudaycoder3-3/+3
Change-Id: I56fbc7cd9c879b18ac65c5e6adf80f01c6b95b84 Reviewed-on: https://gerrit.libreoffice.org/35176 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-03-21Bin noise commentTor Lillqvist1-1/+1
Change-Id: I7367d494143901c9b78349682f07cc292d1d64ea
2017-03-21Make PDFDocument::ReadKeyword work at end of fileStephan Bergmann1-1/+3
If the first ReadChar fails due to EOF, ch would be used uninitialized. If the second ReadChar fails due to EOF, the SeekRel(-1) shouldn't be executed. Change-Id: Ibf99539a3a8880a77653bd7576721104f9782e36 Reviewed-on: https://gerrit.libreoffice.org/35504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-21tdf#96505 Get rid of cargo cult long integer literalsdilekuzulmez1-3/+3
Change-Id: I6bda2915547980b33d059257c8dbd65f181f9f16 Reviewed-on: https://gerrit.libreoffice.org/35291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-08 22:51:43 +0000