summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-11-18SwNavigator: Improve which entry is selected in the content treeJim Raykowski1-85/+111
after the tree is updated and when current document cursor position is at content that is set to not track Intended behavior when the content tree display is updated is for the selected entry before update to be reselected after update if the entry is still in the tree. Currently, if the selected entry before update is a content type, the selected entry after update is the first entry in the tree. If the selected entry before update is not present, e.g. the selected entry is the only member of a content type and is deleted, the first entry in the tree is selected. In these cases, this patch changes the selected entry after update to be the content type entry. Instead of reselecting by entry name, which can result in incorrect selection when non unique entry names are possible, as in Headings, this patch improves entry reselect by comparing unique entry user data. Content tracking is improved by not falling through to other tracked content, e.g. when tables are not being tracked and sections are being tracked, clicking in a table in a section will not select the section in the content tree, the selected entry in the content tree will be unchanged. Change-Id: I8d82059db8688c31c7c0d705445c1d8b4272bec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125176 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-11-17uitest: sw: I don't think this time.sleep is neededXisco Fauli1-3/+0
Change-Id: Ic3f5ebb8e41a7f392385e01c9d7f0f89810ca194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125399 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17uitest: sc: remove sleepXisco Fauli1-5/+0
Change-Id: Id1f3eb0ce1dbf9409ef005a01b2fe3bb1e453ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125400 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17tdf#145731: fix crash closing documentJulien Nabet1-1/+1
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=73334560b2dd2d60ac58d2cc2b1a5295490b03e1 author Julien Nabet <serval2412@yahoo.fr> 2021-11-07 15:40:37 +0100 committer Julien Nabet <serval2412@yahoo.fr> 2021-11-07 21:58:53 +0100 commit 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch) tree b5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e parent 6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff) Replace some macros in forms part 16 Thank you Xisco for having spotted it! Change-Id: Ie0eb2a7e0e9f4c4fc12b83a233553a8713d6a6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125420 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-17sc: Drop 'typedef std::vector<ScMarkArray> MapType'Michael Weghorn1-2/+1
Its only use is in the next line, and it's not even a map anymore, but a vector. Change-Id: Ib7920c420f5e3e18658f3530244097a4b1633951 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125411 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-11-17vcl: split GetGradientSteps() into Get{Complex|Linear}GradientSteps()Chris Sherlock2-12/+32
Change-Id: Ieb0d5d6f1a7c9fff3671ef74ffac9eaf37dcb0e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123060 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-11-17use ListBoxPreview size for the color shown in autofilter color listCaolán McNamara2-3/+9
it's used for a similar case in the color button, GetToolbarIconSizePixel is relatively narrow and we have a hectare of space available here. Draw a border around the color as we do for the similar color button case. Change-Id: If0b24a142d47038d02a977ed88281b2de0b529fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17weld colormenuCaolán McNamara5-25/+26
Change-Id: I6feef72cf924865e2407a96cdd0b6e60c835dbc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17allow menu placement either under or at endCaolán McNamara4-7/+38
Change-Id: Id76cbe69464f439eec900bf9b80b0c63d99b6597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17drop unused PopupMenuFlags::NoHorzPlacementCaolán McNamara3-12/+1
Change-Id: Ic279160f96e5aa2a37690f987c2323b91b2ec49c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125415 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17tdf#142420 color menu should be a child of the autofilter, not a siblingCaolán McNamara3-4/+16
which is why it doesn't appear at all under wayland. This should also get it positioned better rather than using a fixed pixel offset. Change-Id: I9a4193c27b4172469cea3d980c86cff9ca701ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125409 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17wrong function name in commentCaolán McNamara1-1/+1
Change-Id: I80f7f8cbf17bea0de770eb590ade6bbdb2fc7ac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17tdf#145721 sw track changes: sign text moving in redline tooltipsLászló Németh2-2/+10
Write "Moved (deletion)" and "Moved (insertion)" instead of "Deleted" and "Inserted" in tooltip of tracked text movings. Follow-up to commit f51fa7534421a195a58b4a737a2e836d8c25ba81 "tdf#145718 sw, DOCX import: complete tracked text moving" Change-Id: I5db3025ddb7b4758e3699c10971a765784555a20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125405 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-17tdf#145718 sw, DOCX import: complete tracked text movingLászló Németh13-17/+103
Add IsMoved bit to SwRangeRedline, and keep it in both parts of a split Delete/Insert redline. Set this bit during DOCX import, fixing incomplete import of moveFrom/moveTo elements. Details: - Search text moving only at redline Insert() and AppendRedline() instead in the layout code (which was much slower, because triggered by also mouse hovering): - detect text moving in Hide Changes mode, too; - Insertion inside or directly after tracked text moving keeps "moved text" layout of the original moved text parts (before and after the insertion). - at detection of text moving, invalidate (update) layout of the redline pair, too. - fix DOCX import: extend makeRedline() with property RedlineMoved to keep all moveFrom/moveTo stored in DOCX instead of losing them (joining them with normal redlines) in the case of missing Delete/Insert pair (see unit test document); Follow-up to commit ec577f566fa3e6d2666069180f8ec8474054aea9 "tdf#145233 sw track changes: show moved text in green color", commit bcdebc832b272662d28035007a4796e42d1305ae "tdf#104797 DOCX change tracking: handle moveFrom and moveTo" and commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be "tdf#123460 DOCX track changes: moveFrom completely". Change-Id: Iaca80e5e326a172bc7ba5fec64b63668b9378e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125317 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-17rename getSchemeName getSchemeIndex to remove ambiguitySarper Akdemir5-12/+12
[ Miklos: i.e. index could be a theme index or an index into a color set, this one is the later case. ] (cherry picked from commit aef22c3bbf1b4bb8ab9ba2bccb7005e0d0c75cb3, from the feature/themesupport2 branch) Conflicts: oox/source/drawingml/shape.cxx oox/source/drawingml/shape3dproperties.cxx Change-Id: I495e4b39975f1483607972ccbcc9348021710519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125414 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-17tdf#84012: sc_pdf_export: Add unittestXisco Fauli2-0/+43
Change-Id: Ibdbf9cff1afe63eb2263d54d23996efcee22337a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125412 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17CppunitTest_sw_uiwriter3: simplify test a bitXisco Fauli1-8/+3
Change-Id: I18a34239d2b62b698b145c9a29b0617dfbc79098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125408 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17tdf#143978: sc_pdf_export: Add unittestXisco Fauli3-0/+52
Exporting to PDF is the only way I could find to test this issue Change-Id: I05da96cadc2785d31a9a63925ee072456ec72a93 Change-Id: Ic31e1eb37f78451c4e34d91f9dd240716b94f973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125407 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17Use C++17 hex-exponent floating point literalsMike Kaganski1-5/+5
... instead of some calculated/hardcoded decimal literals. The new syntax represents the power of 2 exponent directly. Change-Id: I826bda6e06ec77f0706bb48abe2934f7289fddc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125359 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-17implement initial pptx theme color importSarper Akdemir4-0/+21
[ Miklos: this only handles colors as-is, without any effects. ] (cherry picked from commit ec68ca0b5fb6773f42600f6a5825b4794cdb0990, from the feature/themesupport2 branch) Change-Id: I89890cf7ba6ec758698011752b63d7a60872bef2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125404 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-17uitest: sc: use existing tests to test SetOptimalColumnWidth...Xisco Fauli3-7/+14
... and SetOptimalRowHeight dialogs Change-Id: Ibdee348d84a8b96d8f698e7fc6db89eb24422f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125392 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17tdf#137637: sd: Add UItestXisco Fauli1-0/+34
Change-Id: I5c0b3e85977b0e795a57e23dea0f7c8252777ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120652 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17tdf#144247: sc: Add UItestXisco Fauli2-14/+17
Change-Id: I0e05c9e13bda04ebbbef3f2cf99c86697de5a4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125382 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17tdf#144695 VendorBase::isValidArch also for macOSStephan Bergmann1-1/+3
Lets extend it only to macOS (where there is some confusion now with Rosetta- translated vs. native processes on Apple M1 machines), not to all Unix-like OSs: The comment that it "is not defined what the exact [os.arch] values are" is still relevant. At least for OpenJDK, while Windows has a hardcoded list of possible values in GetJavaProperties at <https://github.com/openjdk/jdk/blob/9604ee82690f89320614b37bfef4178abc869777/src/java.base/windows/native/libjava/java_props_md.c#L568>, the corresponding non-Windows code in GetJavaProperties at <https://github.com/openjdk/jdk/blob/319a3b994703aac84df7bcde272adfcb3cdbbbf0/jdk/src/solaris/native/java/lang/java_props_md.c#L175> uses ARCHPROPNAME which, via > -DARCHPROPNAME='"$(OPENJDK_TARGET_CPU_OSARCH)"' at <https://github.com/openjdk/jdk/blob/c363db8ed00ff27eadf06294364d908d6a7d03a6/jdk/makefiles/CompileNativeLibraries.gmk#L185>, appears to somehow come out of Autoconf at <https://github.com/openjdk/jdk/blob/228c21635b011fbf956b83a0b07fc297e9a34c46/common/autoconf/spec.gmk.in#L93>, so probably can show some variance in actual values being used. Change-Id: I16725cd9365f6bd034372c653aa43ab84d487b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125401 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-17Qt resolve native winId() on demandJan-Marek Glogowski3-4/+9
As for gtk3 in commit ac9789dbb36f45dcc1caf7dd2951353b1574c8ea ("tdf#139609 avoid fetching unnecessary xid under gtk3"). Change-Id: I82b2c22437e5ab957706c25fcc118b28abb07242 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125395 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2021-11-17Qt refactor SystemEnvData setupJan-Marek Glogowski3-50/+27
Change-Id: I900d1079c9a832a9b5170e58ce4e7a8b81d7d01b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125393 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2021-11-17update creditsChristian Lohmaier1-2056/+2076
Change-Id: I0012889f2018c40479bd22c9d34848a6e70ee041
2021-11-17Don't fail jfw_findAllJREs for just one JRE of WrongArchStephan Bergmann1-0/+2
...otherwise if one such JRE had found its way into a user's configuration, "Tools - Options... - LibreOffice - Advanced" would no longer show *any* JREs. Regression introduced with 9143dd4ebe37b608e43d04434cf831624bf55b65 "Related tdf#54443 List only matching JREs", which added WrongArch to the javaPluginError enum. Change-Id: I51fd47e585c6686be7a9282615c0978e4f6c460b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125396 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-17expose the SvxColorItem theme related uno for draw/impressSarper Akdemir4-2/+10
[ Miklos: added the missing SvxShapeControlPropertyMapping entries, breaking tests. ] (cherry picked from commit 88b6801ff2aa61ed2f0d64cef94fe6a9c09f3a35, from the feature/themesupport2 branch) Change-Id: Ifdcde6c4643eb9ac1c36040f5ccb490b9d900efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125394 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-17uitest: sw: Use execute_dialog_through_command and remove sleepsXisco Fauli1-14/+8
Change-Id: I5b14248bedc595092729c2c36cefb936ca9d33f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125397 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-17support ccache for MSVC tooLuboš Luňák16-61/+234
There's no official MSVC support in ccache yet, but there are patches in progress of getting upstreamed. So right now it's necessary to get a patched ccache. Ccache cannot work with -Zi option, since sharing debuginfo in a .PDB cannot be cached. Added --enable-z7-symbols that gets enabled by default if ccache is detected. It works even with PCHs enabled, and externals seem to work too. I get almost 100% hit rate on a rebuild, although such a rebuild is slower than on Linux. Change-Id: I1d230ee1fccc441b9d9bec794cc2e1ec13161999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125179 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17SCSTR_FILTER_TEXT_COLOR is used in two different contextsCaolán McNamara3-52/+58
in the autofilter popup and the standard filter combobox. In the autofilter we want title case to match the other entries there, for the standard filter we need the same text as appears in the combobox list Change-Id: I693d3fa8a9fa1bac0803971be593f107d5817e74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17ofz#41081 divide by zeroCaolán McNamara1-2/+2
and ofz#41088 divide by zero Change-Id: Ic545271709257fe5f676446e82b9638b84867195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17stop vclcanvas from ruining alpha of bitmaps in Skia modeLuboš Luňák1-2/+3
According to the comment and tdf#45219 vclcanvas deliberately forces alpha to be 1bpp because of poor performance. But that's not the case with Skia, alpha is always 8bpp there, so all the hack does it make animations look ugly and it also breaks caching capabilities of the Skia backend because the hack always generates a new bitmap. I don't know which VCL backend the original problem was related to, so at least disable the hack for Skia. Change-Id: I8a90c32dbe911cb79b617c0c447f3e9ced05f746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125373 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17Skia dumping is no longer dbgutil-onlyLuboš Luňák1-2/+0
This is a mistake from f33b76b4e675818deae244427cef84c576a1a1f8. Change-Id: Iae69ae0099a62451d156c80255f55b1f6aad4725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125370 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17disable split debug if --enable-ltoLuboš Luňák1-2/+10
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88389 is right that split-debug doesn't make sense with LTO. Without -ffat-lto-objects or with Clang .o files aren't even really object files that would be normally usable. Since gcc complains if the combination is used, explicitly avoid it. Change-Id: I76992e94f4790238e5aaee691b5cec54fd0ef3a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125379 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17use title case for "No Fill" like "Not Empty"Caolán McNamara1-1/+1
Change-Id: If044b8de9a5400b6db61537519afcf5f18dd1cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17crashtesting: crash on passing null to std::string_viewCaolán McNamara2-0/+31
with many documents, e.g. moz377878-1.xhtml https: //gitlab.com/orcus/orcus/-/merge_requests/113 Change-Id: I085543ebb28c02a1c0ec487b357f6e0a83004363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125378 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17don't attempt to set cursor to first entry if there are no entriesCaolán McNamara1-2/+5
avoids gtk warning of: gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL Change-Id: Ie2c22a02d795591600a7f6da2e11741ba084a81f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17make colorsets work outside of styles and with direct formattingSarper Akdemir4-0/+94
[ Miklos: picked only the document model bits, now in SdrModel, next to styles. ] (cherry picked from commit 1647d34d8573f4940c0cbb7fb6cd9c6b4e5a4a15, from the feature/themesupport2 branch) Change-Id: I80f9e0b205b8b4a6914f851bdc63e3e0ca6706e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125313 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-17retire loplugin:simplifyboolLuboš Luňák4-178/+1
The plugin was originally written to rewrite dumb old OOo code like 'variable != 1 ? true : false'. All that code has already been rewritten, and now this plugin just enforces matter-of-taste stylistics on new code. Change-Id: I8cd2accd7c0ac365b75dcba51a9049bf9e293869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125346 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17remove loplugin:finalprotectedLuboš Luňák4-37/+1
It just forces a custom rule that serves no real purpose. There's no technical difference. If one day a class gets inherited from then this information will be lost/incorrect. And mixing access on a virtual function is poor style. Change-Id: I0c27db8d694ad191a118d4e1d3d4a240e00456fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125337 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17fix system pch breaking after f22e5078cfac93c50ae5169f6545091Luboš Luňák1-0/+1
Change-Id: Ie7f63b52b77e821b92fcf6b09af6c8bf43ca9e9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125377 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17Remove newly redundant breakStephan Bergmann1-1/+0
...after 0047e38da8bdfe09360cc2a658283ad5e18986e7 "svtools: HTMLParser: don't insert EOF into strings" Change-Id: Ib7d47030f215504a86bbfc10d9c35b5a19a7314b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125375 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-17loplugin:stringliteraldefine in avmediaNoel Grandin4-15/+14
Change-Id: Ie34a45a745ac9546208444b2e499b581e18d449f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 890b11c7e389bff4b177beaf79461a6d6cc8ba1c - Add Development Tools icon to Help page Change-Id: I619e94f6c9c58285781cd6635398b4a807d20f55 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125335 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-11-17Fix the calculated constantMike Kaganski1-1/+1
rtl::math::isValidArcArg's comment talks about 2^64 = 1.844e19; but the calculation resulted in 2^63. Unfortunately we can't use C++17 hex-exponent notation in published API header. Change-Id: I1dd6e754431ad028982623ff5de4c6329fd6c2ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125348 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-17fix SkiaTest::testDrawDelayedScaleImage() with GPU+HiDPILuboš Luňák1-0/+2
Change-Id: I0bdaf2679f1f20f6ba0c28641cd8cc6756e4316b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125369 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17avoid a PCH build failing because of a directory missingLuboš Luňák1-2/+4
Change-Id: I3ff3c255d5707b6a802940bc4d96e1a729f1fcc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-17tdf#143971 Removes pop-up dialog for read-only documentsMatt K12-246/+1
No longer does the user get a pop-up dialog when opening documents that are read-only, asking whether they want to be notified when the document becomes editable. The change removes some of the functionality introduced in commit 95eb088802562b75f8b299908160145c7e88d763 "tdf#47065 Add new file open UI options and implement a new thread". Change-Id: Ic25e8e293e7224fb5086249a9d4814914fa961d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125340 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 18:06:58 +0000