summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-10-23Resolves: tdf#113336 avoid crash during teardownCaolán McNamara1-3/+7
Change-Id: Icdebd5aca1a2bdaefb904d153ca97a6cc56ac7ff Reviewed-on: https://gerrit.libreoffice.org/43719 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-23tdf#110431: Fixed losing listbos entries on opening .ods fileMohammed Abdul Azeem4-1/+28
For some reason, XML_TOKEN_INVALID was taking wrong value in windows, causing to fail imports with unknown entries. I've also added some of the tokens I found from several test files to the list. Change-Id: Idd2e7db165b9b4b5a2d8c7a837786fde252fe938 Reviewed-on: https://gerrit.libreoffice.org/43677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 931c84e697dc69745d1c07c40f810638f9f71eda) Reviewed-on: https://gerrit.libreoffice.org/43710
2017-10-22Resolves: tdf#113179 merge language attributes early, tdf#108795 follow-upEike Rathke3-13/+20
Merging attributes from table to top EditEngine has to be done before colorizing with the range finder, as the resulting merged default item set *overwrites* the items set. Change-Id: I6561201de11344161f61d7d4cf6a7b79d76ba493 (cherry picked from commit 8112af3361fdf15fcf5d3177cd967e1d8d97d5f3) Reviewed-on: https://gerrit.libreoffice.org/43572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-21tdf#113225 - hold the solar mutex when entering from UNO.Michael Meeks1-0/+1
http://crashreport.libreoffice.org/stats/crash_details/dff57662-1693-47f6-8b09-88f180d2e706 Change-Id: I4322c2113c300af97fb5854aac4a741b7027e6b1 Reviewed-on: https://gerrit.libreoffice.org/43623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 254c49dcceaa8b181b2cb3338e34e5637be277b9) Reviewed-on: https://gerrit.libreoffice.org/43636 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-20Resolves: tdf#113253 graphics change shape after ppt roundtripCaolán McNamara1-1/+1
Change-Id: I8e7520c206e909c016298f76fcd5083c98184dc4 Reviewed-on: https://gerrit.libreoffice.org/43610 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-20tdf#112633 oox: Save backup images to proper path in documentJacobo Aragunde Pérez3-4/+40
Artistic effects on bitmap images in OOXML files create a backup file with the original image. These were not being saved into the proper path for PPTX files because the `/word` directory was hardcoded in the export code. The path saved to the relations file was incorrect too because it was not taking into account that the relations file is saved to a subdir in PPTX and XLSX documents. Finally, added a unit test. Reviewed-on: https://gerrit.libreoffice.org/43338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 55641f5572f3168c09e096eb89ca563652889758) Change-Id: I3e880ce763dc10dbc86ccf0e00871be5d36f6d88 Reviewed-on: https://gerrit.libreoffice.org/43600 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-20tdf#97630 xmloff: ODF extended draw:fit-to-size messMichael Stahl7-11/+900
The plan: 1. As Regina points out, there is already (in ODF 1.2, but not ODF 1.1) a style:shrink-to-fit attribute for shapes, so use this to represent the AUTOFIT value. The fallback from AUTOFIT to draw:fit-to-size="true" was a stupid idea anyway, probably "false" is less annoying in practice. There are 2 different shapes that implement TextFitToSize property: a) text shapes already interpret ALLLINES and PROPORTIONAL exactly the same b) fontwork custom shapes interpret ALLLINES but do nothing for PROPORTIONAL As Regina points out, there is no shape that needs to distinguish between ALLLINES and PROPORTIONAL, so we do a minor behavioral API CHANGE and from now on interpret PROPORTIONAL as ALLLINES on fontwork custom shapes. This obviates the need to distinguish the values in ODF and so we don't need a new attribute, just use draw:fit-to-size="true" for both. On import, use MID_FLAG_MERGE_PROPERTY to combine the 2 attributes into one value. 2. Restrict the export of draw:fit-to-size to only the standard values "true"/"false". This implements step 1, the step 2 will be done in the future when most users have the import of the style:shrink-to-fit. Change-Id: I4a378aa110fdb82db7a99a839d7ff207248a73e7 Reviewed-on: https://gerrit.libreoffice.org/43521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 33eb9fdb61033b3fd35d923900b1f5791f4b71c8) Reviewed-on: https://gerrit.libreoffice.org/43595 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-20Resolves: tdf#113230 crash in finishParagraphCaolán McNamara1-1/+4
Change-Id: I94535a51a87be097ff7356edff935877b42c3272 Reviewed-on: https://gerrit.libreoffice.org/43599 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-20potential deref of empty xStateSetCaolán McNamara1-1/+1
Change-Id: I83d876b0d966b18cdf85249b7e856e4e4f4dec27 Reviewed-on: https://gerrit.libreoffice.org/43488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 811e636d920ee96e7ebd120b3931cb3da43d0143) Reviewed-on: https://gerrit.libreoffice.org/43548 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-20Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, tooStephan Bergmann1-1/+1
> Oct 20 10:21:31 <sberg> erAck, when "Testing > file:///run/build/libreoffice/sc/qa/unit/data/functions/array/fods/linest.fods" > in CppunitTest_sc_array_functions_test fails with non-informative expected 1 > vs. actual 0, how can I reasonably debug that? (and no, I don't have an X11 > connection to the relevant machine, to see what opening that .fods with LO > would look like there) > Oct 20 10:25:04 <erAck> sberg: sigh.. we're still lacking an "analyze steps" > in the functions test loader, so far only loading the doc and inspecting > provides that; maybe getting individual cell results via UNO would work So disable these tests for aarch64 for now too, to get Flathub builds unstuck, until somebody finds a way to actually debug this. Change-Id: I9bf30d0d7185497f9ad4b04b60b6a67f34a8c44e (cherry picked from commit 6cb20e0b298f41fe88984aebfe5454f936a0ae3a) Reviewed-on: https://gerrit.libreoffice.org/43590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-20Resolves: tdf#113214 change back to previous entry after 'more' is dispatcherCaolán McNamara1-0/+2
Change-Id: Ic5bd5f9182e47c6dfdab8fcd6399ffc482a4fb6a Reviewed-on: https://gerrit.libreoffice.org/43512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7ff293f2d2793b30f30d2f499b332e5329d4ddb4) Reviewed-on: https://gerrit.libreoffice.org/43517 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-19gpg4libre fix tdf#113190 don't show expired/invalid keysThorsten Behrens1-1/+1
Change-Id: I30485bc97d3d287bd867b50398927eabe018914b Reviewed-on: https://gerrit.libreoffice.org/43502 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 087a90e27b7219e8c1aaa880b39376c94a0dcaae) Reviewed-on: https://gerrit.libreoffice.org/43503 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19Again, no -fstack-protector-strong for gcc3_linux_aarch64/cpp2uno.cxxStephan Bergmann1-3/+2
8d12e4ec8b843d59661a12a7a92bfec7e4473e0f "No -fstack-protect-strong for gcc3_linux_aarch64/cpp2uno.cxx vtableSlotCall" had done that in the past (so that setting up the x0/x1 return registers in vtableSlotCall is not clobbered by the stack protector code), but gbuild details have apparently changed in the meantime, so that gb_CXXFLAGS_COMMON's -fstack-protector-strong now ends up on the compiler command line before what is covered by gb_Library_add_cxxobjects's argument, so didn't get subst'ed to -fstack-protector. That caused Flathub aarch64 builds to fail in CustomTarget_testtools/uno_test. However, if both -fstack-protector-strong and -fstack-protector are present on the command line, the second apparently wins, so use that hack for now. (-fstack-protector-strong is only available since GCC 4.9, but -fstack-protector is already available in our current baseline GCC 4.8.1, and even for a build on that baseline it wouldn't hurt if cpp2uno.cxx was explicitly built with -fstack-protector even if none of the other files were built with -fstack-protector-strong.) Change-Id: I9d78d2e5b08b7c0a4adb1531b482cd43617886f7 (cherry picked from commit dddb527db1562f30a2a2b20338dfc8458086a4a9) Reviewed-on: https://gerrit.libreoffice.org/43564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-19Resolves: tdf#109282: a11y crash in use after disposeCaolán McNamara1-2/+4
calc, chart in tab 3 with a11y enabled, select chart switch to tab 1, crash cause mpParent has been deleted, IsDisposed is correctly set, but shape accesses parent anyway Change-Id: I6f57a798bfcc82eebb883291cec54e157ff5187b Reviewed-on: https://gerrit.libreoffice.org/43490 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-19Avoid throwing C++ exception across libjpeg C framesStephan Bergmann1-286/+321
It causes trouble at least for (non-debug) 32-bit ARM Flatpak builds, where CppunitTest_vcl_filters_test aborts with an uncaught css::uno::RuntimeException. This is a partial revert of 6889fa826eef6bd1074d77507818e71dfe8ba152 "rework jpeg error handling to throw rather than setjmp to avoid leaks", switching back to setjmp/longjmp but trying to keep the leaks fixed by introducing any relevant local variables before the setjmps. Change-Id: Ia5984528ea98be1c89a21aee800b247120f88a89 Reviewed-on: https://gerrit.libreoffice.org/43494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit cfbb8b5090537e79ba70e250ddee86d53facbe15) Reviewed-on: https://gerrit.libreoffice.org/43534 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-19tdf#99537 set expand for re-used sidebar panelsJan-Marek Glogowski1-0/+1
When re-using a panel, reset the expand state from the stored state in the PanelContexDescriptor. Change-Id: I00851982bbd36cacdc57459bb6e5be9fcc719e81 Reviewed-on: https://gerrit.libreoffice.org/43466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ce2e94a98f5fc85bef7623a0227b3a95d8093288) Reviewed-on: https://gerrit.libreoffice.org/43481 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-18tdf#112808 Disable "Edit Region" command while cursor in an index.Gulsah Kose1-1/+5
Change-Id: Icefa1e42831ad0ba7a9f5346545adac0033ce3e0 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/43456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit e149c4f3dcd08b9331dbbecf31c200d4d3bb02b5) Reviewed-on: https://gerrit.libreoffice.org/43511 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18tdf#104079 RTF import: fix handling fields inside TOC fieldsMiklos Vajna3-1/+66
The marker trick is not needed for these, but the paragraph margins are lost when using it, so avoid it. (cherry picked from commit 6ee33d0772f991f04e97b5b61d7b11810a1b8ac0) Conflicts: writerfilter/source/dmapper/DomainMapper_Impl.cxx Change-Id: I3fc9644cb85138b5473cb1478196ae8538041fb1 Reviewed-on: https://gerrit.libreoffice.org/43501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17bump product version to 5.4.4.0.0+Christian Lohmaier1-1/+1
Change-Id: I6be9e0d2b48860ef85898bf5a346595680ec68e0
2017-10-17tdf#112211 RTF import: fix unwanted direct formatting for other indentsMiklos Vajna3-6/+52
Commit 56a695fddb915bcba13b088b5b2b4e0841d4acbc (tdf#112211 RTF import: fix unwanted direct formatting for left indents, 2017-09-26) fixed left indents, and given that it was a regression fix, left the other indent types untouched. As it has been pointed out in the bug comment, the original bugdoc actually needs the other indent types removed as well, so let's do that. (cherry picked from commit 295cf49b81b8c008ec0ea2c92f7cf729d5523d4e) Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Change-Id: Ia4ea7e2214b7df27536f46b046f90bd703c107be Reviewed-on: https://gerrit.libreoffice.org/43448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-10-17Different take on tdf#108406: exclude helpimg from installed themesKatarina Behrens2-4/+6
as it still might get selected as default theme under some circumstances and removing it from list in optgdlg.cxx leads to crash This reverts commit 60adba3fb904ed66251ff39c82fe20bec151ef0b but allegedly still crashes on Debian Change-Id: Ib853cc27058d8635482f19a8db26075d64103e1b Reviewed-on: https://gerrit.libreoffice.org/42545 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7e7b9652f44f01fbaf5bc3fde454ba41ce0fe0f7) Reviewed-on: https://gerrit.libreoffice.org/42753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-10-17Updated coreChristian Lohmaier1-0/+0
Project: translations 5bc9e1c1f97f63df77052cb0a982120d75b70a75 update translations for 5.4.3 rc1 and force-fix errors using pocheck Change-Id: I17bb4ceda1007682990cd3313c103d53a7b09dc9
2017-10-17ofz: returning SfxPoolItem belonging to localCaolán McNamara2-3/+4
Change-Id: Ib9760efb1231ef057dfd62d06095c15e3bf73a87 Reviewed-on: https://gerrit.libreoffice.org/43426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-17Resolves: rhbz#1471983 fatal exception on older config without slide bg panelCaolán McNamara1-4/+7
Change-Id: Id437bdd8feac06da42c180ff4f7759ec282fa8d4 Reviewed-on: https://gerrit.libreoffice.org/43280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-17Resolves: tdf#112933 correct number of one decimal in fraction of secondsEike Rathke1-22/+16
Regression from commit 0ac1e2ad19d4fdb46dcf54f67db2df081f4675bb Date: Wed Aug 2 09:39:43 2017 +0100 Resolves: ofz#2833 null deref and similar for date+time commit 42b894f80a6d0c39bb0f7092eb204a15c22c4f38 Date: Sat Aug 5 19:15:36 2017 +0100 ofz#2867 null deref Effectively revert the code changes of those, leaving the test case files intact, and "do the right thing" (switching two lines, to nPos = nPos + sStrArray[i].getLength(); i++; nPos actually had always to be incremented by the length of the *current* string position but was used after only as an error position indicator, meaningless if there was no error. (cherry picked from commit 4f72d2ec6c210232e0abd4965e215611e807c125) Conflicts: svl/source/numbers/zforscan.cxx Backported. Change-Id: I9bc4e5e56d70a275d26df0b72ed6a19e9297e0fa Reviewed-on: https://gerrit.libreoffice.org/43440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-16Resolves: tdf#112780 no ResetDirty() after SetHybridEmptyDisplayedAsString()Eike Rathke1-1/+6
Change-Id: Idea5c1bd8e8577eaf90fc47d39f88c79963c422b (cherry picked from commit df778416981ab02d42182e5c2e46dc09ba2e2a3c) Reviewed-on: https://gerrit.libreoffice.org/43047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-16tdf#113052 needs mpUIBuilder to load breaklistmenuJan-Marek Glogowski1-3/+3
The mpUIBuilder object is also used in the else branch, so move the creation in the outer scope. Change-Id: I18211bbe3c6f85cdd7697225159a98ad672a4ce2 (cherry picked from commit 7f7ed0260ab7e08401f0129cde312cd8aa0fbddf) Reviewed-on: https://gerrit.libreoffice.org/43330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-14tdf#107605: Fix reading version 0 OS/2 font tableKhaled Hosny1-2/+2
The version 0 table os exactly 78 bytes since it does not have any of the extra fields from the later versions. Change-Id: Ie2e478bdefb201b988dc0844240d4ff193d66583 Reviewed-on: https://gerrit.libreoffice.org/43375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-13i18n-perf: cache map of breakiterators, tdf#108703Eike Rathke2-69/+193
This is a combination of 2 commits. i18n-perf: cache map of breakiterators, tdf#108703 See source code comment. Reviewed-on: https://gerrit.libreoffice.org/42866 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0f6b9eca2007629e61d3ab9cdf2a616a33cbdefe) Conflicts: i18npool/inc/breakiterator_unicode.hxx i18npool/source/breakiterator/breakiterator_unicode.cxx Backported. Throw exception also in case an unexpected rBreakType was passed (cherry picked from commit f6990d3f61b37e15d0320ef60d2d66535fadddc0) 331e12ab5115401b9fa87e1f0f2be51f33ccbc75 Change-Id: I75015f3492a24f5f69a163dca165dcf57d6f0e28 Reviewed-on: https://gerrit.libreoffice.org/42906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-08Updated coreLior Kaplan1-0/+0
Project: dictionaries 892f74a64037216393f34e543ded93e0ed16eea7 Fix typo in Croatian dictionary (ver 2.1) Thanks to Claudio Bley for noticing the issue. Change-Id: I8bc521dc38e7980f845002d30ee8a671fed9b648 Reviewed-on: https://gerrit.libreoffice.org/43242 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a2a91e4bb5a5b5247afaaecf0c928e9f7025ecbd) Reviewed-on: https://gerrit.libreoffice.org/43261
2017-10-08tdf#112947: fix write to free'd memory (odbc)Julien Nabet1-0/+1
suggested by Nick Gorham Change-Id: I3579caf5192df6e460dea3a5b3728196d75a65f4 Reviewed-on: https://gerrit.libreoffice.org/43234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/43236 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-07tdf#99689 allow Subscript in Illustration Index...Tamas Bunth1-5/+10
... and Index of Tables. Change-Id: I5a677f431d1a2e3836bcacdd382708b0ce397faf Reviewed-on: https://gerrit.libreoffice.org/42481 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/43212 Tested-by: Jenkins <ci@libreoffice.org>
2017-10-06crashtesting: crash on import of abi3007-4.rtfCaolán McNamara1-6/+9
which started happending at... commit 56a695fddb915bcba13b088b5b2b4e0841d4acbc Date: Tue Sep 26 09:13:05 2017 +0200 tdf#112211 RTF import: fix unwanted direct formatting for left indents Change-Id: Id3e8c4452238b48495b1014eff14cdaddcb047ab Reviewed-on: https://gerrit.libreoffice.org/43172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ca95e886b42157d1d6394ed0b4c910978f5c2fda) Reviewed-on: https://gerrit.libreoffice.org/43178 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-05tdf#98315 Function Wizard showing Breeze icons when in Sifr themeMatthias Freund3-0/+3
Adding the missing link X Change-Id: I5bffa19beaf1e8d4bc06c351e6f32c509c375609 Reviewed-on: https://gerrit.libreoffice.org/43101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-05Resolves: tdf#112827 gtk3 menubar not RTL under RTL localesCaolán McNamara1-4/+1
(cherry picked from commit addd1c34502b959e329354d73808c222986d4b74) Signed-off-by: Lior Kaplan <kaplanlior@gmail.com> Change-Id: Iab4a2980483eb3cd31f8722bd8e5d4eb68b06716 Reviewed-on: https://gerrit.libreoffice.org/43147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-04tdf#112486 Do not force GDI in no OpenGLXisco Fauli1-1/+1
See: http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html Change-Id: I19bb4b58d2260fd23c32a687a9f504540c229985 Reviewed-on: https://gerrit.libreoffice.org/42898 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 5440837e02dee8bc884e02be697bfd4def621d26) Reviewed-on: https://gerrit.libreoffice.org/43109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-04tdf#107605: Fix line height cslculation for broken fontsKhaled Hosny1-5/+9
Change-Id: I06368dd15d7898dda61bc07b0f96bf82b00733b9 Reviewed-on: https://gerrit.libreoffice.org/43095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 9bc39be417a4c436cbe18391fc87e5e835551b07) Reviewed-on: https://gerrit.libreoffice.org/43108 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-04tdf#112292: Revert "use rtl::Reference in SwDocFac"Noel Grandin3-68/+72
This reverts commit a754294ac7a902fe96fbbd6b8b6824a360d6b248 which caused the memory leak reported. Master will be fixed by a different approach. Change-Id: I6a87006109d4eb69ec40aea57ab2e83dcdeb2f8b Reviewed-on: https://gerrit.libreoffice.org/43128 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04tdf#112507 RTF import: fix too narrow table cellMiklos Vajna3-7/+57
Commit e6ec0794858df1444f43659b568119bf126a90e6 (tdf#104937 RTF import: \trwWidthA is an absolute value, 2017-08-29) changed the handling of the fake empty cell at the end of table rows so that the parameter of the control word is an absolute, not a relative value. Turns out this wasn't correct, the DOCX equivalent of that bugdoc shows that the parameter is a relative value after all. The RTF spec also talks about a "width", which is assumed to be a relative value. So fix that bug in a different way again (by making sure that this additional fake cell contributes to the total width of the table, so column separators are counted correctly), this time without less side-effects. (cherry picked from commit 409c230ed70707eeb5e6fcd4ab904bb4a411608a) Change-Id: Ic64fd3a6abae8e0398e8e77123f0473d73f0c4b0 Reviewed-on: https://gerrit.libreoffice.org/43080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-04tdf#112836 master view, bottom areas are wrongly positionedNoel Grandin1-1/+1
Bug was introduced in commit 12b2803f196b897ffb901b0eebe271c5ee43d03e "drop unused PRESOBJ_IMAGE" Change-Id: I50be74b505a674439bd8b67545b89a9660a85a33 Reviewed-on: https://gerrit.libreoffice.org/43062 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d352dda3dbfc9e26b7f80746e1502f3cb4cd45c1) Reviewed-on: https://gerrit.libreoffice.org/43066 Tested-by: Jenkins <ci@libreoffice.org>
2017-10-03Resolves: tdf#112656 don't reset to default font if a custom font was setCaolán McNamara1-5/+2
the list has been laid out with the smaller custom font, including calculating the bounding box of the entry, then rendered with the default larger font Change-Id: I2ae569c9857d4e1016cbf55da4c3334c63dcf5f6 Reviewed-on: https://gerrit.libreoffice.org/42910 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3043863d688c5bbd5101ebd5ddd8a9452e05ca50) Reviewed-on: https://gerrit.libreoffice.org/43031 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-03tdf#112732 sw: fix conditions in SwContentTree::ExecCommand()Michael Stahl1-6/+6
It has to be checked first that it's a CTYPE_CNT because otherwise it's not a SwOutlineContent. The assertion also didn't match the actual requirement. Change-Id: I7fc3a6410f5de1e6b4c18965fff9bd9700562ed1 (cherry picked from commit 8b2619177c16058ae9994d5e39f04a813bacd061) Reviewed-on: https://gerrit.libreoffice.org/42954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-03tdf#91106 sfx2: Stylist: sort top-level styles in hierarchical modeMichael Stahl1-0/+6
(regression from 8f04b172c5c78fa80c3692a729f0191425195869) Change-Id: I111d12a622390afc02eb73a42b1d3c714f046bd2 (cherry picked from commit 41af2a9e26f3ee6b505b343120d5df3617ba5c49) Reviewed-on: https://gerrit.libreoffice.org/42952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-03Resolves: tdf#112680 start color picker with currently selected colorCaolán McNamara3-5/+5
Change-Id: I939a0b88646b4654337505e985cceff883f09343 Reviewed-on: https://gerrit.libreoffice.org/42922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-03gdb pretty-printers: fix StringPrinterHelper for gdb 8.0Michael Stahl2-5/+5
Latest gdb release "lazy_string" validates the array size: Traceback (most recent call last): File "/work/lo/master/solenv/gdb/libreoffice/util/string.py", line 29, in to_string return self.make_string(data, self.encoding, len) File "/work/lo/master/solenv/gdb/libreoffice/util/string.py", line 66, in make_string return data.lazy_string(encoding, length) gdb.error: Length is larger than array size. rtl_uString has "sal_Unicode buffer[1];", which is a lie as the real size is the same as "length". Taking the address of "buffer" appears to avoid the exception. Change-Id: I85710b1adfae584ba09c8d517e9b49b290e79d8a (cherry picked from commit 205677c88cb01e2bbee278443867baed2c89e5fe) Reviewed-on: https://gerrit.libreoffice.org/42943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03tdf#112727: crash in chart (transparency related)Julien Nabet1-1/+2
There's nothing to rearrange if mpFloatTransparenceItem isn't set 0 0x00007fffefb26748 in NameOrIndex::IsIndex() const (this=0x0) at /home/julien/lo/libreoffice/include/svx/xit.hxx:56 1 0x00007fffefb23140 in XFillGradientItem::GetGradientValue() const (this=0x0) at /home/julien/lo/libreoffice/svx/source/xoutdev/xattr.cxx:2009 2 0x00007ffff0b2c95a in svx::sidebar::AreaTransparencyGradientPopup::InitStatus(XFillFloatTransparenceItem const*) (this=0x55555859a520, pGradientItem=0x0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx:61 3 0x00007ffff0b2cd33 in svx::sidebar::AreaTransparencyGradientPopup::Rearrange(XFillFloatTransparenceItem const*) (this=0x55555859a520, pGradientItem=0x0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx:90 4 0x00007ffff0b262ae in svx::sidebar::AreaPropertyPanelBase::ClickTrGrHdl_Impl(ToolBox*) (this=0x555558485a50, pToolBox=0x5555586ed8c0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaPropertyPanelBase.cxx:1272 5 0x00007ffff0b26207 in svx::sidebar::AreaPropertyPanelBase::LinkStubClickTrGrHdl_Impl(void*, ToolBox*) (instance=0x555558485a50, data=0x5555586ed8c0) at /home/julien/lo/libreoffice/svx/source/sidebar/area/AreaPropertyPanelBase.cxx:1268 Change-Id: I1d2db6b91c888ca3598e0ea04dd0fa0e9fc790a7 Reviewed-on: https://gerrit.libreoffice.org/42925 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1fba529cf2d810bfce1f3fbcad84b6f6805e1405) Reviewed-on: https://gerrit.libreoffice.org/42950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-02ofz#3527 ofz#3532 Invalid read of size 8Caolán McNamara2-14/+17
use numrule name to look up numrule instead of cached numrule pointer in case it was deleted on failure to apply the numrule over an invalid range Invalid read of size 8 at 0x1E875132: rtl::OUString::OUString(rtl::OUString const&) (ustring.hxx:143) by 0x1EB33D93: SwWW8ImplReader::StartAnl(unsigned char const*) (ww8par2.cxx:1094) by 0x1EB33003: SwWW8ImplReader::Read_ANLevelNo(unsigned short, unsigned char const*, short) (ww8par2.cxx:910) by 0x1EBA375D: SwWW8ImplReader::ImportSprm(unsigned char const*, int, unsigned short) (ww8par6.cxx:6337) by 0x1EAEEA24: SwWW8ImplReader::ReadTextAttr(int&, long, bool&) (ww8par.cxx:3810) by 0x1EAEF15A: SwWW8ImplReader::ReadAttrs(int&, int&, long, bool&) (ww8par.cxx:3921) by 0x1EAEF6E0: SwWW8ImplReader::ReadText(int, int, ManTypes) (ww8par.cxx:4003) by 0x1EAF6DCE: SwWW8ImplReader::CoreLoad(WW8Glossary const*) (ww8par.cxx:5219) Address 0x31831158 is 200 bytes inside a block of size 248 free'd at 0x4C2F21A: operator delete(void*) (vg_replace_malloc.c:576) by 0x253BC1B5: SwDoc::DelNumRule(rtl::OUString const&, bool) (docnum.cxx:1033) by 0x25CB943D: SwFltControlStack::SetAttrInDoc(SwPosition const&, SwFltStackEntry&) (fltshell.cxx:609) by 0x1EAE5011: SwWW8FltControlStack::SetAttrInDoc(SwPosition const&, SwFltStackEntry&) (ww8par.cxx:1445) by 0x25CB8A9E: SwFltControlStack::SetAttr(SwPosition const&, unsigned short, bool, long, bool) (fltshell.cxx:457) by 0x1EAE420E: SwWW8FltControlStack::SetAttr(SwPosition const&, unsigned short, bool, long, bool) (ww8par.cxx:1185) by 0x1EAE5C12: SwWW8ImplReader::Read_Tab(unsigned short, unsigned char const*, short) (ww8par.cxx:1625) by 0x1EBA35F0: SwWW8ImplReader::EndSprm(unsigned short) (ww8par6.cxx:6321) by 0x1EAEEA44: SwWW8ImplReader::ReadTextAttr(int&, long, bool&) (ww8par.cxx:3813) by 0x1EAEF15A: SwWW8ImplReader::ReadAttrs(int&, int&, long, bool&) (ww8par.cxx:3921) by 0x1EAEF6E0: SwWW8ImplReader::ReadText(int, int, ManTypes) (ww8par.cxx:4003) by 0x1EAF6DCE: SwWW8ImplReader::CoreLoad(WW8Glossary const*) (ww8par.cxx:5219) Change-Id: Ia7ab67e42fc7a162d8089722e77841285f72a671 Reviewed-on: https://gerrit.libreoffice.org/43029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-02Number scanner: accept fractional separators in an ISO 8601 date+time stringEike Rathke2-0/+17
In a strict ISO 8601 date+time string with 'T' separator the Time100SecSep separating seconds and fractional seconds can be either '.' period or ',' comma, so accept those in all locales. Not accepting '.' in all locales was the cause of tdf#100822 before code was changed to use sax::Converter::parseDateTime() instead. Change-Id: Ica676050b52b11da64afbac6feabb43d9e985bc4 (cherry picked from commit 00bb8e4a66008098d1133f4923f6d2d65e0dd598) Reviewed-on: https://gerrit.libreoffice.org/43038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-01Number scanner: accept negative year ISO 8601 input with 'T' time separatorEike Rathke1-2/+3
This is valid input: -1999-11-23T12:34:56 Change-Id: I0464b623b76fb55c1d2b848d0db9278e9589a4d8 (cherry picked from commit c3819630e0205a372899ef67d689619657bbbf33) Reviewed-on: https://gerrit.libreoffice.org/42972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-01Resolves: tdf#100822 use sax::Converter::parseDateTime() for 'd' ISO 8601 dateEike Rathke1-8/+11
Instead of squeezing the string through the locale dependent number parser (which should force '.' Time100SecSeparator for 'T' ISO 8601 but apparently doesn't yet) that is a bottle neck anyway. Change-Id: I70f74e680322a715c9cc658c8be033620d9798e3 (cherry picked from commit 5374c04a89e1720490a3625dfd95406c2d60c0cd) Reviewed-on: https://gerrit.libreoffice.org/42970 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 01:47:57 +0000