Age | Commit message (Collapse) | Author | Files | Lines |
|
The ScRefCellValue is always initialized to point to the relevant
cell. Originally there used to be a cell pointer that could be
null, but since 43e50ec759200fe166dba59d3ff76af2a2e148c8 it's been
always set and so checking again is pointless.
Change-Id: Ib661ec5de73891ed3a5cd0346287324183721806
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125687
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
They are tiny and they are used in performance-critical parts
of Calc.
Change-Id: If227b11ac7929dd1369545a590d8ef1a977185f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125698
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Id116ed42c553bb6524876288ca0066be4a4a1820
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125694
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I111f6c7ab5ab2033c08683a16adaf388eeabc9ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125577
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: Ib712072deec9368a3a580562dd1fc3bc28e86e68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125679
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
9b73d3e8926d5f9b10464d19b539eef3eb088f50 disabled painting
to windows in LOK mode, because it doesn't make sense as
those windows are not even visible, but it tried to do it
by avoiding even invalidations. That can trigger problems
because some dialogs actually are forwarded to clients in LOK
mode, and apparently they need the invalidations to proceed
normally (the Format->Cell dialog in Online didn't repaint
scrolling of the Date listbox, I don't know what exactly
the actual problem was, but mnPaintFlags were different
than when not avoiding invalidations).
So revert most of the relevant commits and keep only avoiding
actual drawing, which is what 057968bbce406efe6564347329df45b7e
did.
Change-Id: I4e212966830f4c690e6143b9d5fedbc24619e1ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125674
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The suitable type for variable nIndex is determined by knowing that
the return type of the detectNumberFormat() is sal_uInt32, and the
second parameter for the getNumberFormatType() is also sal_uInt32.
Change-Id: I6578eba05f151ee31eb8eb8142d70f8f5c7c702b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125696
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: I84497ee93e30b639199bbbb958ac1b2c758db50c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125693
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
which results in lots of nice string_view improvements picked up by the
plugins
Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie8f0b57c33fff787735b09ecf8308f86b56d8bb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125121
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
|
|
* Used range based for loop in fillhatchprimitive2d.cxx
+ Goal: Better readability of the code
Change-Id: Ie8ddaa9960e714b161ec530961b36a9935055ae0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125413
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: I8a97c1d89770fe2c0ba0d3f75ce9f3fec0df2e53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125692
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Size the buffer at construction to avoid realloc
Change-Id: I7fed6e345104fe9d4192aaa9664e7fe2662218bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125691
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
in favour of the existing get*() methods.
The get*() methods 0 or false or empty in the case of "null", which
is exactly the same behaviour as the conversion methods.
These implicit conversion methods cause lookup problems when combined
with some upcoming OUString changes.
And the code looks cleaner this way too, and has less magic when calling
methods.
Change-Id: Ieb4756bf693e83b996a32667fc1b955f89193496
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125690
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Content::getPropertyValues() has no less than 2 fallbacks that cause it
to return property values IsDocument=true and IsFolder=false in case
there is an authentication failure or server connection failure.
Change-Id: Iddcda6420c517f522d98e58b12a7e19247ff2d1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125667
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
FStatHelper doesn't use an XCommandEnvironment and is thus unsuitable
for remote access as it can't even authenticate with the password
container; it should only be used for local access.
Due to this problem, the ContentIsDocument() would always return a
hard-coded "true" value from the webdav UCP, causing a spurious dialog
that an existing file would be overwritten in Save Remote.
(regression from 67fa088be7db1df661188ef4bab490a76fb06b85)
Change-Id: Ibe667f2012e261b84d4c69c84fdd499b7276e64b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125666
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
* DAV_HTTP_NOAUTH wasn't actually handled anywhere; treat it the same as
DAV_HTTP_AUTH for now
* Content::getResourceType() would just determine that the server
doesn't support DAV if there is any authentication missing
* Content::getResourceOptions() would cache authentication error that is
caused by executing the command without any XCommandEnvironment and
therefore no XInteractionHandler
Change-Id: Ie319a505da4b0f6bde01d6611262b8b1dad33d2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125665
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Recognize moved text by accessing to the hidden redline content
pContentSect during ODT import (in the case of Delete redlines)
and ChangesInMargin mode (Delete or Insert redlines depending on
Deletion in Margin or Insertion in Margin modes).
Fix Undo and redline stack handling by moving IsMoved bit to
SwRedlineData from SwRangeRedline.
Note: .fodt format is applicable for the unit test document,
because it's not affected by the problem.
Change-Id: Ifd4f993520bec4b845d978a844c465509ea87b50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125552
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
This fixes a regression in LO 6.4 caused by
commit 86cb2a1f98c0585d2121e6ae34fe62f072ef9a63
Not surprisingly, adding a new condition that multiple
other items match on caused a regression.
bFlag is always set to false at the top of the loop.
In the above commit, bFlag was not set to true,
and so thus it would always be false.
So just set the SlotId to 0
to avoid rSet.Put - like so many other cases already do.
Change-Id: I02e9ca9d8dd75db519e801ad0e86fc8d541ae20a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125688
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
For Writer & Calc
Change-Id: I85815acf11b750ec76d138ff8fe72cc4791e9038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125689
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
This is a partial revert of LO 6.3
commit 2c23a96f7b6888c0e05fdc2aba57f03cd797b647.
Change-Id: I17525d06d96779671caaa84e1e48629289453ad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125685
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I99aa1f1843c5ff6e4c76716178e721a96ae284fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125676
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Lots of
> [build LNK] Library/cppuhelper3MSC.dll
> servicemanager.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl xmlreader::Span::Span(char const *,long)" (__imp_??0Span@xmlreader@@QEAA@PEBDJ@Z) referenced in function "public: __cdecl `anonymous namespace'::Parser::Parser(class rtl::OUString const &,class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> const &,struct cppuhelper::ServiceManager::Data *)" (??0Parser@?A0x40CCA2FC@@QEAA@AEBVOUString@rtl@@AEBV?$Reference@VXComponentContext@uno@star@sun@com@@@uno@star@sun@com@@PEAUData@ServiceManager@cppuhelper@@@Z)
> servicemanager.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl xmlreader::Span::Span(void)" (__imp_??0Span@xmlreader@@QEAA@XZ) referenced in function "public: __cdecl `anonymous namespace'::Parser::Parser(class rtl::OUString const &,class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> const &,struct cppuhelper::ServiceManager::Data *)" (??0Parser@?A0x40CCA2FC@@QEAA@AEBVOUString@rtl@@AEBV?$Reference@VXComponentContext@uno@star@sun@com@@@uno@star@sun@com@@PEAUData@ServiceManager@cppuhelper@@@Z)
> servicemanager.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl xmlreader::Span::equals(char const *,long)const " (__imp_?equals@Span@xmlreader@@QEBA_NPEBDJ@Z) referenced in function "public: __cdecl `anonymous namespace'::Parser::Parser(class rtl::OUString const &,class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> const &,struct cppuhelper::ServiceManager::Data *)" (??0Parser@?A0x40CCA2FC@@QEAA@AEBVOUString@rtl@@AEBV?$Reference@VXComponentContext@uno@star@sun@com@@@uno@star@sun@com@@PEAUData@ServiceManager@cppuhelper@@@Z)
[...]
Change-Id: I2cf96b8ce52027fa3c307a0973cdfb91fa990763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125683
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
(Otherwise, the FunctionDecl's body was null and all the error and note
diagnostics were flagged as expected but not seen.)
Change-Id: I32acb6e0028433c9b40545cf91d8fe1acd19a77a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125682
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This was already handled in oox/ at import-time: this adds it to the doc
model, including UNO API and PPTX import.
This is a dependency PPTX export and UI.
Change-Id: I5d875b53d715beb10c13ef616d06cf958d43f70f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125684
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Because I'm unable to remember if Stt is Start or Stat.
Change-Id: Ie853c6e94e45c3e14e002a0218d11c61905a3180
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125672
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
(regression from dc2010964fb8d18d5c4fe96172ee082276a1e587
which broke JunitTest_ucb_unoapi)
Change-Id: I14a79c3b7d1161234da64822186bcf97d4022264
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125671
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Probably when this was first implemented in 6.4,
it should have set a transparency threshold of when to accept
the color as the background (perhaps at 50%).
But since this has already been running for a while,
I only cancel it if it is fully transparent.
No existing unit tests matched this scenario.
I'm not making a unit test because the color really
ought to be set - it should just be transparent.
LO doesn't seem to have a character highlight
transparency capability, so this needs to be emulated.
Change-Id: I7b295894e529f8345cadc9b30bc43598a9a02e2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125670
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
* Update helpcontent2 from branch 'master'
to f2cbbd18d34a7fb8ece9c774cdcb5a2e38fac957
- tdf#145831: fix typo in PNG
Change-Id: If393a87a9e17615e65b93852c41f0aeb0c9b55c8
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125678
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Id67530f1a7c91e3e4e29974b7b9050c7b1fc159f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125669
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7d045d439226c67f479643c71f632a760ad3c2ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125664
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I1a904f4261f80c2ce709a6e97767c9ba6a71b8f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125662
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I9a45839f6566caf41ccee2f8d149b4d0c60c3503
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125663
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Avoid calling SharedStringPool::intern() on values that are
repeatedly the same.
Change-Id: I094f2e777a4ca24536e0c25e6a1c6358ccf49f61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125660
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
A more generic fix coming.
This reverts commit b4c1bb2f91e9ae47820c289e2c08f640a958cf05.
Change-Id: Ia7821f1c8585506556708f1bf8526e7f509aafd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125659
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I97b8d6282c72307cc29a913af221d283523f2fae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125653
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This was already handled by converting them to raw colors at import
time. This commit imports the color scheme contents (the 12 colors) into
the doc model.
This is a dependency to export them back to PPTX and to be able to
update these colors on the UI by picking a different theme.
Change-Id: I177de4f15d5f0e628669998d1cda7db24220b2eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125651
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to 023b21a704bf0bae904b87907dd72d48d518ac09
- Document ScriptForge Dispose() method
Change-Id: Ic2ff80cfc2dc987ea7e62d7c216358af279712a7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125452
Tested-by: Jenkins
Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
|
|
Effects and Shadow went down, Line and Graphic aka Image up
Change-Id: Ifb921e8b84d6fd18926c3249891c76c61ee6626f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125661
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I2ba1ebb161f4004b819fd106c090fefd8d8af8ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125658
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Exports language in run properties of the datetime footer.
And also overrides the placeholder "Date" text with formatted
datetime text if the datetime footer is a nonfixed one.
Fixes regression from: 166671f4aa19deec47c10a220ae1d29fa57faa93
(tdf#59323: pptx import: import footer fields as properties)
Change-Id: Ib888e5cf51ea7e14fb13278e96610051e1e5fe5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124123
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
and no need to use the for i in range(90) loop
Change-Id: I9b039d49dc74f61289ad11979da1f244ec59903f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125655
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
All tests still pass, so the end result should be the same, but
this way it's done in one call.
Change-Id: If5da34837a45ad600ae30568e4ba7651ac5838bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125644
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
I'll want some common extra functionality there later.
Change-Id: I249f9ca4662fc8e8d52c58b1bd33293f363464d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125643
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Remove the temporary buffer in INetURLObject::setAbsURIRef,
and just write directly to the main buffer.
This is a behaviour change since we are "committing" bad data to the
buffer if the URL is incorrect, but since it that case we set the
whole object to be invalid, that should not matter.
Change-Id: Ic8e7d4027bcb927005edd7de4098f4f525412869
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125648
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Add move operator to OUStringBuffer to avoid copy
Change-Id: Ifef326449d87aac79f4b1142db7a53faad427580
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125626
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
What happens with Nextcloud:
CURLINFO_HEADER_OUT: 0xa028408: PUT .../testB.odt HTTP/1.1
User-Agent: LibreOffice 7.3.0.0 curl/7.79.1 NSS/3.71
Accept: */*
Accept-Encoding: deflate, gzip
Transfer-Encoding: chunked
Expect: 100-continue
debug log: 0xa028408: STATE: DO => DID handle 0xa028408; line 2077 (connection #0)
debug log: 0xa028408: STATE: DID => PERFORMING handle 0xa028408; line 2196 (connection #0)
debug log: 0xa028408: HTTP 1.1 or later with persistent connection
CURLINFO_HEADER_IN: 0xa028408: HTTP/1.1 100 Continue
debug log: 0xa028408: CURLINFO_DATA_OUT 8357
debug log: 0xa028408: Signaling end of chunked upload via terminating chunk.
debug log: 0xa028408: CURLINFO_DATA_OUT 5
debug log: 0xa028408: Mark bundle as not supporting multiuse
debug log: 0xa028408: HTTP 1.1 or later with persistent connection
CURLINFO_HEADER_IN: 0xa028408: HTTP/1.1 201 Created
CURLINFO_HEADER_IN: 0xa028408: Date: Fri, 19 Nov 2021 16:27:47 GMT
CURLINFO_HEADER_IN: 0xa028408: Server: Apache
CURLINFO_HEADER_IN: 0xa028408: Content-Length: 0
... yes, "201 Created" a 0 byte file.
https://github.com/nextcloud/server/issues/7995
Apparently this doesn't happen with header Content-Length: 8347
Change-Id: I3f38d50530a8b6430b27de2525370e1d95705da6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125579
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
This potentially allows to introduce other degree fractions easily,
like Degree<sal_Int64, 60000>, with automatically defined conversion
functions.
Change-Id: Id1c32d9e029943844bdc833178c1f99387ff87fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This reverts expanded controls from patch Icb22f2a9f24852898ab4550bc0cec32732ad32dd
Change-Id: Iac9a0d920193d47976d6a2fc9305c43b09447019
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125642
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
* Update helpcontent2 from branch 'master'
to 957baaaa79fc771842444d2fd5df6c9f9383f6d7
- Document Duplicate/Rename sheet shortcuts in Calc
Based on Regina's comment on bug tdf#145745 there are quick ways to duplicate and rename Calc sheets. This patch documents these shortcuts.
Change-Id: I887018cec48b829b73edd3c593d32f2044d60778
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125450
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|