summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-06-27Unit test for update reference in deletion of last col/row, tdf#108788Eike Rathke1-0/+30
Change-Id: Ibb7a30144a1eebac3b233320c3d56c7be41cc7e3
2017-06-27Document::retrieveDefaultAttributesImpl did nothingStephan Bergmann2-53/+4
...ever since dac3b388798e78803a5df77894bfd30cddeb77c3 "INTEGRATION: CWS a11ysep" Change-Id: I1bba12e9f6ab69cf561a7eda010cefba91c47a49
2017-06-27tdf#108714: allow <w:br> as direct child of <w:body>Mike Kaganski8-1/+101
LibreOffice doesn't accept <w:br> element as a child of <w:body>. ECMA-376-1:2016 17.3.3.1 describes br as element of a run content, and points to CT_Br in §A.1. CT_Br may appear only as part of EG_RunInnerContent. In turn, EG_RunInnerContent may appear only inside CT_R. So, using <w:br> outside of <w:r> produces ill-formed OOXML. Open XML SDK 2.5 Productivity Tool for Microsoft Office confirms that, showing OpenXmlUnknownElement error. However, Word accepts it as direct child of <w:body>. It behaves as if the <w:br> were used as first element in first run of the following <w:p> (thus creating page break after next paragraph). Another Word bug that provokes third-parties to create ill-formed documents, and requires LibreOffice to be bug-to-bug compatible. This commit makes the following changes: 1. Registers a dedicated complex type CT_Br_OutOfOrder to handle those unusual breaks, with corresponding handler function. 2. In the handler function, saves the gathered property set to parser state to use later in next paragraph group handler. This reproduces Word behaviour. Change-Id: I5df6927e2de9266b58f87807319ad1c4977e45a7 Reviewed-on: https://gerrit.libreoffice.org/39168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-27tdf#100075 DOCX frame height rule updatedVasily Melenchuk3-6/+49
According to "[MS-OE376]: Office Implementation Information for ECMA-376 Standards Support" Word treats default value for hRule attribute in a different way: if frame height is missing it is "auto" (as in specification), but if frame height exist, then default value for hRule is "atLeast". Change-Id: I0ce30b61d1a6b85febbbd8a6bf5af3eb1bb2767f Reviewed-on: https://gerrit.libreoffice.org/39065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27Sticky here means we can bail out early, tdf#108788 follow-upEike Rathke1-0/+11
Change-Id: I475b95321a2a49148073b7c6aeeb28b7c5b73750
2017-06-27Fix typoEike Rathke1-1/+1
Change-Id: Idac70b87926cfc34712a2e65923d8a035c870765
2017-06-27Resolves: tdf#108788 update references for deletions at end of sheetEike Rathke3-21/+59
ie. when the last column or row is included in the deletion. This seems to have never worked. Change-Id: Ic1bd1944298fe248367597177ca01e109585fcd2
2017-06-27use std::array in BlockInfoNoel Grandin3-32/+33
Change-Id: I28a13592e5993454ae96b0a32ba328013da7856e Reviewed-on: https://gerrit.libreoffice.org/39296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27Remove unused ItemProcessor argumentStephan Bergmann5-25/+9
Change-Id: Ie650f8c046f60a749999e1819edb5abad79e5362
2017-06-27svtools: use implicit defined copy assignmentJochen Nitschke1-65/+0
Change-Id: Iea061bbcf0bf6e894f1bb6028de75eb0f8e2c8f0 Reviewed-on: https://gerrit.libreoffice.org/39294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27basegfx: remove trivial copy ctorsJochen Nitschke2-28/+0
Change-Id: If6668552ec56d1b6439ead56fb2d77491a84ea13 Reviewed-on: https://gerrit.libreoffice.org/39295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27Fix typoAndrea Gelmini1-1/+1
To complete commit 3f3181522bd5fa7cd32dc81c624ef260b29cfc9c Change-Id: Ia6784899e39be6822577e3b8d5f4082ed765fd5e Reviewed-on: https://gerrit.libreoffice.org/39271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27Fix typosAndrea Gelmini4-5/+5
Change-Id: If4373f47fdf0ccfcbd490299f8b8d09e17bf92cd Reviewed-on: https://gerrit.libreoffice.org/39272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27PresenterPaneBorderPainter::Renderer::PaintBitmap rpBackgroundBitmap is unusedStephan Bergmann1-21/+13
...ever since 4d91841e0bc18d5b01fe85eb03eb0be589cf0c74 "INTEGRATION: CWS presenterscreen". (But PresenterTheme::GetBitmap is called with "Background" at least also from PresenterWindowManager::SetTheme in sdext/source/presenter/PresenterWindowManager.cxx, so that code cannot be cleaned away.) Change-Id: I2cdf96ce4d27af2d0beca51e5769fbf148973431
2017-06-27loplugin:oncevar in swNoel Grandin80-303/+170
Change-Id: Ia96172489eec09607113d388a5b683bb6e0d2dec Reviewed-on: https://gerrit.libreoffice.org/39290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27inline ElementPtrNoel Grandin3-31/+30
Change-Id: I93a9527283a819a95563565a252a5088253c91c0 Reviewed-on: https://gerrit.libreoffice.org/39293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27android, fix codemaker buildbreakerjan Iversen1-2/+2
Interesting android does not use --enable-java Change-Id: If834485d5a1cfcd2c6ddcd6f30dcbb61aa838dae
2017-06-27sw: fix the assertion in SwModule::Notify()Michael Stahl1-1/+3
This assertion (for i#116192) is actually triggered while loading fdo65932.html in CppunitTest_sw_filters_test: The perverted LoadHiddenDocument() hack in SwHTMLParser::SetControlSize() may create a view too early, before loading finishes, but this shouldn't be a problem because HTML is never a template, so move the assertion into the place where we actually modify the document directly without going via the shell. Change-Id: Ifa4b1ec4ab4142f4159daf5785cd90b5468f7e3e
2017-06-27fdo#43157 convert OSL_ASSERT to assert in sw/sourceBernhard Widl5-5/+5
Change-Id: Ibef2f8deb36e2123f22bd925d1360c34de0ce47b Reviewed-on: https://gerrit.libreoffice.org/39270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27tdf#108806: convert CRLF into space in OOXML textMike Kaganski3-2/+17
Change-Id: I8e2e108a705ecdb55c096a589d83d51c48b0b83c Reviewed-on: https://gerrit.libreoffice.org/39286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-27iOS, first attempt to get bridges compiling.jan Iversen1-9/+15
Need to adapt for other iOS CPU´s Change-Id: Icb0b49265d3ec67057e57bfe5610389afe404568
2017-06-27gpg4libre: Show message when no cert manager foundSamuel Mehrbrodt3-1/+10
Change-Id: I0da5f20b049ab2d8c992cb2a04dcf544f0b35aa1 Reviewed-on: https://gerrit.libreoffice.org/39289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27loplugin:oncevar in svxNoel Grandin36-112/+59
Change-Id: I22a3a13e059ac7d3479f12860564fe3eb1b55e44 Reviewed-on: https://gerrit.libreoffice.org/39282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27gpg4libre: Add seahorse to list of certificate managersSamuel Mehrbrodt1-1/+1
which is the Gnome default app for ḱey management Change-Id: I4c27074f83538640fb1729c5cfddd96981d35f40 Reviewed-on: https://gerrit.libreoffice.org/39288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-27tdf#108809 Message boxes: Add more descriptive window titleSamuel Mehrbrodt4-6/+71
E.g. 'Error' for error boxes instead of just 'LibreOffice 6.0' Change-Id: I7142d15e9219a2aa6733523887cdf43b50200b7b Reviewed-on: https://gerrit.libreoffice.org/39284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27PresenterPaneBase::PaintBorderBackground does nothingStephan Bergmann2-32/+1
...ever since 1eeb7358933afbb8d673c16c92bfd8492e8b5620 "INTEGRATION: CWS presenterscreen" Change-Id: Ibb5bf69eb3d11aa3c3b67ed0b342ca95ecf40bfe
2017-06-27tdf#108711 GPG key selection should only be possible for ODF >= 1.2 documentsSamuel Mehrbrodt4-2/+26
gpg4libre Change-Id: I6dbdaefddacf55c9381d156ada20cb3f25d4b3cb Reviewed-on: https://gerrit.libreoffice.org/39263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27gpg4libre: Show error message when signing failsSamuel Mehrbrodt5-0/+20
Change-Id: I58f3febaaaaa225952e87ad3f092950ace37d15d Reviewed-on: https://gerrit.libreoffice.org/39283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27Use base class to set/get super/sub scriptTamas Bunth2-163/+0
Looks like some obsolete code Change-Id: If600609ccd0baf3c10261cc850ac5ddc3c046401 Reviewed-on: https://gerrit.libreoffice.org/39216 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-06-27iOS, remove java and cppunittestjan Iversen2-4/+4
Low level functions will not be tested Change-Id: I72fa44ea713639db97e39801a3975d6731a684c2
2017-06-27Ported bin/generate-bash-completion from Perl to PythonArkadiy Illarionov3-242/+164
Change-Id: Ie1b5cd0a1f64198f8e6362a02484055c5ae6b26e Reviewed-on: https://gerrit.libreoffice.org/39077 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27loplugin:oncevar in svtoolsNoel Grandin17-75/+34
Change-Id: Ic97e75c81a0c00853d2f10aaf182ab476c466c86 Reviewed-on: https://gerrit.libreoffice.org/39281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27loplugin:oncevar in starmath..svlNoel Grandin16-122/+83
Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c Reviewed-on: https://gerrit.libreoffice.org/39280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27loplugin:useuniqueptr in variousNoel Grandin15-175/+102
extending it to find places we can use std::unique_ptr on arrays Change-Id: I9feb1d12d738d6931e752ecb6dd51cbc1540c81b Reviewed-on: https://gerrit.libreoffice.org/39255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27SmartArt: std::for_each -> range-based for loop.Jan Holesovsky3-20/+17
Change-Id: Ie2b36175a52c897bcf39da0ac2daa35979aac923 Reviewed-on: https://gerrit.libreoffice.org/39285 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-26SmartArt: separate LayoutAtomVisitors from LayoutAtomsGrzegorz Araminowicz6-255/+327
Change-Id: Ifbed15c881e4c0b987cd2fdbb903709a0b8b0e36 Reviewed-on: https://gerrit.libreoffice.org/39269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-06-26Remove nonsense TODOSamuel Mehrbrodt1-1/+1
Change-Id: I97fd74c664e125f6c04f585e20c84ce702927e50 Reviewed-on: https://gerrit.libreoffice.org/39277 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-26Cleanup commentSamuel Mehrbrodt1-8/+3
Change-Id: I218675bcb832c158171f87bb7c52a658ceaa7a67 Reviewed-on: https://gerrit.libreoffice.org/39278 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-26Updated coreAdolfo Jayme Barrientos1-0/+0
Project: help bb320c4e73967aff4b1b92c46c82a5dc5bdd8d3f Expand some useless “MS” abbreviations to “Microsoft” Abbreviations should be used only when we lack space (e.g., in UI), but there’s plenty of it here Change-Id: Ib0ac97b2003ca96e4bc286a1a1436bda0f81bd8a
2017-06-26lwp: use std::array and get copy ctor for freeJochen Nitschke2-35/+8
Change-Id: I3c0f8cea0adca843ec88f4742243c6cdada6bc5f Reviewed-on: https://gerrit.libreoffice.org/39260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26assert( nStartCol + nSize <= MAXCOL+1 ); tdf#108788 prepEike Rathke1-0/+1
Change-Id: I647253f32bfac0460c263f662ab95ec0151bf38c
2017-06-26Avoid loplugin:unreffunStephan Bergmann1-1/+7
...after 272d5a02a3de2350f8af7a93281b651316b24ae5 "Revert 'tdf#108524 sw: attempt to split section frames inside table cells'" Change-Id: Ic1ec8cd3284e2ba98630552c80d99b5d67fc7efd
2017-06-26Resolves: tdf#108643 don't restore orig size on first chart activateCaolán McNamara1-1/+3
Change-Id: Ibe51eb81ea1b0874fc1a9018871f07c9af38e8d2 Reviewed-on: https://gerrit.libreoffice.org/39268 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-26EditEngine: Added test to check MultiPara Copy/Paste with Bold/Italic textVarun Dhall1-0/+301
Change-Id: Ic94338662009a4e0ddbc28e21ac1f5028ddd9126 Reviewed-on: https://gerrit.libreoffice.org/39219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-26Fix loplugin:vclwidgets' disposeOnce checkStephan Bergmann1-16/+27
Found when trying to temporarily add a SAL_DEBUG to (otherwise empty) ~NotebookbarTabControl (sfx2/source/notebookbar/NotebookbarTabControl).
2017-06-26Revert "tdf#108524 sw: attempt to split section frames inside table cells"Michael Stahl4-49/+5
This reverts commit f991b842addddeada6dc45c4054deeca5aa7f17b. It doesn't really work and crashes on ooo61225-1.sxw in 1 in SwFrame::FindTabFrame() (this=0x0) at sw/source/core/inc/frame.hxx:913 2 in SwFrame::GetNextSctLeaf(MakePageType) (this=0x3137130, eMakePage=MAKEPAGE_INSERT) at sw/source/core/layout/sectfrm.cxx:1529 3 in SwFrame::GetLeaf(MakePageType, bool) (this=0x3137130, eMakePage=MAKEPAGE_INSERT, bFwd=true) at sw/source/core/layout/flowfrm.cxx:805 4 in SwFlowFrame::MoveFwd(bool, bool, bool) (this=0x31371d8, bMakePage=true, bPageBreak=false, bMoveAlways=false) at sw/source/core/layout/flowfrm.cxx:1861 The code added in GetNextSctLeaf() looks unfinished to me: it assumes that something else has added a follow-frame for the SwCellFrame containing the SwSectionFrame already, but AFAICT the GetNextSctLeaf() function is responsible for creating that SwCellFrame follow. The caller (in GetLeaf()) specifically checks for this condition and avoids calling GetNextCellLeaf(). Change-Id: I51875830771f07f5d2fec293f6063c73fc68d468
2017-06-26Revert "crashtesting failure on ooo61225-1.sxw"Michael Stahl3-10/+12
This reverts commit 55d4cc340068b0f590ab3a2119a2a2a71a3f8e5e. It's obviously bogus to have mbInfTab set but ImplFindTabFrame return null. Also, just loading the document still crashes with the same problem in a different place.
2017-06-26updater: make it more difficult to misuse the APIMarkus Mohrhard1-29/+19
Change-Id: Ief5b2e37f289d6bfa92a909701c331d50509b0a3
2017-06-26updater: reduce scope of ArchiveReader and pass by referenceMarkus Mohrhard1-53/+48
Change-Id: Ifbcfa5b612cb0a8670bf3dd0be6e74708cc969c1
2017-06-26updater: subclasses need to pass the archiveReader parameter to their parentsMarkus Mohrhard1-11/+26
Change-Id: I1d69d592a05908e4e2a2e832a5b6ef9d13fc2e2c
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-09 21:20:13 +0000