summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-10-15Do not include <sys/sysmacros.h> header unconditionally, but perform a check ↵Gleb Popov2-0/+7
for it in the configure script. This header is missing at least on FreeBSD. Change-Id: Iecb8c35e2ea8af84cf1488334a4d39ba0b5af7e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104214 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-10-15need to ClearFormats to invalidate cache of what is dndedCaolán McNamara2-5/+7
Change-Id: I2280d1d883448f1a538a78acec0d1b7f04df5ffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-15pdfium: add an FPDFImageObj_GetBitmap() wrapperMiklos Vajna4-24/+54
Replaces both FPDFBitmapDeleter and most manual calls to FPDFBitmap_Destroy(). Change-Id: I4676dd2f51b6b348ebbb6edc0379d7afd8fa79d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104324 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-15Replace list by vector in vcl/impdelJulien Nabet1-3/+4
Change-Id: I91f5859413ec3265647b8d55225b29ee95a06857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104182 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-14tdf#136577: sw: Add UItestXisco Fauli1-4/+33
Change-Id: I0b03eae6349b712e921f471e1c4dc082a64568df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104320 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14Replace list by vector in scripting/eventhelpherJulien Nabet1-5/+5
Change-Id: Ia7a24649cc8f204fe412b240df02b3a814ed491c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104180 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-14More fixes of uses of now-explicit OUString ctor taking raw sal_Unicode pointerStephan Bergmann7-10/+10
...in Windows-only code, after c927aab29ebfff1ce3ac0b2f27ae343025a9890c "Make the OUString ctors taking raw sal_Unicode pointer/non-const array explicit". Interestingly, these occurrences were accepted by MSVC and only cause errors with clang-cl, so happened to go unnoticed until now. Change-Id: I33e7653e28a21541ef793b4b0750abb6037752db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104314 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14The Clang RecursiveASTVisitor change is already in Clang 11Stephan Bergmann5-8/+8
...see 5d546de67b44dec23ecfa5a6378e2968912f8253 "Adapt to Clang 12 trunk RecursiveASTVisitor change"; no longer sure why I thought <https://github.com/ llvm/llvm-project/commit/5689b38c6a4220cc5f6ba68a56486229b10071bf> "Removed a RecursiveASTVisitor feature to visit operator kinds with different methods" would not be included in the release/11.x branch Change-Id: I1e206368c447b74cc6adec4c1d4790c80f0cb744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104309 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14use shadowcolor for bordercolorCaolán McNamara1-1/+1
this is what the calc inputbar has always done Change-Id: I17d3dd0b45575e81d6f2e2f109d371cfe366883b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14send ComboBox "changed" on autocomplete suggestionCaolán McNamara1-7/+13
and put include_mru into its own function Change-Id: I9e7c669df7c538ae7271b16a0fdc31f102e9333f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14tdf#137453: sc_subsequent_filters_test: Add unittestXisco Fauli2-0/+17
Change-Id: Ief6559122820c490eebe256535fae5e009b5e2b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104318 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14Fix typoAndrea Gelmini1-1/+1
Change-Id: I6265c482cdc1468516d0e9eff704f2017effd411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104315 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-14tdf#137294 don't change subset sensitivity after setting search modeCaolán McNamara1-5/+8
Change-Id: Iaa76e2bc8029ac8f8a52b0c45f74b57395090088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Related: tdf#137250 need signal-changed for ComboBoxText tooCaolán McNamara1-1/+1
e.g. changing font in format, character with up/down/typeahead Change-Id: I2aabae8ea4108830bb5a0ca89ad694fe88a7444d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14related tdf#108944 writerfilter: fix another missing ftn separatorJustin Luth3-1/+8
A comment can also cause a missing footnote separator. Found by doing a code read. Change-Id: I42296f2e9406ad144c6e45873fac0f2cb8d11839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104282 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-10-14Removed executable bits on docx fileAndrea Gelmini1-0/+0
Change-Id: I3cfd9950a97a7a388c34de2d09cbd93bc02cd179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104316 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-14Resolves tdf#137447 - Access galleries via tight extensionsHeiko Tietze3-81/+252
Button and code added to galbrws1 Change-Id: Ic599cc32980f9a3ee297891f80cefe478c28c302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104248 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: I1c16d73731e76e0569b796c1e5cff17f91fffd95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104317 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-14Fix build for Intel on an Apple Silicon MacTor Lillqvist1-0/+3
Change-Id: Id1a5906db87b05218b0810045c698e5ab2a09eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104271 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-14tdf#137356 framework: fix opening the same document twice for long loadsMiklos Vajna7-16/+195
If the document loading is long enough that the statusbar is updated, then we can have this situation that we start loading the document, then spin the main loop during load and do a second load of the same document as part of the main loop spinning: #0 SwDoc::SwDoc() (this=0x1c6a180) at sw/source/core/doc/docnew.cxx:194 ... #6 0x00007ffff359a6dd in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x1c5c260, seqArguments=uno::Sequence of length 15 = {...}) ... #33 0x00007fffeeb81ecd in Application::Reschedule(bool) (i_bAllEvents=true) at vcl/source/app/svapp.cxx:460 ... #36 0x00007ffff4265251 in framework::StatusIndicator::start(rtl::OUString const&, int) (this=0x1aace80, sText="Loading document...", nRange=1000000) at framework/source/helper/statusindicator.cxx:51 #37 0x00007fffd026dfd3 in XMLReader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) (this=0x1bb7d20, rDoc=..., rBaseURL="file:///.../test.odt", rPaM=SwPaM = {...}, rName="") at sw/source/filter/xml/swxml.cxx:630 ... #42 0x00007ffff359a6dd in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x1bce4d0, seqArguments=uno::Sequence of length 15 = {...}) at sfx2/source/doc/sfxbasemodel.cxx:1883 The reason for this is is that by the time LoadEnv::impl_searchAlreadyLoaded() searches for frames which already have this doc open, the first load is still in progress, and we assiciate the frame with its controller (which has the URL) only once the load finishes. Fix the problem by setting the URL on the frame directly for the duration of the load: this way an in-progress load also counts as a duplicate and we'll have just one document open at the end. Regression from commit 74ac65c49cc1d53b1aa93c2b7c720255867aace2 (#i114963# Enable IPC before OpenClients to allow client connections when printing., 2016-09-06), we just didn't process incoming requests on the socket before, so the problem was less visible. Change-Id: Ib138c4c264e2508c20104ab268501bcca31e2790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104310 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-14tdf#136577 sw: fix Undo of Replace with nothingMichael Stahl1-1/+1
The UI doesn't allow to replace an empty selection anyway, but it now happens on Undo. (regression from e1629c210ad78310e3d48c0756723134a27b89df) Change-Id: I468f28335beaeb8c42df8ed4cfc90f2c03129239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104308 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-14ImageTree::getImageStream may sub a req for a .png with svg dataCaolán McNamara1-9/+11
so we can't rely on the input path name as to its data format. its going to be either png or data, so select which based on the first byte, so presumably keeping the startup optimization of commit 9e5cbcf90f15f46f84900a58bcaee437b98587f6 Date: Wed Dec 18 15:35:19 2019 +0200 load images by explicit type Change-Id: I0b2b743c138075f651d376767984be88745327a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137477 - Access templates via tight extensionsHeiko Tietze3-141/+114
UI modified and code added Change-Id: I1231bb03bc96295b9a7e6cdb85162f7f8ea3add0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104285 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14sw: fix unsorted redlines in SwTable::ConvertSubtableBox()Michael Stahl1-1/+1
ooo12626-10.odt asserts because MoveNodeRange() handles redlines only with an explicit flag. (regression from e366c928819c44b5c253c45dca6dae40b71c9808) Change-Id: I80c6e696e51c6d9c366af30ecf8b6df265d0fc91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104286 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-10-14tdf#137446: sc: Add UItestXisco Fauli2-0/+62
Change-Id: Ied157591f779e19b953b7e59df3fd975d38826f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104277 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14tdf#133260: sc_ucalc: Add unittestXisco Fauli2-0/+21
Change-Id: I4661057a3e65f0e5ab7b18d8ad44bcd08a659039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104281 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14add unittest for SkiaSalBitmap copy-on-write data sharingLuboš Luňák3-0/+46
Change-Id: I2e331785d49c55116bf9cb893be25da1067df8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104283 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-14tdf#135260 sw_redlinehide: fix insert-with-delete differentlyMichael Stahl2-10/+4
The problem with the fix for tdf#127635 is that now the cursor doesn't move left on backspace if change tracking is on. (regression from 398ba26077f9029bdf6f7378bfc9ce8376b6f02d) Revert that and fix the autocorrect position in SwWrtShell::Insert() instead. Change-Id: I5989a589b654fc6e5ba3dd66922af15eff758ecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104280 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-14Fixes to TipOfTheDay dialogHeiko Tietze3-9/+12
* Reverts 231a4e024b85aa0ad06a5632d3f514152babea30 and sets initial value to -1 to start from zero * Improves translatability of string Change-Id: Ib541a72fa3f6eecdf5bbdf17ce2a4e56ff90c397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104276 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-10-14Resolves: tdf#137445 use the DisableEditHyperlink state as of menu launch timeCaolán McNamara3-2/+29
at context menu popup time set if the EditHyperlink entry should be disabled and use that state if queried about it if EditHyperlink is dispatched from the menu. So ignoring where the mouse currently happens to be when the menu was dismissed. The dispatch is done async, if at all, so also trigger an async Query with Invalidate so at least one Query is ensured to reset the stored state Change-Id: I970b15954851f39b039d844c44711bf712fcb482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves: tdf#137382 update label to "Keep inside text boundaries"Seth Chaiklin1-1/+1
was "Follow text flow" uses same non-conflicting keyboard accelerator as before 'x' Change-Id: I61d93f0c73efc813a71f8625c38caebccdac5793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104163 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-14Fix of accessibility warnings for the additions dialogHeiko Tietze3-116/+270
Adds also an icon to the dicitionaries linkbutton Change-Id: I49d40f92bd055ec976dd1ba8f02e9c88064512b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104275 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14Resolves: tdf#137248 Fix wrong condition breaking non-group interpretEike Rathke1-4/+4
Regression from commit 4f36f2ccab6286ec09480caea602c0fa19195736 CommitDate: Thu Sep 10 11:15:47 2020 +0200 detect if a cell still needs interpreting after Interpret() The bool return from ScFormulaCell::Interpret() does not indicate if it was succesful but whether a group interpret was done. As both calls here happen in a non-group context bailing out on that if false (no group interpret) is wrong. Instead, ask the cell if it still needs to be interpreted after having been interpreted. Change-Id: I40eeeef65e1da3d729cb3fef550620b1ea0a5741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104261 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-14Resolves: tdf#137453 Implicit conversion from sal_uInt64 to sal_Int32 is bad..Eike Rathke2-17/+18
Change-Id: I5681249808cf623d3b7df09988f285268ea8d85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104255 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-14mbMousePosFreezed is always falseCaolán McNamara5-9/+1
Change-Id: I664b8e8c02b3af6af96300e3b2aa40a1cff91946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137429 - Ensure first tip is shown firstHeiko Tietze1-6/+6
Starting in safe mode (or the first time) shows now array[0] instead of [1] Change-Id: I50643c4443705a5137080c6dbdb1ad329151b308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104230 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14better fix for tdf#136455 without destroying widgets we don't truly ownCaolán McNamara1-18/+7
Change-Id: I9c3148fc6dd8658e1ff4a91ff83888288806f9e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14SetMousePosFreezed is always called with falseCaolán McNamara2-2/+2
Change-Id: Id1e32f3a4d7efd7805a2142682b1e9486d120539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104258 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Resolves tdf#137447 - Access icon themes via tight extensionsHeiko Tietze3-223/+346
Button and code added to optgdlg Change-Id: Ib4aa0883a6af2844ab68ed3c0b7f0e21bc655d94 Signed-off-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14loplugin:external (clang-cl)Stephan Bergmann1-0/+5
Change-Id: I2d636f229ea52505cc263ea0219cf9f00130effd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14tdf#76047 XLSX import: fix links to external dataAttila Szűcs4-1/+28
in array formulas to avoid loss of cell content. Without using SetExternalLinks in applyArrayFormulas the IDs of the linked files were not replaced with file names. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I57c304a46899f4171db9ad12e7e187bd6e4c1c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104049 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-14-Werror,-Wshadow (clang-cl)Stephan Bergmann1-3/+3
Change-Id: I3f76ca202c38b42f55d669a0160fa8203b136031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104246 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14tdf#137025 sw: apply textbox padding set in TextAttila Bakos (NISZ)5-0/+115
dialog window using Spacing to Borders in Format->Text Box and Shape->Text attributes... on the selected text box. There are two types of text boxes in sw, the older editeng one, what worked fine, and the newer one, the shape + text frame one, where modifying Spacing to Borders had no effect. This has been fixed by copying the modified shape attributes to the associated text frame. Change-Id: I8da0b414fd4771fa86851d9a6affbd9502894ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103674 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-14cleanup SdrGrafObj and remove unneeded semi-colonsTomaž Vajngerl1-21/+38
Change-Id: I817eaecf9c88440586e0d5fcd3fd0a3ce592195d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104237 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-14pdfium: add an FPDFImageObj_GetImageMetadata() wrapperMiklos Vajna3-46/+16
And in general use more pdfium wrappers in CppunitTest_vcl_pdfexport, so all the '#if defined OSL_BIGENDIAN' checks can be removed. Change-Id: Id05e6ecf3dbb103a263d6068085eede847be320f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-14loplugin:includeform (clang-cl)Stephan Bergmann1-4/+4
Change-Id: If1cffd3896d87695ba189728d8c1f1f04d55b6b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:unreffun (clang-cl)Stephan Bergmann1-1/+0
Change-Id: I9e478c71662aa5a5347d11adae0435e737fced82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104247 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:stringconstant (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I407b5e80a331950790f549ac8a50e8d7e49ee6d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14loplugin:redundantcast (clang-cl)Stephan Bergmann2-3/+3
Change-Id: I2918d9ac8a4600bf5729604bda1beffb1dca78d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104244 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14-Werror,-Wmicrosoft-exception-spec (clang-cl)Stephan Bergmann1-1/+1
> C:/lo/core/bridges/source/cpp_uno/msvc_shared/except.cxx(124,11): error: exception specification in declaration does not match previous declaration [-Werror,-Wmicrosoft-exception-spec] > RTTInfos::RTTInfos() throw() {} > ^ > C:/lo/core/bridges/inc\msvc/except.hxx(93,5): note: previous declaration is here > RTTInfos(); > ^ Change-Id: I7fa9d85de70d1398f89443b202b9b60c36dcc46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104243 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 07:23:41 +0000