summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-09-12ConvertNumbersToText: handle legacy listsMike Kaganski1-3/+21
Handle css::text::PositionAndSpaceMode::LABEL_WIDTH_AND_POSITION Change-Id: I5024359b1a34b0ebb63165ace5e517dd90994faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102510 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-12tdf#41202 writer: allow shift+click to decrease selectionMartin van Zijl1-1/+1
Change-Id: I8f0f03a3ea0eafda166d19a5cd9fa24e97345a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102399 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-09-12Fix typosAndrea Gelmini2-3/+3
Change-Id: Ica93ad739eb32372addc01e1c72804e33d8ce819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102508 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-12sw rtfexport: add explanation comments to unit testJustin Luth1-0/+2
Change-Id: I6b2579c6c92f0090fe7bee732ab6c8571272e9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102454 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-09-12Remove unused patches.Kohei Yoshida6-413/+0
Change-Id: I2a1dbe15f2df42b4f74e0c00b91ace6c0d3f5f8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102503 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2020-09-12Upgrade liborcus to 0.16.0.Kohei Yoshida15-52/+480
Change-Id: Iae29fb26417dfc161698a81bee84e81545969065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102502 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2020-09-12non-cross: set Java FOR_BUILD variablesJan-Marek Glogowski1-0/+6
Seems I never had some JAVA_HOME ponting to some different Java, then my build system. At least that is my guess from the lo_callgrind_linux Jenkins build. Change-Id: I4315ff64064463edf34f0f96006ae72f80f1ffa4
2020-09-11tdf#135693: sw: Add UItestXisco Fauli2-0/+37
Change-Id: If38daeb35ae8ba09aac50490a15c66dc0650f784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102485 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-11log what token was unexpectedCaolán McNamara1-1/+1
Change-Id: I192bd691816a044dbca389621730ca7ee3a584e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11Make arbitrary cell length limit in CSV import a constexprEike Rathke1-13/+14
... so we could up that in one place if we really wanted. Usually exceeding that length is due to malformed data opening a quoted field without closing it. However, there might be valid reasons to allow more than 64k characters in one cell, but think about a *reasonable* limit, not 2GB ... Change-Id: I7f9ea80ab2f7a4eb34d93203286c973ea03f1ce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102495 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-11Handle empty rRange in OverlayManager::RangeToInvalidateRectangleStephan Bergmann1-0/+3
Not sure why it started to happen just now, but my Linux UBSan build now failed CppunitTest_sd_tiledrendering with > svx/source/sdr/overlay/overlaymanager.cxx:290:44: runtime error: 1.79769e+308 is outside the range of representable values of type 'int' > #0 in sdr::overlay::OverlayManager::RangeToInvalidateRectangle(basegfx::B2DRange const&) const at svx/source/sdr/overlay/overlaymanager.cxx:290:44 > #1 in sdr::overlay::OverlayManager::invalidateRange(basegfx::B2DRange const&) at svx/source/sdr/overlay/overlaymanager.cxx:311:55 > #2 in sdr::overlay::OverlayManager::impApplyRemoveActions(sdr::overlay::OverlayObject&) at svx/source/sdr/overlay/overlaymanager.cxx:186:13 > #3 in sdr::overlay::OverlayManager::~OverlayManager() at svx/source/sdr/overlay/overlaymanager.cxx:224:21 > #4 in sdr::overlay::OverlayManagerBuffered::~OverlayManagerBuffered() at svx/source/sdr/overlay/overlaymanagerbuffered.cxx:377:9 > #5 in sdr::overlay::OverlayManagerBuffered::~OverlayManagerBuffered() at svx/source/sdr/overlay/overlaymanagerbuffered.cxx:368:9 > #6 in salhelper::SimpleReferenceObject::release() at include/salhelper/simplereferenceobject.hxx:72:49 > #7 in rtl::Reference<sdr::overlay::OverlayManager>::clear() at include/rtl/ref.hxx:180:19 > #8 in SdrPaintWindow::~SdrPaintWindow() at svx/source/svdraw/sdrpaintwindow.cxx:251:22 [...] > #16 in SdrPaintView::DeletePaintWindow(SdrPaintWindow&) at svx/source/svdraw/svdpntv.cxx:83:24 > #17 in SdrPaintView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/svdraw/svdpntv.cxx:417:9 > #18 in SdrObjEditView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/svdraw/svdedxv.cxx:2316:22 > #19 in FmFormView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/form/fmview.cxx:196:14 > #20 in sd::View::~View() at sd/source/ui/view/sdview.cxx:148:9 > #21 in sd::DrawView::~DrawView() at sd/source/ui/view/drawview.cxx:75:1 > #22 in sd::DrawView::~DrawView() at sd/source/ui/view/drawview.cxx:74:1 [...] > #34 in sd::framework::BasicViewFactory::releaseResource(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResource> const&) at sd/source/ui/framework/factories/BasicViewFactory.cxx:229:1 > #35 in sd::framework::ConfigurationControllerResourceManager::DeactivateResource(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&, com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&) at sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx:201:48 > #36 in sd::framework::ConfigurationControllerResourceManager::DeactivateResources(std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId>, std::allocator<com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> > > const&, com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&)::$_0::operator()(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&) const at sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx:88:20 [...] > #38 in sd::framework::ConfigurationControllerResourceManager::DeactivateResources(std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId>, std::allocator<com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> > > const&, com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&) at sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx:84:5 > #39 in sd::framework::ConfigurationUpdater::UpdateCore(sd::framework::ConfigurationClassifier const&) at sd/source/ui/framework/configuration/ConfigurationUpdater.cxx:249:28 > #40 in sd::framework::ConfigurationUpdater::UpdateConfiguration() at sd/source/ui/framework/configuration/ConfigurationUpdater.cxx:160:21 > #41 in sd::framework::ConfigurationUpdater::RequestUpdate(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&) at sd/source/ui/framework/configuration/ConfigurationUpdater.cxx:107:13 > #42 in sd::framework::ChangeRequestQueueProcessor::ProcessOneEvent() at sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx:161:33 > #43 in sd::framework::ChangeRequestQueueProcessor::ProcessUntilEmpty() at sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx:173:9 > #44 in sd::framework::ConfigurationController::disposing() at sd/source/ui/framework/configuration/ConfigurationController.cxx:126:41 > #45 in cppu::WeakComponentImplHelperBase::dispose() at cppuhelper/source/implbase.cxx:104:13 > #46 in cppu::PartialWeakComponentImplHelper<com::sun::star::drawing::framework::XConfigurationController, com::sun::star::lang::XInitialization>::dispose() at include/cppuhelper/compbase.hxx:90:36 > #47 in sd::DrawController::DisposeFrameworkControllers() at sd/source/ui/unoidl/DrawController.cxx:814:21 > #48 in sd::DrawController::dispose() at sd/source/ui/unoidl/DrawController.cxx:162:5 > #49 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1485:33 > #50 in (anonymous namespace)::XFrameImpl::close(unsigned char) at framework/source/services/frame.cxx:1692:12 > #51 in SfxFrame::DoClose() at sfx2/source/view/frame.cxx:109:29 > #52 in SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) at sfx2/source/view/viewfrm.cxx:1534:28 > #53 in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:49:24 > #54 in (anonymous namespace)::SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) at sfx2/source/doc/objxtor.cxx:146:12 > #55 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1439:76 > #56 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:716:13 > #57 in SdXImpressDocument::dispose() at sd/source/ui/unoidl/unomodel.cxx:2708:19 > #58 in LOKitSearchTest::tearDown() at sd/qa/unit/tiledrendering/LOKitSearchTest.cxx:113:22 [...] where the given rRange is apparently empty Change-Id: I7324f1660dc3b782a4e489884a319f4aeb690b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102492 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-11Resolves: tdf#107459 MATCH() in descending sorted array find last equal valueEike Rathke1-1/+1
... not reverse the first equal value. This only affected the array/matrix argument case, not cell references. Change-Id: I0ff574a5132b6ee93789ac32f6c5de02465263f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-11use 32bit configure flags for 32bit windows jenkins TBChristian Lohmaier2-0/+3
Change-Id: I621a049cbebb6e3ebe052098b1d945aaa9f075d7
2020-09-11cross-build: fix Java NI linkingJan-Marek Glogowski20-35/+119
LibreOffice has a JNI component on Windows and Linux, the officebean. Therefore we need a host JDK for linkage to the jawt, and a build JDK to compile the Java code. Change-Id: I4138628ab3ea2ef5900a5b4e9281050ae84e4eb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102483 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11WIN cross: fix libjpeg-turbo buildJan-Marek Glogowski1-2/+2
Change-Id: Iae4696df714ba27c0053f7ca3eb485816e8e58c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102481 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11Fix naming in configure.acJan-Marek Glogowski1-5/+6
Regression from commit 63972e79bbb9ea9654e755381641052632b0402c Change-Id: Icb8e4aa7c1c837640c61334f7a0983a771a43df6
2020-09-11oox smartart: add support for syncing font heights of multiple shapesMiklos Vajna11-11/+176
When 2 or more shapes have their text set to autofit and they have a constraint like: <dgm:constr type="primFontSz" for="des" forName="node" op="equ"/> Then make sure that the automatic font size is the same for all shapes and all content fits, by using the smallest scaling factor from all relevant shapes. Some rework is needed, because normally oox::drawingml::Shapes don't have access to their parents, at the same time there can be multiple SmartArts on a single slide, so storing the grouping info in the filter is problematic, too. Solve this by storing the grouping in the toplevel oox::drawingml::Shape and exposing them in XmlFilterBase just during the time the children of the toplevel shape of the SmartArt are added. This works, because we know SmartArts can't be nested. Change-Id: I6c591eadc7166c7c42752650afdb7ee1e416cff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102490 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-11tdf#125234 Qt5 set glpyh font bounding boxJan-Marek Glogowski3-10/+39
Not sure if this is strictly needed, and obviously it will be "wrong" for a sub font containing just some of the glyphs, but since other backends also do this, follow suit. Change-Id: Ib83542b685b38d800d09b7a19780f9ac619c7ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102487 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11Qt5 add some output formaters for Qt classesJan-Marek Glogowski1-0/+28
This simply converts them to LO equivalents. Since this is just for easier debugging, there is IMHO no need for "more optimized" variants. Change-Id: I283d0e2b69f945517aaa79f3c6dbea38dcb50ef0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102489 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11tdf#131581: sw: Add UItestXisco Fauli1-0/+44
Change-Id: Ie6fd0f0e9894f2795e87580e00f4d75272bb3c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-11tdf#125234 Qt use glyph widths, not advanceJan-Marek Glogowski1-10/+7
We're working on the font level here, not the layouting. So use LO's TTF functions to read the glyph widths of the font directly. Change-Id: Ib3bd59a91aa08ca9e629a45ba7539d757bef2c1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102488 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11WIN cross: fix gpg-related library buildsJan-Marek Glogowski12-47/+107
Cross compiling these libraries requires to supply the cross- compiler via the CC_FOR_BUILD environment variable. Since we have to use the gcc-wrappers, we now need two different invocations with different inclues and libraries, but just have fixed environment variables. Also, the CC_FOR_BUILD clashes with LO's own variant, but that is easy to fix. So this change includes: - gcc-wrappers: new option --wrapper-env-prefix to add a prefix to the environment variable names - gcc-wrappers: new option --wrapper-print-cmdline to dump the real command called, when a verbose build is executed - gcc-wrappers: default to exe, if the output has no extension - unify build flags for gpg related libraries Change-Id: I4e6a6ba3c6e09237c8ffefa40ce61131290a3852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102482 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11Fix the minimal build-tools targetJan-Marek Glogowski18-83/+203
The revert commits change the build-tools target for a DESKTOP build to build the complete LO. This restores the original, minimal one and also adds a whitelist of allowd build types. OpenCL needs a configure switch, as it's status is also stored in a config header, so preventing the build is not enough. This also reverts: - commit 802161a505272732566210e9ebbd8fe1b23fb86d - commit 02d931a59e2966d0c2736db8dee7be3e3dcd6bae Change-Id: Ibfcb0c54e72da1b7c2e63c082ea6586520a787fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102480 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11WIN drop --enable-64bit to select Windows targetJan-Marek Glogowski6-243/+204
This changes the Windows build to use the default configure switch to select the target / host of the compiled binaries to get the possibility to cross compile on Windows the "default" way. Note that selecting i686-pc-cygwin on x86_64 doesn't do a cross- compilation, as no special build tools are needed, because x86_64 can run x86 binaries just fine. A consequence of the change is the default target host, which is now the same then the build system, instead of the previous x86 default. Change-Id: I5584f34f665573ebac40d5d7753d96addeb84dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102479 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11image-sort: add --quiet option for build-toolsJan-Marek Glogowski2-19/+25
Otherwise you'll get many warnings for missing images, because the cross-toolset target just builds some small part of LO. This also converts the program to use argparse. Change-Id: I22adda23ab3a25bced871a87d38373543cd5ae72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102478 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11Add a MariadDB configure optionJan-Marek Glogowski1-6/+15
The code is already disabled on iOS and Android, so this just allows changing this setting on all platforms via configure. Also needed for the "minimal" build-tools setup. Change-Id: I590fda4cdc63b58fc17dcfb9da49c75c858b8fc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102477 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11cross-compile: fix PATH handling for hostJan-Marek Glogowski2-4/+14
Reading and exporting the PATH variable will result in a bunch of error, so we have to work with full patch when using the grep and sed commands. Since we just want the PATH for the rest of the host config run, we can simply restore it. Change-Id: I970f3bddece01c1f20ab9db7d55569e5df190675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102476 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-11tdf#118002 fix export to pptx with missing background property setCaolán McNamara1-1/+2
Change-Id: Ifd08ab2357ff8294bc691fb3312a002e7f349f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11remove outdated commentsNoel Grandin1-2/+0
ever since commit 722aa442977e5ca27ab05b4299d26346b5a4e883 convert some MAXCOL to use ScSheetLimits Change-Id: I15bd107e1d0f81a5b3223c3d6995b4105f97ce01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102464 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11tdf#135667 DOCX export: fix border line of OLE objectsAttila Bakos6-103/+288
which wasn't exported. Note: the enlarged monolithic export function was split in the following new functions: - WriteOLEShape() exports the replacement shape of the OLE object. - GetOLEStyle() returns the string value of the style attribute. - ExportOLESurround() handles the surround settings. Also add GetVMLShapeTypeDefinition() to reuse picture frame VML formula string used by VMLExport. Co-authored-by: Arató Dániel (NISZ) Change-Id: I29800a50c60a824a14849ac286a18e5e2f97c689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102034 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-11tdf#135565 prepare font preview virtual deviceCaolán McNamara1-1/+3
make SalInstanceComboBox::create_render_virtual_device do more setup to have an appropiate default background. Change-Id: I43aeb6ffe85d21f11f3ebb1f981c0db67247e5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102403 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2020-09-11tdf#77236 DOCX shape export: fix missing solidFillRegényi Balázs4-9/+21
(resulting for example, invisible shapes). Co-authored-by: Szabolcs Tóth Change-Id: I328514022f4a594c374d5a97db39d1cf3a954e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102195 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-11drop misleading GetWindowTextColor useCaolán McNamara1-1/+0
We use a font from StyleSettings::GetFieldFont(), but use a font color from StyleSettings::GetWindowTextColor() and then immediately afterwards use SetTextColor(StyleSettings::GetFieldTextColor()); Change-Id: I60f653947242a4e2d5fe48bd1d0df7a3ab693685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11invalidate prerendered fontname cache on style changeCaolán McNamara2-17/+40
Change-Id: Ie2111f23dc3346b914442090e3d9257c5659fafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11remove duplicate XML_TOK_TEXT_FRAME_FILTER_NAMENoel Grandin4-10/+10
which has been there ever since commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import And add assert to prevent more duplicates Change-Id: I371a117896c1ab36fabf69da41229a7bcf5459d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11Do not even unload cui library during exitStephan Bergmann1-2/+4
<https://gerrit.libreoffice.org/c/core/+/102222> "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString" kept crashing in UITest_sw_options: VclAbstractDialogFactory::Create loaded the cui library, then some code created OUString instances pointing at the > const OUStringLiteral VIEWOPT_DATANAME = u"page data"; (cui/source/options/treeopt.cxx) in the cui library's rodata section, and at least one of those OUString instances ended up in the data structures owned by the static configmgr::Components singleton (configmgr/source/components.cxx). Now the UITest_sw_options test code in sw/qa/uitest/options/tdf78133.py makes some modifications that apparently cause SvtLinguConfig (unotools/source/config/lingucfg.cxx) to be used but, for whatever reason (i.e., whether or not that is another bug that would benefit from chasing it down), not get cleaned up properly, so that during termination, > warn:unotools.config:799178:799178:unotools/source/config/configmgr.cxx:140: ConfigManager not empty gets emitted, and that SvtLinguConfig apparently holds on to configmgr data so that the configmgr::Components singleton data structures are not fully cleaned up prior to exit. So when the exit handlers run, they happened to be run in such an order that first this static aDialogLibrary was destroyed, causing the cui library (and its rodata segment) to be unloaded, and only then the static configmgr::Components singleton was destroyed. The latter tried to remove all its not-yet-cleaned-up (see above) data structures, which still referenced an OUString instance containing a---meanwhile dangling---pointer to VIEWOPT_DATANAME, causing a crash. So instead of a static Module, use Module::release, as is already used in other places loading libraries. Change-Id: Ibc16d26f6125d20317a641b95ef71b4b406f0999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102456 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-11application level settings-changed event callbacks not triggeringCaolán McNamara1-1/+1
this was originally... ImplDelData aDel( pWinEvent->GetWindow() ); while ( aIter != aEnd && !aDel.IsDead() ) before commit 1db7af8bc9febdf72138fac533ec81d6983da729 Date: Tue Jan 26 22:10:52 2016 +0530 tdf#96888 - Kill internal vcl dog-tags ... back then if GetWindow was null ImplDelData.IsDead() was always false Change-Id: I1e75c27635532afa08ed43bf92bda35b34ae6320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11small optimisationNoel Grandin1-4/+60
avoid allocating predicate on heap, which is expensive when walking over large numbers of styles nodes Change-Id: Ida4369b77fb74f3af1258a97b0b99e3a78413833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11Missing test dependenciesStephan Bergmann1-0/+2
From-scratch `make CppunitTest_sw_core_layout` had failed for me on Linux with > warn:vcl.builder:1528301:1528301:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:1529052:1529052:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui xmlreader/source/xmlreader.cxx:66 Change-Id: I021cf45a61a894a88aee64110a9b9ea8f7a20888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102452 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-11crashtesting: failed on export of tdf118002-1.potx to pptxCaolán McNamara2-4/+4
because the bg isn't set a master isn't exported, so the endelement XML_sldMasterIdLst isn't exported and the document is broken so don't exit early if the propertyset isn't found and always call ImplWriteSlideMaster Modify the ppt variant PPTWriter::ImplWriteSlideMaster to do nothing on an empty propertyset allowing PowerPointExport:ImplWriteSlideMaster to output its XML_sldMasterIdLst on the last master Change-Id: I512ee10b3b3c80b6566827d708b737c6c502c3b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102451 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11Clean-up of commit I29af97001954ad353a386164b68cd22f6230e3e5Tibor Nagy1-3/+9
Change-Id: I1963a5d899da2d122e60c4d87ca32aba4fb1f32a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102449 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-11ofz#25553 Infinite loopCaolán McNamara5-28/+28
Change-Id: Ie0ecacb69b1e99ca52abd9038baa176be8383661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11optimisation: use o3tl::sorted_vector in XMLPropertyStates_ImplNoel Grandin1-37/+12
Change-Id: I9774e0d3f29decedd910fafe3c3174bab930f521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102438 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11optimisation: used std::vector for list of integersNoel Grandin1-7/+12
Change-Id: I98b211d632f0282faeaa30e971841faae89bfeff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11Additions: Clean-up and localize labelsMuhammet Kara2-10/+12
Change-Id: I7073df0d277399745a9c7e0de4d240121ce7b37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102410 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-09-11tdf#135660 DOCX import: fix OLE icon wrap distanceDaniel Arato (NISZ)4-0/+33
The text wrap distance (also sometimes called "margin") of OLE VML icons used to be thrown away when a .docx file is opened. Change-Id: I79837421470dde5e68e916f87924b170ebf1d734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102159 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-11tdf#136587 rtf writerfilter: don't deduplicate yourselfJustin Luth2-2/+9
The default style was not being imported because it was based on itself, and therefore deduplicated itself away, or something like that. Probably this is the only scenario that truly would end up deduplicating itself, but I made it generic just in case. Why not? Change-Id: I621092bf2e067933b5d23d27689a5d3a7f8cf2bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102328 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-09-11convert IMAP_OBJ to scoped enumNoel Grandin11-86/+89
Change-Id: Id265c098a173b2daf581568779d99c7574f067c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102406 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-11Use { ... } for grouping that does not need a sub-shellStephan Bergmann1-2/+2
...in case that makes ever so small a difference, esp. on Windows (where spawning processes is known to be expensinve; but note that at least Bash seems to not spawn a sub-shell anyway when what is enclosed in ( ... ) is just a simple single process, which is commonly the case for these cppunittester invocations) Change-Id: Ie9200270743754e02fbfdb2b17239e9873031dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-11convert IMAP_FORMAT to scoped enumNoel Grandin5-26/+29
Change-Id: I58090ced672267614ade2e3e81e6264d01b77901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 03:28:47 +0000