summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-01-07jsdialog: make source selector dialog buttons workSzymon Kłos2-0/+16
Make sure buttons are welded so we will be able to execute actions. Change-Id: I1cb7bdcd80d1cd4d60751940e4d24ecf8e7be1ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108881 Tested-by: Jenkins
2021-01-07handle also !mbPrepared Graphic correctly when parallel loadingLuboš Luňák1-32/+40
GraphicFilter::MakeGraphicsAvailableThreaded() can cause loading of swapped out Graphic objects too (since def31e135e5e2c0adb1502?). So make sure those are processed the same way as they would be when swapped in. Change-Id: Ibc8eb34b2167e2e21ea2c0c5ce9da14b75f3b6f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108814 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07do not process ImpGraphic twiceLuboš Luňák1-1/+6
Graphic objects share those, and it's ImpGraphic that actually does all the work, so it's enough to process each one once. Change-Id: I771a68e04bf5e1d866ae32973a3096e8d4a82445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108813 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07faster debug dumping for SkiaLuboš Luňák3-2/+18
Write out the png images as quickly as possible, with still at least minimal compression. Without compression the debug images are way too big, but otherwise it's preferred that this is fast (especially when possibly dumping thousands of images). Skia's PNG code ignores the quality and hardcodes the libpng defaults, so patch Skia to explicitly handle the quality we want. It'd be also possible to use SkPngEncoder directly, but SkImage makes it non-trivial to get at the pixel data if it's on the GPU, and the internal getROPixels() invoked by encodeToData() also caches the content, so be lazy and patch Skia. Change-Id: I09cc61115246de4fc9d076953eb7fec8140c32cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108668 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07set fill color when filling alphavdev area for gradients (tdf#138959)Luboš Luňák1-0/+5
When drawing a gradient to an alpha-enabled output device, make the area also opaque (=black in the alphavdev). Change-Id: I2ba1a598e0bf6291e5422253352a201e224af2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108806 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07tdf#42982 Improved UNO API error reportinghomeboy4453-9/+9
Change-Id: I450ea0b1a19381c47370633d124c2ba906415987 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108356 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-01-07tdf#138544 sw LoadUserSettings: default PrinterIndependentLayoutJustin Luth1-3/+5
I hope I understand this correctly. In Options - Load/Save - General, there is option "Load user-specific settings with the document" (default = true). Turning this off seems to simply mean, don't read the settings in Options - LibreOffice Writer - Compatibility from the document. The assumption I guess is that this would instead use system defaults. (Well, actually the user can "modify" these and "set as default".) Well, that wasn't quite true in a few cases, like this one. The general logic says "if the setting is not specified in the doc, set to some old behaviour". And that makes sense. Of course there is no setting in old documents - the concept didn't exist yet. But when we explicitly exclude these user-enforceable compat items, do we really want to force old behaviour instead of current behaviour? And if the user has actually modified these defaults, do we want to ignore the user's settings? I doubt it. So here is the first patch. When you start a new document, Writer compat setting "Use printer metrics for document formatting" is off. Now, when saving and reloading it with LoadUserSettings disabled, it is still the program default of "off", instead of "on". And if the user modifies it to always be on, it will still turn on - so no regression there. Change-Id: I13b236852da843ce72be16d79e2fdace1550523c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108545 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-07Add missing include for std::for_eachMike Kaganski2-0/+34
It is reported now by Windows build after e0f1b5bd94550835c639efda4e4c9a801c78dbe9 "Upgrade external/boost to latest Boost 1.75.0". Change-Id: Ia69c74cd72c7e8ce56c56ffbfb1c1e467ce2bdc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108932 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-07tdf131407 Move UItest to CppUnitTestdiwanshu8852-35/+27
Change-Id: I4d40587099bdbe87cf4ab5c9b2acb1ac9ed8cdd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108399 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-07openssl_headers depends on generated opensslconf.hStephan Bergmann1-1/+1
...at workdir/UnpackedTarball/openssl/include/openssl/opensslconf.h, as can be seen with failed builds like <https://ci.libreoffice.org//job/lo_tb_master_mac/35209>: [...] > [build PAT] openssl > [build C ] UnpackedTarball/mariadb-connector-c/plugins/auth/caching_sha2_pw.c > [build C ] UnpackedTarball/mariadb-connector-c/libmariadb/secure/openssl_crypt.c > [build DEP] LNK:Library/libclucene.dylib > [build LNK] Library/libclucene.dylib > In file included from /Users/tdf/lode/jenkins/workspace/lo_tb_master_mac/workdir/UnpackedTarball/mariadb-connector-c/libmariadb/secure/openssl_crypt.c:21: > /Users/tdf/lode/jenkins/workspace/lo_tb_master_mac/workdir/UnpackedTarball/openssl/include/openssl/evp.h:13:11: fatal error: 'openssl/opensslconf.h' file not found > # include <openssl/opensslconf.h> > ^~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. Change-Id: Ied1dcdd0afb6099e9218671c6a06c0edaafc931e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-07Support for signing when PRODUCTNAME contain spacesVasily Melenchuk1-11/+9
Anyway files are stored without spaces, so we should use same name. Additionally removed PRODUCTNAME_no_spaces variable, it's just a redundant alias. Change-Id: I5b88ac3b07d06969f7639a25603392c9d662d3f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108405 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-01-07fix oss-fuzz build and fftesterCaolán McNamara2-13/+4
since... commit 94d34e53ac9eb41cba96a56bf715d4b02794a12a Date: Tue Dec 29 22:32:01 2020 +0900 Move TIFF reader and writer from filter module into VCL Change-Id: I2dc5da100071f51eaceaf1f8be4a191f6827668c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07one gtk-delete stock id with contextCaolán McNamara1-1/+1
no other use-stock has a context Change-Id: I6092cf82ca34b3a9cbf7b0609649c23298e0c0d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07poppler: upgrade to release 21.01.0Michael Stahl3-56/+42
Fixes CVE-2020-27778 and changelogs mention lots of fuzzing fixes. Change-Id: Ib07bdee726905e74afc13a01bbbd53f218121744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108912 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-07external/libebook: Missing include (for std::min)Stephan Bergmann2-0/+13
...as reported now by various Windows builders after e0f1b5bd94550835c639efda4e4c9a801c78dbe9 "Upgrade external/boost to latest Boost 1.75.0" Change-Id: Ib1f4ea2ca05003b24347c7233bd06cef7d4c955f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108920 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-07pdfium: rework to eliminate FPDF_ANNOTATION from the public interfaceMiklos Vajna2-50/+74
Change-Id: Ib11213f0307cd215b71e3da08468be6e82e2eb55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108914 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-07ScTable::GetProtection and ScDocument::GetTabProtection can be constMike Kaganski14-29/+31
Change-Id: Ic30a3fe10ae6206e876a05bed5dc189a9516b452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108851 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-07Make Pivot table db & external source dialogs asyncSzymon Kłos3-93/+130
Change-Id: Iff1a49a9fa04b55ece1aa30259ab57d105883eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108798 Tested-by: Jenkins
2021-01-07Missing construction of SfxCmisVersionsDialog::m_xVersionBoxStephan Bergmann1-0/+1
...ever since b1baf73dc671069bedec18d170f8199b0766ea60 "weld SfxCmisVersionsDialog". (Found by GCC 11 trunk with --enable-optimized, > sfx2/source/dialog/versdlg.cxx: In constructor ‘SfxCmisVersionsDialog::SfxCmisVersionsDialog(weld::Window*, SfxViewFrame*)’: > sfx2/source/dialog/versdlg.cxx:435:36: error: ‘this’ pointer null [-Werror=nonnull] > 435 | m_xVersionBox->set_size_request(m_xVersionBox->get_approximate_digit_width() * 90, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | m_xVersionBox->get_height_rows(15)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I2720d6bc49af717951a0af6a262fb013a27e09df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-07tdf#129815 Add InsertQrCode to Insert tab menu drop downandreas kainz15-0/+105
Change-Id: Iac7678cd3aaa25dcb66144f53656795f15023b9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108821 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-01-07Update git submodulesAndrea Gelmini1-0/+0
* Update helpcontent2 from branch 'master' to bdf63c9283a2081c947b65ef12a18cc9818f4bfb - Fix typos Change-Id: Ieaa9f4476a8738121453eb3589b98d5c17feeb72 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108915 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-07tdf#134439, tdf#116070: sw: Add UItestXisco Fauli2-0/+67
Change-Id: I7daf9437244238dfd4e270e8dee30ab8bfe4cc3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108885 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-07tdf#135636: sw: Add UItestXisco Fauli2-0/+54
Change-Id: I916db54fbb595ebc6d07194140a4aa09f7df9dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108887 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-07improve JpegWriterTest - detect type is correct during roundtripTomaž Vajngerl3-5/+14
Change-Id: I4560be2dd1627caf8126142930c3479668689273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108823 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-07Resolves: tdf#139126 DBL_MAX is a valid value, just not for WriterEike Rathke1-1/+3
Restore the old side effect behaviour where "1.79769313486232E+308" was not converted back to DBL_MAX, Writer doesn't check cell value after import for this "special value", *cough*. Change-Id: I31cf598d5f91d1f727d5f1f0e936a3505ea1b9e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108875 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-01-06Upgrade external/boost to latest Boost 1.75.0Stephan Bergmann10-118/+38
* <https://dev-www.libreoffice.org/src/boost_1_75_0.tar.xz> has been generated (on Fedora 33) with > $ wget https://dl.bintray.com/boostorg/release/1.75.0/source/boost_1_75_0.tar.bz2 > $ printf '953db31e016db7bb207f11432bef7df100516eeb746843fa0486a222e3fd49cb boost_1_75_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_75_0.html> > boost_1_75_0.tar.bz2: OK > $ external/boost/repack_tarball.sh boost_1_75_0.tar.bz2 > Unpacking boost_1_75_0.tar.bz2 ... > Removing unnecessary files ... > Creating boost_1_75_0.tar.xz ... > Cleaning up ... > cc378a036a1cfd3af289f3da24deeb8dba7a729f61ab104c7b018a622e22d21b boost_1_75_0.tar.xz > Done. * external/boost/StaticLibrary_boost_date_time.mk: Even though date_generators.cpp and greg_weekday.cpp are still present, their function definitions are now covered by inline function definitions in include files, > workdir/UnpackedTarball/boost/libs/date_time/src/gregorian/greg_weekday.cpp:23:17: error: redefinition of 'as_short_string' > greg_weekday::as_short_string() const > ^ > workdir/UnpackedTarball/boost/boost/date_time/gregorian/greg_weekday.hpp:52:17: note: previous definition is here > const char* as_short_string() const > ^ etc. and > workdir/UnpackedTarball/boost/libs/date_time/src/gregorian/date_generators.cpp:23:36: error: redefinition of 'nth_as_str' > BOOST_DATE_TIME_DECL const char* nth_as_str(int ele) > ^ > workdir/UnpackedTarball/boost/boost/date_time/date_generators.hpp:157:22: note: previous definition is here > inline const char* nth_as_str(int ele) > ^ * external/boost/StaticLibrary_boost_filesystem.mk now lacked various symbols, as seen when linking external/liborcus' orcus-parser library: > "boost::filesystem::emit_error(int, boost::system::error_code*, char const*)", referenced from: [...] > "boost::filesystem::emit_error(int, boost::filesystem::path const&, boost::system::error_code*, char const*)", referenced from: [...] > "boost::filesystem::emit_error(int, boost::filesystem::path const&, boost::filesystem::path const&, boost::system::error_code*, char const*)", referenced from: [...] > "boost::filesystem::filesystem_error::filesystem_error(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, boost::filesystem::path const&, boost::system::error_code)", referenced from: [...] > "boost::filesystem::filesystem_error::filesystem_error(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, boost::filesystem::path const&, boost::filesystem::path const&, boost::system::error_code)", referenced from: [...] > "boost::filesystem::filesystem_error::~filesystem_error()", referenced from: [...] > "boost::filesystem::detail::dir_itr_close(void*&, void*&)", referenced from: [...] > "boost::filesystem::detail::directory_iterator_construct(boost::filesystem::directory_iterator&, boost::filesystem::path const&, unsigned int, boost::system::error_code*)", referenced from: [...] > "boost::filesystem::detail::directory_iterator_increment(boost::filesystem::directory_iterator&, boost::system::error_code*)", referenced from: [...] > "typeinfo for boost::filesystem::filesystem_error", referenced from: [...] * No longer sure why external/boost/gcc9.patch.0 from e7b8728f5c0292a6c6a18e76220b1769ecf25aa3 "external/boost: silence -Werror=deprecated-copy (GCC trunk towards GCC 9)" was necessary at all, in addition to that commit's > #pragma GCC diagnostic ignored "-Wdeprecated-copy" changes, but at least a build with recent GCC 11 trunk appears to work fine now without it. (And the patch would no longer have applied as-is.) * The dropped patches in external/boost/c++20-allocator.patch.0 and external/boost/clang-cl.patch.0 would no longer have applied as-is, but also appear not to be needed any more. * external/boost/include/boost/property_tree/ptree_fwd.hpp became necessary to silence > In file included from workdir/UnpackedTarball/boost/boost/property_tree/ptree_fwd.hpp:16, > from libreofficekit/qa/gtktiledviewer/gtv-helpers.hxx:21, > from libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:19: > workdir/UnpackedTarball/boost/boost/throw_exception.hpp: In instantiation of ‘boost::wrapexcept<E>::wrapexcept(const E&, const boost::source_location&) [with E = boost::property_tree::ptree_bad_data]’: > workdir/UnpackedTarball/boost/boost/throw_exception.hpp:171:11: required from ‘void boost::throw_exception(const E&, const boost::source_location&) [with E = boost::property_tree::ptree_bad_data]’ > workdir/UnpackedTarball/boost/boost/property_tree/detail/ptree_implementation.hpp:826:13: required from ‘void boost::property_tree::basic_ptree<Key, Data, KeyCompare>::put_value(const Type&, Translator) [with Type = char [8]; Translator = boost::property_tree::stream_translator<char, std::char_traits<char>, std::allocator<char>, char [8]>; Key = std::__cxx11::basic_string<char>; Data = std::__cxx11::basic_string<char>; KeyCompare = std::less<std::__cxx11::basic_string<char> >]’ > workdir/UnpackedTarball/boost/boost/property_tree/detail/ptree_implementation.hpp:845:34: required from ‘boost::property_tree::basic_ptree<K, D, C>& boost::property_tree::basic_ptree<Key, Data, KeyCompare>::put(const path_type&, const Type&, Translator) [with Type = char [8]; Translator = boost::property_tree::stream_translator<char, std::char_traits<char>, std::allocator<char>, char [8]>; Key = std::__cxx11::basic_string<char>; Data = std::__cxx11::basic_string<char>; KeyCompare = std::less<std::__cxx11::basic_string<char> >; boost::property_tree::basic_ptree<Key, Data, KeyCompare>::path_type = boost::property_tree::string_path<std::__cxx11::basic_string<char>, boost::property_tree::id_translator<std::__cxx11::basic_string<char> > >]’ > workdir/UnpackedTarball/boost/boost/property_tree/detail/ptree_implementation.hpp:859:19: required from ‘boost::property_tree::basic_ptree<K, D, C>& boost::property_tree::basic_ptree<Key, Data, KeyCompare>::put(const path_type&, const Type&) [with Type = char [8]; Key = std::__cxx11::basic_string<char>; Data = std::__cxx11::basic_string<char>; KeyCompare = std::less<std::__cxx11::basic_string<char> >; boost::property_tree::basic_ptree<Key, Data, KeyCompare>::path_type = boost::property_tree::string_path<std::__cxx11::basic_string<char>, boost::property_tree::id_translator<std::__cxx11::basic_string<char> > >]’ > libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:300:103: required from here > workdir/UnpackedTarball/boost/boost/throw_exception.hpp:134:82: error: implicitly-declared ‘boost::property_tree::ptree_bad_data::ptree_bad_data(const boost::property_tree::ptree_bad_data&)’ is deprecated [-Werror=deprecated-copy-dtor] > 134 | explicit wrapexcept( E const & e, boost::source_location const & loc ): E( e ) > | ^ > In file included from workdir/UnpackedTarball/boost/boost/property_tree/exceptions.hpp:84, > from workdir/UnpackedTarball/boost/boost/property_tree/string_path.hpp:16, > from workdir/UnpackedTarball/boost/boost/property_tree/ptree.hpp:16, > from external/boost/include/boost/property_tree/ptree.hpp:30, > from workdir/UnpackedTarball/boost/boost/property_tree/json_parser.hpp:14, > from external/boost/include/boost/property_tree/json_parser.hpp:30, > from libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:26: > workdir/UnpackedTarball/boost/boost/property_tree/detail/exception_implementation.hpp:51:12: note: because ‘boost::property_tree::ptree_bad_data’ has user-provided ‘virtual boost::property_tree::ptree_bad_data::~ptree_bad_data()’ > 51 | inline ptree_bad_data::~ptree_bad_data() throw() > | ^~~~~~~~~~~~~~ etc. Change-Id: I36fcd04ca6f109910761a5802535a18cfb17ddd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108878 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-06Update git submodulesSeth Chaiklin1-0/+0
* Update helpcontent2 from branch 'master' to 491c08b20af8a0d1b2fcf3caf74926202fbcb541 - tdf#107229 update "Save as Template" help The labels on the controls changed with https://gerrit.libreoffice.org/c/core/+/107813 This patch: * updates the labels to the new names, + add a link in the <relatedtopics> to the Template Manager help page. + add <note> that explains this is recommended method and mentions "Import" as another way to add templates. Change-Id: Iad5b580d6c2f8917c37eb6cac9ba5b1c94adaa8e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107998 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-06Update git submodulesSeth Chaiklin1-0/+0
* Update helpcontent2 from branch 'master' to ef042f162e7403d0afb776b2efe81590e5242012 - tdf#107229 update help page for template manager ( shared/guide/template_manager.xhp ) + variable to <h1> for embedding into Related Topics + add "Thumbnail View" and "List View" and associated icon tables - remove <note>, which only repeats the information in <howtoget> + add missing "you" in introduction + add "Presentations" to filter list and XML markup to paragraph + add "All Categories" to Category list and XML markup to paragraph * spelling correction "defaults" -> "default" * improve explanation in <tip> about adding folders to Template path and XML markup in paragraph * change "Settings button" to "Settings icon" to be consistent with the "Settings" section; add "Reset Default Template" option and explanation. + add "Rename Category" to Settings submenu, and add XML markup + Add icon tables for "Setting", "Import", "Export", "Extensions" - Remove "tip" that only says "Refer to standard template" (which was included in original version from 2017. Same link is already included in Related topics. * Correct label from "Browse templates online" --> "Extensions" * updated description for searching for templates online * templates.libreoffice.org --> extensions.libreoffice.org. Because tags are curated on that website, have added the tag for templates to the URL. (changed in two places) + add explanations about how to select multiple templates for "Move" and "Export", thereby implying that batch operations are possible. + add tip with sys-switch about shortcut key to select all in connection with "Move" and "Export" + Add <h2> heading before context menu items * Change context menu item headings from <h2> to <h3> * change "Delete" explanation to indicate that multiple templates can be deleted, and add XML markup + Add <note> that builtin templates cannot be edited, renamed, or deleted * correction to Example 1 about selecting/opening templates * correct reference to icon in Example 2 and add period. * change (e.g.,) to "for example" in Example 2 * Reworked Example 3 from "negative" formulation to "positve" statement of what can be used, and then note that unavailable features can be accessed by restarting Template Manager. Change-Id: Ie53d865545a78224bcd018928667edd33e4b51dc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107549 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-06remove support for deprecated GtkAlignmentCaolán McNamara7-90/+0
Change-Id: I29e21e9e4d9b80b8c8e331ed9cce76b2e7fe0f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara46-14933/+13839
for cui part c git show -w is recommended to view these changesets Change-Id: I8c37b4904b528b5afe01c26b83c8df27b251909f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108688 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06replace only use of deprecated gtk-connectCaolán McNamara3-5/+2
Change-Id: I09cdb5c109b67f3686e701468c5a814c6c184832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06Update git submodulesQuentin PAGÈS1-0/+0
* Update dictionaries from branch 'master' to f4efcfcdb88a3c9208eb2b47e5be19047bb34768 - Update for Occitan dictionary Change-Id: Ieaa782496a85449833c7117c3c975cbeb00adb21 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/108899 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-06Drop comphelper::string::equals; compare OUString to OUStringCharMike Kaganski5-21/+13
In cui/source/tabpages/autocdlg.cxx, use code point-based methods for comparison with sal_UCS4 values in SvxSwAutoFormatFlags. Change-Id: If34c981393774d1b8db649f0c29870e1ca6bdfe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-06openssl: upgrade to release 1.1.1iMichael Stahl3-21/+2
Fixes CVE-2020-1971 * openssl-macos-arm64.patch.1: remove, was fixed upstream Change-Id: I405270228682025bf26240e3ea923bfd234068f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108804 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-06Resolves: tdf#139173 One-off error in limits for DEC2HEX()Eike Rathke1-1/+1
BIN2HEX() and OCT2HEX() were not affected because the string input is already limited to 10 characters and the converted decimal can't even reach the limits. Change-Id: Iba4212e8fc382287a1a454edf91426ba21497ae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108824 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-01-06pyuno: uno.Char is UTF-16 code unit, not UCS-4Michael Stahl1-3/+4
Check for that in ctor. Change-Id: Ia69b3d87ac4ccb5b6cc13169d7022c04607c609f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108803 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-06bIsBig member is redundantNoel Grandin2-55/+34
we can just use nLen != 0 to get the same information Change-Id: I2406322aa8b7cfc5e276818df763c6de08397454 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-06external/boost: Backport a Boost 1.72.0 fixStephan Bergmann2-0/+43
...for issues with MSVC 2019 16.8.3 --with-latest-c++ in external/libwpd: > [build CXX] workdir/UnpackedTarball/libwpd/src/lib/libwpd_internal.cpp > C:\lo\core\workdir\UnpackedTarball\boost\boost/proto/generate.hpp(239): error C2039: 'value': is not a member of 'boost::proto' > C:\lo\core\workdir\UnpackedTarball\boost\boost/proto/generate.hpp(32): note: see declaration of 'boost::proto' > C:\lo\core\workdir\UnpackedTarball\boost\boost/proto/generate.hpp(239): note: This diagnostic occurred in the compiler generated function 'Extends<boost::proto::exprns_::expr<boost::proto::tagns_::tag::terminal,boost::proto::argsns_::term<MemberClass::* >,boost::proto::argsns_::term<MemberClass::* >::arity>> boost::proto::pod_generator<Extends>::operator ()(const boost::proto::exprns_::expr<boost::proto::tagns_::tag::terminal,boost::proto::argsns_::term<MemberClass::* >,boost::proto::argsns_::term<MemberClass::* >::arity> &) const' > C:\lo\core\workdir\UnpackedTarball\boost\boost/proto/generate.hpp(252): note: see reference to class template instantiation 'boost::proto::pod_generator<Extends>' being compiled [...] Change-Id: Iae62b41e09b89bd387efab2744d47d938a868d17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108839 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-06Fix MSVC 2019 16.8.3 --with-latest-c++ error C2102: '&' requires l-valueStephan Bergmann1-1/+1
Change-Id: Iff1db722239c32822bbc23ddd13e2df105a993e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108837 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-06Fix MSVC 2019 16.8.3 --with-latest-c++ two-phase name lookup issuesStephan Bergmann2-0/+8
> C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(105): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 5 arguments > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(83): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(118): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::string>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::string &)' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(382): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[18],std::string>(MSIHANDLE,const char (&)[18],const std::string &)' being compiled > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(105): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 6 arguments > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(83): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(118): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::string,char[6]>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::string &,const char (&)[6])' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx(516): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[19],std::string,char[6]>(MSIHANDLE,const char (&)[19],const std::string &,const char (&)[6])' being compiled and > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(104): error C2660: '`anonymous-namespace'::WriteLogElem': function does not take 5 arguments > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(82): note: see declaration of '`anonymous-namespace'::WriteLogElem' > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(117): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLogElem<char,std::wstring>(MSIHANDLE,MSIHANDLE,std::ostringstream &,UINT,const Ch *,const std::wstring &)' being compiled > with > [ > Ch=char > ] > C:/lo/core/setup_native/source/win32/customactions/reg_dlls/reg_dlls.cxx(159): note: see reference to function template instantiation 'void `anonymous-namespace'::WriteLog<char[27],std::wstring>(MSIHANDLE,const char (&)[27],const std::wstring &)' being compiled Change-Id: I7e8c121f8589ae847c9e4fd12e218408ea9e451e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-06external/clucene: Fix MSVC /Zc:strictStringsStephan Bergmann2-0/+23
...which is apparently enabled at least in MSVC 2019 16.8.3 when building with --with-latest-c++ (i.e., /std:c++latest): > C:/lo/core/workdir/UnpackedTarball/clucene/src/contribs-lib/CLucene/analysis/PorterStemmer.cpp(124): error C2664: 'bool lucene::analysis::PorterStemmer::ends(TCHAR *)': cannot convert argument 1 from 'const wchar_t [5]' to 'TCHAR *' > C:/lo/core/workdir/UnpackedTarball/clucene/src/contribs-lib/CLucene/analysis/PorterStemmer.cpp(124): note: Conversion from string literal loses const qualifier (see /Zc:strictStrings) > C:/lo/core/workdir/UnpackedTarball/clucene/src/contribs-lib/CLucene/analysis/PorterStemmer.cpp(97): note: see declaration of 'lucene::analysis::PorterStemmer::ends' etc. (and which is not silenced by gb_Library_set_warnings_disabled in external/clucene/Library_clucene.mk, unlike the corresponding Clang/GCC -Wwrite-strings) Change-Id: Id3c8eefa4658bf942de6c8ae9b219212eba79995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108840 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-06Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 40c4109b5b8554f5c068b0ccadad5577a6a0096c - ScriptForge library modules - WiP - Exception module - 7.1 mention in lib_Scriptforge - x-refs between VBA Err object and sf_exception Change-Id: I8512635ff54b50bb190c3fe734441d6b7e9ae9c1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107798 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-06tdf#134288 svx: fix rendering of text on a zero-width shapeMiklos Vajna3-13/+66
We have conflicting requirements here: on one hand, the shape is zero width, so the text area is also zero. On the other hand, we put some text on the shape, which should be visible. The result was that the left/right text margin (2x250 mm100) was counted as part of the text area, so we put a few (but not 1) characters / line for zero width. Fix this to be PowerPoint-compatible: as the width decreases, we break the text up to more and more lines, but if the width is 0, then we don't break it up at all. An alternative would be to do this later in SdrTextObj::impDecomposeBlockTextPrimitive(), but there we no longer know the width is really 0, because the text margins and some small increase (+1 to be an inclusive range, +1 to have a non-zero scale) is already added to the original width. Change-Id: Ieaa3e726bc5d37983b6221452e14f01db315f790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108835 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-06Release solar mutex before using an apartment-threaded COM objectMike Kaganski2-5/+28
See https://lists.freedesktop.org/archives/libreoffice/2020-December/086448.html for motivation This partially reverts f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de. Although this change is questionable, it's intended to avoid crashes (tdf#139074); a better fix should replace this eventually. Optionally releasing a lock isn't a good API and might hide other bugs, but the better solution to handle all requests in the main thread would need an even larger rewrite of the Windows clipboard code. It's simply too late for that in this LO release cycle. Change-Id: I60e847599fe873025c9903b9d6290ed4cdf4a961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107669 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-06Fix various MSVC 2019 16.8.3 --with-latest-c++ issuesStephan Bergmann1-24/+24
> C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(863): error C2440: 'type cast': cannot convert from '_typelib_TypeClass' to 'com::sun::star::uno::TypeClass' > C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(863): note: Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast) > C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(863): error C2046: illegal case etc. and > C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): error C2668: 'System::Array::GetValue': ambiguous call to overloaded function > C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): note: could be 'System::Object ^System::Array::GetValue(__int64)' > C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): note: or 'System::Object ^System::Array::GetValue(int)' > C:/lo/core/cli_ure/source/uno_bridge/cli_data.cxx(1333): note: while trying to match the argument list '(sal_Int32)' etc. (the latter hit at least with a 32-bit --host=i686-pc-cygwin build) Change-Id: Iac372204ee86c8bd590f3b940ed2382dd7f8d2d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108838 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-06Hide calc input bar tooltips in onlineSzymon Kłos1-10/+14
Change-Id: I07b364d55a3578161087eef281e313d5efae3ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105632 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108797 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-06move the bigint based Scale() implementations to one central placeNoel Grandin9-70/+52
Picking the best looking one in the process. Change-Id: I77f9236fcd21f883a23fe2f43f20336f17b44cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108831 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-06use anonymous union for BigIntNoel Grandin1-2/+5
since we only use one or the other of these fields. Change-Id: Ib9cb4895028420a74d0a65d6cd934b0f56f203a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-06NFC sw dialog titlepage.cxx: general code cleanupJustin Luth2-76/+60
1.) make the shell a reference since it is always assumed. 2.) flatten and reduce unnecessary code 3.) aTitleDesc can be initialized earlier, so eliminate one unecessary page jump. 4.) rename nNoPages - since "No" really needs to be "No." with a fullstop in order to be a shortform for number. Plus there are lots of NumPages here - so which one is it? Change-Id: I2b6b73ddd9f6ec1b72f7e71b7803ed28355a030d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108331 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-06exclude more tests for non-default DPINoel Grandin1-0/+3
Change-Id: I411c70069273889821de96f2f2cea46d8f11da9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 16:58:55 +0000