summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-07-30tdf#135244: prevent jumping to cursor at document renderMike Kaganski1-0/+5
This prevents the jumps when printing Change-Id: I8b6f7d60aa0ed443ec8e05ad5812830a6b655abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99715 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-30tdf#135244: move LockAllViews to SfxObjectShellMike Kaganski4-11/+28
... so that it may be called from SfxObjectShell::SaveTo_Impl, and handle export cases in addition to save (as) handled in tdf#41063. Change-Id: Ie39196656dd1a95dcb6bab3ae8138c2f5c8729e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99714 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-29expand out macroNoel Grandin1-11/+15
Change-Id: I607e1defbd657546bfc017d16d0edfcf0dc2c028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29i18npool: create instances with uno constructorsNoel Grandin5-259/+220
See tdf#74608 for motivation. Change-Id: I814512ccc546bd015558a8122f0d2e3803437e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29tdf#134250 add unit testMichael Stahl2-0/+147
Change-Id: I4c5d7bc1c2471a14afabf331acb8c2f2781382bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99672 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-29update DbFilterField to use the new replacement controlsCaolán McNamara3-22/+18
Change-Id: I5b138a776ebbad9e5f7a50f3f44ab56fa283cba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Port to FreeBSD aarch64miki2-0/+19
Change-Id: Ib18894db8c2943dd1502c96951545bb75a1944eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91978 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-29center the filter checkbox like the normal oneCaolán McNamara1-1/+10
Change-Id: I7954430640fe9788c650f5fe7b103426731204cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29update svtools pchCaolán McNamara1-3/+2
Change-Id: If636d1bda03c2932225980d9f2f31f0d06748a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29automatic layout height is sufficient for the toc CtrlParentWinCaolán McNamara1-2/+0
Change-Id: I6ece49cce56aedf4f6da1361443c1337387143fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99712 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29use 0 as the limit-less caseCaolán McNamara2-4/+3
since... commit 9ebe58f0437bbb5714e629bd22e004ac895086d6 Change-Id: I001567bb7beb0a51d55c75fe36761f4c964348e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99711 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29move SetReadOnly into ControlBase as SetEditableReadOnlyCaolán McNamara3-7/+29
and cast to that instead of "Edit" and override the Editable controls impls to do something suitable when called Change-Id: I24cc02b603e9551df4e3eb39f6cb4839883db777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99709 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29dynamic_cast followed by static_castCaolán McNamara1-1/+1
Change-Id: I63cb568b21f0f645849b39685966d28d16760594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99706 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29use a EditControl nowCaolán McNamara1-3/+1
Change-Id: I011770676c91ea7cc83dc215ae92fa37c816e200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29tdf#130154: update locale data for Estonian [et-EE] - follow-upMihkel Tõnnov1-16/+16
Follow-up for 4804d969bacd25ad586b3bf70d3dc8c27adb48ef: * change abbreviations to omit trailing periods, as officially preferred * add quotes around literal characters in date formats (so those formats wouldn't be mistakenly detected as "user-defined") * revert sorting of a few date formats for backwards compatibility's sake: - when opening files created in 7.0, previous versions shouldn't add ". a" anymore to formats that aren't supposed to have it Change-Id: I666273aa32e7ca363aa929b8a1fd83bf46533f6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99264 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-07-29loplugin:flatten in sc/filter/xmlNoel Grandin36-3501/+3502
Change-Id: I93117f601a8f450ebfcde32c156802137b87da76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29update creditsChristian Lohmaier1-1580/+1619
Change-Id: I5ab692f72ae2433fa39b23c65f16fe9a71fc990c
2020-07-29loplugin:flatten in sc/core/toolNoel Grandin30-6426/+6431
Change-Id: Ibe5302ee320cf2e89c814dfb34ad42f9d72a25aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99700 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29loplugin:flatten in sc/ui/AccessibilityNoel Grandin7-404/+404
Change-Id: Ia99a0f99cbec91fde97bad525768725e5a1ad22a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29ignore invalid dates like the vcl Calendar doesCaolán McNamara1-0/+3
Change-Id: I6a607936849923bfb7e7db3550ebca3c9083aa8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29[API CHANGE] officecfg: remove SecureExtensionsCaolán McNamara2-459/+0
SecureExtensions has been unused since commit 38f78d69ee94c951d78676ef0f176457b333ff2a Date: Fri Sep 23 14:51:06 2005 +0000 INTEGRATION: CWS fwk20 (1.96.8); FILE MERGED 2005/08/15 09:49:56 pb 1.96.8.1: fix: #i49802# security warning removed Change-Id: Id95edfb8e60402a80b11855ffaef5aa01f9f6231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29replace and drop SvtExtendedSecurityOptions classCaolán McNamara8-298/+15
Change-Id: Ibe3443531c83eb44080217b61f5746be9cce9c49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29tdf#135264: draw to mpAlphaVDev after DrawTransparentNativelyMike Kaganski1-3/+2
Otherwise the transparency is lost for the cases where mpAlphaVDev is used. Change-Id: Ic7b92cb69727dbe8901695ba496878f0ea381826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99694 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-29WIN fix detection of user-passed, wrong 32bit JDKJan-Marek Glogowski1-4/+4
If you pass an explicit JDK using --with-jdk-home, this would always test the registry value for the 32 bit test. Change-Id: If295964c5a594af26fa98ba9f4b302a6c8e7e45a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99686 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-29Add verbose climaker outputJan-Marek Glogowski1-0/+1
If you run gbuild verbose, make climaker output verbose too. Change-Id: I712f156bae33bfd403403675f4e2117282a7079c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99684 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-29configure: fix TLS result outputJan-Marek Glogowski1-1/+5
Change-Id: I488e287667a02bf9212b024420bb462deeeb052d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99685 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-29replace and drop MiscCfgCaolán McNamara15-360/+45
Change-Id: I5ea9e3663fc5d30d725cf18757badb9b9802da18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29drop lines that don't do anythingCaolán McNamara1-2/+0
since... commit 9a4d0581c72653e60562d1b8e2121772d21f8a9e Date: Mon Oct 12 11:49:13 2009 +0200 #i103496#: move SysLocale stuff to unotools Change-Id: I6a7c3d71af7e91f873a2cab3393e8cefdcdff28d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99693 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: Icb8d98103b40574f7120e2c93c03e4147cd9b5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29Fix typoAndrea Gelmini3-4/+4
Change-Id: I4b1eefee1fd77d946f2926d0a0bb5b929de5d374 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98997 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29Fix typoAndrea Gelmini1-1/+1
Change-Id: I2abdfc45dac226ee177209655d9f92cb88f0fdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99704 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia723bc6d16a9102f24e17176edce440fbc646bd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99638 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29replace and drop SvtPrintWarningOptionsCaolán McNamara11-438/+17
Change-Id: I17fd4156eb940fbdc925d9761301096e5349135f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29ofz#24404 row insert attempt in table with same table already in the rowCaolán McNamara3-1/+21
Change-Id: I0f52de029600b182e479af3bdf56da7ea2c2ef01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29tdf#133958 only move the selection to the error if its not already thereCaolán McNamara1-2/+11
Change-Id: I3046c842cc6c8bcc867c79989a8978d382b08269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Removed executable permission on fileAndrea Gelmini1-0/+0
Change-Id: I17b53755a4ac953208d347be1424e85b2455363d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99690 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-07-29allocate bitmap data buffer on demand in SkiaSalBitmapLuboš Luňák2-20/+55
And also make sure mScanlineSize is always correct, which it seems like it possibly might not have been the case (the delayed scaling makes it a bit complicated, as the internal scanline size is based on the internal bitmap size mPixelsSize, not the externally reported bitmap size mSize). Change-Id: I0d6cc2fca27ffa1c3accc13b38c8c01b5ffc8ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99680 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-29sd_component_getFactory no longer existsCaolán McNamara2-4/+52
Change-Id: I78405fc5ddbafa9760644bebaeee4ce4622a6c3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99679 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29drop newly unused SvtFontOptionsCaolán McNamara7-400/+0
Change-Id: Iaab664770d96a7d197354949bbe6d82c248f1037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Further timing issues with test_insert_hyperlinkStephan Bergmann1-0/+1
<https://ci.libreoffice.org/job/lo_ubsan/1709/> still failed with > FAIL: test_insert_hyperlink (hyperlinkdialog.HyperlinkDialog) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/hyperlinkdialog.py", line 71, in test_insert_hyperlink > self.assertEqual(get_state_as_dict(xindication)["Text"], "link") > AssertionError: '' != 'link' > + link > so try a fix similar to 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" Change-Id: I04b1616f3c5028065aafadbd73e0e52ef220ce5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99669 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-29tdf#115753 fix table border missing when there are merged cellsnd1015-16/+55
Remove code that ignores merged cells. Change-Id: I907220e9ffc9d18561171efd7d6b39d14a8341fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93836 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-29tdf#59674 Word export: set a tabstop at numbering IndentAtJustin Luth4-19/+32
...if the specified tabstop would be ignored - for the benefit of MS Word. After the numbering character, the tab in Writer stops at A.) IndentAt, or B.) a non-default tabstop. In other words, Writer ignores default tabstops. (Caveat, LO ignores IndentAt when numbering sets a larger tabstop.) However, MS Word does NOT necessarily stop at IndentAt, but it stops at default tabstops, or a specified tabstop. It only seems to stop at IndentAt if there are only default tabstops that are farther than IndentAt. In other words, Word usually ignores IndentAt. (This is true for .doc and .rtf formats. It is also true for .docx format with MS Word 2003, but not with MS Word 2016.) In this patch, I only try to fix Word ignoring the IndentAt. [A basically-unsolvable edge case is when the tabstop is larger than the first line indent, but still not behind the numbering character.] This patch could regress if paragraph-level tabstops define the position. In that case, we have introduced another tabstop at the indentAt position, and so a SECOND tabstop on the FIRST line might end up at the wrong position. This is an EXTREMELY unlikely situation, and in fact, both LO and Word seem to tabstop there anyway, so I no longer think it would cause a regression. Go figure. I heavily modified an existing unit test because although that fix "works" and was an "easy fix" it probably ought to have calculated the IndentAt and used that instead of zero to replace the LO default values. It works, however, so I won't bother doing anything about it. (Also, the paragraph used doesn't matter - it is the same list.) Change-Id: Ia13ac880ab63c610b26c99ab77903e08ebdebe35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99529 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-29optimize a bit more conversions to/from Skia bitmap formatsLuboš Luňák10-60/+269
It turns out this doesn't really matter in practice, since if converting between pixel formats is where time is spent, something higher must be already wrong. But since I've already written this... Change-Id: I25451664d529a9226d2d81b2c424a4f4e5422ad5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99577 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-29move ImageButton to toolkit-only headersCaolán McNamara2-15/+15
Change-Id: I2413d4165f2b1a88c53facbb0993cc6623a28082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29sw reqif-xhtml export: avoid writing text-decoration:noneMiklos Vajna4-7/+44
This CSS key is allowed, but only the underline and line-through values are allowed in reqif mode, according to the top of page 66 of "01_OMG_Requirements Interchange Format (ReqIF)_Version 1.2_formal-16-07-01.pdf". Change-Id: Ide64344f58bde4569fe499d8514dab36a055bda9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99662 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-29tdf#134250 sw_redlinehide: fix Undo with section before tableMichael Stahl1-1/+12
... at start of document, part 2: In SwUndoDelete::UndoImpl(), the m_aEndStr wasn't inserted, because the pTextNd was a section node. This caused asserts when trying to add the history hints that used to be in the end text node. thints.cxx:1295: bool SwTextNode::InsertHint(SwTextAttr*, SetAttrMode): Assertion `!pAttr->GetEnd() || (*pAttr->GetEnd() <= Len())' failed. (regression from 57d488660572d62ef0371e50dcdd4ca7a6d98a14) Change-Id: I48caa7487d2d1e6250b5aceab18f270555d3ee8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99644 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-29tdf#134250 sw_redlinehide: fix copy non-empty node before non-textnodeMichael Stahl1-1/+8
The problem in CopyImplImpl() is that pCopyPam's end position was updated to index 0 but text was copied into the node, which is thus not covered by pCopyPam and thus also not by SwUndoInserts. Then SwUndoInserts::UndoImpl() doesn't delete the bookmarks in the end node and the bookmark positions cause ~SwIndexReg asserts. Change-Id: I4cc03e846eae4cabd9eb4346a98c1e5c2866050d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99643 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-29replace and drop SvtCompatibilityViewOptionsCaolán McNamara8-231/+9
Change-Id: Iab187468cf25b4a4afc7c79578677156ff224df9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29expand last ImageButton to underlying PushButtonCaolán McNamara2-2/+2
Change-Id: I260a738b06831684840175ba9b126ce41bacedfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29LOK: added margin between sidebar and formula-barPranam Lashkari1-1/+3
Margin code moved from online to core Adding offset in online caused row/column header getting out of sync Change-Id: Ie977e0f6c6180b2bc20c94b88fd1d56144ed5faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96893 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99639 Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 07:37:01 +0000