summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-09-28Test the case for pivot tables sharing a groupTamás Zolnai2-0/+29
Fixed with 3b64a198568d5b2bb14066581aca112cc6182fd7 Change-Id: Ideea06ea95f6c565e1487f2b27ef249c38c5d4dd
2016-09-27Resolves: tdf#101475 adjacent cells text is still too wideCaolán McNamara2-13/+17
this still isn't brilliant I guess Change-Id: I18b6647133329afa85826a8014f839986a9b68de
2016-09-27MediaWiki export help: “WikiMedia” → “MediaWiki”; minor copyeditingAdolfo Jayme Barrientos5-40/+36
Why is “wiki” always capitalized? It’s not a proper name. Change-Id: I55941f192e149dc93a6576e5ca21edac78299cb4
2016-09-27Resolves: tdf#101884 keyboard navigation in User defined border controlCaolán McNamara1-0/+1
Change-Id: I92ea37754f057c560d19b41f814a1d649ea74876
2016-09-27sc-perf: avoid repeated TrackFormulas() during bulk broadcast, tdf#87101 rel.Eike Rathke4-1/+33
Multiple callers involved. Most significantly ScDocument::Broadcast() calls ScDocument::TrackFormulas() individually. Track/collect pending formula cells at the end of the bulk broadcast instead, which gives an instructions read speedup by factor 6 for the broadcast, and an overall speedup in the scenario for inserting the rows by factor ~2 wall clock time. ScDocument::InsertRows() Before, Ir Incl: 282,227,033,656 After, Ir Incl: 66,307,994,805 With cycle detection: ScDocument::TrackFormulas() Before: Ir Incl Ir Self 66,981,644,959 11,913,444,899 After: Ir Incl Ir Self 10,819,556,073 1,973,232,494 Change-Id: I85fe8b03ecb52cffaa6fa14354b3cc3467ecc111
2016-09-27add test for tdf#101843Markus Mohrhard1-0/+24
Change-Id: I90bd5e8042e3157286774c97d2ea3c109da2b658
2016-09-27tdf#101843, ensure repeated rows set the hidden/filtered flag correctlyMarkus Mohrhard1-0/+6
Change-Id: I759107eeb074698d5e4987c76005788aee33287d
2016-09-27tdf#102630: [API CHANGE] Remove SharePoints support from PathSubstitutionStephan Bergmann1-560/+0
...apparently unused and broken (see issue) Change-Id: Ic20d287b59d3317fecdba03a3edf8f51611c91ba
2016-09-27Adapt external/liblangtag/clang-cl.patch.0 to liblangtag 0.6.1Stephan Bergmann1-0/+21
Change-Id: Idf75ffa042c4858ef9bea99d603adb691b295139
2016-09-27this should always be empty nowCaolán McNamara1-8/+2
Change-Id: I5849ce78407675150ca1fd96388a4569bcd14f4a
2016-09-27Resolves: tdf#102177 focus not restored from context menusCaolán McNamara3-28/+40
the problem being that the attempt to restore the focus in the document in the floatingwindow tear down is blocked because the menus have set that window as modal so the focus isn't set. The attempt to set the focus in the floatingwindow teardown causes the SavedFocus in the menufloatingwindow to be dropped, so the extra layer of code to restore focus after modality is removed doesn't do anything this is fallout from... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves: tdf#87120 no keyboard navigation inside floating windows which allows the focus to "truly" enter the menus, triggering the floatingwindow attempt, which fails but blocks the menufloatingwindow attempt easiest thing seems to make the restoring modality, and then restore focus, something that MenuFloatingWindow does before it finishes Change-Id: I97a4ac71419dcb04709e4667586d8343e89ddbeb
2016-09-27ImplEndPopupModeHdl takes no argumentCaolán McNamara1-1/+1
Change-Id: I2e4a498bb9c4d5e887f55d38cdae6c6aeef44a4d
2016-09-27detangle code that now looks silly since...Caolán McNamara1-12/+6
commit 9b7dfb10641ba7978ffcbd1db0507163411ae027 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jun 9 16:52:21 2016 +0100 EndSaveFocus does nothing on the !bRestore case removed the code that made it look like it made sense Change-Id: I2e7280fd6643e86d65cba04c8302be099d6f3d0e
2016-09-27the only place the default xFocusId arg isn't used...Caolán McNamara2-4/+4
the argument is (effectively) equal to the default Change-Id: I26fcd43d2bc8e37e6887c244f728e3231328e34e
2016-09-27Use FixedVariable::bAbsPath to check for special path varsStephan Bergmann1-3/+1
Change-Id: I526c45ecf3c7e21b87c16eef5047707f74da7668
2016-09-27Remove redundant FixedVariable::nEnumValueStephan Bergmann1-34/+36
Change-Id: I39a2a65e06cdf421786fbbfedecad604fcb3abd2
2016-09-27Remove unnecessary typedefsStephan Bergmann1-4/+2
Change-Id: I0c65720a3db88242bdf36338864f6961478f547f
2016-09-27Use range-based forStephan Bergmann1-16/+11
Change-Id: If112967db4828f8570692af5dbbbd9e3c2a837aa
2016-09-27Reduce var scopeStephan Bergmann1-4/+2
Change-Id: I5b5ea9968c7648e38a5cacda5e1f6ba8bea78749
2016-09-27tdf#101249 fixed crash after inserting OLE object 2Szymon Kłos1-7/+9
Change-Id: I1997e69e09cfae10b26a3b3e851583714ee9b3e9 Reviewed-on: https://gerrit.libreoffice.org/29318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-09-27clang plugins: do "dotdot" normalisationNoel Grandin9-28/+42
which fixes some false positives Change-Id: I555349180b5ca819f29695789f1545ba2177bd09 Reviewed-on: https://gerrit.libreoffice.org/29320 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-27Revert "tdf#90697 unit test for rtf import"Samuel Mehrbrodt2-80/+0
b/c of crash in dbgutil build This reverts commit 298571e2e10f5a925abc3cb75940dbef5701b583. Change-Id: I41e6e9d17809e416813b4ee4032f38d3278b4103 Reviewed-on: https://gerrit.libreoffice.org/29319 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-27sw: avoid emitting invalid cursor pos during end text edit of commentMiklos Vajna4-2/+58
A comment text edit (provided by editeng) works with relative twip coordinates, conversion of the cursor position to absolute twips happens in ImpEditView::ShowCursor(), provided that the pOutWin member has a map mode origin that respresents the offset correctly. This is not true during SwSidebarWin::DeactivatePostIt(), the map mode origin is already reset back to 0, so just don't emit callbacks during shutdown, the sw body text cursor will be shown later anyway. Change-Id: I02c15bb9fad99db8e43fd2f37df770dd165be788
2016-09-27add BASE test caseZdeněk Crhonek1-0/+2129
Change-Id: I40ca3d8b2851bd2ccbf2826eb7ccf80abbf80b7e Reviewed-on: https://gerrit.libreoffice.org/29193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-27configure: reject Apple JDKMichael Stahl1-0/+7
Since commit 32bc8ddbf335dd26019edcf12758643b4cff9913 the jvmfwk rejects Apple JDK and while the Java code builds fine with it, various tests such as CppunitTest_dbaccess_hsqldb_test fail if it is the only installed JRE. The simplest way to avoid the problem is to not allow building with Apple JDK. Change-Id: I5701e38cffded4596ac94608867a038ff76f75ec
2016-09-27configure: non-working ant is an error, not a warningMichael Stahl1-3/+1
For example ant 1.8.4 doesn't work with JDK 1.8. Change-Id: I709fd0591c330cbfe6542976eb2fa0c3aec1e63f
2016-09-27SAL_WARN in case bBackToLoaded failedStephan Bergmann1-1/+4
Change-Id: I3ee3801ae36b7394a97f46e76116cfd11c74de2d
2016-09-27convert floating add field to .ui formatCaolán McNamara10-236/+172
Change-Id: Ica9adc19f370d6340d2f5fac552cf1b995b390e0
2016-09-27Resolves: tdf#98946 too many running MathTypes...Caolán McNamara1-0/+16
causes mathtype to display a warning dialog, so try restoring them back to loaded after loading them in order to get their preferred size Change-Id: Idff714efa228a739f380dbae429d852a8f8c5298 Reviewed-on: https://gerrit.libreoffice.org/29234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-27tdf#87914 sw: add an initial .uno:SmallCaps commandMiklos Vajna9-0/+91
- handle it in SwTextShell (for normal Writer text) - simple icon in the galaxy theme Change-Id: Ib8f11dbca28b19a2fc0411c92d9f0b4b052277bb
2016-09-27Add noteStephan Bergmann1-0/+7
Change-Id: I68af0bcfd6700ee40f2d0879e57de9d66c62c983
2016-09-27tdf#101898: Only re-substitute whole segments with $(username)Stephan Bergmann1-1/+2
...otherwise, if $(username) happens to be "user", it will endlessly re- substitute inside a (already partly re-substituted) URL of the form $(user)/... Regression introduced with 16fb0d3d0f68708c183c53bd18660a23970b77fe "tdf#98407 PathSubstitution: Add substitution for $(username)". Change-Id: I1c8b64f383fdfd97fa5edc192e9ca4b46944d6f1
2016-09-27Actually, just get rid of these file-local const variablesTor Lillqvist1-13/+8
Use string literals instead. Follow-up to b7dfa4d6625d066f5507420089434cb7ac29c968. Change-Id: I364c792d69c052b0d581490f425b2543172c62d8
2016-09-27sw: Drop unused forward declarationsTakeshi Abe14-20/+0
Change-Id: I2913466f8fa87b3c377a1abf65b8ccc477b73f40 Reviewed-on: https://gerrit.libreoffice.org/29311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-27tdf#90697 unit test for rtf importSamuel Mehrbrodt2-0/+80
When importing this rtf file, sections were interpreted as page breaks. They shouldn't, instead all content should be on the same page. Change-Id: I445ce507d14d21ef568734ab7020eed9cbfe57ac Reviewed-on: https://gerrit.libreoffice.org/29298 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-27tdf#38835 - strip out non-trivial globals before mainRosen1-4/+4
deleted calling OUString object calling in global Change-Id: Iac4cb9583bf8c00a6743d018f6234ca5181d72e3 Reviewed-on: https://gerrit.libreoffice.org/29312 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-27add GAMMAINV test caseZdeněk Crhonek1-0/+4973
Change-Id: I46c185f911604a2b70c0be9e5e05ce385871e271 Reviewed-on: https://gerrit.libreoffice.org/29304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-27Updated coreJohnny_M1-0/+0
Project: help 10fd59fe53de18975ae62bed7df510ea0432f728 Improved topic relations for a selected set of pages Following pages are affected by this update: 1. "Functions by Category" (https://help.libreoffice.org/Calc/Functions_by_Category): - Added a variable to its heading, so that it can be referenced from other places - Removed self-referece in its "Related Topics" (it was turned into the above heading reference instead, thereby also correcting the remote HTTP page reference to local help file referece). Note: Pages already using the reference will auto-ajust (e.g. "Related Topics" of https://help.libreoffice.org/Calc/Statistical_Functions_Part_One) - Corrected "Operators" reference location by moving it into "Related Topics" 2. "Statistics Functions" (https://help.libreoffice.org/Calc/Statistics_Functions): - Added a variable to its heading, so that it can be referenced from other places (point 6 below) - Cleaned up references by adding a "Related Topics" section - Using links to heading variables in "Related Topics", for improved heading string consistency 3. "Text Functions" (https://help.libreoffice.org/Calc/Text_Functions): - Added a variable to its heading, so that it can be referenced from other places (point 5 below) 4. "Add-in Functions" (https://help.libreoffice.org/Calc/Add-in_Functions): - Added a variable to its heading, so that it can be referenced from other places (points 5 and 6 below) 5. "Add-in Functions, List of Analysis Functions Part One": - Added a variable to its heading, so that it can be referenced from other places (point 6 below) - Moved "Related Topics" chapter to the bottom of the page - Using links to heading variables in "Related Topics", for improved heading string consistency 6. "Add-in Functions, List of Analysis Functions Part Two": - Added a variable to its heading, so that it can be referenced from other places (points 2 and 5 above) - Moved "Related Topics" chapter to the bottom of the page - Using links to heading variables in "Related Topics", for improved heading string consistency The updated pages were tested as described in https://wiki.documentfoundation.org/HelpContent#Without_the_LibreOffice_Core_Repo on 32-bit Debian Linux with: Version: 5.3.0.0.alpha0+ Build ID: d15082cac2306fb9562ff126eb5827b7b9eee1e1 CPU Threads: 2; OS Version: Linux 4.6; UI Render: default; TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-09-19_05:41:30 Locale: en-US (en_US.UTF-8); Calc: group Change-Id: Icbb3725fd16d3ff76e5e4244c2284349332cffb7 Reviewed-on: https://gerrit.libreoffice.org/29306 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-27Add note that Rectangle::toString() format now has a stability requirementTor Lillqvist1-0/+3
De facto, at least. Change-Id: Ie83f275d376841a7e4e9f7e80895165fe70a69b9
2016-09-26Move up the less common case and reduce indentation for the main case.Kohei Yoshida1-24/+23
Change-Id: Id30a849af718629515251cac39eead39a2d9e5e6
2016-09-27don't dynamically link to system boost in internal boost caseMarkus Mohrhard1-0/+1
Change-Id: If1cc03b3861ac89b14d8d726fa4ce042f0086b24
2016-09-27tdf#101104 this paranoid safety check actually causes a bugMarkus Mohrhard1-4/+0
Change-Id: Id31f98f5f84eabf603045e4d9f7ebd448689eed5
2016-09-27OOPS, we were actually testing the wrong methodMarkus Mohrhard3-3/+16
Change-Id: I29adf81d3da56d7150e5182025d931ee62598e63
2016-09-27Return early on errorTamás Zolnai1-19/+18
Change-Id: I963c069e27903e3d1a709ce0c17666a17f45f132
2016-09-27This parameter can be const.Tamás Zolnai2-2/+2
Change-Id: Ia77b9bebb0653ce5d428956b4d2fca39461bb7c2
2016-09-26Related: rhbz#1366710 fedora mips64 and mips64le use lib64Caolán McNamara1-1/+1
Change-Id: I34aacd5c15595786b8dde4202a7538c4ff7889a3
2016-09-26cppcheck: noExplicitConstructorCaolán McNamara3-3/+3
Change-Id: Id410f19787f25bc9633ff69fa947c477cc999420
2016-09-26implement prototype for more stable calc cell style namesMarkus Mohrhard21-10/+143
This should ensure that as long as the style does not change the cell style name is the same after an import export cycle. Each ScPatternAttr stores a unique ID and we store the ID to name mapping during import. During export if we find a ScPatternAttr that has a key that is also stored in the map we write back the style name from the map. To avoid name collisions we block the style names from the import for the export. The missing piece to make this completely awesome is now to make sure that styles are sorted by name during export. That way we can reduce the diff between import and export even more. Change-Id: Ie4fe2aa00f07efec27ea129e314ac0b6b7e0d8c0 Reviewed-on: https://gerrit.libreoffice.org/29255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-26Resolves: rhbz#1378521 csv dialog a11y returns a new accessible on every queryCaolán McNamara2-4/+38
the gtk a11y rather assumes that the a11y things "belong" to the matching widget/component and those owners will dispose them, so follow that pattern here and dispose the a11y objects when the parent is disposed to reproduce, enable a11y, load a csv, click once in the first column of the preview area and cancel the dialog and close libreoffice Change-Id: Ib830da499e9f2d6fed94fb12ede7c929b607ab10 Reviewed-on: https://gerrit.libreoffice.org/29301 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-27bnc#957991: Improve pivot cache reading performanceTamás Zolnai3-16/+114
Performance problem was caused by grouping. Pivot tables with the same source are linked to each other by the pivot cache and so all the pivot tables were updated when one group was added to one of the tables. This code change first of all fixes a functional issue: group name was wrongly imported and so pivot tables using group fields were broken. This caused by calling RefreshPivotTableGroups() on a pivot table which is not part of the cache yet and so update was not called on this table. Calling ReloadGroupTableData() solve this problem. Second part of the codechange is about the consistency of the pivot cache. We have an invariant in this code to have the same groups for tabels with the same source. To keep this invariant we update every newly inserted tables adding the neccessary groups. The performance improvement here is that until the table is not part of the cache, it does not updates other tables. Group syncronization is done when the table is inserted to the ScDPCollection. Change-Id: Iaff55ffa3ed9c9b48cb18bd150eb4e1f7b617353