summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-03-18uitest for bug tdf#115573Zdeněk Crhonek1-0/+142
Change-Id: Ibf257160cd33c83ae6f3a0b6170011d49ed9cd3f Reviewed-on: https://gerrit.libreoffice.org/51462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-18tdf#115228 Terminology TSCPheiko tietze3-5/+5
Renamed some terms Change-Id: Ia23f2490155101d59ef2bb3ce181709bb427197e Reviewed-on: https://gerrit.libreoffice.org/48744 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-18Use for-range loops in helpcompilerJulien Nabet4-43/+29
Change-Id: I787a5b43cb09ac308082cac0e66540f975d79ead Reviewed-on: https://gerrit.libreoffice.org/51473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-18remove define for GraphicObject url and inline the stringTomaž Vajngerl1-3/+1
Change-Id: I505f7c21f666d78955aace1776536d34a9e29ce3 Reviewed-on: https://gerrit.libreoffice.org/51391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-18cleanup UnoGraphicObjectTomaž Vajngerl1-28/+31
Change-Id: I7d8982223170b4675b85e350d9515ef99df0f715 Reviewed-on: https://gerrit.libreoffice.org/51390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-18Create UNO API property testers for common typesJens Carl3-0/+164
Create UNO API property testers for common, so it's possible to share/use them between all the UNO API service property tests. Testers are available for the types 'boolean', 'long', 'short', and 'string'. Change-Id: Ia36dba98c774695b3ba6ac9d9917af9fb20efdba Reviewed-on: https://gerrit.libreoffice.org/51259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-18Colibre icons: use #696969 for font iconsandreas kainz210-143/+109
Change-Id: I350d4af1826636c4c2d8465314479d901d30efa0 Reviewed-on: https://gerrit.libreoffice.org/51486 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18Colibre icons: fix sc_help iconandreas kainz2-1/+2
Change-Id: I2410d18a23ce70f5885630472b05bb5074aba9a6 Reviewed-on: https://gerrit.libreoffice.org/51485 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18tdf#112118: use correct border when calculating marginMike Kaganski9-54/+108
This is a longstanding (at least since 2000: already present in commit 7b0b5cdf) error where left border linespace was used when calculating right margin. It was copypasted from ww8 import to ooxml code verbatim. The problem only manifests itself when left and right border spacings are not the same; and since we had other errors in the borders import, that additional problem simply wasn't apparent. Also use scaled border width in border distance/margin calculations. Unit tests updated. Change-Id: I70961e1bde29471def69e1ef944ba2779cffe307 Reviewed-on: https://gerrit.libreoffice.org/51474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-18Colibre icons: add foil iconsandreas kainz14-0/+7
Change-Id: Ic0cfcc1937c8156d0d8035e1123c36179364bc18 Reviewed-on: https://gerrit.libreoffice.org/51484 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18Colibre icons: add svtools iconsandreas kainz18-0/+9
Change-Id: Ibd4aad68f05d8126e2506b8392b2a1e63ed794f5 Reviewed-on: https://gerrit.libreoffice.org/51483 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18Colibre icons: add svx iconsandreas kainz16-0/+8
Change-Id: I95129be8a2fd9d6e2e0cccbb4c6457c6a0b81a58 Reviewed-on: https://gerrit.libreoffice.org/51482 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18Colibre icons: fix templates_32 iconandreas kainz2-1/+1
Change-Id: I8be7bd253284ece1c6a7778e568fe9b0daf9bf5e Reviewed-on: https://gerrit.libreoffice.org/51481 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18Colibre icons: add vcl iconsandreas kainz14-0/+7
Change-Id: I53de7245ef90805c32f116f1e84e698c0f9d5e78 Reviewed-on: https://gerrit.libreoffice.org/51480 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-18Colibre icons: add xmlsecurity iconsandreas kainz8-0/+4
Change-Id: Ic6f218e73d8b085ab74b5f815753987ad49333f7 Reviewed-on: https://gerrit.libreoffice.org/51479 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-17Colibre icons: global icon fixesandreas kainz20-5/+10
Change-Id: If167db7cbeb86133516c35636a39ddb1269d2c7d Reviewed-on: https://gerrit.libreoffice.org/51472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-17OperationSmiley: Adapted TestDocumentArmin Le Grand1-0/+0
The OperationSmiley fix is about removing the old hack that for CustomShapes in top-left and bottom-right points were added. In the ScTiledRenderingTest::testGraphicInvalidate UnitTest using this document exactly that top-left wrong polygon was hit which is now no longer there. The used shape was an ellipse, so this makes a difference - there *is* no geometry in the top-left corner of this shape. To fix that, I exchanged the ellipe CustomShape with a rectangle CustomShape. That way, the old hit behaviour will be replicated. Change-Id: I4b96ad79ba91166f097207226577d34087625589
2018-03-17OperationSmiley: Corrected shadowing of local variablesArmin Le Grand1-1/+1
Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa
2018-03-17OperationSmiley: Corrected shadowing of local variablesArmin Le Grand1-2/+2
Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa
2018-03-17OperationSmiley: Removed unused param from SdrPathObj constructorArmin Le Grand2-2/+2
Change-Id: Ia69e822c698ea13650d868472ba63744727ff886
2018-03-17OperationSmiley: Secured quite some places using CustomShapeArmin Le Grand5-1/+6
Changed quite some places of SdrObjCustomShape usage to use references instead of pointers, thus forcing to more secure handling. Changed some test and change methods, even found a memory leak by doing so. Added some incudes/predefines for linux builds. Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7
2018-03-17OperationSmiley: Secured quite some places using CustomShapeArmin Le Grand15-383/+608
Changed quite some places of SdrObjCustomShape usage to use references instead of pointers, thus forcing to more secure handling. Changed some test and change methods, even found a memory leak by doing so. Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7
2018-03-17OperationSmiley: Added support for using same FillGeometryArmin Le Grand6-27/+106
It is now possible to use a single FillGeometry to fill objects that are made of multiple filled objects (e.g. CustomShapes) so that they look as using a single fill. This is used for CustomShapes, but may later be 'extended' to be used for more cases. The basic functionality was already in the primitives, but had to be added to SDrObject due to these being used for CustomShapeVisualization (currently - would be better to change this to primitives, too). Change-Id: I1d9fb158191a9ec663e46f3911213be2f3d88986
2018-03-17OperationSmiley: Remove brightness from SdrPathObjArmin Le Grand4-73/+135
There was a member at SdrPathObj called mdBrightness only for holding a blend value during creation of SdrPathObjs for CustomShape visualization. This has nothing to do on the model data, move it to where it belongs Change-Id: Iee101f90a1275ce1ed97e8e8d0ccf7084c83d4f6
2018-03-17Use for-range loops in frameworkJulien Nabet27-709/+480
Change-Id: I72ea832848fd7c76863bcee70a3303de488c0b0f Reviewed-on: https://gerrit.libreoffice.org/51471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17iOS, balanced return stackjan Iversen1-21/+19
stack balenced for entering and exiting _privateSnippetExecutor Change-Id: I381c487d3412a39b113e9725807fd018b2b4036a
2018-03-17Typos: definied->definedJulien Nabet3-3/+3
Change-Id: I052d6a4815372c79b6d62c1c85d303c6272af3df Reviewed-on: https://gerrit.libreoffice.org/51466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17Typos concerning hierarchyJulien Nabet4-4/+4
Change-Id: Ied3c6d1513f2181a5f7da2904a0df2f806146cec Reviewed-on: https://gerrit.libreoffice.org/51465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17Use for-range loops in embeddedobj, embedserv and formulaJulien Nabet5-34/+20
Change-Id: I56e1bace8ab8312524e681d3865a1a89d523812d Reviewed-on: https://gerrit.libreoffice.org/51459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: I967e67d08b22dc3c56fe860bea49f301b75b4ff9 Reviewed-on: https://gerrit.libreoffice.org/51463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17Use for-range loops in fpickerJulien Nabet4-98/+80
Change-Id: I9bca308889c6e15ce9fcbc82f5c6c5e126b29022 Reviewed-on: https://gerrit.libreoffice.org/51460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17cui: Add tooltip to user-defined number format commentSamuel Thibault1-0/+1
The context is not obvious when using a screen reader. Change-Id: Ibabc9b33081b729c1ded5b43b6dfa05aeb854fc3 Reviewed-on: https://gerrit.libreoffice.org/51289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-17sc: prefix members of ScRefHandlerHenry Castro2-16/+16
Change-Id: I7ba7f17256c244604549321fc4812ce845c28877 Reviewed-on: https://gerrit.libreoffice.org/51451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-17uitest logger: call correct function for key loggingSaurav Chirania1-2/+2
isMod2() and isMod3() functions have been used in place to isMod1() to generate correct key logs. Change-Id: Idcb83ad8bf00d31cac08cb7ff17ecca635b44967 Reviewed-on: https://gerrit.libreoffice.org/51367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-17scalc: Add missing labellingSamuel Thibault1-0/+6
The "first page number" spin button was missing accessibility labelling. Change-Id: I750cebf33f20056819abc00bb6875e2d89100fdd Reviewed-on: https://gerrit.libreoffice.org/51291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-17Use for-range loops in formsJulien Nabet6-48/+35
Change-Id: I23f63f2a98ce64513f5cb4b06e373b5ec9509d62 Reviewed-on: https://gerrit.libreoffice.org/51445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17tdf#84205 If theme not found, use firstSzymon Kłos3-2/+20
Not a complete fix, workaround. Change-Id: If4d765eaeae3419f4f1deb4e1cfbe0113a71da94 Reviewed-on: https://gerrit.libreoffice.org/51440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-17iOS update unwind abi to v. 26jan Iversen1-7/+9
Change-Id: Id149b6a17dec8e6030d78e235c7451b2244152d1
2018-03-17iOS, remove copy of source code to instdirjan Iversen1-6/+0
The build phase contained copy statements for bridges/source/cpp_uno/ which should not happen Change-Id: Ied4c1b2ef29effe4642f5ca0e7dc3a5b41ef0b68
2018-03-17sd lok: Enable mapmode in case of lok to calculate centerPranav Kant5-31/+26
This reverts the solution in 9fee132c18b658c9ea9fb1114c1fefa56b57532a. Also, calculate center using the new function for chart, image, and text shape insertion. Change-Id: Ie893050b7c875760db0194e7a3f0c2cd3068963b Reviewed-on: https://gerrit.libreoffice.org/51343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-17sd lok: Set the view size to full page size + fix unit testsPranav Kant4-2/+46
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I2d1577bc963d324959b272ed3174571ab197d014 Reviewed-on: https://gerrit.libreoffice.org/51416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-17sc: prefix members of ScFormulaReferenceHelperHenry Castro2-129/+129
Change-Id: I412c7336802032da93c3cc4df1d7f6d8baf36a7b Reviewed-on: https://gerrit.libreoffice.org/51442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-17Colibre icons: add layout icons for impressandreas kainz28-0/+14
Change-Id: I0b05de738cdcb77ca92e95ee93a682bc417e27f9 Reviewed-on: https://gerrit.libreoffice.org/51449 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-17tdf#106375: change tool tip to "Align Center"Reshma2-2/+2
change "Center Horizontally" to "Align Center" in Formatting toolbar Change-Id: Ib5fbe70eb2a5490f7dd234ca8e5db118e68c8a73 Reviewed-on: https://gerrit.libreoffice.org/51045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-17Colibre icons: finish cmd filesandreas kainz32-0/+38
Change-Id: I7cc165fc2c0931aad519a8b2a872dda89ce153d5 Reviewed-on: https://gerrit.libreoffice.org/51448 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-17lok: notify clients of clipboard changesAshod Nakashian2-5/+22
Change-Id: I93d8eacc0defb1176ec5d767f49356812cf90ff6 Reviewed-on: https://gerrit.libreoffice.org/50327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-16Colibre icons: add cellborder iconandreas kainz2-0/+84
Change-Id: Ifd74d3cfbc6b4b1c2c4a7a1b5529e137a7b041eb Reviewed-on: https://gerrit.libreoffice.org/51446 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-16Tango icons: move svg and xcf source files to tango_svgandreas kainz305-0/+8
Change-Id: I94a2c7a1048a3e29776a0b5b6f78a7d043b751ca Reviewed-on: https://gerrit.libreoffice.org/51376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-16First cut at annotating 'exotic' filters.Michael Meeks27-14/+235
The idea being that we can improve security by warning for these. Change-Id: I7d993417bfb6a8fe868bc3e07ccbcfe71bf285ff Reviewed-on: https://gerrit.libreoffice.org/50387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-16rhbz#1392145 ensure titlebar close button matches 'outside' directionCaolán McNamara3-2/+34
Change-Id: I20e925c58adb56acd4d1a63720d330c8b6613441 Reviewed-on: https://gerrit.libreoffice.org/51433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>