summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-08-02clipboard: repair unit test so that it runs in the lok mode.Michael Meeks2-1/+3
SwTransferable::AddSupportedFormats needs the kit to be active. Change-Id: Id84210eb2e526785f35dfae609d861c310885314
2019-08-02clipboard: log before erasingAshod Nakashian1-1/+1
Change-Id: I6d59cdd31c62bbc7db81ccb8985745f68d19cd28
2019-08-02clipboard: check for null.Michael Meeks1-2/+1
Change-Id: I07060035a9744642c98d4a0946695408dc0f6b42
2019-08-02lok: share more of the clipboard mime-type handling code.Michael Meeks1-14/+1
Change-Id: I98fc9fa0fd1b5afa00c33b642d2d504eab0b62ba
2019-08-02clipboard: encourage paste to show up by having some dummy content.Michael Meeks3-1/+17
Having an empty system clipboard is a hyper-unusual state, but this is quite common for new lok instances. If we populate some dummy state we can hide that. Allows context-menu paste into new documents. Change-Id: Ia180dd370c180d2d666cc57330db6c1385578a36
2019-08-02Try harder to generate HTML from text.Michael Meeks1-22/+57
Change-Id: I5b4778cceefc652274a72b779cd6c060a50bf06c
2019-08-02lok: minimal implementation of isComplex for calc for now.Michael Meeks6-35/+66
Change-Id: Ic4141d30a0ff48a9ec5ecc8e6119d9d779c4a0fc
2019-08-02lok: vital to quote nested JSON inserted into a json property.Michael Meeks1-1/+16
Somehow this managed to work fine in most browsers, but when the Kit/Poco tried to parse JSON to extract viewID it could explode. Change-Id: I39d2ecc9ee95b7e6f67a23c8b15f9a1d01769ddc
2019-08-02Set clipboard for a window when createdSzymon Kłos1-0/+12
This allows to paste in dialogs input using tunneled context menu. Change-Id: Ie6cc6f1a6cd453734c8f6084b0bd50d1d7ab6c09
2019-08-02LOK: Copy Graphics as embedded PNG in HTMLAshod Nakashian2-2/+37
Change-Id: Id8c14d7304d30bfcd956b126dfe291ef044f62bf
2019-08-02lok: cleanup clipboards associated with a view on destruction.Michael Meeks3-7/+38
Also defer destruction potentially indefinitely for bad users who quit without destroying views, documents, shutting down nicely etc. Change-Id: Ieea6ad00b2983d372b745179bfe3b884c3c64eb0
2019-08-02LOK: Improved selection complexity detectionAshod Nakashian2-17/+16
Only Graphics and OLE now unconditionally trigger 'complex' case, and for all others, we actually tally the number of text characters. Currently anything above 512KB is flagged as 'complex'. Change-Id: I19fbef72f2eb725648b2a18c1ee41b1612d2bac0
2019-08-02LOK: Enable embedding images in text/html format outputAshod Nakashian4-19/+27
Change-Id: Ibd8bed796678ee26de2ceb6e434dce24da4eab05
2019-08-02LOK: detect Graphics in isComplex for WriterAshod Nakashian2-22/+6
Change-Id: I814d71a21fa5352a9a1051f5477cb452a0dc5c2f
2019-08-02LOK: Implement getSelectionTypeAshod Nakashian4-5/+63
Detects all complex scenarios, except for Graphics. DesktopLOKTest::testComplexSelection() has commented out check that currently fails due to the missing detection of Graphics nodes. Change-Id: Ifce17192d26daba218d2c3d38577cccec0699e99
2019-08-02clipboard: get view setting correct before setClipboard.Michael Meeks2-3/+9
Change-Id: If8e9b057b819074f035c598569e3bf6d3d2fff00
2019-08-02lok: clipboard: per view clipboard creation.Michael Meeks4-14/+37
A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29
2019-08-02lok: clipboard: per view clipboard creation.Michael Meeks6-44/+214
A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29
2019-08-02build fix: missing #include <ndgrf.hxx>Andras Timar1-0/+1
Change-Id: I72caa16d3c5b5698226cc7d3f07d3d32820032d8
2019-08-02Fix build: unused argumentSzymon Kłos1-1/+1
Change-Id: Id79d9c093da21b9f68bb38a51ac5f142a69364ed
2019-08-02LOK: Support detecting complex selectionsAshod Nakashian9-1/+125
Includes unit-test, but is otherwise not complete implementation. Change-Id: I5fdcd543358caab1858f6351238c21312665839c
2019-08-02lok: use utf-8 for text/plain always.Michael Meeks1-2/+5
Change-Id: Ie91f89b3dc6ba3eddcf8383948dddc7878eae4d8
2019-08-02Add more powerful selection fetch & clipboard set methods.Michael Meeks5-48/+236
Change-Id: I6633356d13480377a83a006588ec69ebcb56a93f
2019-08-02Avoid odd crash where OLE object can't generate an image preview.Michael Meeks1-0/+6
Change-Id: Ib77eca6907aa09383a96f3c9de6f7a7c4799c3bc
2019-08-02lok: disable calc char-set dialog for HTML when pasting.Michael Meeks1-1/+2
Change-Id: I3ec9e98549d06ae3e6b4ede89215a5137d01ccab
2019-08-02lok: don't be prejudiced against a single missing mime-type.Michael Meeks1-0/+3
Change-Id: Ic5004c306cbd01071c397ed1a61ef094b439a48f
2019-08-02weld OGeneralPageDialogCaolán McNamara2-3/+3
Change-Id: I1a5342f9f009234b2c8b1231155a11c9283c4ec8 Reviewed-on: https://gerrit.libreoffice.org/76856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02sw comments on frames: no overlay in the LOK API, either: insert caseMiklos Vajna3-1/+54
This is similar to commit 28fcb7d86765194b4015e7023449333f43aba0c5 (sw comments on frames: no overlay in the LOK API, either, 2019-07-16), but that one handled the initial fetch of comment states, while this one does the incremental updates. With this, there is no overlay on commented images right after inserting them. Change-Id: I060303806a6611b113b4813300ed1cafd0b654fa Reviewed-on: https://gerrit.libreoffice.org/76859 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-02Fix typoAndrea Gelmini1-2/+2
Change-Id: Idaaec17114aa2b03c00da075f5accc4c0c0e69b4 Reviewed-on: https://gerrit.libreoffice.org/75768 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02dispose MySQLNativePageCaolán McNamara2-6/+13
Change-Id: I2506d08b8c2e5b501bccb8b5ef2e6d829a912852 Reviewed-on: https://gerrit.libreoffice.org/76854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02remove newly unused OGenericAdministrationPage ctorCaolán McNamara2-11/+0
Change-Id: Ibb1353e5b14648253cb455664693271fd4482c51 Reviewed-on: https://gerrit.libreoffice.org/76850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop some newly unused functionsCaolán McNamara2-40/+0
Change-Id: I2ee32a9fdac6ff85927a5755ce341a591a462544 Reviewed-on: https://gerrit.libreoffice.org/76849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02void* -> weld::Widget*Caolán McNamara8-14/+14
Change-Id: I1341fa27fd184ff1302b867aea6c215c22fb477d Reviewed-on: https://gerrit.libreoffice.org/76847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02rename DBMySQLNativeSettings back to MySQLNativeSettingsCaolán McNamara5-22/+22
Change-Id: I00d6de729a1d650d479663b6e1d05f8087e7fe9a Reviewed-on: https://gerrit.libreoffice.org/76846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused MySQLNativeSettingsCaolán McNamara2-235/+1
Change-Id: I11801ea43d69b3f79d8fba1305d4d9c8c199d29b Reviewed-on: https://gerrit.libreoffice.org/76845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld MySQLNativeSetupPageCaolán McNamara4-23/+50
Change-Id: Ie27649de602241936378f1e937100718d0c95d5e Reviewed-on: https://gerrit.libreoffice.org/76844 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused LayoutHelperCaolán McNamara2-48/+0
Change-Id: I602c9a3f9df79ad8c268c6902adac9046abd34ea Reviewed-on: https://gerrit.libreoffice.org/76841 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OLDAPConnectionPageSetupCaolán McNamara5-81/+60
Change-Id: Id1b5becb2e9978cf4713a35d4f89125658d3de17 Reviewed-on: https://gerrit.libreoffice.org/76840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02Avoid -fsanitize=signed-integer-overflow within m_pFrame->GrowTst( LONG_MAX );Stephan Bergmann1-1/+2
`--convert-to pdf doc/ooo70429-1.doc` (i.e., the attachment Whole Book.odt at <https://bz.apache.org/ooo/show_bug.cgi?id=70429#c2>) failed with > sw/source/core/layout/wsfrm.cxx:2659:27: runtime error: signed integer overflow: 9223372036854775647 + 9254 cannot be represented in type 'long' > #0 in SwLayoutFrame::GrowFrame(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:2659:27 > #1 in SwFrame::Grow(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:1493:35 > #2 in SwContentFrame::GrowFrame(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:2147:37 > #3 in SwFrame::Grow(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:1493:35 > #4 in SwTextFrame::GrowTst(long) at sw/source/core/inc/txtfrm.hxx:815:12 > #5 in SwTextFrameBreak::IsInside(SwTextMargin const&) const at sw/source/core/text/widorp.cxx:156:34 [...] when frame 5 calls nHeight += m_pFrame->GrowTst( LONG_MAX ); As various places along the code path between frames 5 and 0 already clip values at LONG_MAX, it looks reasonable to similarly clip the increased nReal here. Change-Id: I27202ad47a397f8f57cfccfb3cb85a5dc0ac17cb Reviewed-on: https://gerrit.libreoffice.org/76851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-02Fix typosAndrea Gelmini10-17/+17
Change-Id: I8e2f3104f3ae9d20e520d357e61c02afde0cedf4 Reviewed-on: https://gerrit.libreoffice.org/76858 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02Fix typo in codeAndrea Gelmini1-1/+1
Change-Id: Ie32bb0cf7f987ab57dc03d1485535a1019fd111a Reviewed-on: https://gerrit.libreoffice.org/76853 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-08-02Fix typosAndrea Gelmini17-36/+36
Change-Id: Ie183c445bf8a545f59aac7b0e29f72ab679a6cf3 Reviewed-on: https://gerrit.libreoffice.org/76852 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02Revert "fix some accessibility warnings"Noel Grandin6-75/+23
This reverts commit 885ae69174cf717edd00526e5cf8f1585c505c95. <caolan> noel_grandin, wrt the accessibility labelled-by and label-for. If the label really is a GtkLabel then setting its mnemonic target (in glade, general tab, and use underline and select a target) is the most straight forward thing to do and implies those a11y relations <caolan> the painful manual a11y labelled-by/label-for are typically for using something weird, like a checkbutton, as a label for something Change-Id: I13db8ec65d10248aa46cb6b01398ec302dd06b59 Reviewed-on: https://gerrit.libreoffice.org/76837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02weld OGeneralSpecialJDBCConnectionPageSetupCaolán McNamara3-105/+95
Change-Id: Ie4c2a34127a79d290105f0f032b4edf22d5871cd Reviewed-on: https://gerrit.libreoffice.org/76838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02build fails with libxmlsec version 1.2.27Lionel Elie Mamane1-1/+1
Due to indirect inclusion of C++ headers in scope of an 'extern "C"'. Possibly it works with version 1.2.24 to 1.2.26. Change-Id: I12bd43b51b1cf829bfe91d4ab1eb5470b86ec18e Reviewed-on: https://gerrit.libreoffice.org/75349 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-02Fix typosAndrea Gelmini19-30/+30
Change-Id: I3d1dd03022eb37609ee0dd62c4ee9cec93ac0717 Reviewed-on: https://gerrit.libreoffice.org/76813 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02tdf#123702 RTF/DOCX default 1" left/right page marginsLászló Németh2-7/+7
since MSO 2007: now 1440 twips = 2540 1/100 mm (it was 1800 twips = 3175 1/100 mm). Changing the default value fixes the layout of the documents based on RTF templates without explicit margins. Change-Id: I0395fb7cdd6ba176f266c8f0a9309ba48a047da3 Reviewed-on: https://gerrit.libreoffice.org/76812 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-02fix some accessibility warningsNoel Grandin6-23/+75
Change-Id: I18f9a71ac4e2ef5c159e13bc3cb0e36cf7c550a5 Reviewed-on: https://gerrit.libreoffice.org/76834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02weld OAuthentificationPageSetupCaolán McNamara5-102/+36
Change-Id: Ib5de669f22abeaae3716918702066ce608910874 Reviewed-on: https://gerrit.libreoffice.org/76830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02DrawButtonFlags::NoText never setCaolán McNamara2-28/+21
Change-Id: I23531adc0798ec4a97538a8002ba0866535677a3 Reviewed-on: https://gerrit.libreoffice.org/76829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>