summaryrefslogtreecommitdiff
path: root/basic
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-04-28 11:59:26 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-05-02 11:55:03 +0200
commit769d383b06ccf11983cc33887b60dbb1b151fa5a (patch)
treea5474928c857e9af5b6b39de0be08bf2e9e334dc /basic
parent29a72ca674ce9cd3d5c4ede63e2b10044f84247a (diff)
loplugin:checkunusedparams in basctl and basic
Change-Id: I077ce96aed3c79045d5e8438109a8b1690ff1218 Reviewed-on: https://gerrit.libreoffice.org/37062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
-rw-r--r--basic/inc/sbstdobj.hxx18
-rw-r--r--basic/source/runtime/stdobj1.cxx40
2 files changed, 28 insertions, 30 deletions
diff --git a/basic/inc/sbstdobj.hxx b/basic/inc/sbstdobj.hxx
index 7cc22584fab7..d306c3d81e97 100644
--- a/basic/inc/sbstdobj.hxx
+++ b/basic/inc/sbstdobj.hxx
@@ -43,9 +43,9 @@ protected:
virtual ~SbStdPicture() override;
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
- void PropType( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropWidth( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropHeight( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
+ void PropType( SbxVariable* pVar, bool bWrite );
+ void PropWidth( SbxVariable* pVar, bool bWrite );
+ void PropHeight( SbxVariable* pVar, bool bWrite );
public:
@@ -69,12 +69,12 @@ protected:
virtual ~SbStdFont() override;
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
- void PropBold( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropItalic( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropStrikeThrough( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropUnderline( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropSize( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
- void PropName( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
+ void PropBold( SbxVariable* pVar, bool bWrite );
+ void PropItalic( SbxVariable* pVar, bool bWrite );
+ void PropStrikeThrough( SbxVariable* pVar, bool bWrite );
+ void PropUnderline( SbxVariable* pVar, bool bWrite );
+ void PropSize( SbxVariable* pVar, bool bWrite );
+ void PropName( SbxVariable* pVar, bool bWrite );
public:
diff --git a/basic/source/runtime/stdobj1.cxx b/basic/source/runtime/stdobj1.cxx
index 8284a1acf7ed..ed8df7686965 100644
--- a/basic/source/runtime/stdobj1.cxx
+++ b/basic/source/runtime/stdobj1.cxx
@@ -56,7 +56,7 @@ SbxObject* SbStdFactory::CreateObject( const OUString& rClassName )
}
-void SbStdPicture::PropType( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdPicture::PropType( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
{
@@ -76,7 +76,7 @@ void SbStdPicture::PropType( SbxVariable* pVar, SbxArray*, bool bWrite )
}
-void SbStdPicture::PropWidth( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdPicture::PropWidth( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
{
@@ -91,7 +91,7 @@ void SbStdPicture::PropWidth( SbxVariable* pVar, SbxArray*, bool bWrite )
pVar->PutInteger( (sal_Int16)aSize.Width() );
}
-void SbStdPicture::PropHeight( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdPicture::PropHeight( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
{
@@ -141,16 +141,15 @@ void SbStdPicture::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
}
SbxVariable* pVar = pHint->GetVar();
- SbxArray* pPar_ = pVar->GetParameters();
const sal_uInt32 nWhich = pVar->GetUserData();
bool bWrite = pHint->GetId() == SfxHintId::BasicDataChanged;
- // Propteries
+ // Properties
switch( nWhich )
{
- case ATTR_IMP_TYPE: PropType( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_WIDTH: PropWidth( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_HEIGHT: PropHeight( pVar, pPar_, bWrite ); return;
+ case ATTR_IMP_TYPE: PropType( pVar, bWrite ); return;
+ case ATTR_IMP_WIDTH: PropWidth( pVar, bWrite ); return;
+ case ATTR_IMP_HEIGHT: PropHeight( pVar, bWrite ); return;
}
SbxObject::Notify( rBC, rHint );
@@ -158,7 +157,7 @@ void SbStdPicture::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
}
-void SbStdFont::PropBold( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropBold( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
SetBold( pVar->GetBool() );
@@ -166,7 +165,7 @@ void SbStdFont::PropBold( SbxVariable* pVar, SbxArray*, bool bWrite )
pVar->PutBool( IsBold() );
}
-void SbStdFont::PropItalic( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropItalic( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
SetItalic( pVar->GetBool() );
@@ -174,7 +173,7 @@ void SbStdFont::PropItalic( SbxVariable* pVar, SbxArray*, bool bWrite )
pVar->PutBool( IsItalic() );
}
-void SbStdFont::PropStrikeThrough( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropStrikeThrough( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
SetStrikeThrough( pVar->GetBool() );
@@ -182,7 +181,7 @@ void SbStdFont::PropStrikeThrough( SbxVariable* pVar, SbxArray*, bool bWrite )
pVar->PutBool( IsStrikeThrough() );
}
-void SbStdFont::PropUnderline( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropUnderline( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
SetUnderline( pVar->GetBool() );
@@ -190,7 +189,7 @@ void SbStdFont::PropUnderline( SbxVariable* pVar, SbxArray*, bool bWrite )
pVar->PutBool( IsUnderline() );
}
-void SbStdFont::PropSize( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropSize( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
SetSize( (sal_uInt16)pVar->GetInteger() );
@@ -198,7 +197,7 @@ void SbStdFont::PropSize( SbxVariable* pVar, SbxArray*, bool bWrite )
pVar->PutInteger( (sal_Int16)GetSize() );
}
-void SbStdFont::PropName( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropName( SbxVariable* pVar, bool bWrite )
{
if( bWrite )
{
@@ -259,19 +258,18 @@ void SbStdFont::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
}
SbxVariable* pVar = pHint->GetVar();
- SbxArray* pPar_ = pVar->GetParameters();
const sal_uInt32 nWhich = pVar->GetUserData();
bool bWrite = pHint->GetId() == SfxHintId::BasicDataChanged;
// Propteries
switch( nWhich )
{
- case ATTR_IMP_BOLD: PropBold( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_ITALIC: PropItalic( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_STRIKETHROUGH:PropStrikeThrough( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_UNDERLINE: PropUnderline( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_SIZE: PropSize( pVar, pPar_, bWrite ); return;
- case ATTR_IMP_NAME: PropName( pVar, pPar_, bWrite ); return;
+ case ATTR_IMP_BOLD: PropBold( pVar, bWrite ); return;
+ case ATTR_IMP_ITALIC: PropItalic( pVar, bWrite ); return;
+ case ATTR_IMP_STRIKETHROUGH:PropStrikeThrough( pVar, bWrite ); return;
+ case ATTR_IMP_UNDERLINE: PropUnderline( pVar, bWrite ); return;
+ case ATTR_IMP_SIZE: PropSize( pVar, bWrite ); return;
+ case ATTR_IMP_NAME: PropName( pVar, bWrite ); return;
}
SbxObject::Notify( rBC, rHint );