diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2021-09-15 09:21:50 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2021-09-15 10:14:58 +0200 |
| commit | bd7e394769f43c296a20c6faa48b6ae3a142c7a8 (patch) | |
| tree | 6eec4a5875490f8f241d44c83941c93ace5d283c | |
| parent | 2987a0f4d38463a167e23c243668974d2cb863fb (diff) | |
Uninitialized data member
...introduced in d467cd0dd9e9cf3b018859a592e2638527bc7add "tdf#135683 speedup
DocumentRedlineManager::GetRedlinePos", causing isssues like
> [_RUN_____] SwDocTest::testFileNameFields
> /sw/inc/docary.hxx:238:50: runtime error: load of value 190, which is not a valid value for type 'bool'
> #0 0x2b89dcc7897e in SwRedlineTable::HasOverlappingElements() const /sw/inc/docary.hxx:238:50
> #1 0x2b89dcc40efc in sw::DocumentRedlineManager::GetRedlinePos(SwNode const&, RedlineType) const /sw/source/core/doc/DocumentRedlineManager.cxx:2624:25
> #2 0x2b89df2a4e8c in SwScriptInfo::selectRedLineDeleted(SwTextNode const&, MultiSelection&, bool) /sw/source/core/text/porlay.cxx:2653:44
> #3 0x2b89df285fbe in SwScriptInfo::CalcHiddenRanges(SwTextNode const&, MultiSelection&, std::__debug::vector<std::pair<sw::mark::IBookmark const*, SwScriptInfo::MarkKind>, std::allocator<std::pair<sw::mark::IBookmark const*, SwScriptInfo::MarkKind> > >*) /sw/source/core/text/porlay.cxx:2687:5
> #4 0x2b89df29359b in SwScriptInfo::GetBoundsOfHiddenRange(SwTextNode const&, int, int&, int&, std::__debug::vector<int, std::allocator<int> >*) /sw/source/core/text/porlay.cxx:1917:9
> #5 0x2b89dfa1c1e6 in SwTextNode::CalcHiddenCharFlags() const /sw/source/core/txtnode/ndtxt.cxx:4522:5
[...]
during CppunitTest_sw_uwriter at <https://ci.libreoffice.org/job/lo_ubsan/2135/>
Change-Id: I42c8801f83d2e92a826864494b1f0f4c63f30f6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122109
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
| -rw-r--r-- | sw/inc/docary.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx index 08e2d8b761dd..97642d2e3bbf 100644 --- a/sw/inc/docary.hxx +++ b/sw/inc/docary.hxx @@ -226,7 +226,7 @@ private: vector_type maVector; /// Sometimes we load bad data, and we need to know if we can use /// fast binary search, or if we have to fall back to a linear search - bool m_bHasOverlappingElements; + bool m_bHasOverlappingElements = false; public: ~SwRedlineTable(); bool Contains(const SwRangeRedline* p) const { return maVector.find(const_cast<SwRangeRedline*>(p)) != maVector.end(); } |