summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2013-01-22 13:53:26 +0000
committerCaolán McNamara <caolanm@redhat.com>2013-01-22 16:57:44 +0000
commitb12527bf0ec4964a16240f9535b6fcab53ed1cf7 (patch)
tree4c582e168f6ee0262b69d3f31baf20f9d5423170
parent63065fa781d2568f22a5cc70d9390a2407f40ad8 (diff)
Tutorial step #3 remove redundant button widget constructors
1. It's nearly always the case that the Help button has no methods called on it except its ctor, i.e. no changes to its default behaviour, so explicit mention of it can be removed. 2. Thats's often the case for the Cancel button 3. That's occasionally the case for the OK button Change-Id: Ic192962b2e55546cd448d7a69394ae13a743299e
-rw-r--r--svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx2
-rw-r--r--svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.hxx2
2 files changed, 0 insertions, 4 deletions
diff --git a/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx b/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
index 298a92732f08..7b08a504daab 100644
--- a/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
+++ b/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
@@ -54,8 +54,6 @@ ChineseTranslationDialog::ChineseTranslationDialog( Window* pParent )
54 , m_aPB_Editterms( this, TextConversionDlgs_ResId( PB_EDITTERMS ) ) 54 , m_aPB_Editterms( this, TextConversionDlgs_ResId( PB_EDITTERMS ) )
55 , m_aFL_Bottomline( this, TextConversionDlgs_ResId( T_FL_BOTTOMLINE ) ) 55 , m_aFL_Bottomline( this, TextConversionDlgs_ResId( T_FL_BOTTOMLINE ) )
56 , m_aBP_OK( this, TextConversionDlgs_ResId( PB_OK ) ) 56 , m_aBP_OK( this, TextConversionDlgs_ResId( PB_OK ) )
57 , m_aBP_Cancel( this, TextConversionDlgs_ResId( PB_CANCEL ) )
58 , m_aBP_Help( this, TextConversionDlgs_ResId( PB_HELP ) )
59 , m_pDictionaryDialog(0) 57 , m_pDictionaryDialog(0)
60{ 58{
61 FreeResource(); 59 FreeResource();
diff --git a/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.hxx b/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.hxx
index a1b321737f36..92c920c0a7ad 100644
--- a/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.hxx
+++ b/svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.hxx
@@ -65,8 +65,6 @@ private:
65 FixedLine m_aFL_Bottomline; 65 FixedLine m_aFL_Bottomline;
66 66
67 OKButton m_aBP_OK; 67 OKButton m_aBP_OK;
68 CancelButton m_aBP_Cancel;
69 HelpButton m_aBP_Help;
70 68
71 ChineseDictionaryDialog* m_pDictionaryDialog; 69 ChineseDictionaryDialog* m_pDictionaryDialog;
72}; 70};