diff options
author | Dennis Francis <dennis.francis@collabora.co.uk> | 2017-08-08 17:02:19 +0530 |
---|---|---|
committer | Dennis Francis <dennis.francis@collabora.co.uk> | 2017-08-09 07:43:36 +0200 |
commit | 2585eb9d15f5c047d846ccb4b4d606d9ac89e518 (patch) | |
tree | 8df219fa8b3efdc33d9b6b601135f4eafc4417b2 | |
parent | 5ad8376d1698026ccab0634605fdb17ea3c59f3a (diff) |
tdf#108802 : In SfxControllerItem::dispose do not directly...
call pBindings->Release(), but call UnBind() instead which
correctly sets the state to "UnBound" by setting
pNext = this.
Thanks to Miklos Vajna for pointing this out !
Change-Id: I08e85496cff6df0952d6c5ec4ee979a93b8862d0
Reviewed-on: https://gerrit.libreoffice.org/40882
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
-rw-r--r-- | sfx2/source/control/ctrlitem.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sfx2/source/control/ctrlitem.cxx b/sfx2/source/control/ctrlitem.cxx index cd22920f144e..dadead816898 100644 --- a/sfx2/source/control/ctrlitem.cxx +++ b/sfx2/source/control/ctrlitem.cxx @@ -203,7 +203,7 @@ SfxControllerItem::~SfxControllerItem() void SfxControllerItem::dispose() { if ( IsBound() ) - pBindings->Release(*this); + UnBind(); } void SfxControllerItem::StateChanged |