diff options
| author | David Tardon <dtardon@redhat.com> | 2016-05-03 14:49:34 +0200 |
|---|---|---|
| committer | Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> | 2016-05-03 20:52:34 +0000 |
| commit | 00d2bef594998f8c5669f7070cf5a2c779c9b633 (patch) | |
| tree | 7be2fd014ce934f9d742bb782bff5bce96abc4b5 | |
| parent | a3bdddc2bab5510ff67aaacc3dc6d66372b7dd92 (diff) | |
tdf#99353 take the footgun away from FilterCache
FilterCache::impl_saveItem changes the properties of a config. item
one-by-one. But it also listens to the configuration changes and reloads
the whole item from the configuration on change...
Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
(cherry picked from commit 390ddd3bde617388e481b6747aa7bbea17d5ddf1)
Reviewed-on: https://gerrit.libreoffice.org/24611
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
| -rw-r--r-- | filter/source/config/cache/filtercache.cxx | 2 | ||||
| -rw-r--r-- | filter/source/config/cache/filtercache.hxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/filter/source/config/cache/filtercache.cxx b/filter/source/config/cache/filtercache.cxx index dacad0981133..f39b67ff5bc6 100644 --- a/filter/source/config/cache/filtercache.cxx +++ b/filter/source/config/cache/filtercache.cxx @@ -1809,7 +1809,7 @@ CacheItemList::iterator FilterCache::impl_loadItemOnDemand( EItemType void FilterCache::impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xItem, EItemType eType, - const CacheItem& aItem) + const CacheItem aItem) throw(css::uno::Exception) { CacheItem::const_iterator pIt; diff --git a/filter/source/config/cache/filtercache.hxx b/filter/source/config/cache/filtercache.hxx index a98684957065..c3db85aff2f4 100644 --- a/filter/source/config/cache/filtercache.hxx +++ b/filter/source/config/cache/filtercache.hxx @@ -839,7 +839,7 @@ class FilterCache : public BaseLock /** TODO */ static void impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xSet , EItemType eType , - const CacheItem& aValue) + const CacheItem aValue) throw(css::uno::Exception); |