summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSzymon Kłos <szymon.klos@collabora.com>2021-03-24 11:45:51 +0100
committerMichael Meeks <michael.meeks@collabora.com>2021-04-09 11:22:28 +0100
commitc35d5947240de72360d654e72ee52559c59da217 (patch)
tree724c6de0e947dfb760f37125e36cdee47da516ea
parent7625be8507b59eb51f98e1d28505fb24c17e6deb (diff)
SfxInPlaceClient: avoid crash when chart deleted by other view
Be sure m_pClient still is valid. In case when one view was in the chart editing mode and other view deleted the slide, m_pClient was cleared in the meantime what caused a crash Change-Id: Ie433946799abef4c75af7b96f3e5cf9ba0e7ec47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113032 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113786 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
-rw-r--r--sfx2/source/view/ipclient.cxx3
1 files changed, 2 insertions, 1 deletions
diff --git a/sfx2/source/view/ipclient.cxx b/sfx2/source/view/ipclient.cxx
index 751c41456031..fc594ff2e658 100644
--- a/sfx2/source/view/ipclient.cxx
+++ b/sfx2/source/view/ipclient.cxx
@@ -308,7 +308,8 @@ void SAL_CALL SfxInPlaceClient_Impl::visibilityChanged( sal_Bool bVisible )
throw uno::RuntimeException();
m_pClient->GetViewShell()->OutplaceActivated( bVisible );
- m_pClient->Invalidate();
+ if (m_pClient) // it can change in the above code
+ m_pClient->Invalidate();
}