diff options
| author | Behdad Esfahbod <behdad@behdad.org> | 2018-07-31 23:00:15 -0700 |
|---|---|---|
| committer | Behdad Esfahbod <behdad@behdad.org> | 2018-07-31 23:00:15 -0700 |
| commit | fd638d215feb058c2294e447cc68f6f50e2b481d (patch) | |
| tree | 046a0c66c8a373fa1334d54ed73f73eda2f77af0 | |
| parent | 896ff15ae60a4a4b94c62946e69196b877839bb5 (diff) | |
[atomic] Add XXX items around Solaris ops
Since add_int and cas are both read-modify-write, I wonder if we
also need a barrier after them.
| -rw-r--r-- | src/hb-atomic-private.hh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/hb-atomic-private.hh b/src/hb-atomic-private.hh index ef72872a..0d0badfb 100644 --- a/src/hb-atomic-private.hh +++ b/src/hb-atomic-private.hh @@ -122,11 +122,11 @@ static inline void _hb_memory_barrier (void) { __sync_synchronize (); } #include <mbarrier.h> typedef unsigned int hb_atomic_int_impl_t; -#define hb_atomic_int_impl_add(AI, V) ( ({__machine_rw_barrier ();}), atomic_add_int_nv ((AI), (V)) - (V)) +#define hb_atomic_int_impl_add(AI, V) ( ({__machine_rw_barrier ();}), atomic_add_int_nv ((AI), (V)) - (V) /* XXX barrier again? */) static inline void _hb_memory_barrier (void) { __machine_rw_barrier (); } -#define hb_atomic_ptr_impl_cmpexch(P,O,N) ( ({__machine_rw_barrier ();}), atomic_cas_ptr ((void **) (P), (void *) (O), (void *) (N)) == (void *) (O) ? true : false) +#define hb_atomic_ptr_impl_cmpexch(P,O,N) ( ({__machine_rw_barrier ();}), atomic_cas_ptr ((void **) (P), (void *) (O), (void *) (N)) == (void *) (O) ? true : false /* XXX barrier again? */) #elif !defined(HB_NO_MT) && defined(__APPLE__) |