summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-06-19Release 1.17.1gst-plugins-good-1.17.1Tim-Philipp Müller6-1316/+5806
2020-06-19meson: deinterlace: Check host cpu type for asm buildSeungha Yang1-1/+1
Add host cpu type check as we would enable asm only for x86_64 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/636>
2020-06-19meson: Fix build error with MSVC caused by ARCH_X86_64 defineSeungha Yang1-1/+0
ARCH_X86_64 define will enable GCC specific code path in dv_types.h while building dv plugin. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/636>
2020-06-19shout2: advertise documentation caps properlyTim-Philipp Müller2-4/+19
shout2send caps depend on what the libshout2 version in question supports, but the documentation caps should always be the same. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/635>
2020-06-18qtdemux: Split tag reading functions outJan Schmidt5-1229/+1311
Move some code out of the enormous qtdemux.c into a separate qtdemux_tags helper, and make some structs available via qtdemux.h to accommodate that. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/634>
2020-06-18qtdemux: Move some tree parsing files out to a separate file.Jan Schmidt4-93/+171
Reduce a tiny bit of the bulk of qtdemux.c by moving some agnostic helper functions out. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/634>
2020-06-18qtdemux: Factor out svmi parsing. Fix bounds checking.Jan Schmidt2-45/+74
Move the SVMI stereoscopic atom parsing out to a helper function to shrink qtdemux_parse_trak a bit. Add a bounds check that the received atom is large enough before parsing it. Add a note to the atom parser that svmi comes from the MPEG-A spec 23000-11. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/634>
2020-06-18pulse: fix discovery of newly added devicesGuillaume Desmottes1-2/+0
Fix regression introduced in 7bc5e28d85992b03e5852879b8d4d96043496caf preventing the device provider to send the device-added message for new devices. By early returning the patch was discarding add/remove events. Fix #735 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/626>
2020-06-18examples: qmlsink: rename qrc file to avoid naming conflicts with older ↵Tim-Philipp Müller3-2/+2
meson versions Would get "Tried to create target "qt5-qmlsink_qrc", but a target of that name already exists." with older meson versions. Work around that by renaming the qrc file. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/633>
2020-06-17meson: Check the nasm version with run_commandNirbheek Chauhan1-5/+29
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/751 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/631>
2020-06-16rtspsrc: Don't return TRUE for unhandled querySeungha Yang1-2/+3
Expected return value for unhandled query is FALSE Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/629>
2020-06-16deinterlace: Add yadif ASM optimisationsVivia Nikolaidou7-40/+2411
Measured to be about 3.4x faster than C Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/621>
2020-06-12deinterlace: Fix invalid read in yadifVivia Nikolaidou1-2/+2
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/621>
2020-06-12qt/gloverlay: reset OpenGL state after Qt drawingMatthew Waters1-0/+7
Reset to the original OpenGL state as required by the GStreamer OpenGL API contract. Fixes output with a glimagesink element downstream. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/623>
2020-06-12qt/gloverlay: reset current OpenGL context after QtMatthew Waters1-0/+6
Qt may replace the drawable with its own which breaks output if Qt is not displaying the resulting video as used with e.g. glimagesink. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/623>
2020-06-12flvdemux: Change a GST_ERROR_OBJECT() back to GST_DEBUG_OBJECT()Sebastian Dröge1-1/+1
It was accidentally changed in https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/436 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/624>
2020-06-11Use gst_element_class_set_metadata when passing dynamic stringsJordan Petridis2-2/+2
gst_element_class_set_metadata is meant to only be used with static or inlined strings, which isn't the case for the 2 elements here resulting in use-after-free later on. https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/622>
2020-06-10Revert "rtpjitterbuffer: Avoid deadlock on flush"Sebastian Dröge1-7/+4
This reverts commit 54810bf44f27d9c180730f58f16f6e172c7b0bc8 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/620>
2020-06-10docs: Update plugins cacheThibault Saunier1-2336/+2420
2020-06-09rtpjitterbuffer: g_queue_clear_full introduced in glib 2.60U. Artie Eoff1-0/+12
Define g_queue_clear_full if glib < 2.60. Fixes #747 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/619>
2020-06-09rtpsession: Make internal-ssrc as show default for docThibault Saunier2-2/+4
2020-06-09docs: Update plugins cacheThibault Saunier1-15/+7193
2020-06-09tests: don't pull in all -bad plugin, only allow the one we needTim-Philipp Müller1-1/+1
Set up our plugin include list for tests in such a way that we don't pull in *all* plugins from -bad but only the one used in the splitmuxsink unit test, i.e. the timecode plugin, so we don't accidentally use other encoders/decoders such as nvenc/dec for example. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/617>
2020-06-08rtptimerqueue: Fix leak on timer collisionNicolas Dufresne1-3/+6
While the caller should make sure this does not happen, make sure timer collision are not silently ignored and leaked. Fixes #726 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/616>
2020-06-08rtpjitterbuffer: Keep JBUF lock while processing timersNicolas Dufresne1-27/+42
Until now, do_expected_timeout() was shortly dropping the JBUF_LOCK in order to push RTX event event without causing deadlock. As a side effect, some CPU hung would happen as the timerqueue would get filled while looping over the due timers. To mitigate this, we were processing the lost timer first and placing into a queue the remainign to be processed later. In the gap caused by an unlock, we could endup receiving one of the seqnum present in the pending timers. In that case, the timer would not be found and a new one was created. When we then update the expected timer, the seqnum would already exist and the updated timer would be lost. In this patch we remove the unlock from do_expected_timeout() and place all pending RTX event into a queue (instead of pending timer). Then, as soon as we have selected a timer to wait (or if there is no timer to wait for) we send all the upstream RTX events. As we no longer unlock, we no longer need to pop more then one timer from the queue, and we do so with the lock held, which blocks any new colliding timers from being created. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/616>
2020-06-08tests: vp9enc: enforce I420 formatGuillaume Desmottes1-1/+1
Test was not enforcing a video format on videotestsrc. I420 was picked as it was the first format in GST_VIDEO_FORMATS_ALL which will no longer be true (gst-plugins-base!689). Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/615>
2020-06-08rtpjitterbuffer: Avoid deadlock on flushEdward Hervey1-4/+7
When a GST_EVENT_FLUSH_START reaches the jitterbuffer, there is a chance that our task is currently blocking waiting for a timer. There was two problems: * That wait wasn't checking for flushing situations * The flushing handling wasn't waking up that conditional (to check whether it should abort) Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/608>
2020-06-06plugins: uddate gst_type_mark_as_plugin_api() callsMathieu Duponchelle49-80/+80
2020-06-05rtpbin: Initialize uninitialized variable correctlySebastian Dröge1-1/+1
`last_out` would be used uninitialized if the element has no `set-active` signal. Initialize it to -1 as that's what the "default" value is further below. CID 1455443 Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/727 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/613>
2020-06-04vpxenc: Add new bit-per-pixel property to select a better "default" bitrateMikhail Fludkov5-16/+231
As part of this also change the default bitrate value to 0. The default value was 256000 previously. In reality, if the property was not set the bitrate value would be scaled according to the resolution which is not very intuitive behavior. It is better to use 0 for this purpose. Now together with newly introduced property "bits-per-pixel" 0 means to assign the bitrate according to resolution/framerate. The default bitrates are now - 1.2Mbps for VP8 720p@30fps - 0.8Mbps for VP9 720p@30fps and scaled accordingly for different resolutions/framerates. Previously the default bitrate was also not scaled according to the framerate but only took the resolution into account. This also fixes the side effect of setting bitrate to 0. Previously encoder would not produce any data at all. Addition from Sebastian Dröge <sebastian@centricular.com> to assume 30fps if no framerate is given in the caps instead of not calculating any bitrate at all. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/611>
2020-06-03doc: Require hotdoc >= 0.11.0Thibault Saunier1-0/+11
2020-06-03doc: Fix wrong link to GString in rtpjitterbufferThibault Saunier1-1/+1
2020-06-03docs: Update gst_plugins_cache.jsonSebastian Dröge1-11185/+10854
2020-06-03plugins: Use gst_type_mark_as_plugin_api() for all non-element plugin typesMathieu Duponchelle49-1/+129
2020-06-02vpxdec: Check that output width and height != 0Stian Selnes2-0/+43
For VP8 it's possible to signal width or height to be 0, but it does not make sense to do so. For VP9 it's impossible. Hence, we most likely have a corrupt stream. Trying to negotiate caps downstream with either width or height as 0 will fail with something like gst_video_decoder_negotiate_default: assertion 'GST_VIDEO_INFO_WIDTH (&state->info) != 0' failed Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/610>
2020-05-29speex: Fix crash on Windows caused by cross-CRT issueSeungha Yang2-2/+3
Use speex_header_free() to free memory which was allocated by library. Cross-CRT issue should not happen on 1.17 Cerbero build but might happen custom build or so. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/606>
2020-05-27rtspsrc: Use the correct type for storing the max-rtcp-rtp-time-diff propertySebastian Dröge1-1/+1
It's an integer property and rtpbin also expects an integer. Passing it as a GstClockTime (guint64) to g_object_set() will cause problems, and on big endian MIPS apparently causes crashes. Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/737 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/605>
2020-05-27tests: fix meson test env setup to make sure we use the right gst-plugin-scannerTim-Philipp Müller1-1/+6
If core is built as a subproject (e.g. as in gst-build), make sure to use the gst-plugin-scanner from the built subproject. Without this, gstreamer might accidentally use the gst-plugin-scanner from the install prefix if that exists, which in turn might drag in gst library versions we didn't mean to drag in. Those gst library versions might then be older than what our current build needs, and might cause our newly-built plugins to get blacklisted in the test registry because they rely on a symbol that the wrongly-pulled in gst lib doesn't have. This should fix running of unit tests in gst-build when invoking meson test or ninja test from outside the devenv for the case where there is an older or different-version gst-plugin-scanner installed in the install prefix. In case no gst-plugin-scanner is installed in the install prefix, this will fix "GStreamer-WARNING: External plugin loader failed. This most likely means that the plugin loader helper binary was not found or could not be run. You might need to set the GST_PLUGIN_SCANNER environment variable if your setup is unusual." warnings when running the unit tests. In the case where we find GStreamer core via pkg-config we use a newly-added pkg-config var "pluginscannerdir" to get the right directory. This has the benefit of working transparently for both installed and uninstalled pkg-config files/setups. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/603>
2020-05-25rtspsrc: Error out when failling to receive message responseThibault Saunier1-0/+18
And let it rety twice. Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/717 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/601>
2020-05-22v4l2: videodec: Fix broken template capsNicolas Dufresne1-4/+4
The profiles and levels were applied to the common caps instead of the copy. That had the side effect of setting profiles/level from one CODEC onto another. Leaving to encoder not being registered or not-negotiated errors. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/599>
2020-05-22v4l2: codec: Fix GValue leakNicolas Dufresne4-41/+48
The levels and profiles probe function returned a dynamically allocated GValue that was leaked. Simplify this by using a stack allocated GValue and a boolean return value. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/599>
2020-05-22v4l2codec: Remove uneeded factorisationNicolas Dufresne1-12/+5
There is only one user of that function and the split only increase complexicity. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/599>
2020-05-20v4l2src: Ignore non-increasing sequence numberNicolas Dufresne1-1/+3
With older kernel, older driver or just broken drivers, the sequence number may not be increasing. This simply ignore the sequence in this case. This would otherwise miss-leading large amount of lost frame being reported. Fixes #729 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/598>
2020-05-20qtoverlay: add the root item as a propertyMatthew Waters3-11/+68
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/595>
2020-05-20flvdemux: Send gap events if one of the streams falls behind the other by ↵Sebastian Dröge1-0/+53
more than 3s Same mechanism and threshold as in other demuxers. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/597>
2020-05-20flvdemux: Remove unused audio_linked/video_linked booleansSebastian Dröge1-2/+0
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/597>
2020-05-20flvdemux: Answer bitrate queries from upstreamEdward Hervey2-2/+61
If upstream (such as queue2 in urisourcebin) asks for our bitrate, check if we have stored audio/video bitrates, and use them. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/596>
2020-05-20flvdemux: Handle empty metadata stringsEdward Hervey1-1/+2
g_utf8_validate() errors out on empty string. But empty strings are valid, so only check if they're not Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/596>
2020-05-20flvdemux: Set ACCEPT_TEMPLATE flag on sinkpadEdward Hervey1-1/+1
A demuxer can accept any caps matching its sinkpad template caps Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/596>
2020-05-15qtglrenderer.cc: Fix compilingRaul Tambre1-2/+3
46bfb7d247aef880c15300dad63eb2bbf6dc4928 fixed a format warning without checking if it actually compiled. toUtf8() returns QByteArray so we need to assign it to a temporary variable to be able to get the raw string data from it. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/593>