diff options
| author | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-06-06 12:40:57 +0100 |
|---|---|---|
| committer | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-06-06 12:40:57 +0100 |
| commit | 10e060649109ffb790a2b5bbfa978fd5d5c6ddd5 (patch) | |
| tree | 98de35534fed4a9e2d7b2699e443404d610122a9 | |
| parent | 17e2e9acd9b9be3cc3637a60507892ca4a97bd0a (diff) | |
avaudenc: add a comment about using -1 in _finish_frame
See https://bugzilla.gnome.org/show_bug.cgi?id=729268
| -rw-r--r-- | ext/libav/gstavaudenc.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ext/libav/gstavaudenc.c b/ext/libav/gstavaudenc.c index a9aa88ad35..04081049aa 100644 --- a/ext/libav/gstavaudenc.c +++ b/ext/libav/gstavaudenc.c @@ -554,6 +554,9 @@ gst_ffmpegaudenc_encode_audio (GstFFMpegAudEnc * ffmpegaudenc, codec = ffmpegaudenc->context->codec; if ((codec->capabilities & CODEC_CAP_VARIABLE_FRAME_SIZE) || !audio_in) { + /* FIXME: Not really correct, as -1 means "all the samples we got + given so far", which may not be true depending on the codec, + but we have no way to know AFAICT */ ret = gst_audio_encoder_finish_frame (enc, outbuf, -1); } else { ret = gst_audio_encoder_finish_frame (enc, outbuf, frame.nb_samples); |