diff options
| author | Tim-Philipp Müller <tim.muller@collabora.co.uk> | 2010-01-31 13:03:33 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim.muller@collabora.co.uk> | 2010-01-31 13:03:58 +0000 |
| commit | efc5181d1374a61517d180768c35d48cc5ae9fb5 (patch) | |
| tree | c65596c9393e41c23bb4891b4f4e57cebd9dd71c | |
| parent | cd6b16734eeeaa7d73b6a62febac068459cf6882 (diff) | |
rtspreal: don't construct config header with uninitialised bytes
Turns out 4 + 4 + 2 + (4 * 2) is actually 18 and not 22. This avoids
a presumably unintentional padding of uninitialised bytes at the end
of the CONT tags chunk, which should be harmless but causes warnings
in valgrind (see #608533 for a test URL).
| -rw-r--r-- | gst/realmedia/rtspreal.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gst/realmedia/rtspreal.c b/gst/realmedia/rtspreal.c index 07f1df06..0b32b0cc 100644 --- a/gst/realmedia/rtspreal.c +++ b/gst/realmedia/rtspreal.c @@ -326,2 +326,3 @@ rtsp_ext_real_parse_sdp (GstRTSPExtension * ext, GstSDPMessage * sdp, + /* FIXME: use GstByteWriter to write the header */ /* PROP */ @@ -354,3 +355,3 @@ rtsp_ext_real_parse_sdp (GstRTSPExtension * ext, GstSDPMessage * sdp, - size = 22 + title_len + author_len + comment_len + copyright_len; + size = 18 + title_len + author_len + comment_len + copyright_len; ENSURE_SIZE (offset + size); |