From 5e32a710d7e28c063424d9334a74973c7ad19b0c Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Fri, 6 Jul 2007 11:42:53 +0000 Subject: ext/libpng/gstpngdec.c: Remove endianness-flipping hack that seems to have been required only because of a bug in ffm... Original commit message from CVS: * ext/libpng/gstpngdec.c: (gst_pngdec_caps_create_and_set): Remove endianness-flipping hack that seems to have been required only because of a bug in ffmpegcolorspace. Partially Fixes: #451908 --- ChangeLog | 7 +++++++ ext/libpng/gstpngdec.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e27bd8f47..c4f6d8c89 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2007-07-06 Jan Schmidt + + * ext/libpng/gstpngdec.c: (gst_pngdec_caps_create_and_set): + Remove endianness-flipping hack that seems to have been required + only because of a bug in ffmpegcolorspace. + Partially Fixes: #451908 + 2007-07-05 Stefan Kost * docs/plugins/Makefile.am: diff --git a/ext/libpng/gstpngdec.c b/ext/libpng/gstpngdec.c index bed0a63d6..e74578171 100644 --- a/ext/libpng/gstpngdec.c +++ b/ext/libpng/gstpngdec.c @@ -357,9 +357,14 @@ gst_pngdec_caps_create_and_set (GstPngDec * pngdec) /* Get Color type */ color_type = png_get_color_type (pngdec->png, pngdec->info); - /* HACK: The doc states that it's RGBA but apparently it's not... */ +#if 0 + /* We used to have this HACK to reverse the outgoing bytes, but the problem + * that originally required the hack seems to have been in ffmpegcolorspace's + * RGBA descriptions. It doesn't seem needed now that's fixed, but might + * still be needed on big-endian systems, I'm not sure. J.S. 6/7/2007 */ if (color_type == PNG_COLOR_TYPE_RGB_ALPHA) png_set_bgr (pngdec->png); +#endif /* Gray scale converted to RGB and upscaled to 8 bits */ if ((color_type == PNG_COLOR_TYPE_GRAY_ALPHA) || -- cgit v1.2.3