From 5ac6b84475657f7e76bb092273e6daed0c26d0dd Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Tue, 31 Mar 2009 17:06:50 +0300 Subject: matroska: don't alter passed data and especialy don't leak. If we need different size, Make a copy, work with that and free it. --- gst/matroska/matroska-demux.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gst/matroska/matroska-demux.c b/gst/matroska/matroska-demux.c index 118a3d6fb..6b9c377bf 100644 --- a/gst/matroska/matroska-demux.c +++ b/gst/matroska/matroska-demux.c @@ -4981,9 +4981,8 @@ gst_matroska_demux_video_caps (GstMatroskaTrackVideoContext * return NULL; } if (size < sizeof (gst_riff_strf_vids)) { - vids = - (gst_riff_strf_vids *) g_realloc (vids, - sizeof (gst_riff_strf_vids)); + vids = g_new (gst_riff_strf_vids, 1); + memcpy (vids, data, size); } /* little-endian -> byte-order */ @@ -5011,6 +5010,9 @@ gst_matroska_demux_video_caps (GstMatroskaTrackVideoContext * if (buf) gst_buffer_unref (buf); + + if (vids != (gst_riff_strf_vids *) data) + g_free (vids); } } else if (!strcmp (codec_id, GST_MATROSKA_CODEC_ID_VIDEO_UNCOMPRESSED)) { guint32 fourcc = 0; -- cgit v1.2.3