diff options
author | Stefan Kost <ensonic@users.sf.net> | 2009-03-31 16:42:15 +0300 |
---|---|---|
committer | Stefan Kost <ensonic@users.sf.net> | 2009-03-31 16:42:15 +0300 |
commit | fa8e2d9bfeec654f036995861aabb9b9907fb8e3 (patch) | |
tree | e6b81938cbd3f5a19a45bb98accb6f620a50fa49 | |
parent | ef7bcf7bd1974220f706a103d372b3fa530b4e33 (diff) |
goom: the structure is not fully initialized, but the copied.
Set to fully to 0 to avoid creep of uninitialized values.
-rw-r--r-- | gst/goom/plugin_info.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gst/goom/plugin_info.c b/gst/goom/plugin_info.c index 68e0bf0a5..6a2411d92 100644 --- a/gst/goom/plugin_info.c +++ b/gst/goom/plugin_info.c | |||
@@ -109,7 +109,7 @@ void | |||
109 | plugin_info_init (PluginInfo * pp, int nbVisuals) | 109 | plugin_info_init (PluginInfo * pp, int nbVisuals) |
110 | { | 110 | { |
111 | 111 | ||
112 | PluginInfo p; | 112 | PluginInfo p = { 0, }; |
113 | int i; | 113 | int i; |
114 | 114 | ||
115 | p.sound.speedvar = p.sound.accelvar = p.sound.totalgoom = 0; | 115 | p.sound.speedvar = p.sound.accelvar = p.sound.totalgoom = 0; |
@@ -147,6 +147,7 @@ plugin_info_init (PluginInfo * pp, int nbVisuals) | |||
147 | p.nbVisuals = nbVisuals; | 147 | p.nbVisuals = nbVisuals; |
148 | p.visuals = (VisualFX **) malloc (sizeof (VisualFX *) * nbVisuals); | 148 | p.visuals = (VisualFX **) malloc (sizeof (VisualFX *) * nbVisuals); |
149 | 149 | ||
150 | /* huh, we're setting a local variable and now copying it over? */ | ||
150 | *pp = p; | 151 | *pp = p; |
151 | pp->sound.params.params[0] = &pp->sound.biggoom_speed_limit_p; | 152 | pp->sound.params.params[0] = &pp->sound.biggoom_speed_limit_p; |
152 | pp->sound.params.params[1] = &pp->sound.biggoom_factor_p; | 153 | pp->sound.params.params[1] = &pp->sound.biggoom_factor_p; |