summaryrefslogtreecommitdiff
authorStefan Kost <ensonic@users.sf.net>2009-03-31 13:42:15 (GMT)
committer Stefan Kost <ensonic@users.sf.net>2009-03-31 13:42:15 (GMT)
commitfa8e2d9bfeec654f036995861aabb9b9907fb8e3 (patch) (side-by-side diff)
treee6b81938cbd3f5a19a45bb98accb6f620a50fa49
parentef7bcf7bd1974220f706a103d372b3fa530b4e33 (diff)
downloadgst-plugins-good-fa8e2d9bfeec654f036995861aabb9b9907fb8e3.zip
gst-plugins-good-fa8e2d9bfeec654f036995861aabb9b9907fb8e3.tar.gz
goom: the structure is not fully initialized, but the copied.
Set to fully to 0 to avoid creep of uninitialized values.
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--gst/goom/plugin_info.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gst/goom/plugin_info.c b/gst/goom/plugin_info.c
index 68e0bf0..6a2411d 100644
--- a/gst/goom/plugin_info.c
+++ b/gst/goom/plugin_info.c
@@ -109,7 +109,7 @@ void
plugin_info_init (PluginInfo * pp, int nbVisuals)
{
- PluginInfo p;
+ PluginInfo p = { 0, };
int i;
p.sound.speedvar = p.sound.accelvar = p.sound.totalgoom = 0;
@@ -147,6 +147,7 @@ plugin_info_init (PluginInfo * pp, int nbVisuals)
p.nbVisuals = nbVisuals;
p.visuals = (VisualFX **) malloc (sizeof (VisualFX *) * nbVisuals);
+ /* huh, we're setting a local variable and now copying it over? */
*pp = p;
pp->sound.params.params[0] = &pp->sound.biggoom_speed_limit_p;
pp->sound.params.params[1] = &pp->sound.biggoom_factor_p;