summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>2014-04-21 13:34:37 +0100
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>2014-04-21 17:21:20 +0100
commit54c5710adbe58001a66a5159af79293876c5aba0 (patch)
tree1f93f262831bf22ace6e79fc5a107fc097788981
parent25fa88f8aae16d9f11db4808c11080e070b6af41 (diff)
matroskamux: fix PAR fraction sanity check
It was checking par_num twice, and never par_denum. Coverity 1139634
-rw-r--r--gst/matroska/matroska-mux.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/gst/matroska/matroska-mux.c b/gst/matroska/matroska-mux.c
index 734750900..e1472d9cb 100644
--- a/gst/matroska/matroska-mux.c
+++ b/gst/matroska/matroska-mux.c
@@ -1416,7 +1416,7 @@ theora_streamheader_to_codecdata (const GValue * streamheader,
hdr += 4 + 4;
par_num = GST_READ_UINT32_BE (hdr) >> 8;
par_denom = GST_READ_UINT32_BE (hdr + 3) >> 8;
- if (par_num > 0 && par_num > 0) {
+ if (par_num > 0 && par_denom > 0) {
if (par_num > par_denom) {
videocontext->display_width =
videocontext->pixel_width * par_num / par_denom;