From 732f3055a38d16c90dfa67752e0caf96ca707d01 Mon Sep 17 00:00:00 2001 From: Sebastian Dröge Date: Mon, 30 Nov 2009 10:22:15 +0100 Subject: subtitleoverlay: Fix some pad refcount issues Fixes bug #603345. --- gst/playback/gstsubtitleoverlay.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gst/playback/gstsubtitleoverlay.c b/gst/playback/gstsubtitleoverlay.c index d55ff65ee..26571bf92 100644 --- a/gst/playback/gstsubtitleoverlay.c +++ b/gst/playback/gstsubtitleoverlay.c @@ -876,12 +876,14 @@ _pad_blocked_cb (GstPad * pad, gboolean blocked, gpointer user_data) if (G_UNLIKELY (!sink)) { GST_WARNING_OBJECT (self, "Can't get text sink from textoverlay"); gst_object_unref (src); + continue; } if (G_UNLIKELY (gst_pad_link (src, sink) != GST_PAD_LINK_OK)) { GST_WARNING_OBJECT (self, "Can't link parser to textoverlay"); gst_object_unref (sink); gst_object_unref (src); + continue; } gst_object_unref (sink); gst_object_unref (src); @@ -1178,6 +1180,7 @@ _pad_blocked_cb (GstPad * pad, gboolean blocked, gpointer user_data) gst_object_unref (sink); continue; } + gst_object_unref (sink); sink = _get_sub_pad (element); if (G_UNLIKELY (!sink)) { -- cgit v1.2.3