vdpau: fix GstBaseVideoDecoder returning wrong GstStateChangeReturn

when gst_base_video_decoder_[start|stop] fails we now return
GST_STATE_CHANGE_FAILURE instead of returning what the parent class returns

1 files changed, 4 insertions, 2 deletions

diff --git a/sys/vdpau/basevideodecoder/gstbasevideodecoder.c b/sys/vdpau/basevideodecoder/gstbasevideodecoder.c
index 353badffa..1e9cf14ec 100644
--- a/sys/vdpau/basevideodecoder/gstbasevideodecoder.c
+++ b/sys/vdpau/basevideodecoder/gstbasevideodecoder.c
@@ -914,24 +914,26 @@ gst_base_video_decoder_change_state (GstElement * element,
   GstStateChangeReturn ret;
 
   base_video_decoder = GST_BASE_VIDEO_DECODER (element);
 
   switch (transition) {
     case GST_STATE_CHANGE_READY_TO_PAUSED:
-      gst_base_video_decoder_start (base_video_decoder);
+      if (!gst_base_video_decoder_start (base_video_decoder))
+        return GST_STATE_CHANGE_FAILURE;
       break;
 
     default:
       break;
   }
 
   ret = GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);
 
   switch (transition) {
     case GST_STATE_CHANGE_PAUSED_TO_READY:
-      gst_base_video_decoder_stop (base_video_decoder);
+      if (!gst_base_video_decoder_stop (base_video_decoder))
+        ret = GST_STATE_CHANGE_FAILURE;
       break;
 
     default:
       break;
   }